Skip to contentSkip to conversation

arm64: remove unused asm/compiler.h header file

PATCH New Ard Biesheuvel 3 participants 3 messages Sep 27, 2018 – Oct 1, 2018 arm64

lore
Share & tools
lore

Ard Biesheuvel

author
#0 lore raw

PATCH 1/1 arm64: remove unused asm/compiler.h header file

arm64 does not define CONFIG_HAVE_ARCH_COMPILER_H, nor does it keep anything useful in its copy of asm/compiler.h, so let's remove it before anybody starts using it.

Signed-off-by Ard Biesheuvel <[email protected]>
---
 arch/arm64/include/asm/compiler.h | 30 ------------------------------
 arch/arm64/include/asm/sysreg.h   |  1 -
 arch/arm64/include/asm/uaccess.h  |  1 -
 arch/arm64/kernel/psci.c          |  1 -
 4 files changed, 33 deletions(-)
 delete mode 100644 arch/arm64/include/asm/compiler.h
arch/arm64/include/asm/compiler.h deleted +0 -30
deleted file mode 100644
index ee35fd0f2236..000000000000
@@ -1,30 +0,0 @@
-/*
- * Based on arch/arm/include/asm/compiler.h
- *
- * Copyright (C) 2012 ARM Ltd.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License version 2 as
- * published by the Free Software Foundation.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program.  If not, see <http://www.gnu.org/licenses/>.
- */
-#ifndef __ASM_COMPILER_H
-#define __ASM_COMPILER_H
-
-/*
- * This is used to ensure the compiler did actually allocate the register we
- * asked it for some inline assembly sequences.  Apparently we can't trust the
- * compiler from one version to another so a bit of paranoia won't hurt.  This
- * string is meant to be concatenated with the inline asm string and will
- * cause compilation to stop on mismatch.  (for details, see gcc PR 15089)
- */
-#define __asmeq(x, y)  ".ifnc " x "," y " ; .err ; .endif\n\t"
-
-#endif	/* __ASM_COMPILER_H */
arch/arm64/include/asm/sysreg.h +0 -1
index c1470931b897..6d307212bf7c 100644
@@ -20,7 +20,6 @@
 #ifndef __ASM_SYSREG_H
 #define __ASM_SYSREG_H
 
-#include <asm/compiler.h>
 #include <linux/stringify.h>
 
 /*
arch/arm64/include/asm/uaccess.h +0 -1
index e66b0fca99c2..07c34087bd5e 100644
@@ -32,7 +32,6 @@
 #include <asm/cpufeature.h>
 #include <asm/ptrace.h>
 #include <asm/memory.h>
-#include <asm/compiler.h>
 #include <asm/extable.h>
 
 #define get_ds()	(KERNEL_DS)
arch/arm64/kernel/psci.c +0 -1
index e8edbf13302a..8cdaf25e99cd 100644
@@ -24,7 +24,6 @@
 
 #include <uapi/linux/psci.h>
 
-#include <asm/compiler.h>
 #include <asm/cpu_ops.h>
 #include <asm/errno.h>
 #include <asm/smp_plat.h>
Signature · 1 line
2.18.0
#1 lore raw

PATCH 1/1 arm64: remove unused asm/compiler.h header file

Quoted 4 lines · Ard Biesheuvel

arm64 does not define CONFIG_HAVE_ARCH_COMPILER_H, nor does it keep anything useful in its copy of asm/compiler.h, so let's remove it before anybody starts using it.

Quoted 8 lines
Signed-off-by Ard Biesheuvel <[email protected]>
---
 arch/arm64/include/asm/compiler.h | 30 ------------------------------
 arch/arm64/include/asm/sysreg.h   |  1 -
 arch/arm64/include/asm/uaccess.h  |  1 -
 arch/arm64/kernel/psci.c          |  1 -
 4 files changed, 33 deletions(-)
 delete mode 100644 arch/arm64/include/asm/compiler.h
Acked-by Will Deacon <[email protected]>

Will

maintainer Applied
#2 lore raw

PATCH 1/1 arm64: remove unused asm/compiler.h header file

In reply to Ard Biesheuvel
Quoted 5 lines · Ard Biesheuvel

arm64 does not define CONFIG_HAVE_ARCH_COMPILER_H, nor does it keep anything useful in its copy of asm/compiler.h, so let's remove it before anybody starts using it.

Signed-off-by Ard Biesheuvel <[email protected]>

Queued for 4.20. Thanks.

Signature · 1 line
Catalin