Skip to contentSkip to conversation

usb: typec: pci: Enable Intel USB role mux on Apollo Lake platforms

PATCH RESEND New Heikki Krogerus 1 participant 1 message Oct 1, 2018

Subsystems (2)
Stable branch USB
lore
Share & tools
lore

Heikki Krogerus

author
#0 lore raw

PATCH RESEND v2 3/3 usb: typec: pci: Enable Intel USB role mux on Apollo Lake platforms

Hi,

Not a biggie, but why was the topic for this patch changed?

I'm not sure Apollo lakes even have Type-C connectors. The mux is needed with the uAB connectors.

Quoted 33 lines · Mathias Nyman

From: Heikki Krogerus <[email protected]>

Intel Apollo Lake has the same internal USB role mux as Intel Cherry Trail.

Cc <[email protected]>
Signed-off-by Heikki Krogerus <[email protected]>
Signed-off-by Mathias Nyman <[email protected]>
---
 drivers/usb/host/xhci-pci.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/usb/host/xhci-pci.c +4 -2
index 722860e..51dd8e0 100644
@@ -179,10 +179,12 @@ static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci)
 		xhci->quirks |= XHCI_PME_STUCK_QUIRK;
 	}
 	if (pdev->vendor == PCI_VENDOR_ID_INTEL &&
-		 pdev->device == PCI_DEVICE_ID_INTEL_CHERRYVIEW_XHCI) {
+	    pdev->device == PCI_DEVICE_ID_INTEL_CHERRYVIEW_XHCI)
 		xhci->quirks |= XHCI_SSIC_PORT_UNUSED;
+	if (pdev->vendor == PCI_VENDOR_ID_INTEL &&
+	    (pdev->device == PCI_DEVICE_ID_INTEL_CHERRYVIEW_XHCI ||
+	     pdev->device == PCI_DEVICE_ID_INTEL_APL_XHCI))
 		xhci->quirks |= XHCI_INTEL_USB_ROLE_SW;
-	}
 	if (pdev->vendor == PCI_VENDOR_ID_INTEL &&
 	    (pdev->device == PCI_DEVICE_ID_INTEL_CHERRYVIEW_XHCI ||
 	     pdev->device == PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_XHCI ||
Signature · 1 line
2.7.4