Skip to contentSkip to conversation

scsi/pmcraid.c: Use dma_pool_zalloc

PATCH In review Souptick Joarder 1 participant 3 messages Oct 2, 2018 – Oct 24, 2018

Subsystems (2)
SCSI PMC sierra MaxRAID driver
lore
Share & tools
lore

Souptick Joarder

author
#0 lore raw

PATCH 1/1 scsi/pmcraid.c: Use dma_pool_zalloc

Replaced dma_pool_alloc + memset with dma_pool_zalloc.

Signed-off-by Sabyasachi Gupta <[email protected]>
Signed-off-by Souptick Joarder <[email protected]>
---
 drivers/scsi/pmcraid.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/scsi/pmcraid.c +1 -3
index 4e86994..84a2734 100644
@@ -4681,7 +4681,7 @@ static int pmcraid_allocate_control_blocks(struct pmcraid_instance *pinstance)
 
 	for (i = 0; i < PMCRAID_MAX_CMD; i++) {
 		pinstance->cmd_list[i]->ioa_cb =
-			dma_pool_alloc(
+			dma_pool_zalloc(
 				pinstance->control_pool,
 				GFP_KERNEL,
 				&(pinstance->cmd_list[i]->ioa_cb_bus_addr));

@@ -4690,8 +4690,6 @@ static int pmcraid_allocate_control_blocks(struct pmcraid_instance *pinstance)
 			pmcraid_release_control_blocks(pinstance, i);
 			return -ENOMEM;
 		}
-		memset(pinstance->cmd_list[i]->ioa_cb, 0,
-			sizeof(struct pmcraid_control_block));
 	}
 	return 0;
 }
Signature · 1 line
1.9.1
author
#1 lore raw
Quoted 5 lines · Souptick Joarder

Replaced dma_pool_alloc + memset with dma_pool_zalloc.

Signed-off-by Sabyasachi Gupta <[email protected]>
Signed-off-by Souptick Joarder <[email protected]>

Any comment on this patch ?

Quoted 29 lines
---
 drivers/scsi/pmcraid.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/scsi/pmcraid.c +1 -4
index 4e86994..84a2734 100644
@@ -4681,7 +4681,7 @@ static int pmcraid_allocate_control_blocks(struct pmcraid_instance *pinstance)
 
        for (i = 0; i < PMCRAID_MAX_CMD; i++) {
                pinstance->cmd_list[i]->ioa_cb =
-                       dma_pool_alloc(
+                       dma_pool_zalloc(
                                pinstance->control_pool,
                                GFP_KERNEL,
                                &(pinstance->cmd_list[i]->ioa_cb_bus_addr));

@@ -4690,8 +4690,6 @@ static int pmcraid_allocate_control_blocks(struct pmcraid_instance *pinstance)
                        pmcraid_release_control_blocks(pinstance, i);
                        return -ENOMEM;
                }
-               memset(pinstance->cmd_list[i]->ioa_cb, 0,
-                       sizeof(struct pmcraid_control_block));
        }
        return 0;
 }
--

1.9.1

author
#2 lore raw
Quoted 9 lines · Souptick Joarder
Quoted 5 lines · Souptick Joarder

Replaced dma_pool_alloc + memset with dma_pool_zalloc.

Signed-off-by Sabyasachi Gupta <[email protected]>
Signed-off-by Souptick Joarder <[email protected]>

Any comment on this patch ?

Any comment on this patch ?

Quoted 30 lines
Quoted 30 lines
---
 drivers/scsi/pmcraid.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/scsi/pmcraid.c +1 -4
index 4e86994..84a2734 100644
@@ -4681,7 +4681,7 @@ static int pmcraid_allocate_control_blocks(struct pmcraid_instance *pinstance)
 
        for (i = 0; i < PMCRAID_MAX_CMD; i++) {
                pinstance->cmd_list[i]->ioa_cb =
-                       dma_pool_alloc(
+                       dma_pool_zalloc(
                                pinstance->control_pool,
                                GFP_KERNEL,
                                &(pinstance->cmd_list[i]->ioa_cb_bus_addr));

@@ -4690,8 +4690,6 @@ static int pmcraid_allocate_control_blocks(struct pmcraid_instance *pinstance)
                        pmcraid_release_control_blocks(pinstance, i);
                        return -ENOMEM;
                }
-               memset(pinstance->cmd_list[i]->ioa_cb, 0,
-                       sizeof(struct pmcraid_control_block));
        }
        return 0;
 }
--

1.9.1