Skip to contentSkip to conversation

ad5820: DT new optional field enable-gpios

PATCH In review Ricardo Ribalda Delgado 3 participants 3 messages Oct 2, 2018 – Oct 5, 2018

Subsystems (2)
Device tree bindings Media (V4L/DVB)
lore
Share & tools
lore

Ricardo Ribalda Delgado

author
#0 lore raw

PATCH v6 2/6 ad5820: DT new optional field enable-gpios

Document new enable-gpio field. It can be used to disable the part without turning down its regulator.

Cc [email protected]
Signed-off-by Ricardo Ribalda Delgado <[email protected]>
Acked-by Pavel Machek <[email protected]>
---
 Documentation/devicetree/bindings/media/i2c/ad5820.txt | 6 ++++++
 1 file changed, 6 insertions(+)
Documentation/devicetree/bindings/media/i2c/ad5820.txt +6 -0
index 5940ca11c021..db596e8eb0ba 100644
@@ -8,6 +8,11 @@ Required Properties:
 
   - VANA-supply: supply of voltage for VANA pin
 
+Optional properties:
+
+   - enable-gpios : GPIO spec for the XSHUTDOWN pin. The XSHUTDOWN signal is
+active low, a high level on the pin enables the device.
+
 Example:
 
        ad5820: coil@c {

@@ -15,5 +20,6 @@ Example:
                reg = <0x0c>;
 
                VANA-supply = <&vaux4>;
+               enable-gpios = <&msmgpio 26 GPIO_ACTIVE_HIGH>;
        };
Signature · 1 line
2.19.0
Reviewed-by on v6 2/6
#1 lore raw

Hi Ricardo,

Thank you for the patch.

Quoted 6 lines · On Tuesday, 2 October 2018 14:13:56 EEST Ricardo Ribalda Delgado wrote:

Document new enable-gpio field. It can be used to disable the part without turning down its regulator.

Cc [email protected]
Signed-off-by Ricardo Ribalda Delgado <[email protected]>
Acked-by Pavel Machek <[email protected]>
Reviewed-by Laurent Pinchart <[email protected]>
Quoted 27 lines
---
 Documentation/devicetree/bindings/media/i2c/ad5820.txt | 6 ++++++
 1 file changed, 6 insertions(+)
(quoted diff) +0 -0

b/Documentation/devicetree/bindings/media/i2c/ad5820.txt index 5940ca11c021..db596e8eb0ba 100644

Documentation/devicetree/bindings/media/i2c/ad5820.txt +3 -0
@@ -8,6 +8,11 @@ Required Properties:
 
   - VANA-supply: supply of voltage for VANA pin
 
+Optional properties:
+
+   - enable-gpios : GPIO spec for the XSHUTDOWN pin. The XSHUTDOWN signal

is +active low, a high level on the pin enables the device.

Documentation/devicetree/bindings/media/i2c/ad5820.txt +2 -0
+
 Example:
 
        ad5820: coil@c {

@@ -15,5 +20,6 @@ Example:
                reg = <0x0c>;
 
                VANA-supply = <&vaux4>;
+               enable-gpios = <&msmgpio 26 GPIO_ACTIVE_HIGH>;
        };
Signature · 3 lines
Regards,

Laurent Pinchart
maintainer Reviewed-by on v6 2/6
#2 lore raw
In reply to Ricardo Ribalda Delgado
Quoted 10 lines · Ricardo Ribalda Delgado

Document new enable-gpio field. It can be used to disable the part without turning down its regulator.

Cc [email protected]
Signed-off-by Ricardo Ribalda Delgado <[email protected]>
Acked-by Pavel Machek <[email protected]>
---
 Documentation/devicetree/bindings/media/i2c/ad5820.txt | 6 ++++++
 1 file changed, 6 insertions(+)
Reviewed-by Rob Herring <[email protected]>