spidev: Enable the Liebherr's BK4 board to work with spidev driver
PATCH 1/1 spidev: Enable the Liebherr's BK4 board to work with spidev driver
With this commit the DSPI driver on the BK4 board can be used for SPI transmission managed from user space (via /dev/spidev0.0).
Example usage/testing:
insmod ./spi-fsl-dspi.ko
./spidev_test -D /dev/spidev0.0 -s 3000000 -v -H -b 8 -p "\xCC\x11\x22\x74"
--- drivers/spi/spidev.c | 1 + 1 file changed, 1 insertion(+)
drivers/spi/spidev.c +1 -0
@@ -669,6 +669,7 @@ static const struct of_device_id spidev_dt_ids[] = { { .compatible = "lineartechnology,ltc2488" }, { .compatible = "ge,achc" }, { .compatible = "semtech,sx1301" }, + { .compatible = "lwn,bk4" }, {}, };MODULE_DEVICE_TABLE (of, spidev_dt_ids);
Signature · 1 line
2.11.0
Quoted 2 lines · Lukasz Majewski
With this commit the DSPI driver on the BK4 board can be used for SPI transmission managed from user space (via
/dev/spidev0.0).
Hi Lukasz,
I tried submitting a similar patch for another devicem but got no reaction [1]. In the meanwhile, there has been another proposal [2] which moves handling of this into userspace via udev. You might want to take a look at that mechanism instead (and perhaps send your Tested-by tag). It has worked well for me.
[1] https://patchwork.kernel.org/patch/10558889/
[2] https://patchwork.kernel.org/project/spi-devel-general/list/?series=21295
Cheers,
Jan
Mark Brown
maintainerQuoted 3 lines · Jan Kundrát
Hi Lukasz,
I tried submitting a similar patch for another devicem but got no reaction [1]. In the meanwhile, there has been another proposal [2] which moves
As documented in SubmittingPatches please send patches to the maintainers for the code you would like to change. The normal kernel workflow is that people apply patches from their inboxes, if they aren't copied they are likely to not see the patch at all and it is much more difficult to apply patches.
Hi Jan,
Quoted 9 lines · Jan Kundrát
Quoted 5 lines
Hi Lukasz,
I tried submitting a similar patch for another devicem but got no reaction [1]. In the meanwhile, there has been another proposal [2] which movesAs documented in SubmittingPatches please send patches to the maintainers for the code you would like to change.
I'm using the ./scripts/get_maintainer.py script to obtain list of relevant people.
Moreover, you may want to look for gitk -- <patch to your modified file> and add developers, who did some remarkable work in that file.
Also git-blame helps.
And another issue - maitainers are very often very busy (as maintaining/reviewing is not their main occupation).
We would like to have a prompt response/review, but it is acceptable to wait week or two for reply....
Please also document in the ./Documentation/devicetree the introduced compatible -> there are some examples (ge,ahca) in the misc directory.
Quoted 4 lines
The normal kernel
workflow is that people apply patches from their inboxes, if they aren't copied they are likely to not see the patch at all and it is much more difficult to apply patches.
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [email protected]
Mark Brown
maintainerQuoted 5 lines · Lukasz Majewski
Quoted 2 lines
As documented in SubmittingPatches please send patches to the maintainers for the code you would like to change.
I'm using the
./scripts/get_maintainer.pyscript to obtain list of relevant people.
Your patch went to the right place (and I applied it yesterday), that was directed at Jan - the reason his patch got missed is that he didn't send it to me.
Quoted 2 lines
Please also document in the
./Documentation/devicetreethe introduced compatible -> there are some examples (ge,ahca) in the misc directory.
Good point.
Mark Brown
maintainerApplied "spidev: Enable the Liebherr's BK4 board to work with spidev driver" to the spi tree
In reply to Lukasz MajewskiThe patch
spidev: Enable the Liebherr's BK4 board to work with spidev driver
has been applied to the spi tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark
Quoted 1 line
From
5e9feb3544a72321553d17fcfa0c7e88435ea7adMon Sep 17 00:00:00 2001
From: Lukasz Majewski <[email protected]>
Date: Fri, 28 Sep 2018 00:31:52 +0200
Subject: [PATCH] spidev: Enable the Liebherr's BK4 board to work with spidev
driver
With this commit the DSPI driver on the BK4 board can be used for SPI transmission managed from user space (via /dev/spidev0.0).
Example usage/testing:
insmod ./spi-fsl-dspi.ko
./spidev_test -D /dev/spidev0.0 -s 3000000 -v -H -b 8 -p "\xCC\x11\x22\x74"
--- drivers/spi/spidev.c | 1 + 1 file changed, 1 insertion(+)
drivers/spi/spidev.c +1 -0
@@ -669,6 +669,7 @@ static const struct of_device_id spidev_dt_ids[] = { { .compatible = "lineartechnology,ltc2488" }, { .compatible = "ge,achc" }, { .compatible = "semtech,sx1301" }, + { .compatible = "lwn,bk4" }, {}, };MODULE_DEVICE_TABLE (of, spidev_dt_ids);
Signature · 1 line
2.19.0.rc2