android-tools: depends on openssl10 only for target builds
PATCH 1/4 android-tools: depends on openssl10 only for target builds
* openssl isn't used by TOOLS enabled for native and nativesdk builds:
TOOLS_class-native = "fastboot ext4_utils mkbootimg" TOOLS_class-nativesdk = "fastboot ext4_utils mkbootimg" it's used e.g. by adb which is enabled only for target
* with openssl10 it cannot be really used by anything, because openssl.cnf from openssl10-native will conflict with openssl.cnf installed to RSS by openssl-native, causing:
DEBUG: Executing python function sstate_task_prefunc
DEBUG: Python function sstate_task_prefunc finished
DEBUG: Executing python function extend_recipe_sysroot
NOTE: Direct dependencies are ['virtual:native:/OE/build/owpb/webos-ports/openembedded-core/meta/recipes-devtools/e2fsprogs/e2fsprogs_1.44.3.bb:do_populate_sysroot', '/OE/build/owpb/webos-ports/openembedded-core/meta/recipes-devtools/quilt/quilt-native_0.65.bb:do_populate_sysroot', '/OE/build/owpb/webos-ports/openembedded-core/meta/recipes-devtools/gcc/gcc-cross_8.2.bb:do_populate_sysroot', '/OE/build/owpb/webos-ports/openembedded-core/meta/recipes-devtools/gcc/gcc-runtime_8.2.bb:do_populate_sysroot', '/OE/build/owpb/webos-ports/openembedded-core/meta/recipes-core/glibc/glibc_2.28.bb:do_populate_sysroot', 'virtual:native:/OE/build/owpb/webos-ports/meta-openembedded/meta-oe/recipes-devtools/android-tools/android-tools_5.1.1.r37.bb:do_populate_sysroot', 'virtual:native:/OE/build/owpb/webos-ports/openembedded-core/meta/recipes-devtools/rpm/rpm_4.14.2.bb:do_populate_sysroot', 'virtual:native:/OE/build/owpb/webos-ports/openembedded-core/meta/recipes-devtools/dwarfsrcfiles/dwarfsrcfiles.bb:do_populate_sysroot', 'virtual:native:/OE/build/owpb/webos-ports/openembedded-core/meta/recipes-devtools/pseudo/pseudo_git.bb:do_populate_sysroot']
ERROR: Error executing a python function in exec_python_func() autogenerated:
The stack trace of python calls that resulted in this exception/failure was:
File: 'exec_python_func() autogenerated', lineno: 2, function: <module>
0001:
*** 0002:extend_recipe_sysroot(d)
0003:File: '/OE/build/owpb/webos-ports/openembedded-core/meta/classes/staging.bbclass', lineno: 553, function: extend_recipe_sysroot
0549: dest = newmanifest[l]
0550: if l.endswith("/"):
0551: staging_copydir(l, targetdir, dest, seendirs)
0552: continue
*** 0553: staging_copyfile(l, targetdir, dest, postinsts, seendirs)
0554:
0555: bb.note("Installed into sysroot: %s" % str(msg_adding))
0556: bb.note("Skipping as already exists in sysroot: %s" % str(msg_exists))
0557:
File: '/OE/build/owpb/webos-ports/openembedded-core/meta/classes/staging.bbclass', lineno: 151, function: staging_copyfile
0147: os.symlink(linkto, dest)
0148: #bb.warn(c)
0149: else:
0150: try: *** 0151: os.link(c, dest)
0152: except OSError as err:
0153: if err.errno == errno.EXDEV:
0154: bb.utils.copyfile(c, dest)
0155: else:
Exception: FileExistsError: [Errno 17] File exists: '/OE/build/owpb/webos-ports/tmp-glibc/sysroots-components/x86_64/openssl-native/etc/ssl/openssl.cnf' -> '/OE/build/owpb/webos-ports/tmp-glibc/work/tissot-webos-linux/android-system-image-tissot/20180914-22-r0/recipe-sysroot-native/etc/ssl/openssl.cnf'
DEBUG: Python function extend_recipe_sysroot finished
ERROR: Function failed: extend_recipe_sysroot
--- .../recipes-devtools/android-tools/android-tools_5.1.1.r37.bb | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
meta-oe/recipes-devtools/android-tools/android-tools_5.1.1.r37.bb +2 -1
@@ -7,7 +7,8 @@ LIC_FILES_CHKSUM = " \ file://${COMMON_LICENSE_DIR}/BSD-2-Clause;md5=8bef8e6712b1be5aa76af1ebde9d6378 \ file://${COMMON_LICENSE_DIR}/BSD-3-Clause;md5=550794465ba0ec5312d6919e203a55f9 \ " -DEPENDS = "libbsd libpcre openssl10 zlib libcap" +DEPENDS = "libbsd libpcre zlib libcap" +DEPENDS_append_class-target = " openssl10" ANDROID_MIRROR = "android.googlesource.com" CORE_REPO = "${ANDROID_MIRROR}/platform/system/core"
Signature · 1 line
2.17.1
PATCH 2/4 android-tools: import 2 changes from meta-webos-ports
* import upstream-able changes from following commits:
https://github.com/webOS-ports/meta-webos-ports/commit/9d032e47b5a90846485393095a4fd9b923578f22
https://github.com/webOS-ports/meta-webos-ports/commit/fea52b88281e197482b7412824802c057ec99000
https://github.com/webOS-ports/meta-webos-ports/commit/d8068a7a4722f6203ef16d85c235f86a5a76fa9c
https://github.com/webOS-ports/meta-webos-ports/commit/c314b69505343ea959adc9789e0a1fca52a8af67
--- .../0001-Allow-adbd-to-be-ran-as-root.patch | 24 +++++++++++++++++++ .../android-tools/android-tools-adbd.service | 5 ++-- .../android-tools/android-tools_5.1.1.r37.bb | 1 + 3 files changed, 28 insertions(+), 2 deletions(-) create mode 100644 meta-oe/recipes-devtools/android-tools/android-tools/0001-Allow-adbd-to-be-ran-as-root.patch
meta-oe/recipes-devtools/android-tools/android-tools/0001-Allow-adbd-to-be-ran-as-root.patch new file +24 -0
@@ -0,0 +1,24 @@ +From 3237f335c5b559c68749173f4343e6475f9eb8c7 Mon Sep 17 00:00:00 2001 +From: Florent Revest <[email protected]> +Date: Mon, 30 Oct 2017 21:05:46 +0100 +Subject: [PATCH] Allow adbd to be ran as root + +--- + adb/adb.c | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/adb/adb.c b/adb/adb.c +index 10a1e0d..a88641f 100644 +--- a/adb/adb.c ++++ b/adb/adb.c +@@ -1267,6 +1267,7 @@ static int should_drop_privileges() { + int secure = 0; + char value[PROPERTY_VALUE_MAX]; + ++ return 0; + /* run adbd in secure mode if ro.secure is set and + ** we are not in the emulator + */ +-- +2.14.3 +
meta-oe/recipes-devtools/android-tools/android-tools/android-tools-adbd.service +3 -2
@@ -1,12 +1,13 @@ [Unit] Description=Android Debug Bridge +ConditionPathExists=/var/usb-debugging-enabled +Before=android-system.service [Service] Type=simple Restart=on-failure -ExecStartPre=/usr/bin/android-gadget-setup adb +ExecStartPre=-/usr/bin/android-gadget-setup adb ExecStart=/usr/bin/adbd -StandardOutput=null [Install] WantedBy=basic.target
meta-oe/recipes-devtools/android-tools/android-tools_5.1.1.r37.bb +1 -0
@@ -49,6 +49,7 @@ SRC_URI = " \ file://fastboot.mk;subdir=${BPN} \ file://mkbootimg.mk;subdir=${BPN} \ file://0001-usb_linux.c-fix-build-with-glibc-2.28.patch;patchdir=system/core \ + file://0001-Allow-adbd-to-be-ran-as-root.patch;patchdir=system/core \ " S = "${WORKDIR}/git"
Signature · 1 line
2.17.1
PATCH 3/4 android-tools: use patchdir parameter to apply patches
In reply to Martin Jansa* helps to apply the patches for correct git repo
* split remove-selinux-android.patch into 2, because devtool modify fails to apply
it across 2 different git repositories:
ERROR: Command Error: 'sh -c 'PATCHFILE="remove-selinux-android.patch" git -c user.name="OpenEmbedded" -c user.email="oe.patch@oe" commit -F /tmp/tmpvn7yf20j --author="Sergio Schvezov <[email protected]>" --date="Wed, 7 Sep 2016 12:58:47 +0300"'' exited with 0 Output:
On branch devtool
Changes not staged for commit:
modified: system/core (modified content)
modified: system/extras (modified content)
no changes added to commit
ERROR: Function failed: patch_do_patch
ERROR: Logfile of failure stored in: /OE/build/owpb/webos-ports/tmp-glibc/work/aarch64-webos-linux/android-tools/5.1.1.r37-r0/devtooltmp-7qrccor9/temp/log.do_patch.8643
NOTE: Tasks Summary: Attempted 3 tasks of which 0 didn't need to be rerun and 1 failed.
NOTE: Writing buildhistory
ERROR: Extracting source for android-tools failed
* similarly with remove-bionic-android.patch
--- .../0001-add-base64-implementation.patch | 16 +++++----- .../android-tools/0002-adb-Musl-fixes.patch | 32 +++++++++---------- .../android-tools/define-shell-command.patch | 6 ++-- .../android-tools/fix-big-endian-build.patch | 6 ++-- ...eclaration-function-strlcat-strlcopy.patch | 18 +++++------ ...Add-dt-parameter-to-specify-DT-image.patch | 12 +++---- .../remove-bionic-android-libselinux.patch | 16 ++++++++++ .../android-tools/remove-bionic-android.patch | 29 ++++++----------- .../remove-selinux-android-extras.patch | 28 ++++++++++++++++ .../remove-selinux-android.patch | 29 ++--------------- .../android-tools/use-capability.patch | 6 ++-- .../android-tools/use-local-socket.patch | 18 +++++------ .../android-tools/android-tools_5.1.1.r37.bb | 26 ++++++++------- 13 files changed, 127 insertions(+), 115 deletions(-) create mode 100644 meta-oe/recipes-devtools/android-tools/android-tools/remove-bionic-android-libselinux.patch create mode 100644 meta-oe/recipes-devtools/android-tools/android-tools/remove-selinux-android-extras.patch
meta-oe/recipes-devtools/android-tools/android-tools/0001-add-base64-implementation.patch +8 -8
@@ -7,15 +7,15 @@ musl needs it Signed-off-by: Khem Raj <[email protected]> --- - system/core/adb/adb_auth_client.c | 2 +- - system/core/adb/base64.c | 315 ++++++++++++++++++++++++++++++++++++++ + adb/adb_auth_client.c | 2 +- + adb/base64.c | 315 ++++++++++++++++++++++++++++++++++++++ 2 files changed, 316 insertions(+), 1 deletion(-) - create mode 100644 system/core/adb/base64.c + create mode 100644 adb/base64.c -diff --git a/system/core/adb/adb_auth_client.c b/system/core/adb/adb_auth_client.c +diff --git a/adb/adb_auth_client.c b/adb/adb_auth_client.c index 55e9dca..104b413 100644 ---- a/system/core/adb/adb_auth_client.c -+++ b/system/core/adb/adb_auth_client.c +--- a/adb/adb_auth_client.c ++++ b/adb/adb_auth_client.c @@ -75,7 +75,7 @@ static void read_keys(const char *file, struct listnode *list) if (sep) *sep = '\0';
@@ -25,11 +25,11 @@ index 55e9dca..104b413 100644 if (ret != sizeof(key->key)) { D("%s: Invalid base64 data ret=%d\n", file, ret); free(key); -diff --git a/system/core/adb/base64.c b/system/core/adb/base64.c +diff --git a/adb/base64.c b/adb/base64.c new file mode 100644 index 0000000..95da284 --- /dev/null -+++ b/system/core/adb/base64.c ++++ b/adb/base64.c @@ -0,0 +1,315 @@ +/* + * Copyright (c) 1996-1999 by Internet Software Consortium.
meta-oe/recipes-devtools/android-tools/android-tools/0002-adb-Musl-fixes.patch +16 -16
@@ -9,16 +9,16 @@ Do not redefine close() and lseek() Signed-off-by: Khem Raj <[email protected]> --- - system/core/adb/adb.h | 2 ++ - system/core/adb/disable_verity_service.c | 13 ++++++++----- - system/core/adb/framebuffer_service.c | 7 ++++--- - system/core/adb/sysdeps.h | 12 ++++++------ + adb/adb.h | 2 ++ + adb/disable_verity_service.c | 13 ++++++++----- + adb/framebuffer_service.c | 7 ++++--- + adb/sysdeps.h | 12 ++++++------ 4 files changed, 20 insertions(+), 14 deletions(-) -diff --git a/system/core/adb/adb.h b/system/core/adb/adb.h +diff --git a/adb/adb.h b/adb/adb.h index 44e5981..bcdc49f 100644 ---- a/system/core/adb/adb.h -+++ b/system/core/adb/adb.h +--- a/adb/adb.h ++++ b/adb/adb.h @@ -18,7 +18,9 @@ #define __ADB_H
@@ -29,10 +29,10 @@ index 44e5981..bcdc49f 100644 #include "adb_trace.h" #include "transport.h" /* readx(), writex() */ -diff --git a/system/core/adb/disable_verity_service.c b/system/core/adb/disable_verity_service.c +diff --git a/adb/disable_verity_service.c b/adb/disable_verity_service.c index ed3da52..29fa3d6 100644 ---- a/system/core/adb/disable_verity_service.c -+++ b/system/core/adb/disable_verity_service.c +--- a/adb/disable_verity_service.c ++++ b/adb/disable_verity_service.c @@ -14,25 +14,28 @@ * limitations under the License. */
@@ -67,10 +67,10 @@ index ed3da52..29fa3d6 100644 static void write_console(int fd, const char* format, ...) { char buffer[256]; -diff --git a/system/core/adb/framebuffer_service.c b/system/core/adb/framebuffer_service.c +diff --git a/adb/framebuffer_service.c b/adb/framebuffer_service.c index 8cbe840..8f0ccfb 100644 ---- a/system/core/adb/framebuffer_service.c -+++ b/system/core/adb/framebuffer_service.c +--- a/adb/framebuffer_service.c ++++ b/adb/framebuffer_service.c @@ -14,6 +14,10 @@ * limitations under the License. */
@@ -92,10 +92,10 @@ index 8cbe840..8f0ccfb 100644 #include <linux/fb.h> #include <sys/ioctl.h> #include <sys/mman.h> -diff --git a/system/core/adb/sysdeps.h b/system/core/adb/sysdeps.h +diff --git a/adb/sysdeps.h b/adb/sysdeps.h index cc1f839..ea39ac3 100644 ---- a/system/core/adb/sysdeps.h -+++ b/system/core/adb/sysdeps.h +--- a/adb/sysdeps.h ++++ b/adb/sysdeps.h @@ -123,8 +123,8 @@ static __inline__ int unix_close(int fd) { return close(fd);
meta-oe/recipes-devtools/android-tools/android-tools/define-shell-command.patch +3 -3
@@ -4,11 +4,11 @@ Author: Fathi Boudra <[email protected]> Upstream-Status: Inappropriate --- - system/core/adb/services.c | 4 ---- + adb/services.c | 4 ---- 1 file changed, 4 deletions(-) ---- a/system/core/adb/services.c -+++ b/system/core/adb/services.c +--- a/adb/services.c ++++ b/adb/services.c @@ -299,11 +299,7 @@ static int create_subproc_raw(const char } #endif /* !ABD_HOST */
meta-oe/recipes-devtools/android-tools/android-tools/fix-big-endian-build.patch +3 -3
@@ -15,10 +15,10 @@ them to be used when initializing structures. Signed-off-by: Thomas Petazzoni <[email protected]> -Index: b/system/core/adb/usb_linux_client.c +Index: b/adb/usb_linux_client.c =================================================================== ---- a/system/core/adb/usb_linux_client.c -+++ b/system/core/adb/usb_linux_client.c +--- a/adb/usb_linux_client.c ++++ b/adb/usb_linux_client.c @@ -34,8 +34,15 @@ #define MAX_PACKET_SIZE_FS 64 #define MAX_PACKET_SIZE_HS 512
meta-oe/recipes-devtools/android-tools/android-tools/implicit-declaration-function-strlcat-strlcopy.patch +9 -9
@@ -3,13 +3,13 @@ Author: Fathi Boudra <[email protected]> Upstream-Status: Inappropriate --- - system/core/adb/adb.c | 1 + - system/core/fs_mgr/fs_mgr_fstab.c | 2 +- - system/core/include/cutils/sockets.h | 2 +- + adb/adb.c | 1 + + fs_mgr/fs_mgr_fstab.c | 2 +- + include/cutils/sockets.h | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) ---- a/system/core/fs_mgr/fs_mgr_fstab.c -+++ b/system/core/fs_mgr/fs_mgr_fstab.c +--- a/fs_mgr/fs_mgr_fstab.c ++++ b/fs_mgr/fs_mgr_fstab.c @@ -17,7 +17,7 @@ #include <ctype.h> #include <stdio.h>
@@ -19,8 +19,8 @@ Upstream-Status: Inappropriate #include <sys/mount.h> #include "fs_mgr_priv.h" ---- a/system/core/include/cutils/sockets.h -+++ b/system/core/include/cutils/sockets.h +--- a/include/cutils/sockets.h ++++ b/include/cutils/sockets.h @@ -19,7 +19,7 @@ #include <errno.h>
@@ -30,8 +30,8 @@ Upstream-Status: Inappropriate #include <stdbool.h> #ifdef HAVE_WINSOCK ---- a/system/core/adb/adb.c -+++ b/system/core/adb/adb.c +--- a/adb/adb.c ++++ b/adb/adb.c @@ -41,6 +41,7 @@ #include <sys/prctl.h> #include <getopt.h>
meta-oe/recipes-devtools/android-tools/android-tools/mkbootimg-Add-dt-parameter-to-specify-DT-image.patch +6 -6
@@ -10,12 +10,12 @@ Change-Id: Ie29a11cbf4138426bfd19ae486d69a5fcbd8f442 Upstream-Status: Inappropriate --- - system/core/mkbootimg/bootimg.h | 7 +++++-- - system/core/mkbootimg/mkbootimg.c | 21 +++++++++++++++++++++ + mkbootimg/bootimg.h | 7 +++++-- + mkbootimg/mkbootimg.c | 21 +++++++++++++++++++++ 2 files changed, 26 insertions(+), 2 deletions(-) ---- a/system/core/mkbootimg/bootimg.h -+++ b/system/core/mkbootimg/bootimg.h +--- a/mkbootimg/bootimg.h ++++ b/mkbootimg/bootimg.h @@ -41,8 +41,8 @@ struct boot_img_hdr unsigned tags_addr; /* physical addr for kernel tags */
@@ -41,8 +41,8 @@ Upstream-Status: Inappropriate ** ** 0. all entities are page_size aligned in flash ** 1. kernel and ramdisk are required (size != 0) ---- a/system/core/mkbootimg/mkbootimg.c -+++ b/system/core/mkbootimg/mkbootimg.c +--- a/mkbootimg/mkbootimg.c ++++ b/mkbootimg/mkbootimg.c @@ -65,6 +65,7 @@ int usage(void) " [ --board <boardname> ]\n" " [ --base <address> ]\n"
meta-oe/recipes-devtools/android-tools/android-tools/remove-bionic-android-libselinux.patch new file +16 -0
@@ -0,0 +1,16 @@ +Description: remove bionic specific calls +Author: Fathi Boudra <[email protected]> + +Upstream-Status: Inappropriate +--- +--- a/src/procattr.c ++++ b/src/procattr.c +@@ -8,7 +8,7 @@ + #include "selinux_internal.h" + #include "policy.h" + +-#ifdef HOST ++#ifndef __BIONIC__ + static pid_t gettid(void) + { + return syscall(__NR_gettid);
meta-oe/recipes-devtools/android-tools/android-tools/remove-bionic-android.patch +9 -20
@@ -3,13 +3,13 @@ Author: Fathi Boudra <[email protected]> Upstream-Status: Inappropriate --- - system/core/include/cutils/properties.h | 1 - - system/core/libcutils/properties.c | 2 +- - system/core/liblog/logd_write.c | 5 +++++ + include/cutils/properties.h | 1 - + libcutils/properties.c | 2 +- + liblog/logd_write.c | 5 +++++ 3 files changed, 6 insertions(+), 2 deletions(-) ---- a/system/core/include/cutils/properties.h -+++ b/system/core/include/cutils/properties.h +--- a/include/cutils/properties.h ++++ b/include/cutils/properties.h @@ -19,7 +19,6 @@ #include <sys/cdefs.h>
@@ -18,8 +18,8 @@ Upstream-Status: Inappropriate #include <stdint.h> #ifdef __cplusplus ---- a/system/core/liblog/logd_write.c -+++ b/system/core/liblog/logd_write.c +--- a/liblog/logd_write.c ++++ b/liblog/logd_write.c @@ -23,6 +23,7 @@ #include <stdlib.h> #include <string.h>
@@ -40,8 +40,8 @@ Upstream-Status: Inappropriate newVec[0].iov_base = (unsigned char *) &log_id_buf; newVec[0].iov_len = sizeof_log_id_t; ---- a/system/core/libcutils/properties.c -+++ b/system/core/libcutils/properties.c +--- a/libcutils/properties.c ++++ b/libcutils/properties.c @@ -104,10 +104,10 @@ int32_t property_get_int32(const char *k return (int32_t)property_get_imax(key, INT32_MIN, INT32_MAX, default_value); }
@@ -54,14 +54,3 @@ Upstream-Status: Inappropriate int property_set(const char *key, const char *value) { ---- a/external/libselinux/src/procattr.c -+++ b/external/libselinux/src/procattr.c -@@ -8,7 +8,7 @@ - #include "selinux_internal.h" - #include "policy.h" - --#ifdef HOST -+#ifndef __BIONIC__ - static pid_t gettid(void) - { - return syscall(__NR_gettid);
meta-oe/recipes-devtools/android-tools/android-tools/remove-selinux-android-extras.patch new file +28 -0
@@ -0,0 +1,28 @@ +Subject: drop useless includes of Android SELINUX extensions; avoids having to clone another module; this should be sent upstream +Author: Sergio Schvezov <[email protected]> + +Upstream-Status: Inappropriate +--- + ext4_utils/make_ext4fs.c | 1 - + ext4_utils/make_ext4fs_main.c | 1 - + +--- a/ext4_utils/make_ext4fs.c ++++ b/ext4_utils/make_ext4fs.c +@@ -62,7 +62,6 @@ + + #include <selinux/selinux.h> + #include <selinux/label.h> +-#include <selinux/android.h> + + #define O_BINARY 0 + +--- a/ext4_utils/make_ext4fs_main.c ++++ b/ext4_utils/make_ext4fs_main.c +@@ -32,7 +32,6 @@ + #ifndef USE_MINGW + #include <selinux/selinux.h> + #include <selinux/label.h> +-#include <selinux/android.h> + #else + struct selabel_handle; + #endif
meta-oe/recipes-devtools/android-tools/android-tools/remove-selinux-android.patch +3 -26
@@ -3,33 +3,10 @@ Author: Sergio Schvezov <[email protected]> Upstream-Status: Inappropriate --- - system/core/adb/file_sync_service.c | 3 --- - system/extras/ext4_utils/make_ext4fs.c | 1 - - system/extras/ext4_utils/make_ext4fs_main.c | 1 - - 3 files changed, 5 deletions(-) + adb/file_sync_service.c | 3 --- ---- a/system/extras/ext4_utils/make_ext4fs.c -+++ b/system/extras/ext4_utils/make_ext4fs.c -@@ -62,7 +62,6 @@ - - #include <selinux/selinux.h> - #include <selinux/label.h> --#include <selinux/android.h> - - #define O_BINARY 0 - ---- a/system/extras/ext4_utils/make_ext4fs_main.c -+++ b/system/extras/ext4_utils/make_ext4fs_main.c -@@ -32,7 +32,6 @@ - #ifndef USE_MINGW - #include <selinux/selinux.h> - #include <selinux/label.h> --#include <selinux/android.h> - #else - struct selabel_handle; - #endif ---- a/system/core/adb/file_sync_service.c -+++ b/system/core/adb/file_sync_service.c +--- a/adb/file_sync_service.c ++++ b/adb/file_sync_service.c @@ -26,7 +26,6 @@ #include <errno.h>
meta-oe/recipes-devtools/android-tools/android-tools/use-capability.patch +3 -3
@@ -3,11 +3,11 @@ Author: Loïc Minier <[email protected]> Upstream-Status: Inappropriate --- - system/core/include/private/android_filesystem_config.h | 2 +- + include/private/android_filesystem_config.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ---- a/system/core/include/private/android_filesystem_config.h -+++ b/system/core/include/private/android_filesystem_config.h +--- a/include/private/android_filesystem_config.h ++++ b/include/private/android_filesystem_config.h @@ -27,7 +27,7 @@ #include <sys/types.h> #include <stdint.h>
meta-oe/recipes-devtools/android-tools/android-tools/use-local-socket.patch +9 -9
@@ -3,13 +3,13 @@ Author: Hilko Bengen <[email protected]> Upstream-Status: Inappropriate --- - system/core/adb/adb.c | 6 +++++- - system/core/adb/adb_client.c | 5 +++-- - system/core/adb/transport_local.c | 3 ++- + adb/adb.c | 6 +++++- + adb/adb_client.c | 5 +++-- + adb/transport_local.c | 3 ++- 3 files changed, 10 insertions(+), 4 deletions(-) ---- a/system/core/adb/adb.c -+++ b/system/core/adb/adb.c +--- a/adb/adb.c ++++ b/adb/adb.c @@ -1230,7 +1230,11 @@ int launch_server(int server_port) */ void build_local_name(char* target_str, size_t target_size, int server_port)
@@ -23,8 +23,8 @@ Upstream-Status: Inappropriate } #if !ADB_HOST ---- a/system/core/adb/adb_client.c -+++ b/system/core/adb/adb_client.c +--- a/adb/adb_client.c ++++ b/adb/adb_client.c @@ -185,12 +185,12 @@ int _adb_connect(const char *service) strcpy(__adb_error, "service name too long"); return -1;
@@ -48,8 +48,8 @@ Upstream-Status: Inappropriate if(writex(fd, tmp, 4) || writex(fd, service, len)) { strcpy(__adb_error, "write failure during connection"); adb_close(fd); ---- a/system/core/adb/transport_local.c -+++ b/system/core/adb/transport_local.c +--- a/adb/transport_local.c ++++ b/adb/transport_local.c @@ -121,7 +121,8 @@ int local_connect_arbitrary_ports(int co } #endif
meta-oe/recipes-devtools/android-tools/android-tools_5.1.1.r37.bb +14 -12
@@ -30,17 +30,21 @@ SRC_URI = " \ git://${LIBHARDWARE_REPO};name=libhardware;protocol=https;nobranch=1;destsuffix=git/hardware/libhardware \ git://${LIBSELINUX_REPO};name=libselinux;protocol=https;nobranch=1;destsuffix=git/external/libselinux \ git://${BUILD_REPO};name=build;protocol=https;nobranch=1;destsuffix=git/build \ - file://remove-selinux-android.patch \ - file://use-capability.patch \ - file://use-local-socket.patch \ + file://remove-selinux-android.patch;patchdir=system/core \ + file://use-capability.patch;patchdir=system/core \ + file://use-local-socket.patch;patchdir=system/core \ + file://mkbootimg-Add-dt-parameter-to-specify-DT-image.patch;patchdir=system/core \ + file://remove-bionic-android.patch;patchdir=system/core \ + file://define-shell-command.patch;patchdir=system/core \ + file://implicit-declaration-function-strlcat-strlcopy.patch;patchdir=system/core \ + file://fix-big-endian-build.patch;patchdir=system/core \ + file://0001-add-base64-implementation.patch;patchdir=system/core \ + file://0002-adb-Musl-fixes.patch;patchdir=system/core \ + file://0001-usb_linux.c-fix-build-with-glibc-2.28.patch;patchdir=system/core \ + file://0001-Allow-adbd-to-be-ran-as-root.patch;patchdir=system/core \ + file://remove-selinux-android-extras.patch;patchdir=system/extras \ file://preserve-ownership.patch;patchdir=system/extras \ - file://mkbootimg-Add-dt-parameter-to-specify-DT-image.patch \ - file://remove-bionic-android.patch \ - file://define-shell-command.patch \ - file://implicit-declaration-function-strlcat-strlcopy.patch \ - file://fix-big-endian-build.patch \ - file://0001-add-base64-implementation.patch \ - file://0002-adb-Musl-fixes.patch \ + file://remove-bionic-android-libselinux.patch;patchdir=external/libselinux \ file://android-tools-adbd.service \ file://.gitignore;subdir=git \ file://adb.mk;subdir=${BPN} \
@@ -48,8 +52,6 @@ SRC_URI = " \ file://ext4_utils.mk;subdir=${BPN} \ file://fastboot.mk;subdir=${BPN} \ file://mkbootimg.mk;subdir=${BPN} \ - file://0001-usb_linux.c-fix-build-with-glibc-2.28.patch;patchdir=system/core \ - file://0001-Allow-adbd-to-be-ran-as-root.patch;patchdir=system/core \ " S = "${WORKDIR}/git"
Signature · 1 line
2.17.1
PATCH 4/4 android-tools: refresh patches with devtool
In reply to Martin Jansa* devtool isn't able to regenerate them completely, it generates only top level commit which says that submodules were changed, like this:
From c8fa114325e4e532657499b9bb6fd23cb6536eaa Mon Sep 17 00:00:00 2001
From: OpenEmbedded <oe.patch@oe>
Date: Tue, 2 Oct 2018 16:46:55 +0000
Subject: [PATCH] Committing changes from do_patch
---
external/libselinux | 2 +- system/core | 2 +- system/extras | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)
..
but it still creates relatively good commits in each submodule and after small manual cleanup they can be exported with git format-patch --no-numbered --no-signature
* rename .gitignore to prevent git ignoring the changes in .patch files in meta-oe already (we want to use it only later during the build)
---
.../0001-adb-remove-selinux-extensions.patch} | 19 +++++--
...Use-local-sockets-where-appropriate.patch} | 20 +++++---
.../0003-adb-define-shell-command.patch} | 16 ++++--
...adb-Fix-build-on-big-endian-systems.patch} | 12 +++--
.../0005-adb-add-base64-implementation.patch} | 13 ++---
.../0006-adb-Musl-fixes.patch} | 15 +++---
...b_linux.c-fix-build-with-glibc-2.28.patch} | 6 +--
...08-adb-Allow-adbd-to-be-ran-as-root.patch} | 11 ++--
...dd-dt-parameter-to-specify-DT-image.patch} | 14 +++---
...x-capability.h-on-linux-systems-too.patch} | 10 ++--
.../0011-Remove-bionic-specific-calls.patch} | 48 ++++++++++--------
...aration-of-stlcat-strlcopy-function.patch} | 38 ++++++++------
...xt4_utils-remove-selinux-extensions.patch} | 19 +++++--
...dd-o-argument-to-preserve-ownership.patch} | 21 ++++----
.../android-tools/{.gitignore => gitignore} | 0
.../0001-Remove-bionic-specific-calls.patch} | 13 ++++-
.../android-tools/android-tools_5.1.1.r37.bb | 50 +++++++++----------
17 files changed, 192 insertions(+), 133 deletions(-)
rename meta-oe/recipes-devtools/android-tools/android-tools/{remove-selinux-android.patch => core/0001-adb-remove-selinux-extensions.patch} (51%)
rename meta-oe/recipes-devtools/android-tools/android-tools/{use-local-socket.patch => core/0002-adb-Use-local-sockets-where-appropriate.patch} (73%)
rename meta-oe/recipes-devtools/android-tools/android-tools/{define-shell-command.patch => core/0003-adb-define-shell-command.patch} (39%)
rename meta-oe/recipes-devtools/android-tools/android-tools/{fix-big-endian-build.patch => core/0004-adb-Fix-build-on-big-endian-systems.patch} (74%)
rename meta-oe/recipes-devtools/android-tools/android-tools/{0001-add-base64-implementation.patch => core/0005-adb-add-base64-implementation.patch} (98%)
rename meta-oe/recipes-devtools/android-tools/android-tools/{0002-adb-Musl-fixes.patch => core/0006-adb-Musl-fixes.patch} (92%)
rename meta-oe/recipes-devtools/android-tools/android-tools/{0001-usb_linux.c-fix-build-with-glibc-2.28.patch => core/0007-adb-usb_linux.c-fix-build-with-glibc-2.28.patch} (76%)
rename meta-oe/recipes-devtools/android-tools/android-tools/{0001-Allow-adbd-to-be-ran-as-root.patch => core/0008-adb-Allow-adbd-to-be-ran-as-root.patch} (64%)
rename meta-oe/recipes-devtools/android-tools/android-tools/{mkbootimg-Add-dt-parameter-to-specify-DT-image.patch => core/0009-mkbootimg-Add-dt-parameter-to-specify-DT-image.patch} (89%)
rename meta-oe/recipes-devtools/android-tools/android-tools/{use-capability.patch => core/0010-Use-linux-capability.h-on-linux-systems-too.patch} (49%)
rename meta-oe/recipes-devtools/android-tools/android-tools/{remove-bionic-android.patch => core/0011-Remove-bionic-specific-calls.patch} (59%)
rename meta-oe/recipes-devtools/android-tools/android-tools/{implicit-declaration-function-strlcat-strlcopy.patch => core/0012-Fix-implicit-declaration-of-stlcat-strlcopy-function.patch} (55%)
rename meta-oe/recipes-devtools/android-tools/android-tools/{remove-selinux-android-extras.patch => extras/0001-ext4_utils-remove-selinux-extensions.patch} (41%)
rename meta-oe/recipes-devtools/android-tools/android-tools/{preserve-ownership.patch => extras/0002-ext4_utils-add-o-argument-to-preserve-ownership.patch} (82%)
rename meta-oe/recipes-devtools/android-tools/android-tools/{.gitignore => gitignore} (100%)
rename meta-oe/recipes-devtools/android-tools/android-tools/{remove-bionic-android-libselinux.patch => libselinux/0001-Remove-bionic-specific-calls.patch} (38%)meta-oe/recipes-devtools/android-tools/android-tools/core/0001-adb-remove-selinux-extensions.patch renamed from meta-oe/recipes-devtools/android-tools/android-tools/remove-selinux-android.patch +15 -4
@@ -1,10 +1,21 @@ -Subject: drop useless includes of Android SELINUX extensions; avoids having to clone another module; this should be sent upstream -Author: Sergio Schvezov <[email protected]> +From 7b7200727413ca4a9bb132221c543ec033dffafa Mon Sep 17 00:00:00 2001 +From: Sergio Schvezov <[email protected]> +Date: Wed, 7 Sep 2016 12:58:47 +0300 +Subject: [PATCH] adb: remove selinux extensions + +* drop useless includes of Android SELINUX extensions +* avoids having to clone another module +* this should be sent upstream Upstream-Status: Inappropriate + +Signed-off-by: Martin Jansa <[email protected]> --- - adb/file_sync_service.c | 3 --- + adb/file_sync_service.c | 3 --- + 1 file changed, 3 deletions(-) +diff --git a/adb/file_sync_service.c b/adb/file_sync_service.c +index 7933858516..3cbd0cd863 100644 --- a/adb/file_sync_service.c +++ b/adb/file_sync_service.c @@ -26,7 +26,6 @@
@@ -23,7 +34,7 @@ Upstream-Status: Inappropriate } *x++ = '/'; } -@@ -251,7 +249,6 @@ static int handle_send_file(int s, char +@@ -251,7 +249,6 @@ static int handle_send_file(int s, char *path, uid_t uid, if(fd >= 0) { struct utimbuf u; adb_close(fd);
meta-oe/recipes-devtools/android-tools/android-tools/core/0002-adb-Use-local-sockets-where-appropriate.patch renamed from meta-oe/recipes-devtools/android-tools/android-tools/use-local-socket.patch +14 -6
@@ -1,13 +1,17 @@ -Subject: adb: Use local sockets where appropriate -Author: Hilko Bengen <[email protected]> +From d855f042ca09a358cebe2d3c1d29d512afd7ebb8 Mon Sep 17 00:00:00 2001 +From: Hilko Bengen <[email protected]> +Date: Wed, 7 Sep 2016 12:58:47 +0300 +Subject: [PATCH] adb: Use local sockets where appropriate Upstream-Status: Inappropriate --- - adb/adb.c | 6 +++++- - adb/adb_client.c | 5 +++-- - adb/transport_local.c | 3 ++- + adb/adb.c | 6 +++++- + adb/adb_client.c | 5 +++-- + adb/transport_local.c | 3 ++- 3 files changed, 10 insertions(+), 4 deletions(-) +diff --git a/adb/adb.c b/adb/adb.c +index 10a1e0da26..027edd9359 100644 --- a/adb/adb.c +++ b/adb/adb.c @@ -1230,7 +1230,11 @@ int launch_server(int server_port)
@@ -23,6 +27,8 @@ Upstream-Status: Inappropriate } #if !ADB_HOST +diff --git a/adb/adb_client.c b/adb/adb_client.c +index eb1720d22c..a383faefe3 100644 --- a/adb/adb_client.c +++ b/adb/adb_client.c @@ -185,12 +185,12 @@ int _adb_connect(const char *service)
@@ -48,9 +54,11 @@ Upstream-Status: Inappropriate if(writex(fd, tmp, 4) || writex(fd, service, len)) { strcpy(__adb_error, "write failure during connection"); adb_close(fd); +diff --git a/adb/transport_local.c b/adb/transport_local.c +index 948cc15812..71582a8c88 100644 --- a/adb/transport_local.c +++ b/adb/transport_local.c -@@ -121,7 +121,8 @@ int local_connect_arbitrary_ports(int co +@@ -121,7 +121,8 @@ int local_connect_arbitrary_ports(int console_port, int adb_port) } #endif if (fd < 0) {
meta-oe/recipes-devtools/android-tools/android-tools/core/0003-adb-define-shell-command.patch renamed from meta-oe/recipes-devtools/android-tools/android-tools/define-shell-command.patch +11 -5
@@ -1,15 +1,21 @@ -Description: we intend to run on Linux system so the shell is always /bin/sh, - for the host or the target. -Author: Fathi Boudra <[email protected]> +From 4421c2e19946dcd651fd8ac022b96627fc526149 Mon Sep 17 00:00:00 2001 +From: Fathi Boudra <[email protected]> +Date: Wed, 7 Sep 2016 12:58:47 +0300 +Subject: [PATCH] adb: define shell command + +we intend to run on Linux system so the shell is always /bin/sh, +for the host or the target. Upstream-Status: Inappropriate --- - adb/services.c | 4 ---- + adb/services.c | 4 ---- 1 file changed, 4 deletions(-) +diff --git a/adb/services.c b/adb/services.c +index 21b08dc201..d44b0c5068 100644 --- a/adb/services.c +++ b/adb/services.c -@@ -299,11 +299,7 @@ static int create_subproc_raw(const char +@@ -299,11 +299,7 @@ static int create_subproc_raw(const char *cmd, const char *arg0, const char *arg } #endif /* !ABD_HOST */
meta-oe/recipes-devtools/android-tools/android-tools/core/0004-adb-Fix-build-on-big-endian-systems.patch renamed from meta-oe/recipes-devtools/android-tools/android-tools/fix-big-endian-build.patch +9 -3
@@ -1,4 +1,7 @@ -Fix build on big endian systems +From 548b8ca62c64a16305929e2eaf3d546d48de9c25 Mon Sep 17 00:00:00 2001 +From: Thomas Petazzoni <[email protected]> +Date: Tue, 21 Feb 2017 19:46:24 +0100 +Subject: [PATCH] adb: Fix build on big endian systems The usb_linux_client.c file defines cpu_to_le16/32 by using the C library htole16/32 function calls. However, cpu_to_le16/32 are used
@@ -14,9 +17,12 @@ To solve this, we simply open-code cpu_to_le16/32 in a way that allows them to be used when initializing structures. Signed-off-by: Thomas Petazzoni <[email protected]> +--- + adb/usb_linux_client.c | 11 +++++++++-- + 1 file changed, 9 insertions(+), 2 deletions(-) -Index: b/adb/usb_linux_client.c -=================================================================== +diff --git a/adb/usb_linux_client.c b/adb/usb_linux_client.c +index 8426e0ea14..6e8b5bbbd2 100644 --- a/adb/usb_linux_client.c +++ b/adb/usb_linux_client.c @@ -34,8 +34,15 @@
meta-oe/recipes-devtools/android-tools/android-tools/core/0005-adb-add-base64-implementation.patch renamed from meta-oe/recipes-devtools/android-tools/android-tools/0001-add-base64-implementation.patch +5 -8
@@ -1,19 +1,19 @@ -From bbeb72f11c64f190b23abbed5f44311bd021bdc9 Mon Sep 17 00:00:00 2001 +From 753bcb5971401b82fb2e6197d31c9e386f6d0392 Mon Sep 17 00:00:00 2001 From: Khem Raj <[email protected]> Date: Fri, 15 Sep 2017 15:46:38 -0700 -Subject: [PATCH 1/2] add base64 implementation +Subject: [PATCH] adb: add base64 implementation musl needs it Signed-off-by: Khem Raj <[email protected]> --- adb/adb_auth_client.c | 2 +- - adb/base64.c | 315 ++++++++++++++++++++++++++++++++++++++ + adb/base64.c | 315 ++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 316 insertions(+), 1 deletion(-) create mode 100644 adb/base64.c diff --git a/adb/adb_auth_client.c b/adb/adb_auth_client.c -index 55e9dca..104b413 100644 +index 55e9dcad19..104b413b8b 100644 --- a/adb/adb_auth_client.c +++ b/adb/adb_auth_client.c @@ -75,7 +75,7 @@ static void read_keys(const char *file, struct listnode *list)
@@ -27,7 +27,7 @@ index 55e9dca..104b413 100644 free(key); diff --git a/adb/base64.c b/adb/base64.c new file mode 100644 -index 0000000..95da284 +index 0000000000..95da284d0d --- /dev/null +++ b/adb/base64.c @@ -0,0 +1,315 @@
@@ -346,6 +346,3 @@ index 0000000..95da284 + return (tarindex); +} + --- -2.14.1 -
meta-oe/recipes-devtools/android-tools/android-tools/core/0006-adb-Musl-fixes.patch renamed from meta-oe/recipes-devtools/android-tools/android-tools/0002-adb-Musl-fixes.patch +6 -9
@@ -1,7 +1,7 @@ -From f8653ed0ede4aa781ab758fcd44fdc05ffbe0b0a Mon Sep 17 00:00:00 2001 +From 62d957a1271c88ec08d67984fbe31601f0bd41a9 Mon Sep 17 00:00:00 2001 From: Khem Raj <[email protected]> Date: Fri, 15 Sep 2017 15:50:57 -0700 -Subject: [PATCH 2/2] adb: Musl fixes +Subject: [PATCH] adb: Musl fixes __nonnull is gcc specific include sys/types.h for size_t
@@ -16,7 +16,7 @@ Signed-off-by: Khem Raj <[email protected]> 4 files changed, 20 insertions(+), 14 deletions(-) diff --git a/adb/adb.h b/adb/adb.h -index 44e5981..bcdc49f 100644 +index 44e5981bdc..bcdc49f63c 100644 --- a/adb/adb.h +++ b/adb/adb.h @@ -18,7 +18,9 @@
@@ -30,7 +30,7 @@ index 44e5981..bcdc49f 100644 #include "transport.h" /* readx(), writex() */ diff --git a/adb/disable_verity_service.c b/adb/disable_verity_service.c -index ed3da52..29fa3d6 100644 +index ed3da52108..29fa3d65a9 100644 --- a/adb/disable_verity_service.c +++ b/adb/disable_verity_service.c @@ -14,25 +14,28 @@
@@ -68,7 +68,7 @@ index ed3da52..29fa3d6 100644 { char buffer[256]; diff --git a/adb/framebuffer_service.c b/adb/framebuffer_service.c -index 8cbe840..8f0ccfb 100644 +index 8cbe8403cc..8f0ccfb7aa 100644 --- a/adb/framebuffer_service.c +++ b/adb/framebuffer_service.c @@ -14,6 +14,10 @@
@@ -93,7 +93,7 @@ index 8cbe840..8f0ccfb 100644 #include <sys/ioctl.h> #include <sys/mman.h> diff --git a/adb/sysdeps.h b/adb/sysdeps.h -index cc1f839..ea39ac3 100644 +index cc1f839e9f..ea39ac39cc 100644 --- a/adb/sysdeps.h +++ b/adb/sysdeps.h @@ -123,8 +123,8 @@ static __inline__ int unix_close(int fd)
@@ -129,6 +129,3 @@ index cc1f839..ea39ac3 100644 static __inline__ int adb_unlink(const char* path) { --- -2.14.1 -
meta-oe/recipes-devtools/android-tools/android-tools/core/0007-adb-usb_linux.c-fix-build-with-glibc-2.28.patch renamed from meta-oe/recipes-devtools/android-tools/android-tools/0001-usb_linux.c-fix-build-with-glibc-2.28.patch +3 -3
@@ -1,7 +1,7 @@ -From cb80906bd3869bba370a088e4634ae4a8093fdd8 Mon Sep 17 00:00:00 2001 +From de393bba41c8feff932c77d6c30233945f380d42 Mon Sep 17 00:00:00 2001 From: Martin Jansa <[email protected]> Date: Sat, 11 Aug 2018 13:23:37 +0000 -Subject: [PATCH] usb_linux.c: fix build with glibc-2.28 +Subject: [PATCH] adb: usb_linux.c: fix build with glibc-2.28 * include sysmacros for major, minor
@@ -11,7 +11,7 @@ Signed-off-by: Martin Jansa <[email protected]> 1 file changed, 1 insertion(+) diff --git a/adb/usb_linux.c b/adb/usb_linux.c -index f16bdd036..c8a773244 100644 +index f16bdd0361..c8a7732441 100644 --- a/adb/usb_linux.c +++ b/adb/usb_linux.c @@ -22,6 +22,7 @@
meta-oe/recipes-devtools/android-tools/android-tools/core/0008-adb-Allow-adbd-to-be-ran-as-root.patch renamed from meta-oe/recipes-devtools/android-tools/android-tools/0001-Allow-adbd-to-be-ran-as-root.patch +4 -7
@@ -1,17 +1,17 @@ -From 3237f335c5b559c68749173f4343e6475f9eb8c7 Mon Sep 17 00:00:00 2001 +From 3a788e9168c9b9eac66c4fa479413f4a95c61be4 Mon Sep 17 00:00:00 2001 From: Florent Revest <[email protected]> Date: Mon, 30 Oct 2017 21:05:46 +0100 -Subject: [PATCH] Allow adbd to be ran as root +Subject: [PATCH] adb: Allow adbd to be ran as root --- adb/adb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/adb/adb.c b/adb/adb.c -index 10a1e0d..a88641f 100644 +index 027edd9359..e0f7ecde45 100644 --- a/adb/adb.c +++ b/adb/adb.c -@@ -1267,6 +1267,7 @@ static int should_drop_privileges() { +@@ -1271,6 +1271,7 @@ static int should_drop_privileges() { int secure = 0; char value[PROPERTY_VALUE_MAX];
@@ -19,6 +19,3 @@ index 10a1e0d..a88641f 100644 /* run adbd in secure mode if ro.secure is set and ** we are not in the emulator */ --- -2.14.3 -
meta-oe/recipes-devtools/android-tools/android-tools/core/0009-mkbootimg-Add-dt-parameter-to-specify-DT-image.patch renamed from meta-oe/recipes-devtools/android-tools/android-tools/mkbootimg-Add-dt-parameter-to-specify-DT-image.patch +8 -6
@@ -1,19 +1,19 @@ -From cc5e7b02a3be57709a1aed6e34be100b82a71620 Mon Sep 17 00:00:00 2001 +From dd195778a9930b7967b21a3b8eb390b70253dbad Mon Sep 17 00:00:00 2001 From: David Ng <[email protected]> Date: Fri, 27 Jul 2012 17:15:03 -0700 -Subject: [PATCH 1/2] mkbootimg: Add --dt parameter to specify DT image +Subject: [PATCH] mkbootimg: Add --dt parameter to specify DT image New optional --dt parameter to specify a kernel device tree image. -Change-Id: Ie29a11cbf4138426bfd19ae486d69a5fcbd8f442 - Upstream-Status: Inappropriate --- - mkbootimg/bootimg.h | 7 +++++-- - mkbootimg/mkbootimg.c | 21 +++++++++++++++++++++ + mkbootimg/bootimg.h | 7 +++++-- + mkbootimg/mkbootimg.c | 21 +++++++++++++++++++++ 2 files changed, 26 insertions(+), 2 deletions(-) +diff --git a/mkbootimg/bootimg.h b/mkbootimg/bootimg.h +index 9171d85a7b..308c537d6b 100644 --- a/mkbootimg/bootimg.h +++ b/mkbootimg/bootimg.h @@ -41,8 +41,8 @@ struct boot_img_hdr
@@ -41,6 +41,8 @@ Upstream-Status: Inappropriate ** ** 0. all entities are page_size aligned in flash ** 1. kernel and ramdisk are required (size != 0) +diff --git a/mkbootimg/mkbootimg.c b/mkbootimg/mkbootimg.c +index fc92b4dc30..658052cdf2 100644 --- a/mkbootimg/mkbootimg.c +++ b/mkbootimg/mkbootimg.c @@ -65,6 +65,7 @@ int usage(void)
meta-oe/recipes-devtools/android-tools/android-tools/core/0010-Use-linux-capability.h-on-linux-systems-too.patch renamed from meta-oe/recipes-devtools/android-tools/android-tools/use-capability.patch +7 -3
@@ -1,11 +1,15 @@ -Subject: use linux/capability.h on linux systems too -Author: Loïc Minier <[email protected]> +From ef743c9c3c7452ae904a5c343ee2b759ab3a87cb Mon Sep 17 00:00:00 2001 +From: =?UTF-8?q?Lo=C3=AFc=20Minier?= <[email protected]> +Date: Wed, 7 Sep 2016 12:58:47 +0300 +Subject: [PATCH] Use linux/capability.h on linux systems too Upstream-Status: Inappropriate --- - include/private/android_filesystem_config.h | 2 +- + include/private/android_filesystem_config.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) +diff --git a/include/private/android_filesystem_config.h b/include/private/android_filesystem_config.h +index 2f528b95c8..3e0b00928e 100644 --- a/include/private/android_filesystem_config.h +++ b/include/private/android_filesystem_config.h @@ -27,7 +27,7 @@
meta-oe/recipes-devtools/android-tools/android-tools/core/0011-Remove-bionic-specific-calls.patch renamed from meta-oe/recipes-devtools/android-tools/android-tools/remove-bionic-android.patch +28 -20
71 lines not on this page · raw message
meta-oe/recipes-devtools/android-tools/android-tools/core/0012-Fix-implicit-declaration-of-stlcat-strlcopy-function.patch renamed from meta-oe/recipes-devtools/android-tools/android-tools/implicit-declaration-function-strlcat-strlcopy.patch +23 -15
@@ -1,13 +1,29 @@ -Description: fix implicit declaration of stlcat/strlcopy functions. -Author: Fathi Boudra <[email protected]> +From cd4525d760c6f88c9bf85f7bf488da79cd0d3264 Mon Sep 17 00:00:00 2001 +From: Fathi Boudra <[email protected]> +Date: Wed, 7 Sep 2016 12:58:47 +0300 +Subject: [PATCH] Fix implicit declaration of stlcat/strlcopy functions Upstream-Status: Inappropriate --- - adb/adb.c | 1 + - fs_mgr/fs_mgr_fstab.c | 2 +- - include/cutils/sockets.h | 2 +- + adb/adb.c | 1 + + fs_mgr/fs_mgr_fstab.c | 2 +- + include/cutils/sockets.h | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) +diff --git a/adb/adb.c b/adb/adb.c +index e0f7ecde45..aaefd9b401 100644 +--- a/adb/adb.c ++++ b/adb/adb.c +@@ -41,6 +41,7 @@ + #include <sys/prctl.h> + #include <getopt.h> + #include <selinux/selinux.h> ++#include <grp.h> + #else + #include "usb_vendors.h" + #endif +diff --git a/fs_mgr/fs_mgr_fstab.c b/fs_mgr/fs_mgr_fstab.c +index edd9591164..9ddb4643b5 100644 --- a/fs_mgr/fs_mgr_fstab.c +++ b/fs_mgr/fs_mgr_fstab.c @@ -17,7 +17,7 @@
@@ -19,6 +35,8 @@ Upstream-Status: Inappropriate #include <sys/mount.h> #include "fs_mgr_priv.h" +diff --git a/include/cutils/sockets.h b/include/cutils/sockets.h +index daf43ec944..d3270c69e7 100644 --- a/include/cutils/sockets.h +++ b/include/cutils/sockets.h @@ -19,7 +19,7 @@
@@ -30,13 +48,3 @@ Upstream-Status: Inappropriate #include <stdbool.h> #ifdef HAVE_WINSOCK ---- a/adb/adb.c -+++ b/adb/adb.c -@@ -41,6 +41,7 @@ - #include <sys/prctl.h> - #include <getopt.h> - #include <selinux/selinux.h> -+#include <grp.h> - #else - #include "usb_vendors.h" - #endif
meta-oe/recipes-devtools/android-tools/android-tools/extras/0001-ext4_utils-remove-selinux-extensions.patch renamed from meta-oe/recipes-devtools/android-tools/android-tools/remove-selinux-android-extras.patch +15 -4
@@ -1,11 +1,20 @@ -Subject: drop useless includes of Android SELINUX extensions; avoids having to clone another module; this should be sent upstream -Author: Sergio Schvezov <[email protected]> +From 354604da9d152f1931e91991d3f34197fc8fc759 Mon Sep 17 00:00:00 2001 +From: Sergio Schvezov <[email protected]> +Date: Tue, 2 Oct 2018 16:36:54 +0000 +Subject: [PATCH] ext4_utils: remove selinux extensions + +* drop useless includes of Android SELINUX extensions +* avoids having to clone another module +* this should be sent upstream Upstream-Status: Inappropriate --- - ext4_utils/make_ext4fs.c | 1 - - ext4_utils/make_ext4fs_main.c | 1 - + ext4_utils/make_ext4fs.c | 1 - + ext4_utils/make_ext4fs_main.c | 1 - + 2 files changed, 2 deletions(-) +diff --git a/ext4_utils/make_ext4fs.c b/ext4_utils/make_ext4fs.c +index 2f89ae8a0..732afbed7 100644 --- a/ext4_utils/make_ext4fs.c +++ b/ext4_utils/make_ext4fs.c @@ -62,7 +62,6 @@
@@ -16,6 +25,8 @@ Upstream-Status: Inappropriate #define O_BINARY 0 +diff --git a/ext4_utils/make_ext4fs_main.c b/ext4_utils/make_ext4fs_main.c +index a6c5f6160..f8e7b9da9 100644 --- a/ext4_utils/make_ext4fs_main.c +++ b/ext4_utils/make_ext4fs_main.c @@ -32,7 +32,6 @@
meta-oe/recipes-devtools/android-tools/android-tools/extras/0002-ext4_utils-add-o-argument-to-preserve-ownership.patch renamed from meta-oe/recipes-devtools/android-tools/android-tools/preserve-ownership.patch +9 -12
@@ -1,24 +1,21 @@ -From aa669312a380611d280d126cb509fa282080707e Mon Sep 17 00:00:00 2001 +From b9254539811ce912bfd16dd1d185eba7a10cceff Mon Sep 17 00:00:00 2001 From: Markus Mayer <[email protected]> Date: Wed, 7 Sep 2016 12:58:47 +0300 -Subject: [PATCH] android-tools: add recipe from AOSP tag android-5.1.1_r37 - -Description: add -o argument to preserve ownership +Subject: [PATCH] ext4_utils: add -o argument to preserve ownership See also https://android-review.googlesource.com/#/c/100312/ Upstream-Status: Inappropriate - --- ext4_utils/make_ext4fs.c | 6 ++++++ ext4_utils/make_ext4fs_main.c | 10 ++++++++-- 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/ext4_utils/make_ext4fs.c b/ext4_utils/make_ext4fs.c -index 2f89ae8a..cc41d623 100644 +index 732afbed7..2cbf04399 100644 --- a/ext4_utils/make_ext4fs.c +++ b/ext4_utils/make_ext4fs.c -@@ -68,6 +68,8 @@ +@@ -67,6 +67,8 @@ #endif
@@ -27,7 +24,7 @@ index 2f89ae8a..cc41d623 100644 /* TODO: Not implemented: Allocating blocks in the same block group as the file inode Hash or binary tree directories -@@ -186,6 +188,10 @@ static u32 build_directory_structure(const char *full_path, const char *dir_path +@@ -185,6 +187,10 @@ static u32 build_directory_structure(const char *full_path, const char *dir_path } else { dentries[i].mtime = fixed_time; }
@@ -39,10 +36,10 @@ index 2f89ae8a..cc41d623 100644 if (fs_config_func != NULL) { #ifdef ANDROID diff --git a/ext4_utils/make_ext4fs_main.c b/ext4_utils/make_ext4fs_main.c -index a6c5f616..7af0dddf 100644 +index f8e7b9da9..e82d43277 100644 --- a/ext4_utils/make_ext4fs_main.c +++ b/ext4_utils/make_ext4fs_main.c -@@ -48,13 +48,15 @@ struct selabel_handle; +@@ -47,13 +47,15 @@ struct selabel_handle; extern struct fs_info info;
@@ -59,7 +56,7 @@ index a6c5f616..7af0dddf 100644 fprintf(stderr, " <filename> [<directory>]\n"); } -@@ -80,7 +82,7 @@ int main(int argc, char **argv) +@@ -79,7 +81,7 @@ int main(int argc, char **argv) struct selinux_opt seopts[] = { { SELABEL_OPT_PATH, "" } }; #endif
@@ -68,7 +65,7 @@ index a6c5f616..7af0dddf 100644 switch (opt) { case 'l': info.len = parse_num(optarg); -@@ -143,6 +145,10 @@ int main(int argc, char **argv) +@@ -142,6 +144,10 @@ int main(int argc, char **argv) } #endif break;
meta-oe/recipes-devtools/android-tools/android-tools/gitignore renamed from meta-oe/recipes-devtools/android-tools/android-tools/.gitignore +0 -0
meta-oe/recipes-devtools/android-tools/android-tools/libselinux/0001-Remove-bionic-specific-calls.patch renamed from meta-oe/recipes-devtools/android-tools/android-tools/remove-bionic-android-libselinux.patch +11 -2
@@ -1,8 +1,17 @@ -Description: remove bionic specific calls -Author: Fathi Boudra <[email protected]> +From 36654a4484117e5f4d63a810c0d94bc9c7ee3a83 Mon Sep 17 00:00:00 2001 +From: Fathi Boudra <[email protected]> +Date: Tue, 2 Oct 2018 16:36:54 +0000 +Subject: [PATCH] Remove bionic specific calls Upstream-Status: Inappropriate + +Signed-off-by: Martin Jansa <[email protected]> --- + src/procattr.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/src/procattr.c b/src/procattr.c +index f350808..761cf8e 100644 --- a/src/procattr.c +++ b/src/procattr.c @@ -8,7 +8,7 @@
meta-oe/recipes-devtools/android-tools/android-tools_5.1.1.r37.bb +24 -26
75 lines not on this page · raw message
Signature · 1 line
2.17.1