Bad MAINTAINERS pattern in section 'INTEL PMC CORE DRIVER'
Please fix this defect appropriately.
linux-next MAINTAINERS section:
7441 INTEL PMC CORE DRIVER
7442 M: Rajneesh Bhardwaj <[email protected]>
7443 M: Vishwanath Somayaji <[email protected]>
7444 L: [email protected]
7445 S: Maintained
--> 7446 F: arch/x86/include/asm/pmc_core.h
7447 F: drivers/platform/x86/intel_pmc_core*
Commit that introduced this:
commit 7683e9e529258d01ce99216ad3be21f59eff83ec
Author: Linus Torvalds <[email protected]>
Date: Sun Jul 23 16:06:21 2017 -0700
Properly alphabetize MAINTAINERS file
This adds a perl script to actually parse the MAINTAINERS file, clean up some whitespace in it, warn about errors in it, and then properly sort the end result.
My perl-fu is atrocious, so the script has basically been created by randomly putting various characters in a pile, mixing them around, and then looking it the end result does anything interesting when used as a perl script.
MAINTAINERS | 3585 +++++++++++++++++++++--------------------- scripts/parse-maintainers.pl | 77 + 2 files changed, 1868 insertions(+), 1794 deletions(-)
Last commit with arch/x86/include/asm/pmc_core.h
commit 941691ef2197944a202d7870dcd7da3fb0391c65
Author: Rajneesh Bhardwaj <[email protected]> Date: Wed Jan 31 11:50:22 2018 +0530
platform/x86: intel_pmc_core: Remove unused header file
Recently sent patch 'platform/x86: intel_pmc_core: Remove unused EXPORTED API' missed to remove the header file 'arch/x86/include/asm/pmc_core.h' which was solely used to declare the EXPORTED API 'intel_pmc_slp_s0_counter_read'. This patch provides the errata fix for the same.
arch/x86/include/asm/pmc_core.h | 27 --------------------------- drivers/platform/x86/intel_pmc_core.c | 1 - 2 files changed, 28 deletions(-)
Quoted 13 lines · Joe Perches
Please fix this defect appropriately.
linux-next
MAINTAINERSsection:7441 INTEL PMC CORE DRIVER 7442 M: Rajneesh Bhardwaj <[email protected]> 7443 M: Vishwanath Somayaji <[email protected]> 7444 L: [email protected] 7445 S: Maintained --> 7446 F: arch/x86/include/asm/pmc_core.h 7447 F: drivers/platform/x86/intel_pmc_core*
Quoted 1 line
Commit that introduced this:
This is strange the shuffle of the MAINTAINERS based on the script is a culprit of the above inconsistency.
Btw, I run parse-maintainers.pl against it and there are a lot more "unsorted" lines.
What Linus or me or both did miss?
Quoted 42 lines
commit
7683e9e529258d01ce99216ad3be21f59eff83ec
Author: Linus Torvalds <[email protected]>
Date: Sun Jul 23 16:06:21 2017 -0700Properly alphabetize
MAINTAINERSfileThis adds a perl script to actually parse the
MAINTAINERSfile, clean up some whitespace in it, warn about errors in it, and then properly sort the end result.My perl-fu is atrocious, so the script has basically been created by randomly putting various characters in a pile, mixing them around, and then looking it the end result does anything interesting when used as a perl script.
Signed-off-by Linus Torvalds <[email protected]>MAINTAINERS | 3585 +++++++++++++++++++++--------------------- scripts/parse-maintainers.pl | 77 + 2 files changed, 1868 insertions(+), 1794 deletions(-)Last commit with
arch/x86/include/asm/pmc_core.hcommit
941691ef2197944a202d7870dcd7da3fb0391c65Author: Rajneesh Bhardwaj <[email protected]> Date: Wed Jan 31 11:50:22 2018 +0530platform/x86:
intel_pmc_core: Remove unused header fileRecently sent patch 'platform/x86:
intel_pmc_core: Remove unused EXPORTED API' missed to remove the header file 'arch/x86/include/asm/pmc_core.h' which was solely used to declare the EXPORTED API 'intel_pmc_slp_s0_counter_read'. This patch provides the errata fix for the same.Signed-off-by Rajneesh Bhardwaj <[email protected]>Signed-off-by Andy Shevchenko <[email protected]>arch/x86/include/asm/pmc_core.h | 27 --------------------------- drivers/platform/x86/intel_pmc_core.c | 1 - 2 files changed, 28 deletions(-)
Signature · 2 lines
With Best Regards, Andy Shevchenko
Quoted 13 lines · Andy Shevchenko
Quoted 12 lines · Joe Perches
Please fix this defect appropriately.
linux-next
MAINTAINERSsection:7441 INTEL PMC CORE DRIVER 7442 M: Rajneesh Bhardwaj <[email protected]> 7443 M: Vishwanath Somayaji <[email protected]> 7444 L: [email protected] 7445 S: Maintained --> 7446 F: arch/x86/include/asm/pmc_core.h 7447 F: drivers/platform/x86/intel_pmc_core*
Quoted 8 lines
Quoted 1 line
Commit that introduced this:
This is strange the shuffle of the
MAINTAINERSbased on the script is a culprit of the above inconsistency.Btw, I run parse-maintainers.pl against it and there are a lot more "unsorted" lines.
What Linus or me or both did miss?
Nothing really.
The script used git-blame on the specific line, that's all.
There is no simple way to actually find a specific commit that adds a particular line to a file if there is any refactoring done to the file after it was added.
commit b740d2e9233cb33626d3b62210bcfc6a34baa839
Author: Rajneesh Bhardwaj <[email protected]> Date: Thu May 26 14:41:19 2016 +0530
platform/x86: Add PMC Driver for Intel Core SoC
Anyway, the real cause of the file pattern being unused was also written below:
Quoted 23 lines
Quoted 20 lines
Last commit with
arch/x86/include/asm/pmc_core.hcommit
941691ef2197944a202d7870dcd7da3fb0391c65Author: Rajneesh Bhardwaj <[email protected]> Date: Wed Jan 31 11:50:22 2018 +0530platform/x86:
intel_pmc_core: Remove unused header fileRecently sent patch 'platform/x86:
intel_pmc_core: Remove unused EXPORTED API' missed to remove the header file 'arch/x86/include/asm/pmc_core.h' which was solely used to declare the EXPORTED API 'intel_pmc_slp_s0_counter_read'. This patch provides the errata fix for the same.Signed-off-by Rajneesh Bhardwaj <[email protected]>Signed-off-by Andy Shevchenko <[email protected]>arch/x86/include/asm/pmc_core.h | 27 --------------------------- drivers/platform/x86/intel_pmc_core.c | 1 - 2 files changed, 28 deletions(-)
Quoted 19 lines · Joe Perches
Quoted 18 lines · Andy Shevchenko
Quoted 12 lines · Joe Perches
Please fix this defect appropriately.
linux-next
MAINTAINERSsection:7441 INTEL PMC CORE DRIVER 7442 M: Rajneesh Bhardwaj <[email protected]> 7443 M: Vishwanath Somayaji <[email protected]> 7444 L: [email protected] 7445 S: Maintained --> 7446 F: arch/x86/include/asm/pmc_core.h 7447 F: drivers/platform/x86/intel_pmc_core*Quoted 1 line
Commit that introduced this:
This is strange the shuffle of the
MAINTAINERSbased on the script is a culprit of the above inconsistency.
Quoted 7 lines
Quoted 3 lines
Btw, I run parse-maintainers.pl against it and there are a lot more "unsorted" lines.
What Linus or me or both did miss?Nothing really.
The script used git-blame on the specific line, that's all.
Thanks for reporting this. I have sent the fix to the list.
https://lkml.org/lkml/2018/10/3/500.
Quoted 38 lines
There is no simple way to actually find a specific commit that adds a particular line to a file if there is any refactoring done to the file after it was added.
commit
b740d2e9233cb33626d3b62210bcfc6a34baa839Author: Rajneesh Bhardwaj <[email protected]> Date: Thu May 26 14:41:19 2016 +0530platform/x86: Add PMC Driver for Intel Core SoC
Anyway, the real cause of the file pattern being unused was also written below:
Quoted 23 lines
Quoted 20 lines
Last commit with
arch/x86/include/asm/pmc_core.hcommit
941691ef2197944a202d7870dcd7da3fb0391c65Author: Rajneesh Bhardwaj <[email protected]> Date: Wed Jan 31 11:50:22 2018 +0530platform/x86:
intel_pmc_core: Remove unused header fileRecently sent patch 'platform/x86:
intel_pmc_core: Remove unused EXPORTED API' missed to remove the header file 'arch/x86/include/asm/pmc_core.h' which was solely used to declare the EXPORTED API 'intel_pmc_slp_s0_counter_read'. This patch provides the errata fix for the same.Signed-off-by Rajneesh Bhardwaj <[email protected]>Signed-off-by Andy Shevchenko <[email protected]>arch/x86/include/asm/pmc_core.h | 27 --------------------------- drivers/platform/x86/intel_pmc_core.c | 1 - 2 files changed, 28 deletions(-)
Signature · 2 lines
Best Regards, Rajneesh