Skip to contentSkip to conversation

video: fbdev: arcfb: mark expected switch fall-through

PATCH In review Gustavo A. R. Silva 2 participants 2 messages Oct 3, 2018 – Oct 8, 2018

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 video: fbdev: arcfb: mark expected switch fall-through

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Addresses-Coverity-ID: 115017 ("Missing break in switch")

---
 drivers/video/fbdev/arcfb.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/video/fbdev/arcfb.c +2 -0
index 7e87d0d..a48741a 100644
@@ -419,6 +419,8 @@ static int arcfb_ioctl(struct fb_info *info,
 			schedule();
 			finish_wait(&arcfb_waitq, &wait);
 		}
+		/* fall through */
+
 		case FBIO_GETCONTROL2:
 		{
 			unsigned char ctl2;
Signature · 1 line
2.7.4
#1 lore raw
Quoted 5 lines · Gustavo A. R. Silva

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Addresses-Coverity-ID: 115017 ("Missing break in switch")

Patch queued for 4.20, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics