staging: fbtft: Adding spaces around '<<'

PATCH In review Mamta Shukla 2 participants 4 messages Oct 3, 2018

Subsystems (2)

Staging Fbtft Framebuffer drivers

lore

Share & tools

lore

Mamta Shukla

author

2018-10-03 13:29 UTC #0 lore raw

PATCH 1/1 staging: fbtft: Adding spaces around '<<'

Adding spaces around '<<' to fix checkpatch issue.
CHECK: spaces preferred around that '<<' (ctx:VxV)

Signed-off-by Mamta Shukla <[email protected]>

---
 drivers/staging/fbtft/fbtft.h | 56 +++++++++++++++++++++----------------------
 1 file changed, 28 insertions(+), 28 deletions(-)

drivers/staging/fbtft/fbtft.h +28 ~~-28~~

index 25302ff..a3db23b 100644
@@ -355,39 +355,39 @@ static void __exit fbtft_driver_module_exit(void)                          \
 #define DEBUG_LEVEL_6	(DEBUG_LEVEL_4 | DEBUG_LEVEL_5)
 #define DEBUG_LEVEL_7	0xFFFFFFFF
 
-#define DEBUG_DRIVER_INIT_FUNCTIONS (1<<3)
-#define DEBUG_TIME_FIRST_UPDATE     (1<<4)
-#define DEBUG_TIME_EACH_UPDATE      (1<<5)
-#define DEBUG_DEFERRED_IO           (1<<6)
-#define DEBUG_FBTFT_INIT_FUNCTIONS  (1<<7)
+#define DEBUG_DRIVER_INIT_FUNCTIONS  (1 << 3)
+#define DEBUG_TIME_FIRST_UPDATE      (1 << 4)
+#define DEBUG_TIME_EACH_UPDATE       (1 << 5)
+#define DEBUG_DEFERRED_IO            (1 << 6)
+#define DEBUG_FBTFT_INIT_FUNCTIONS   (1 << 7)
 
 /* fbops */
-#define DEBUG_FB_READ               (1<<8)
-#define DEBUG_FB_WRITE              (1<<9)
-#define DEBUG_FB_FILLRECT           (1<<10)
-#define DEBUG_FB_COPYAREA           (1<<11)
-#define DEBUG_FB_IMAGEBLIT          (1<<12)
-#define DEBUG_FB_SETCOLREG          (1<<13)
-#define DEBUG_FB_BLANK              (1<<14)
+#define DEBUG_FB_READ                (1 << 8)
+#define DEBUG_FB_WRITE               (1 << 9)
+#define DEBUG_FB_FILLRECT            (1 << 10)
+#define DEBUG_FB_COPYAREA            (1 << 11)
+#define DEBUG_FB_IMAGEBLIT           (1 << 12)
+#define DEBUG_FB_SETCOLREG           (1 << 13)
+#define DEBUG_FB_BLANK               (1 << 14)
 
-#define DEBUG_SYSFS                 (1<<16)
+#define DEBUG_SYSFS                  (1 << 16)
 
 /* fbtftops */
-#define DEBUG_BACKLIGHT             (1<<17)
-#define DEBUG_READ                  (1<<18)
-#define DEBUG_WRITE                 (1<<19)
-#define DEBUG_WRITE_VMEM            (1<<20)
-#define DEBUG_WRITE_REGISTER        (1<<21)
-#define DEBUG_SET_ADDR_WIN          (1<<22)
-#define DEBUG_RESET                 (1<<23)
-#define DEBUG_MKDIRTY               (1<<24)
-#define DEBUG_UPDATE_DISPLAY        (1<<25)
-#define DEBUG_INIT_DISPLAY          (1<<26)
-#define DEBUG_BLANK                 (1<<27)
-#define DEBUG_REQUEST_GPIOS         (1<<28)
-#define DEBUG_FREE_GPIOS            (1<<29)
-#define DEBUG_REQUEST_GPIOS_MATCH   (1<<30)
-#define DEBUG_VERIFY_GPIOS          (1<<31)
+#define DEBUG_BACKLIGHT              (1 << 17)
+#define DEBUG_READ                   (1 << 18)
+#define DEBUG_WRITE                  (1 << 19)
+#define DEBUG_WRITE_VMEM             (1 << 20)
+#define DEBUG_WRITE_REGISTER         (1 << 21)
+#define DEBUG_SET_ADDR_WIN           (1 << 22)
+#define DEBUG_RESET                  (1 << 23)
+#define DEBUG_MKDIRTY                (1 << 24)
+#define DEBUG_UPDATE_DISPLAY         (1 << 25)
+#define DEBUG_INIT_DISPLAY           (1 << 26)
+#define DEBUG_BLANK                  (1 << 27)
+#define DEBUG_REQUEST_GPIOS          (1 << 28)
+#define DEBUG_FREE_GPIOS             (1 << 29)
+#define DEBUG_REQUEST_GPIOS_MATCH    (1 << 30)
+#define DEBUG_VERIFY_GPIOS           (1 << 31)
 
 #define fbtft_init_dbg(dev, format, arg...)                  \
 do {                                                         \

Signature · 1 line

1.9.1

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20181003132917.GA29977%40armorer.
For more options, visit https://groups.google.com/d/optout.

Mamta Shukla

author

2018-10-03 13:54 UTC #2 lore raw

Quoted 11 lines · Julia Lawall

Quoted 6 lines · Mamta Shukla
Adding spaces around '<<' to fix checkpatch issue.
CHECK: spaces preferred around that '<<' (ctx:VxV)
It looks like the BIT macro could actually be mre useful here.
julia

Ok, I will make the change.
I need to write new patch, right? Because another version of this patch may conflict the subject.

-Mamta

Quoted 88 lines

Quoted 5 lines

Signed-off-by Mamta Shukla <[email protected]>
---
 drivers/staging/fbtft/fbtft.h | 56

+++++++++++++++++++++----------------------

Review

Quoted 3 lines

 1 file changed, 28 insertions(+), 28 deletions(-)

(quoted diff) +0 -0

b/drivers/staging/fbtft/fbtft.h

drivers/staging/fbtft/fbtft.h static void __exit fbtft_driver_module_exit(void)

Quoted 4 lines

index 25302ff..a3db23b 100644
drivers/staging/fbtft/fbtft.h +0 -0
@@ -355,39 +355,39 @@ static void __exit fbtft_driver_module_exit(void)

Quoted 70 lines

drivers/staging/fbtft/fbtft.h +28 ~~-29~~

 #define DEBUG_LEVEL_6        (DEBUG_LEVEL_4 | DEBUG_LEVEL_5)
 #define DEBUG_LEVEL_7        0xFFFFFFFF
 
-#define DEBUG_DRIVER_INIT_FUNCTIONS (1<<3)
-#define DEBUG_TIME_FIRST_UPDATE     (1<<4)
-#define DEBUG_TIME_EACH_UPDATE      (1<<5)
-#define DEBUG_DEFERRED_IO           (1<<6)
-#define DEBUG_FBTFT_INIT_FUNCTIONS  (1<<7)
+#define DEBUG_DRIVER_INIT_FUNCTIONS  (1 << 3)
+#define DEBUG_TIME_FIRST_UPDATE      (1 << 4)
+#define DEBUG_TIME_EACH_UPDATE       (1 << 5)
+#define DEBUG_DEFERRED_IO            (1 << 6)
+#define DEBUG_FBTFT_INIT_FUNCTIONS   (1 << 7)
 
 /* fbops */
-#define DEBUG_FB_READ               (1<<8)
-#define DEBUG_FB_WRITE              (1<<9)
-#define DEBUG_FB_FILLRECT           (1<<10)
-#define DEBUG_FB_COPYAREA           (1<<11)
-#define DEBUG_FB_IMAGEBLIT          (1<<12)
-#define DEBUG_FB_SETCOLREG          (1<<13)
-#define DEBUG_FB_BLANK              (1<<14)
+#define DEBUG_FB_READ                (1 << 8)
+#define DEBUG_FB_WRITE               (1 << 9)
+#define DEBUG_FB_FILLRECT            (1 << 10)
+#define DEBUG_FB_COPYAREA            (1 << 11)
+#define DEBUG_FB_IMAGEBLIT           (1 << 12)
+#define DEBUG_FB_SETCOLREG           (1 << 13)
+#define DEBUG_FB_BLANK               (1 << 14)
 
-#define DEBUG_SYSFS                 (1<<16)
+#define DEBUG_SYSFS                  (1 << 16)
 
 /* fbtftops */
-#define DEBUG_BACKLIGHT             (1<<17)
-#define DEBUG_READ                  (1<<18)
-#define DEBUG_WRITE                 (1<<19)
-#define DEBUG_WRITE_VMEM            (1<<20)
-#define DEBUG_WRITE_REGISTER        (1<<21)
-#define DEBUG_SET_ADDR_WIN          (1<<22)
-#define DEBUG_RESET                 (1<<23)
-#define DEBUG_MKDIRTY               (1<<24)
-#define DEBUG_UPDATE_DISPLAY        (1<<25)
-#define DEBUG_INIT_DISPLAY          (1<<26)
-#define DEBUG_BLANK                 (1<<27)
-#define DEBUG_REQUEST_GPIOS         (1<<28)
-#define DEBUG_FREE_GPIOS            (1<<29)
-#define DEBUG_REQUEST_GPIOS_MATCH   (1<<30)
-#define DEBUG_VERIFY_GPIOS          (1<<31)
+#define DEBUG_BACKLIGHT              (1 << 17)
+#define DEBUG_READ                   (1 << 18)
+#define DEBUG_WRITE                  (1 << 19)
+#define DEBUG_WRITE_VMEM             (1 << 20)
+#define DEBUG_WRITE_REGISTER         (1 << 21)
+#define DEBUG_SET_ADDR_WIN           (1 << 22)
+#define DEBUG_RESET                  (1 << 23)
+#define DEBUG_MKDIRTY                (1 << 24)
+#define DEBUG_UPDATE_DISPLAY         (1 << 25)
+#define DEBUG_INIT_DISPLAY           (1 << 26)
+#define DEBUG_BLANK                  (1 << 27)
+#define DEBUG_REQUEST_GPIOS          (1 << 28)
+#define DEBUG_FREE_GPIOS             (1 << 29)
+#define DEBUG_REQUEST_GPIOS_MATCH    (1 << 30)
+#define DEBUG_VERIFY_GPIOS           (1 << 31)
 
 #define fbtft_init_dbg(dev, format, arg...)                  \
 do {                                                         \
--

1.9.1

Quoted 2 lines

--
You received this message because you are subscribed to the Google

Groups "outreachy-kernel" group.

Quoted 9 lines

Quoted 1 line
To unsubscribe from this group and stop receiving emails from it, send
an email to [email protected].
Quoted 2 lines
To post to this group, send email to [email protected]. To view this discussion on the web visit
https://groups.google.com/d/msgid/outreachy-kernel/20181003132917.GA29977%40armorer
.
Quoted 2 lines
For more options, visit https://groups.google.com/d/optout.

Julia Lawall

2018-10-03 13:58 UTC #3 lore raw

Quoted 10 lines · Mamta Shukla

On Wed, Oct 3, 2018 at 7:10 PM Julia Lawall <[email protected]> wrote:
On Wed, 3 Oct 2018, Mamta Shukla wrote:
> Adding spaces around '<<' to fix checkpatch issue. > CHECK: spaces preferred around that '<<' (ctx:VxV)

Quoted 7 lines

>It looks like the BIT macro could actually be mre useful here.
>julia
Ok, I will make the change.
I need to write new patch, right? Because another version of this patch may conflict the subject.

That's true. Go ahead for a new patch.

julia

Quoted 108 lines

-Mamta
>
> Signed-off-by: Mamta Shukla <[email protected]>
> ---
>ï¿œ drivers/staging/fbtft/fbtft.h | 56
+++++++++++++++++++++----------------------
>ï¿œ 1 file changed, 28 insertions(+), 28 deletions(-)
>
> diff --git a/drivers/staging/fbtft/fbtft.h
b/drivers/staging/fbtft/fbtft.h
> index 25302ff..a3db23b 100644
> --- a/drivers/staging/fbtft/fbtft.h
> +++ b/drivers/staging/fbtft/fbtft.h
> @@ -355,39 +355,39 @@ static void __exit
fbtft_driver_module_exit(void)ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ \
>ï¿œ #define DEBUG_LEVEL_6ï¿œ ï¿œ ï¿œ ï¿œ (DEBUG_LEVEL_4 | DEBUG_LEVEL_5)
>ï¿œ #define DEBUG_LEVEL_7ï¿œ ï¿œ ï¿œ ï¿œ 0xFFFFFFFF
>
> -#define DEBUG_DRIVER_INIT_FUNCTIONS (1<<3)
> -#define DEBUG_TIME_FIRST_UPDATEï¿œ ï¿œ ï¿œ(1<<4)
> -#define DEBUG_TIME_EACH_UPDATEï¿œ ï¿œ ï¿œ (1<<5)
> -#define DEBUG_DEFERRED_IOï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ(1<<6)
> -#define DEBUG_FBTFT_INIT_FUNCTIONSï¿œ (1<<7)
> +#define DEBUG_DRIVER_INIT_FUNCTIONSï¿œ (1 << 3)
> +#define DEBUG_TIME_FIRST_UPDATEï¿œ ï¿œ ï¿œ (1 << 4)
> +#define DEBUG_TIME_EACH_UPDATEï¿œ ï¿œ ï¿œ ï¿œ(1 << 5)
> +#define DEBUG_DEFERRED_IOï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ (1 << 6)
> +#define DEBUG_FBTFT_INIT_FUNCTIONSï¿œ ï¿œ(1 << 7)
>
>ï¿œ /* fbops */
> -#define DEBUG_FB_READï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ(1<<8)
> -#define DEBUG_FB_WRITEï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ (1<<9)
> -#define DEBUG_FB_FILLRECTï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ(1<<10)
> -#define DEBUG_FB_COPYAREAï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ(1<<11)
> -#define DEBUG_FB_IMAGEBLITï¿œ ï¿œ ï¿œ ï¿œ ï¿œ (1<<12)
> -#define DEBUG_FB_SETCOLREGï¿œ ï¿œ ï¿œ ï¿œ ï¿œ (1<<13)
> -#define DEBUG_FB_BLANKï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ (1<<14)
> +#define DEBUG_FB_READï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ (1 << 8)
> +#define DEBUG_FB_WRITEï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ(1 << 9)
> +#define DEBUG_FB_FILLRECTï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ (1 << 10)
> +#define DEBUG_FB_COPYAREAï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ (1 << 11)
> +#define DEBUG_FB_IMAGEBLITï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ(1 << 12)
> +#define DEBUG_FB_SETCOLREGï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ(1 << 13)
> +#define DEBUG_FB_BLANKï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ(1 << 14)
>
> -#define DEBUG_SYSFSï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ(1<<16)
> +#define DEBUG_SYSFSï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ (1 << 16)
>
>ï¿œ /* fbtftops */
> -#define DEBUG_BACKLIGHTï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ(1<<17)
> -#define DEBUG_READï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ (1<<18)
> -#define DEBUG_WRITEï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ(1<<19)
> -#define DEBUG_WRITE_VMEMï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ (1<<20)
> -#define DEBUG_WRITE_REGISTERï¿œ ï¿œ ï¿œ ï¿œ (1<<21)
> -#define DEBUG_SET_ADDR_WINï¿œ ï¿œ ï¿œ ï¿œ ï¿œ (1<<22)
> -#define DEBUG_RESETï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ(1<<23)
> -#define DEBUG_MKDIRTYï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ(1<<24)
> -#define DEBUG_UPDATE_DISPLAYï¿œ ï¿œ ï¿œ ï¿œ (1<<25)
> -#define DEBUG_INIT_DISPLAYï¿œ ï¿œ ï¿œ ï¿œ ï¿œ (1<<26)
> -#define DEBUG_BLANKï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ(1<<27)
> -#define DEBUG_REQUEST_GPIOSï¿œ ï¿œ ï¿œ ï¿œ ï¿œ(1<<28)
> -#define DEBUG_FREE_GPIOSï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ (1<<29)
> -#define DEBUG_REQUEST_GPIOS_MATCHï¿œ ï¿œ(1<<30)
> -#define DEBUG_VERIFY_GPIOSï¿œ ï¿œ ï¿œ ï¿œ ï¿œ (1<<31)
> +#define DEBUG_BACKLIGHTï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ (1 << 17)
> +#define DEBUG_READï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ(1 << 18)
> +#define DEBUG_WRITEï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ (1 << 19)
> +#define DEBUG_WRITE_VMEMï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ(1 << 20)
> +#define DEBUG_WRITE_REGISTERï¿œ ï¿œ ï¿œ ï¿œ ï¿œ(1 << 21)
> +#define DEBUG_SET_ADDR_WINï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ(1 << 22)
> +#define DEBUG_RESETï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ (1 << 23)
> +#define DEBUG_MKDIRTYï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ (1 << 24)
> +#define DEBUG_UPDATE_DISPLAYï¿œ ï¿œ ï¿œ ï¿œ ï¿œ(1 << 25)
> +#define DEBUG_INIT_DISPLAYï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ(1 << 26)
> +#define DEBUG_BLANKï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ (1 << 27)
> +#define DEBUG_REQUEST_GPIOSï¿œ ï¿œ ï¿œ ï¿œ ï¿œ (1 << 28)
> +#define DEBUG_FREE_GPIOSï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ(1 << 29)
> +#define DEBUG_REQUEST_GPIOS_MATCHï¿œ ï¿œ (1 << 30)
> +#define DEBUG_VERIFY_GPIOSï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ(1 << 31)
>
>ï¿œ #define fbtft_init_dbg(dev, format, arg...)ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ
\
>ï¿œ do {ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ ï¿œ\
> --
> 1.9.1
>
> --
> You received this message because you are subscribed to the
Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from
it, send an email to
[email protected].
> To post to this group, send email to
[email protected].
> To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/20181003132917.GA29977%4 0armorer.
> For more options, visit https://groups.google.com/d/optout.
>
--