Skip to contentSkip to conversation

arm64: dts: clearfog-gt-8k: add PCIe slot description

PATCH New Baruch Siach 3 participants 4 messages Oct 3, 2018

Subsystems (2)
Device tree bindings Arm/Marvell Kirkwood and Armada 370, 375, 38x, 39x, XP, 3700, 7K/8K, CN9130 SoC support
lore
Share & tools
lore

Baruch Siach

author
#0 lore raw

PATCH 1/1 arm64: dts: clearfog-gt-8k: add PCIe slot description

This adds support for the PCIe interface on the CON4 mini-PCIe connector.

Signed-off-by Baruch Siach <[email protected]>
---
 arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts | 7 +++++++
 1 file changed, 7 insertions(+)
arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts +7 -0
index 2e06d82bec58..a13549749ee7 100644
@@ -233,6 +233,13 @@
 	};
 };
 
+&cp0_pcie0 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&cp0_pci0_reset_pins>;
+	reset-gpios = <&cp0_gpio2 0 GPIO_ACTIVE_LOW>;
+	status = "okay";
+};
+
 &cp0_gpio2 {
 	sata_reset {
 		gpio-hog;
Signature · 1 line
2.19.0
maintainer
#1 lore raw

PATCH 1/1 arm64: dts: clearfog-gt-8k: add PCIe slot description

Quoted 2 lines · Baruch Siach

This adds support for the PCIe interface on the CON4 mini-PCIe connector.

Hi Baruch

Is there a dependency between this and the implementation of the reset-gpios? It would be good to at least mention if there is/is not such a dependency. You could put it under the ---.

Quoted 32 lines
Signed-off-by Baruch Siach <[email protected]>
---
 arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts | 7 +++++++
 1 file changed, 7 insertions(+)
arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts +7 -0
index 2e06d82bec58..a13549749ee7 100644
@@ -233,6 +233,13 @@
 	};
 };
 
+&cp0_pcie0 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&cp0_pci0_reset_pins>;
+	reset-gpios = <&cp0_gpio2 0 GPIO_ACTIVE_LOW>;
+	status = "okay";
+};
+
 &cp0_gpio2 {
 	sata_reset {
 		gpio-hog;
Signature · 7 lines
2.19.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
author
#2 lore raw

PATCH 1/1 arm64: dts: clearfog-gt-8k: add PCIe slot description

Hi Andrew,

Quoted 7 lines · Andrew Lunn
Quoted 2 lines · Baruch Siach

This adds support for the PCIe interface on the CON4 mini-PCIe connector.

Is there a dependency between this and the implementation of the reset-gpios? It would be good to at least mention if there is/is not such a dependency. You could put it under the ---.

There is no hard dependency between the patches. This patch is about hardware description which is correct regardless of software implementation. For the hardware to work you need to toggle the reset signal. But you can also do that in the bootloader if the kernel does not support reset-gpios.

baruch

Quoted 23 lines
Quoted 23 lines
Signed-off-by Baruch Siach <[email protected]>
---
 arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts | 7 +++++++
 1 file changed, 7 insertions(+)
arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts +7 -0
index 2e06d82bec58..a13549749ee7 100644
@@ -233,6 +233,13 @@
 	};
 };
 
+&cp0_pcie0 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&cp0_pci0_reset_pins>;
+	reset-gpios = <&cp0_gpio2 0 GPIO_ACTIVE_LOW>;
+	status = "okay";
+};
+
 &cp0_gpio2 {
 	sata_reset {
 		gpio-hog;
Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
maintainer
#3 lore raw

PATCH 1/1 arm64: dts: clearfog-gt-8k: add PCIe slot description

Hi Baruch,

Quoted 11 lines · Baruch Siach

Hi Andrew,

Quoted 7 lines · Andrew Lunn
Quoted 2 lines · Baruch Siach

This adds support for the PCIe interface on the CON4 mini-PCIe connector.

Is there a dependency between this and the implementation of the reset-gpios? It would be good to at least mention if there is/is not such a dependency. You could put it under the ---.

Quoted 8 lines

There is no hard dependency between the patches. This patch is about hardware description which is correct regardless of software implementation. For the hardware to work you need to toggle the reset signal. But you can also do that in the bootloader if the kernel does not support reset-gpios.

baruch

Quoted 1 line
Quoted 1 line
Signed-off-by Baruch Siach <[email protected]>

Applied on mvebu/dt64

Thanks,

Gregory

Quoted 27 lines
Quoted 22 lines
Quoted 22 lines
---
 arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts | 7 +++++++
 1 file changed, 7 insertions(+)
arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts +7 -0
index 2e06d82bec58..a13549749ee7 100644
@@ -233,6 +233,13 @@
 	};
 };
 
+&cp0_pcie0 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&cp0_pci0_reset_pins>;
+	reset-gpios = <&cp0_gpio2 0 GPIO_ACTIVE_LOW>;
+	status = "okay";
+};
+
 &cp0_gpio2 {
 	sata_reset {
 		gpio-hog;
Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
Signature · 3 lines
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com