drm/i915/dp: Remove i915.enable_dp_mst module parameter
Subsystems (2)
RFC 1/1 drm/i915/dp: Remove i915.enable_dp_mst module parameter
MST is enabled by default on all platforms that support it. I don't think we should be providing a switch to work around MST issues as the feature has been supported for a while now. Let's kill this module parameter that we also do not test in CI.
--- drivers/gpu/drm/i915/i915_params.c | 3 --- drivers/gpu/drm/i915/i915_params.h | 1 - drivers/gpu/drm/i915/intel_dp.c | 6 ------ 3 files changed, 10 deletions(-)
drivers/gpu/drm/i915/i915_params.c +0 -3
@@ -156,9 +156,6 @@ i915_param_named_unsafe(huc_firmware_path, charp, 0400,i915_param_named_unsafe (dmc_firmware_path, charp,0400 ,"DMC firmware path to use instead of the default one" ); -i915_param_named_unsafe (enable_dp_mst, bool,0600 , -"Enable multi-stream transport (MST) for new DisplayPort sinks. (default: true)" ); -#if IS_ENABLED (CONFIG_DRM_I915_DEBUG )i915_param_named_unsafe (inject_load_failure, uint,0400 ,"Force an error after a number of failure check points (0:disabled (default), N:force failure at the Nth failure check point)" );
drivers/gpu/drm/i915/i915_params.h +0 -1
@@ -65,7 +65,6 @@ struct drm_printer; param(bool, disable_display, false) \ param(bool, verbose_state_checks, true) \ param(bool, nuclear_pageflip, false) \ - param(bool, enable_dp_mst, true) \ param(bool, enable_dpcd_backlight, false) \param (bool, enable_gvt, false)
drivers/gpu/drm/i915/intel_dp.c +0 -6
@@ -4054,9 +4054,6 @@ intel_dp_can_mst(struct intel_dp *intel_dp) {u8 mstm_cap; -if (!i915_modparams.enable_dp_mst) -return false; -if (!intel_dp->can_mst)return false;
@@ -4072,9 +4069,6 @@ intel_dp_can_mst(struct intel_dp *intel_dp)static void intel_dp_configure_mst (struct intel_dp *intel_dp) { -if (!i915_modparams.enable_dp_mst) -return ; -if (!intel_dp->can_mst)return ;
Signature · 6 lines
2.17.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for drm/i915/dp: Remove i915.enable_dp_mst module parameter
== Series Details ==
== Series Details ==
Series: drm/i915/dp: Remove i915.enable_dp_mst module parameter
URL : https://patchwork.freedesktop.org/series/50520/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4924 -> Patchwork_10349 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/50520/revisions/1/mbox/
== Known issues ==
Here are the changes found in Patchwork_10349 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@amdgpu/amd_basic@cs-compute:
fi-kbl-8809g: NOTRUN -> FAIL (fdo#108094)
igt@amdgpu/amd_prime@amd-to-i915:
fi-kbl-8809g: NOTRUN -> FAIL (fdo#107341)
igt@gem_exec_suspend@basic-s3:
fi-blb-e6850: PASS -> INCOMPLETE (fdo#107718)
igt@kms_flip@basic-flip-vs-dpms:
fi-glk-j4005: PASS -> DMESG-WARN (fdo#106000)
igt@kms_pipe_crc_basic@nonblocking-crc-pipe-b:
fi-byt-clapper: PASS -> FAIL (fdo#107362)
igt@pm_rpm@module-reload:
fi-glk-j4005: PASS -> DMESG-WARN (fdo#106097, fdo#107726)
==== Possible fixes ====
igt@drv_selftest@live_hangcheck:
fi-cfl-8109u: INCOMPLETE -> PASS
igt@gem_exec_suspend@basic-s3:
fi-cfl-8109u: DMESG-WARN (fdo#107345) -> PASS +3
igt@kms_flip@basic-flip-vs-modeset:
fi-glk-j4005: DMESG-WARN (fdo#106000) -> PASS
igt@kms_flip@basic-flip-vs-wf_vblank:
fi-glk-j4005: FAIL (fdo#100368) -> PASS
igt@kms_frontbuffer_tracking@basic:
fi-byt-clapper: FAIL (fdo#103167) -> PASS fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#106000 https://bugs.freedesktop.org/show_bug.cgi?id=106000
fdo#106097 https://bugs.freedesktop.org/show_bug.cgi?id=106097
fdo#107341 https://bugs.freedesktop.org/show_bug.cgi?id=107341
fdo#107345 https://bugs.freedesktop.org/show_bug.cgi?id=107345
fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
fdo#107718 https://bugs.freedesktop.org/show_bug.cgi?id=107718
fdo#107726 https://bugs.freedesktop.org/show_bug.cgi?id=107726
fdo#108094 https://bugs.freedesktop.org/show_bug.cgi?id=108094
== Participating hosts (48 -> 43) ==
Additional (1): fi-pnv-d510
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-icl-u2 fi-ctg-p8600
== Build changes ==
* Linux: CI_DRM_4924 -> Patchwork_10349
CI_DRM_4924: f75010b928b4b4cde8a1d2ce0c2bea516b3ba111 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4665: 267870165d9ef66b4ab423e4efe7bacba023d75e @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10349: ef22f18114f650bad88045f81d4e659c45330ebb @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
ef22f18114f6 drm/i915/dp: Remove i915.enable_dp_mst module parameter
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10349/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 9 lines · Dhinakaran Pandiyan
MST is enabled by default on all platforms that support it. I don't think we should be providing a switch to work around MST issues as the feature has been supported for a while now. Let's kill this module parameter that we also do not test in CI.
Cc Rodrigo Vivi <[email protected]>Cc Ville Syrjälä <[email protected]>Cc Jani Nikula <[email protected]>Signed-off-by Dhinakaran Pandiyan <[email protected]>
Quoted 59 lines
--- drivers/gpu/drm/i915/i915_params.c | 3 --- drivers/gpu/drm/i915/i915_params.h | 1 - drivers/gpu/drm/i915/intel_dp.c | 6 ------ 3 files changed, 10 deletions(-)drivers/gpu/drm/i915/i915_params.c +0
-3@@ -156,9 +156,6 @@ i915_param_named_unsafe(huc_firmware_path, charp, 0400,i915_param_named_unsafe (dmc_firmware_path, charp,0400 ,"DMC firmware path to use instead of the default one" ); -i915_param_named_unsafe (enable_dp_mst, bool,0600 , -"Enable multi-stream transport (MST) for new DisplayPort sinks. (default: true)" ); -#if IS_ENABLED (CONFIG_DRM_I915_DEBUG )i915_param_named_unsafe (inject_load_failure, uint,0400 ,"Force an error after a number of failure check points (0:disabled (default), N:force failure at the Nth failure check point)" );drivers/gpu/drm/i915/i915_params.h +0
-1@@ -65,7 +65,6 @@ struct drm_printer; param(bool, disable_display, false) \ param(bool, verbose_state_checks, true) \ param(bool, nuclear_pageflip, false) \ - param(bool, enable_dp_mst, true) \ param(bool, enable_dpcd_backlight, false) \param (bool, enable_gvt, false)drivers/gpu/drm/i915/intel_dp.c +0
-6@@ -4054,9 +4054,6 @@ intel_dp_can_mst(struct intel_dp *intel_dp) {u8 mstm_cap; -if (!i915_modparams.enable_dp_mst) -return false; -if (!intel_dp->can_mst)return false;@@ -4072,9 +4069,6 @@ intel_dp_can_mst(struct intel_dp *intel_dp)static void intel_dp_configure_mst (struct intel_dp *intel_dp) { -if (!i915_modparams.enable_dp_mst) -return ; -if (!intel_dp->can_mst)return ;Signature · 1 line
2.17.1
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Jani Nikula
maintainerQuoted 4 lines · Dhinakaran Pandiyan
MST is enabled by default on all platforms that support it. I don't think we should be providing a switch to work around MST issues as the feature has been supported for a while now. Let's kill this module parameter that we also do not test in CI.
I agree we don't want to provide this to users to *work around* issues. But maybe we want something like this to *debug* issues?
We have a plethora of unsafe/debug module parameters mainly because they're convenient and take effect from the beginning of the probe. If there was anything comparable for debugfs, I'd be all in.
Should we have this in debugfs instead?
BR,
Jani.
Signature · 5 lines
Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 8 lines · Jani Nikula
Quoted 4 lines · Dhinakaran Pandiyan
MST is enabled by default on all platforms that support it. I don't think we should be providing a switch to work around MST issues as the feature has been supported for a while now. Let's kill this module parameter that we also do not test in CI.
I agree we don't want to provide this to users to *work around* issues. But maybe we want something like this to *debug* issues?
Yes. I was using it for that just a few days ago when looking at a bug.
Also the mst code lacks a bunch of features I think we'd want (remote dpcd, remote i2c write, maybe others). It's still the unloved stepchild with no one really focusing on improving it.
So I think it's way too early to think about removing this outright. Not sure we should ever remove it really. What happens if in the future most of our ci displays are mst capable? Do we just not test sst at all? Granted a modparam is a probably a bit too coarse for that, but I think we may want *something* to force sst.
Signature · 6 lines
Ville Syrjälä Intel _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Rodrigo Vivi
maintainerQuoted 11 lines · Ville Syrjälä
Quoted 8 lines · Jani Nikula
Quoted 4 lines · Dhinakaran Pandiyan
MST is enabled by default on all platforms that support it. I don't think we should be providing a switch to work around MST issues as the feature has been supported for a while now. Let's kill this module parameter that we also do not test in CI.
I agree we don't want to provide this to users to *work around* issues. But maybe we want something like this to *debug* issues?
Yes. I was using it for that just a few days ago when looking at a bug.
so it seems useful and it means that we need to move to debugfs :)
Quoted 5 lines
Also the mst code lacks a bunch of features I think we'd want (remote dpcd, remote i2c write, maybe others). It's still the unloved stepchild with no one really focusing on improving it.
Quoted 13 lines
So I think it's way too early to think about removing this outright. Not sure we should ever remove it really. What happens if in the future most of our ci displays are mst capable? Do we just not test sst at all? Granted a modparam is a probably a bit too coarse for that, but I think we may want *something* to force sst.
Signature · 6 lines
Ville Syrjälä Intel _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 12 lines · Rodrigo Vivi
Quoted 11 lines · Ville Syrjälä
Quoted 10 lines · Jani Nikula
Quoted 7 lines · Dhinakaran Pandiyan
MST is enabled by default on all platforms that support it. I don't think
we should be providing a switch to work around MST issues as the feature
has been supported for a while now. Let's kill this module parameter
that we also do not test in CI.
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
I agree we don't want to provide this to users to *work around* issues. But maybe we want something like this to *debug* issues?
Yes. I was using it for that just a few days ago when looking at a bug.
so it seems useful and it means that we need to move to debugfs :)
It also allows us to have a switch for each primary connector instead of disabling MST completely.
Quoted 7 lines
Quoted 7 lines
Also the mst code lacks a bunch of features I think we'd want (remote dpcd,
remote i2c write, maybe others). It's still the unloved stepchild with no
one really focusing on improving it.
Because things work (mostly) without them :)
But yeah, remote dpcd reads can be very useful for debugging. Why are remote i2c writes needed though?
-DK
Quoted 10 lines
Quoted 10 lines
So I think it's way too early to think about removing this outright.
Not sure we should ever remove it really. What happens if in the future
most of our ci displays are mst capable? Do we just not test sst at all?
Granted a modparam is a probably a bit too coarse for that, but I think
we may want *something* to force sst.
Quoted 7 lines
Quoted 7 lines
Signature · 6 lines
Ville Syrjälä Intel _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.IGT: success for drm/i915/dp: Remove i915.enable_dp_mst module parameter
In reply to Dhinakaran Pandiyan== Series Details ==
== Series Details ==
Series: drm/i915/dp: Remove i915.enable_dp_mst module parameter
URL : https://patchwork.freedesktop.org/series/50520/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4924_full -> Patchwork_10349_full =
== Summary - WARNING ==
Minor unknown changes coming with Patchwork_10349_full need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_10349_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_10349_full:
=== IGT changes ===
==== Warnings ====
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render:
shard-snb: SKIP -> PASS +1
igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-mmap-wc:
shard-hsw: SKIP -> PASS +1== Known issues ==
Here are the changes found in Patchwork_10349_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@drv_suspend@shrink:
shard-skl: PASS -> INCOMPLETE (fdo#106886)
igt@gem_cpu_reloc@full:
shard-skl: NOTRUN -> INCOMPLETE (fdo#108073)
igt@gem_exec_await@wide-contexts:
shard-skl: PASS -> FAIL (fdo#100007)
igt@gem_exec_schedule@pi-ringfull-blt:
shard-glk: NOTRUN -> FAIL (fdo#103158) +2
igt@gem_userptr_blits@readonly-unsync:
shard-skl: NOTRUN -> INCOMPLETE (fdo#108074)
igt@kms_available_modes_crc@available_mode_test_crc:
shard-glk: NOTRUN -> FAIL (fdo#106641)
igt@kms_busy@extended-modeset-hang-newfb-render-c:
shard-glk: NOTRUN -> DMESG-WARN (fdo#107956) +10
igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-b:
shard-skl: NOTRUN -> DMESG-WARN (fdo#107956) +1
igt@kms_cursor_crc@cursor-128x128-random:
shard-apl: PASS -> FAIL (fdo#103232)
shard-glk: NOTRUN -> FAIL (fdo#103232)
igt@kms_cursor_crc@cursor-256x256-random:
shard-skl: NOTRUN -> FAIL (fdo#103232)
igt@kms_cursor_legacy@2x-long-nonblocking-modeset-vs-cursor-atomic:
shard-glk: NOTRUN -> FAIL (fdo#106509, fdo#105454)
igt@kms_cursor_legacy@2x-nonblocking-modeset-vs-cursor-atomic:
shard-glk: NOTRUN -> FAIL (fdo#106509, fdo#107409)
igt@kms_draw_crc@draw-method-xrgb8888-pwrite-ytiled:
shard-glk: NOTRUN -> FAIL (fdo#108222)
igt@kms_flip@flip-vs-expired-vblank-interruptible:
shard-skl: NOTRUN -> FAIL (fdo#105363)
igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-blt:
shard-snb: NOTRUN -> INCOMPLETE (fdo#105411)
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-wc:
shard-glk: NOTRUN -> FAIL (fdo#103167) +3
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite:
shard-apl: PASS -> FAIL (fdo#103167)
igt@kms_frontbuffer_tracking@fbc-1p-rte:
shard-apl: PASS -> DMESG-WARN (fdo#108131, fdo#103558)
igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-onoff:
shard-skl: NOTRUN -> FAIL (fdo#103167)
igt@kms_plane@plane-position-covered-pipe-a-planes:
shard-glk: NOTRUN -> FAIL (fdo#103166)
igt@kms_plane@plane-position-covered-pipe-b-planes:
shard-apl: PASS -> FAIL (fdo#103166)
{igt@kms_plane_alpha_blend@pipe-a-alpha-basic}:
shard-glk: NOTRUN -> DMESG-WARN (fdo#105763, fdo#106538) +1
{igt@kms_plane_alpha_blend@pipe-a-alpha-transparant-fb}:
shard-skl: NOTRUN -> FAIL (fdo#108145) +1
{igt@kms_plane_alpha_blend@pipe-c-alpha-7efc}:
shard-glk: NOTRUN -> FAIL (fdo#108146)
{igt@kms_plane_alpha_blend@pipe-c-alpha-transparant-fb}:
shard-glk: NOTRUN -> FAIL (fdo#108145) +9
igt@kms_setmode@basic:
shard-apl: PASS -> FAIL (fdo#99912)
shard-glk: NOTRUN -> FAIL (fdo#99912)
igt@kms_vblank@pipe-b-query-forked-busy:
shard-apl: PASS -> DMESG-WARN (fdo#105602, fdo#103558) +13
igt@prime_busy@hang-blt:
shard-apl: PASS -> INCOMPLETE (fdo#103927)
==== Possible fixes ====
igt@kms_cursor_crc@cursor-128x42-offscreen:
shard-apl: DMESG-WARN (fdo#105602, fdo#103558) -> PASS +16
igt@kms_cursor_crc@cursor-64x21-random:
shard-apl: FAIL (fdo#103232) -> PASS
igt@kms_cursor_legacy@cursora-vs-flipa-atomic-transitions-varying-size:
shard-kbl: DMESG-WARN (fdo#105604) -> PASS
igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-msflip-blt:
shard-snb: INCOMPLETE (fdo#105411) -> SKIP
igt@kms_properties@connector-properties-legacy:
shard-snb: DMESG-WARN (fdo#107469) -> PASS
igt@testdisplay:
shard-apl: INCOMPLETE (fdo#103927) -> PASS
==== Warnings ====
{igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb}:
shard-apl: DMESG-FAIL (fdo#105602, fdo#103558) -> FAIL (fdo#108145)
igt@kms_plane_multiple@atomic-pipe-b-tiling-yf:
shard-apl: DMESG-FAIL (fdo#105602, fdo#103558, fdo#103166) -> FAIL (fdo#103166) {name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
fdo#100007 https://bugs.freedesktop.org/show_bug.cgi?id=100007
fdo#103158 https://bugs.freedesktop.org/show_bug.cgi?id=103158
fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103232 https://bugs.freedesktop.org/show_bug.cgi?id=103232
fdo#103558 https://bugs.freedesktop.org/show_bug.cgi?id=103558
fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
fdo#105454 https://bugs.freedesktop.org/show_bug.cgi?id=105454
fdo#105602 https://bugs.freedesktop.org/show_bug.cgi?id=105602
fdo#105604 https://bugs.freedesktop.org/show_bug.cgi?id=105604
fdo#105763 https://bugs.freedesktop.org/show_bug.cgi?id=105763
fdo#106509 https://bugs.freedesktop.org/show_bug.cgi?id=106509
fdo#106538 https://bugs.freedesktop.org/show_bug.cgi?id=106538
fdo#106641 https://bugs.freedesktop.org/show_bug.cgi?id=106641
fdo#106886 https://bugs.freedesktop.org/show_bug.cgi?id=106886
fdo#107409 https://bugs.freedesktop.org/show_bug.cgi?id=107409
fdo#107469 https://bugs.freedesktop.org/show_bug.cgi?id=107469
fdo#107956 https://bugs.freedesktop.org/show_bug.cgi?id=107956
fdo#108073 https://bugs.freedesktop.org/show_bug.cgi?id=108073
fdo#108074 https://bugs.freedesktop.org/show_bug.cgi?id=108074
fdo#108131 https://bugs.freedesktop.org/show_bug.cgi?id=108131
fdo#108145 https://bugs.freedesktop.org/show_bug.cgi?id=108145
fdo#108146 https://bugs.freedesktop.org/show_bug.cgi?id=108146
fdo#108222 https://bugs.freedesktop.org/show_bug.cgi?id=108222
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
== Participating hosts (6 -> 6) ==
No changes in participating hosts
== Build changes ==
* Linux: CI_DRM_4924 -> Patchwork_10349
CI_DRM_4924: f75010b928b4b4cde8a1d2ce0c2bea516b3ba111 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4665: 267870165d9ef66b4ab423e4efe7bacba023d75e @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10349: ef22f18114f650bad88045f81d4e659c45330ebb @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10349/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx