Skip to contentSkip to conversation

staging: axis-fifo: Remove parentheses after EOL

PATCH In review Ioannis Valasakis 2 participants 4 messages Oct 4, 2018 Staging

lore
Share & tools
lore

Ioannis Valasakis

author
#0 lore raw

PATCH 1/1 staging: axis-fifo: Remove parentheses after EOL

staging: axis-fifo: Remove parentheses after EOL

According to the script checkpatch.pl and following the Linux Kernel Coding Standards, I remove the parentheses from the EOL and move them to a new line.

Signed-off-by Ioannis Valasakis <[email protected]>
---
 drivers/staging/axis-fifo/axis-fifo.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/staging/axis-fifo/axis-fifo.c +4 -4
index 63c8efd1b8db..f869adf0d0a2 100644
@@ -364,8 +364,8 @@ static ssize_t axis_fifo_read(struct file *f, char __user *buf,
 		 * if nothing is currently available
 		 */
 		spin_lock_irq(&fifo->read_queue_lock);
-		ret = wait_event_interruptible_lock_irq_timeout(
-			fifo->read_queue,
+		ret = wait_event_interruptible_lock_irq_timeout
+			(fifo->read_queue,
 			ioread32(fifo->base_addr + XLLF_RDFO_OFFSET),
 			fifo->read_queue_lock,
 			(read_timeout >= 0) ? msecs_to_jiffies(read_timeout) :

@@ -482,8 +482,8 @@ static ssize_t axis_fifo_write(struct file *f, const char __user *buf,
 		 * currently enough room in the fifo
 		 */
 		spin_lock_irq(&fifo->write_queue_lock);
-		ret = wait_event_interruptible_lock_irq_timeout(
-			fifo->write_queue,
+		ret = wait_event_interruptible_lock_irq_timeout
+			(fifo->write_queue,
 			ioread32(fifo->base_addr + XLLF_TDFV_OFFSET)
 				>= words_to_write,
 			fifo->write_queue_lock,
Signature · 1 line
2.19.0
#1 lore raw
Quoted 5 lines · Ioannis Valasakis

staging: axis-fifo: Remove parentheses after EOL

According to the script checkpatch.pl and following the Linux Kernel Coding Standards, I remove the parentheses from the EOL and move them to a new line.

Thanks for the patch.

Could you move all the arguments after the first one one space to the right, so that they line up with the rigt side of the (.

Also, the commit log message should be written in the imperative, and it is better to write out words in full rather than using abbreviations. Look at some old commits with git log to get an idea of how to write the commit message.

julia

Quoted 42 lines
Signed-off-by Ioannis Valasakis <[email protected]>
---
 drivers/staging/axis-fifo/axis-fifo.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/staging/axis-fifo/axis-fifo.c +4 -5
index 63c8efd1b8db..f869adf0d0a2 100644
@@ -364,8 +364,8 @@ static ssize_t axis_fifo_read(struct file *f, char __user *buf,
 		 * if nothing is currently available
 		 */
 		spin_lock_irq(&fifo->read_queue_lock);
-		ret = wait_event_interruptible_lock_irq_timeout(
-			fifo->read_queue,
+		ret = wait_event_interruptible_lock_irq_timeout
+			(fifo->read_queue,
 			ioread32(fifo->base_addr + XLLF_RDFO_OFFSET),
 			fifo->read_queue_lock,
 			(read_timeout >= 0) ? msecs_to_jiffies(read_timeout) :

@@ -482,8 +482,8 @@ static ssize_t axis_fifo_write(struct file *f, const char __user *buf,
 		 * currently enough room in the fifo
 		 */
 		spin_lock_irq(&fifo->write_queue_lock);
-		ret = wait_event_interruptible_lock_irq_timeout(
-			fifo->write_queue,
+		ret = wait_event_interruptible_lock_irq_timeout
+			(fifo->write_queue,
 			ioread32(fifo->base_addr + XLLF_TDFV_OFFSET)
 				>= words_to_write,
 			fifo->write_queue_lock,
--

2.19.0

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20181003232436.GA29874%40kvasir.local.
For more options, visit https://groups.google.com/d/optout.

author
#2 lore raw

Sure, thing. I am commiting a new patch with th

Quoted 75 lines · Julia Lawall
Quoted 5 lines · Ioannis Valasakis

staging: axis-fifo: Remove parentheses after EOL

According to the script checkpatch.pl and following the Linux Kernel Coding Standards, I remove the parentheses from the EOL and move them to a new line.

Thanks for the patch.

Could you move all the arguments after the first one one space to the right, so that they line up with the rigt side of the (.

Also, the commit log message should be written in the imperative, and it is better to write out words in full rather than using abbreviations. Look at some old commits with git log to get an idea of how to write the commit message.

julia

Review

Quoted 7 lines
Signed-off-by Ioannis Valasakis <[email protected] <javascript:>>

---

 drivers/staging/axis-fifo/axis-fifo.c | 8 ++++---- 
 1 file changed, 4 insertions(+), 4 deletions(-)
(quoted diff) +0 -0

b/drivers/staging/axis-fifo/axis-fifo.c

drivers/staging/axis-fifo/axis-fifo.c static ssize_t axis_fifo_read(struct file *f, char

Quoted 4 lines

index 63c8efd1b8db..f869adf0d0a2 100644

drivers/staging/axis-fifo/axis-fifo.c +0 -0
@@ -364,8 +364,8 @@ static ssize_t axis_fifo_read(struct file *f, char

__user *buf,

drivers/staging/axis-fifo/axis-fifo.c static ssize_t axis_fifo_read(struct file *f, char __user *buf,

Quoted 10 lines
drivers/staging/axis-fifo/axis-fifo.c +2 -2
                  * if nothing is currently available 
                  */ 
                 spin_lock_irq(&fifo->read_queue_lock); 
-                ret = wait_event_interruptible_lock_irq_timeout( 
-                        fifo->read_queue, 
+                ret = wait_event_interruptible_lock_irq_timeout 
+                        (fifo->read_queue, 
                         ioread32(fifo->base_addr + XLLF_RDFO_OFFSET), 
                         fifo->read_queue_lock, 
                         (read_timeout >= 0) ?

msecs_to_jiffies(read_timeout) :

drivers/staging/axis-fifo/axis-fifo.c static ssize_t axis_fifo_write(struct file *f, const

Quoted 1 line
drivers/staging/axis-fifo/axis-fifo.c +0 -0
@@ -482,8 +482,8 @@ static ssize_t axis_fifo_write(struct file *f, const

char __user *buf,

Quoted 15 lines
drivers/staging/axis-fifo/axis-fifo.c +2 -2
                  * currently enough room in the fifo 
                  */ 
                 spin_lock_irq(&fifo->write_queue_lock); 
-                ret = wait_event_interruptible_lock_irq_timeout( 
-                        fifo->write_queue, 
+                ret = wait_event_interruptible_lock_irq_timeout 
+                        (fifo->write_queue, 
                         ioread32(fifo->base_addr + XLLF_TDFV_OFFSET) 
                                 >= words_to_write, 
                         fifo->write_queue_lock,
Signature · 4 lines
2.19.0 

-- 
You received this message because you are subscribed to the Google

Groups "outreachy-kernel" group.

Quoted 1 line

To unsubscribe from this group and stop receiving emails from it, send

an email to [email protected] <javascript:>.

Quoted 1 line

To post to this group, send email to [email protected]

<javascript:>.

Quoted 1 line

To view this discussion on the web visit

https://groups.google.com/d/msgid/outreachy-kernel/20181003232436.GA29874%40kvasir.local.

Quoted 2 lines

For more options, visit https://groups.google.com/d/optout.

author
#3 lore raw

OK, that was a bit unfortunate. So, yes indeed, I am sending a patch which includes the recommended changes. Thank you!

Quoted 79 lines · On Thursday, 4 October 2018 10:54:55 UTC+1, [email protected] wrote:

Sure, thing. I am commiting a new patch with th

Quoted 74 lines · Julia Lawall
Quoted 5 lines · Ioannis Valasakis

staging: axis-fifo: Remove parentheses after EOL

According to the script checkpatch.pl and following the Linux Kernel Coding Standards, I remove the parentheses from the EOL and move them to a new line.

Thanks for the patch.

Could you move all the arguments after the first one one space to the right, so that they line up with the rigt side of the (.

Also, the commit log message should be written in the imperative, and it is better to write out words in full rather than using abbreviations. Look at some old commits with git log to get an idea of how to write the commit message.

julia

Review

Quoted 7 lines
Signed-off-by Ioannis Valasakis <[email protected]>

---

 drivers/staging/axis-fifo/axis-fifo.c | 8 ++++---- 
 1 file changed, 4 insertions(+), 4 deletions(-)
(quoted diff) +0 -0

b/drivers/staging/axis-fifo/axis-fifo.c

drivers/staging/axis-fifo/axis-fifo.c static ssize_t axis_fifo_read(struct file *f, char

Quoted 4 lines

index 63c8efd1b8db..f869adf0d0a2 100644

drivers/staging/axis-fifo/axis-fifo.c +0 -0
@@ -364,8 +364,8 @@ static ssize_t axis_fifo_read(struct file *f, char

__user *buf,

drivers/staging/axis-fifo/axis-fifo.c static ssize_t axis_fifo_read(struct file *f, char __user *buf,

Quoted 10 lines
drivers/staging/axis-fifo/axis-fifo.c +2 -2
                  * if nothing is currently available 
                  */ 
                 spin_lock_irq(&fifo->read_queue_lock); 
-                ret = wait_event_interruptible_lock_irq_timeout( 
-                        fifo->read_queue, 
+                ret = wait_event_interruptible_lock_irq_timeout 
+                        (fifo->read_queue, 
                         ioread32(fifo->base_addr + XLLF_RDFO_OFFSET), 
                         fifo->read_queue_lock, 
                         (read_timeout >= 0) ?

msecs_to_jiffies(read_timeout) :

drivers/staging/axis-fifo/axis-fifo.c static ssize_t axis_fifo_write(struct file *f,

Quoted 1 line
drivers/staging/axis-fifo/axis-fifo.c +0 -0
@@ -482,8 +482,8 @@ static ssize_t axis_fifo_write(struct file *f,

const char __user *buf,

Quoted 15 lines
drivers/staging/axis-fifo/axis-fifo.c +2 -2
                  * currently enough room in the fifo 
                  */ 
                 spin_lock_irq(&fifo->write_queue_lock); 
-                ret = wait_event_interruptible_lock_irq_timeout( 
-                        fifo->write_queue, 
+                ret = wait_event_interruptible_lock_irq_timeout 
+                        (fifo->write_queue, 
                         ioread32(fifo->base_addr + XLLF_TDFV_OFFSET) 
                                 >= words_to_write, 
                         fifo->write_queue_lock,
Signature · 4 lines
2.19.0 

-- 
You received this message because you are subscribed to the Google

Groups "outreachy-kernel" group.

Quoted 1 line

To unsubscribe from this group and stop receiving emails from it, send

an email to [email protected].

Quoted 2 lines

To post to this group, send email to [email protected]. To view this discussion on the web visit

https://groups.google.com/d/msgid/outreachy-kernel/20181003232436.GA29874%40kvasir.local.

Quoted 2 lines

For more options, visit https://groups.google.com/d/optout.