Skip to contentSkip to conversation

qapi/misc.json: Remove superfluous words in CpuModelExpansionType

PATCH Applied Kashyap Chamarthy 5 participants 6 messages Oct 3, 2018 – Oct 9, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 qapi/misc.json: Remove superfluous words in CpuModelExpansionType

While at it, s/QMU/QEMU in @CpuDefinitionInfo.

---
 qapi/misc.json | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
qapi/misc.json +6 -6
index ada9af5add..f98de3a58c 100644
@@ -2017,7 +2017,7 @@
 #
 # @migration-safe: whether a CPU definition can be safely used for
 #                  migration in combination with a QEMU compatibility machine
-#                  when migrating between different QMU versions and between
+#                  when migrating between different QEMU versions and between
 #                  hosts with different sets of (hardware or software)
 #                  capabilities. If not provided, information is not available
 #                  and callers should not assume the CPU definition to be
@@ -2126,11 +2126,11 @@
 # @static: Expand to a static CPU model, a combination of a static base
 #          model name and property delta changes. As the static base model will
 #          never change, the expanded CPU model will be the same, independent of
-#          independent of QEMU version, machine type, machine options, and
-#          accelerator options. Therefore, the resulting model can be used by
-#          tooling without having to specify a compatibility machine - e.g. when
-#          displaying the "host" model. static CPU models are migration-safe.
-#
+#          QEMU version, machine type, machine options, and accelerator options.
+#          Therefore, the resulting model can be used by tooling without having
+#          to specify a compatibility machine - e.g. when displaying the "host"
+#          model. The @static CPU models are migration-safe.
+
 # @full: Expand all properties. The produced model is not guaranteed to be
 #        migration-safe, but allows tooling to get an insight and work with
 #        model details.
Signature · 1 line
2.17.1
Reviewed-by on v1 1/1
#1 lore raw

Hi

Quoted 4 lines · Kashyap Chamarthy

While at it, s/QMU/QEMU in @CpuDefinitionInfo.

Quoted 38 lines
---
 qapi/misc.json | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
qapi/misc.json +6 -7
index ada9af5add..f98de3a58c 100644
@@ -2017,7 +2017,7 @@
 #
 # @migration-safe: whether a CPU definition can be safely used for
 #                  migration in combination with a QEMU compatibility machine
-#                  when migrating between different QMU versions and between
+#                  when migrating between different QEMU versions and between
 #                  hosts with different sets of (hardware or software)
 #                  capabilities. If not provided, information is not available
 #                  and callers should not assume the CPU definition to be
@@ -2126,11 +2126,11 @@
 # @static: Expand to a static CPU model, a combination of a static base
 #          model name and property delta changes. As the static base model will
 #          never change, the expanded CPU model will be the same, independent of
-#          independent of QEMU version, machine type, machine options, and
-#          accelerator options. Therefore, the resulting model can be used by
-#          tooling without having to specify a compatibility machine - e.g. when
-#          displaying the "host" model. static CPU models are migration-safe.
-#
+#          QEMU version, machine type, machine options, and accelerator options.
+#          Therefore, the resulting model can be used by tooling without having
+#          to specify a compatibility machine - e.g. when displaying the "host"
+#          model. The @static CPU models are migration-safe.
+
 # @full: Expand all properties. The produced model is not guaranteed to be
 #        migration-safe, but allows tooling to get an insight and work with
 #        model details.
--

2.17.1

Signature · 1 line
Marc-André Lureau
Reviewed-by on v1 1/1
#2 lore raw
In reply to Kashyap Chamarthy
Quoted 1 line · Kashyap Chamarthy

While at it, s/QMU/QEMU in @CpuDefinitionInfo.

Could mention that it was a repetition of 'independent of'.

Quoted 5 lines
---
  qapi/misc.json | 12 ++++++------
  1 file changed, 6 insertions(+), 6 deletions(-)
Quoted 32 lines
qapi/misc.json +6 -6
index ada9af5add..f98de3a58c 100644
@@ -2017,7 +2017,7 @@
  #
  # @migration-safe: whether a CPU definition can be safely used for
  #                  migration in combination with a QEMU compatibility machine
-#                  when migrating between different QMU versions and between
+#                  when migrating between different QEMU versions and between
  #                  hosts with different sets of (hardware or software)
  #                  capabilities. If not provided, information is not available
  #                  and callers should not assume the CPU definition to be
@@ -2126,11 +2126,11 @@
  # @static: Expand to a static CPU model, a combination of a static base
  #          model name and property delta changes. As the static base model will
  #          never change, the expanded CPU model will be the same, independent of
-#          independent of QEMU version, machine type, machine options, and
-#          accelerator options. Therefore, the resulting model can be used by
-#          tooling without having to specify a compatibility machine - e.g. when
-#          displaying the "host" model. static CPU models are migration-safe.
-#
+#          QEMU version, machine type, machine options, and accelerator options.
+#          Therefore, the resulting model can be used by tooling without having
+#          to specify a compatibility machine - e.g. when displaying the "host"
+#          model. The @static CPU models are migration-safe.
+
  # @full: Expand all properties. The produced model is not guaranteed to be
  #        migration-safe, but allows tooling to get an insight and work with
  #        model details.
Signature · 3 lines
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org
#3 lore raw
Quoted 4 lines · Eric Blake
Quoted 1 line · Kashyap Chamarthy

While at it, s/QMU/QEMU in @CpuDefinitionInfo.

Could mention that it was a repetition of 'independent of'.

Whoever is merging this, please touch up the commit message by adding:

"Remove repetition of 'independent of'"

Thanks!

[...]

Signature · 1 line
/kashyap