Skip to contentSkip to conversation

package/asterisk: libsrtp needs openssl

PATCH Superseded Bernd Kuhls 2 participants 3 messages Oct 3, 2018 – Oct 4, 2018

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Bernd Kuhls

author
#0 lore raw

PATCH 1/1 package/asterisk: libsrtp needs openssl

Fixes configure error

checking for the ability of -lsrtp2 to be linked in a shared object... yes checking for srtp_crypto_policy_set_aes_cm_256_hmac_sha1_80 in -lsrtp2... yes checking for srtp_crypto_policy_set_aes_cm_192_hmac_sha1_80 in -lsrtp2... no checking for srtp_crypto_policy_set_aes_gcm_128_8_auth in -lsrtp2... no checking for srtp_shutdown in -lsrtp2... yes
checking for srtp2/srtp.h... (cached) yes
configure: WARNING: ***
configure: WARNING: *** OpenSSL required when using libsrtp2, checking for libsrtp instead.
configure: WARNING: ***

using this defconfig:

BR2_PACKAGE_LIBSRTP=y
BR2_PACKAGE_ASTERISK=y

Signed-off-by Bernd Kuhls <[email protected]>
---
 package/asterisk/asterisk.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
package/asterisk/asterisk.mk +2 -1
index 9480d6ba82..c3f1136068 100644
@@ -245,7 +245,8 @@ else
 ASTERISK_CONF_OPTS += --without-speex  --without-speexdsp
 endif
 
-ifeq ($(BR2_PACKAGE_LIBSRTP),y)
+# asterisk needs an openssl-enabled libsrtp
+ifeq ($(BR2_PACKAGE_LIBSRTP)$(BR2_PACKAGE_OPENSSL)x$(BR2_STATIC_LIBS),yyx)
 ASTERISK_DEPENDENCIES += libsrtp
 ASTERISK_CONF_OPTS += --with-srtp
 else
Signature · 1 line
2.19.0
#1 lore raw

PATCH 1/1 package/asterisk: libsrtp needs openssl

Hello,

Quoted 27 lines · Bernd Kuhls

Fixes configure error

checking for the ability of -lsrtp2 to be linked in a shared object... yes checking for srtp_crypto_policy_set_aes_cm_256_hmac_sha1_80 in -lsrtp2... yes checking for srtp_crypto_policy_set_aes_cm_192_hmac_sha1_80 in -lsrtp2... no checking for srtp_crypto_policy_set_aes_gcm_128_8_auth in -lsrtp2... no checking for srtp_shutdown in -lsrtp2... yes
checking for srtp2/srtp.h... (cached) yes
configure: WARNING: ***
configure: WARNING: *** OpenSSL required when using libsrtp2, checking for libsrtp instead.
configure: WARNING: ***

using this defconfig:

BR2_PACKAGE_LIBSRTP=y
BR2_PACKAGE_ASTERISK=y

Signed-off-by Bernd Kuhls <[email protected]>
---
 package/asterisk/asterisk.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
package/asterisk/asterisk.mk +0 -0
index 9480d6ba82..c3f1136068 100644

package/asterisk/asterisk.mk else · line 249

Quoted 6 lines
package/asterisk/asterisk.mk +2 -1
@@ -245,7 +245,8 @@ else
 ASTERISK_CONF_OPTS += --without-speex  --without-speexdsp
 endif
 
-ifeq ($(BR2_PACKAGE_LIBSRTP),y)
+# asterisk needs an openssl-enabled libsrtp
+ifeq ($(BR2_PACKAGE_LIBSRTP)$(BR2_PACKAGE_OPENSSL)x$(BR2_STATIC_LIBS),yyx)

Any reason to exclude static linking configurations here? This is not explained in the commit log.

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
author
#2 lore raw

PATCH 1/1 package/asterisk: libsrtp needs openssl

Am Thu, 04 Oct 2018 14:18:56 +0200 schrieb Thomas Petazzoni:

Quoted 6 lines

package/asterisk/asterisk.mk else · line 249

Quoted 3 lines
package/asterisk/asterisk.mk +2 -1
-ifeq ($(BR2_PACKAGE_LIBSRTP),y)
+# asterisk needs an openssl-enabled libsrtp
+ifeq ($(BR2_PACKAGE_LIBSRTP)$(BR2_PACKAGE_OPENSSL)x$(BR2_STATIC_LIBS),yyx)

Any reason to exclude static linking configurations here? This is not explained in the commit log.

Hi Thomas,

openssl support in libsrtp depends on libdl:
https://git.buildroot.net/buildroot/tree/package/libsrtp/libsrtp.mk#n27

Shall I sent v2?

Regards, Bernd