ceres-solver: Removed empty package
PATCH 1/1 ceres-solver: Removed empty package
By default ceres-solver provides a static library and headers. This change removes an empty package and sets an implicit dependency on dev and dbg packages.
It also addresses missing cmake configuration files in dev package.
--- meta-oe/recipes-support/ceres-solver/ceres-solver_1.14.bb | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
meta-oe/recipes-support/ceres-solver/ceres-solver_1.14.bb +4 -1
@@ -13,5 +13,8 @@ S = "${WORKDIR}/git" inherit cmake +FILES_${PN}-dev += "${libdir}/cmake/" + # Only a static library and headers are created -ALLOW_EMPTY_${PN} = "1" +RDEPENDS_${PN}-dev = "" +RRECOMMENDS_${PN}-dbg = "${PN}-dev (= ${EXTENDPKGV})"
Signature · 1 line
2.19.0
Quoted 16 lines · Vyacheslav Yurkov
By default ceres-solver provides a static library and headers. This change removes an empty package and sets an implicit dependency on dev and dbg packages.
It also addresses missing cmake configuration files in dev package.
Signed-off-by Vyacheslav Yurkov <[email protected]>--- meta-oe/recipes-support/ceres-solver/ceres-solver_1.14.bb | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)meta-oe/recipes-support/ceres-solver/ceres-solver_1.14.bb +0
-0
meta-oe/recipes-support/ceres-solver/ceres-solver_1.14.bb S = "${WORKDIR}/git" · line 16
Quoted 4 lines
meta-oe/recipes-support/ceres-solver/ceres-solver_1.14.bb +1
-0@@ -13,5 +13,8 @@ S = "${WORKDIR}/git" inherit cmake +FILES_${PN}-dev += "${libdir}/cmake/"
Why is this needed? cmake files are packaged automatically since oe-core commit:
commit 543e39ad5e2baa0f1ece013a89483783e6b15dd9
Author: Andre McCurdy <[email protected]> Date: Tue Jun 26 12:48:11 2018 -0700
bitbake.conf: handle cmake -dev files packaging with default rules
Quoted 13 lines
meta-oe/recipes-support/ceres-solver/ceres-solver_1.14.bb +3
-1+ # Only a static library and headers are created -ALLOW_EMPTY_${PN} = "1" +RDEPENDS_${PN}-dev = "" +RRECOMMENDS_${PN}-dbg = "${PN}-dev (= ${EXTENDPKGV})"Signature · 7 lines
2.19.0 -- _______________________________________________ Openembedded-devel mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Signature · 1 line
Martin 'JaMa' Jansa jabber: [email protected]
I'm bit behind with oe-core (not on master) and was not aware of that. Anyway I was about to send v2, because I realized that static library and headers should come together, and it doesn't make sense to specify two packages.
Vyacheslav
Quoted 49 lines · Martin Jansa
Quoted 4 lines · Vyacheslav Yurkov
By default ceres-solver provides a static library and headers. This change removes an empty package and sets an implicit dependency on dev and dbg packages.
Review
Quoted 8 lines
It also addresses missing cmake configuration files in dev package.
Signed-off-by Vyacheslav Yurkov <[email protected]>--- meta-oe/recipes-support/ceres-solver/ceres-solver_1.14.bb | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)(quoted diff) +0
-0b/meta-oe/recipes-support/ceres-solver/ceres-solver_1.14.bb
meta-oe/recipes-support/ceres-solver/ceres-solver_1.14.bb S = "${WORKDIR}/git" · line 16
Quoted 8 lines
index
ad7c8f2a3..13ca8efab100644meta-oe/recipes-support/ceres-solver/ceres-solver_1.14.bb +1
-0@@ -13,5 +13,8 @@ S = "${WORKDIR}/git" inherit cmake +FILES_${PN}-dev += "${libdir}/cmake/"Why is this needed? cmake files are packaged automatically since oe-core commit:
commit
543e39ad5e2baa0f1ece013a89483783e6b15dd9Author: Andre McCurdy <[email protected]> Date: Tue Jun 26 12:48:11 2018 -0700bitbake.conf: handle cmake -dev files packaging with default rules
Quoted 8 lines
meta-oe/recipes-support/ceres-solver/ceres-solver_1.14.bb +3
-2+ # Only a static library and headers are created -ALLOW_EMPTY_${PN} = "1" +RDEPENDS_${PN}-dev = "" +RRECOMMENDS_${PN}-dbg = "${PN}-dev (= ${EXTENDPKGV})" --2.19.0
Quoted 5 lines
--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel--
Martin 'JaMa' Jansa jabber: [email protected]