Skip to contentSkip to conversation

staging/rtlwifi: Fixing formatting warnings from checkpatch.pl.

PATCH In review Scott Tracy 2 participants 3 messages Oct 5, 2018 – Oct 6, 2018 Staging

lore
Share & tools
lore

Scott Tracy

author
#0 lore raw

PATCH 1/1 staging/rtlwifi: Fixing formatting warnings from checkpatch.pl.

Fixing formatting warnings in rtlwifi found by checkpatch.pl Changes include breaking up functions calls into multi line calls. No functional/logical changes.

Signed-off-by Scott Tracy <[email protected]>
---
 drivers/staging/rtlwifi/core.c  | 5 +++--
 drivers/staging/rtlwifi/efuse.c | 5 +++--
 2 files changed, 6 insertions(+), 4 deletions(-)
drivers/staging/rtlwifi/core.c +3 -2
index ca37f7511c4d..a36cb44a5388 100644
@@ -1109,7 +1109,7 @@ static void rtl_op_bss_info_changed(struct ieee80211_hw *hw,
 			if (rtlpriv->dm.supp_phymode_switch) {
 				if (sta->ht_cap.ht_supported)
 					rtl_send_smps_action(hw, sta,
-							     IEEE80211_SMPS_STATIC);
+							IEEE80211_SMPS_STATIC);
 			}
 
 			if (rtlhal->current_bandtype == BAND_ON_5G) {

@@ -1882,7 +1882,8 @@ bool rtl_hal_pwrseqcmdparsing(struct rtl_priv *rtlpriv, u8 cut_version,
 				return true;
 			default:
 				WARN_ONCE(true,
-					  "rtlwifi: %s(): Unknown CMD!!\n", __func__);
+					 "rtlwifi: %s(): Unknown CMD!!\n",
+					  __func__);
 				break;
 			}
 		}
drivers/staging/rtlwifi/efuse.c +3 -2
index 1dc71455f270..5b8afdb3e0fe 100644
@@ -245,7 +245,8 @@ void read_efuse(struct ieee80211_hw *hw, u16 _offset, u16 _size_byte, u8 *pbuf)
 	if (!efuse_word)
 		goto out;
 	for (i = 0; i < EFUSE_MAX_WORD_UNIT; i++) {
-		efuse_word[i] = kcalloc(efuse_max_section, sizeof(u16), GFP_ATOMIC);
+		efuse_word[i] = kcalloc(efuse_max_section,
+					sizeof(u16), GFP_ATOMIC);
 		if (!efuse_word[i])
 			goto done;
 	}

@@ -375,7 +376,7 @@ bool efuse_shadow_update_chk(struct ieee80211_hw *hw)
 		for (i = 0; i < 8; i = i + 2) {
 			if ((rtlefuse->efuse_map[EFUSE_INIT_MAP][base + i] !=
 			     rtlefuse->efuse_map[EFUSE_MODIFY_MAP][base + i]) ||
-			    (rtlefuse->efuse_map[EFUSE_INIT_MAP][base + i + 1] !=
+			   (rtlefuse->efuse_map[EFUSE_INIT_MAP][base + i + 1] !=
 			     rtlefuse->efuse_map[EFUSE_MODIFY_MAP][base + i +
 								   1])) {
 				words_need++;
Signature · 1 line
2.17.1
#1 lore raw
Quoted 3 lines · Scott Tracy

Fixing formatting warnings in rtlwifi found by checkpatch.pl Changes include breaking up functions calls into multi line calls. No functional/logical changes.

I believe the code is better before most of these changes.

There are various tradeoffs do source code formatting.

Here you are changing some alignment to open parentheses and converting to < 80 columns.

author
#2 lore raw
Quoted 6 lines · Joe Perches
Quoted 3 lines · Scott Tracy

Fixing formatting warnings in rtlwifi found by checkpatch.pl Changes include breaking up functions calls into multi line calls. No functional/logical changes.

Quoted 8 lines

I believe the code is better before most of these changes.

There are various tradeoffs do source code formatting.

Here you are changing some alignment to open parentheses and converting to < 80 columns.

Joe,
Thanks for the criticism. Fair comments all. I was just working through the KernelNewbies.org tutorial looking for low value changes to get my feet wet and assumed that a "check" was better than a "warning". A also didn't feel confident enough to refactor the code to get under the 80 character limit. Maybe I will spend a little more time refactoring something and then submitting that. Thanks again,

Scott Tracy