staging: iio: adc: ad7280a: fix 2 checks
Subsystems (4)
PATCH 1/1 staging: iio: adc: ad7280a: fix 2 checks
This patch does not change the logic, it only
corrects the checkpatch checks.
The patch fixes 2 checks of type:
"CHECK: spaces preferred around that '-'"
--- drivers/staging/iio/adc/ad7280a.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/iio/adc/ad7280a.c +2 -2
@@ -750,14 +750,14 @@ static irqreturn_t ad7280_event_handler(int irq, void *private) } static IIO_DEVICE_ATTR_NAMED(in_thresh_low_value, - in_voltage-voltage_thresh_low_value, + in_voltage - voltage_thresh_low_value,0644 , ad7280_read_channel_config, ad7280_write_channel_config, AD7280A_CELL_UNDERVOLTAGE); static IIO_DEVICE_ATTR_NAMED(in_thresh_high_value, - in_voltage-voltage_thresh_high_value, + in_voltage - voltage_thresh_high_value,0644 , ad7280_read_channel_config, ad7280_write_channel_config,
Signature · 8 lines
2.17.1 (Apple Git-112) -- Gabriel Capella gabrielcapella.com hardwarelivreusp.org +55 11 98124-5668
Quoted 5 lines · Gabriel Capella
This patch does not change the logic, it only
corrects the checkpatch checks.The patch fixes 2 checks of type:
"CHECK: spaces preferred around that '-'"
I've made the same mistake few days ago. This change is incorrect. Please see: https://lore.kernel.org/patchwork/patch/635994/.
Quoted 26 lines
Signed-off-by Gabriel Capella <[email protected]>--- drivers/staging/iio/adc/ad7280a.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/staging/iio/adc/ad7280a.c +2
-2@@ -750,14 +750,14 @@ static irqreturn_t ad7280_event_handler(int irq, void *private) } static IIO_DEVICE_ATTR_NAMED(in_thresh_low_value, - in_voltage-voltage_thresh_low_value, + in_voltage - voltage_thresh_low_value,0644 , ad7280_read_channel_config, ad7280_write_channel_config, AD7280A_CELL_UNDERVOLTAGE); static IIO_DEVICE_ATTR_NAMED(in_thresh_high_value, - in_voltage-voltage_thresh_high_value, + in_voltage - voltage_thresh_high_value,0644 , ad7280_read_channel_config, ad7280_write_channel_config,
Signature · 1 line
Slawomir Stepien
Quoted 10 lines · Slawomir Stepien
Quoted 5 lines · Gabriel Capella
This patch does not change the logic, it only
corrects the checkpatch checks.The patch fixes 2 checks of type:
"CHECK: spaces preferred around that '-'"I've made the same mistake few days ago. This change is incorrect. Please see: https://lore.kernel.org/patchwork/patch/635994/.
You could add a comment. /* do not put spaces around the hyphen. #checkpatch.pl */
These are the only places which use this style and a lot of people bump into it.
regards,
dan carpenter
Quoted 8 lines · Dan Carpenter
Quoted 7 lines · Slawomir Stepien
Quoted 5 lines · Gabriel Capella
This patch does not change the logic, it only
corrects the checkpatch checks.The patch fixes 2 checks of type:
"CHECK: spaces preferred around that '-'"
Quoted 8 lines
Quoted 3 lines
I've made the same mistake few days ago. This change is incorrect. Please see: https://lore.kernel.org/patchwork/patch/635994/.
You could add a comment. /* do not put spaces around the hyphen. #checkpatch.pl */
These are the only places which use this style and a lot of people bump into it.
Gabriel go ahead if you want to. If not then I would be happy to prepare this patch.
Signature · 1 line
Slawomir Stepien
A few minutes ago a sent a patch adding this comment in two different files.
Thank you for the suggestions.
Em qui, 11 de out de 2018 às 12:32, Slawomir Stepien <[email protected]> escreveu:
Quoted 26 lines · Dan Carpenter
Quoted 5 lines · Slawomir Stepien
Quoted 4 lines · Gabriel Capella
Quoted 3 lines
This patch does not change the logic, it only
corrects the checkpatch checks.Quoted 8 lines
Quoted 6 lines
Quoted 2 lines
The patch fixes 2 checks of type:
"CHECK: spaces preferred around that '-'"I've made the same mistake few days ago. This change is incorrect. Please see: https://lore.kernel.org/patchwork/patch/635994/.
You could add a comment. /* do not put spaces around the hyphen. #
checkpatch.pl */
Quoted 3 lines
These are the only places which use this style and a lot of people bump into it.
Gabriel go ahead if you want to. If not then I would be happy to prepare this
patch.--
Slawomir Stepien
Signature · 4 lines
Gabriel Capella gabrielcapella.com hardwarelivreusp.org +55 11 98124-5668