Skip to contentSkip to conversation

misc: Add support for the Arm Versatile Express config bus

PATCH New Liviu Dudau 3 participants 6 messages Sep 17, 2018 – Oct 7, 2018

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 misc: Add support for the Arm Versatile Express config bus

Add support for the Arm Versatile Express config bus that is being used for exposing various subsystems via a generic configuration bus. This driver adds support for generating transactions on this configuration bus and can be used by other drivers to abstract the communication with the actual function providers.

---
 drivers/misc/Kconfig           |   8 +++
 drivers/misc/Makefile          |   1 +
 drivers/misc/vexpress_config.c | 127 +++++++++++++++++++++++++++++++++
 3 files changed, 136 insertions(+)
 create mode 100644 drivers/misc/vexpress_config.c
drivers/misc/Kconfig +8 -0
index c2b7cc15db..468a5682e3 100644
@@ -41,6 +41,14 @@ config ROCKCHIP_EFUSE
 	  extended (by porting the read function from the Linux kernel sources)
 	  to support other recent Rockchip devices.
 
+config VEXPRESS_CONFIG
+	bool "Enable support for Arm Versatile Express config bus"
+	depends on MISC
+	help
+	  If you say Y here, you will get support for accessing the
+	  configuration bus on the Arm Versatile Express boards via
+	  a sysreg driver.
+
 config CMD_CROS_EC
 	bool "Enable crosec command"
 	depends on CROS_EC
drivers/misc/Makefile +1 -0
index 32ef4a53c7..6d3418efc7 100644
@@ -55,3 +55,4 @@ obj-$(CONFIG_STM32MP_FUSE) += stm32mp_fuse.o
 obj-$(CONFIG_SYS_DPAA_QBMAN) += fsl_portals.o
 obj-$(CONFIG_GDSYS_IOEP) += gdsys_ioep.o
 obj-$(CONFIG_GDSYS_RXAUI_CTRL) += gdsys_rxaui_ctrl.o
+obj-$(CONFIG_VEXPRESS_CONFIG) += vexpress_config.o
drivers/misc/vexpress_config.c new file +127 -0

127 lines not on this page · raw message

Signature · 1 line
2.18.0
#1 lore raw

PATCH 1/1 misc: Add support for the Arm Versatile Express config bus

Hello Liviu,

Am 17.09.2018 um 18:48 schrieb Liviu Dudau:

Quoted 7 lines

Add support for the Arm Versatile Express config bus that is being used for exposing various subsystems via a generic configuration bus. This driver adds support for generating transactions on this configuration bus and can be used by other drivers to abstract the communication with the actual function providers.

Quoted 8 lines
---
  drivers/misc/Kconfig           |   8 +++
  drivers/misc/Makefile          |   1 +
  drivers/misc/vexpress_config.c | 127 +++++++++++++++++++++++++++++++++
  3 files changed, 136 insertions(+)

create mode 100644 drivers/misc/vexpress_config.c

Beside of a nitpick

[...]

drivers/misc/vexpress_config.c line 7

Quoted 13 lines
drivers/misc/vexpress_config.c new file +7 -0
new file mode 100644
index 0000000000..2cd433d01e
@@ -0,1 +1,127 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Copyright (C) 2018 Arm Ltd
+ * Author: Liviu Dudau <[email protected]>
+ *
+ */
+#define DEBUG

Really enable debug?

bye,
Heiko

Signature · 3 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: hs at denx.de
#2 lore raw

PATCH 1/1 misc: Add support for the Arm Versatile Express config bus

Quoted 24 lines · Heiko Schocher

Hello Liviu,

Am 17.09.2018 um 18:48 schrieb Liviu Dudau:

Quoted 7 lines

Add support for the Arm Versatile Express config bus that is being used for exposing various subsystems via a generic configuration bus. This driver adds support for generating transactions on this configuration bus and can be used by other drivers to abstract the communication with the actual function providers.

Quoted 8 lines
---
  drivers/misc/Kconfig           |   8 +++
  drivers/misc/Makefile          |   1 +
  drivers/misc/vexpress_config.c | 127 +++++++++++++++++++++++++++++++++
  3 files changed, 136 insertions(+)

create mode 100644 drivers/misc/vexpress_config.c

Beside of a nitpick

[...]

Quoted 15 lines

drivers/misc/vexpress_config.c line 7

Quoted 13 lines
drivers/misc/vexpress_config.c new file +7 -0
new file mode 100644
index 0000000000..2cd433d01e
@@ -0,1 +1,127 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Copyright (C) 2018 Arm Ltd
+ * Author: Liviu Dudau <[email protected]>
+ *
+ */
+#define DEBUG

Really enable debug?

Sorry, left over from development, I will remove it and re-submit.

Best regards,
Liviu

Quoted 7 lines

bye,
Heiko

Signature · 3 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: hs at denx.de
Signature · 8 lines
====================
| I would like to |
| fix the world,  |
| but they're not |
| giving me the   |
 \ source code!  /
  ---------------
    ¯\_(ツ)_/¯
#3 lore raw

PATCH v2 1/1 misc: Add support for the Arm Versatile Express config bus

In reply to Heiko Schocher

Add support for the Arm Versatile Express config bus that is being used for exposing various subsystems via a generic configuration bus. This driver adds support for generating transactions on this configuration bus and can be used by other drivers to abstract the communication with the actual function providers.

---

Changelog:
- v2: removed #define DEBUG line leftover

 drivers/misc/Kconfig           |   8 +++
 drivers/misc/Makefile          |   1 +
 drivers/misc/vexpress_config.c | 126 +++++++++++++++++++++++++++++++++
 3 files changed, 136 insertions(+)
 create mode 100644 drivers/misc/vexpress_config.c
drivers/misc/Kconfig +8 -0
index c2b7cc15db..468a5682e3 100644
@@ -41,6 +41,14 @@ config ROCKCHIP_EFUSE
 	  extended (by porting the read function from the Linux kernel sources)
 	  to support other recent Rockchip devices.
 
+config VEXPRESS_CONFIG
+	bool "Enable support for Arm Versatile Express config bus"
+	depends on MISC
+	help
+	  If you say Y here, you will get support for accessing the
+	  configuration bus on the Arm Versatile Express boards via
+	  a sysreg driver.
+
 config CMD_CROS_EC
 	bool "Enable crosec command"
 	depends on CROS_EC
drivers/misc/Makefile +1 -0
index 32ef4a53c7..6d3418efc7 100644
@@ -55,3 +55,4 @@ obj-$(CONFIG_STM32MP_FUSE) += stm32mp_fuse.o
 obj-$(CONFIG_SYS_DPAA_QBMAN) += fsl_portals.o
 obj-$(CONFIG_GDSYS_IOEP) += gdsys_ioep.o
 obj-$(CONFIG_GDSYS_RXAUI_CTRL) += gdsys_rxaui_ctrl.o
+obj-$(CONFIG_VEXPRESS_CONFIG) += vexpress_config.o
drivers/misc/vexpress_config.c new file +126 -0

126 lines not on this page · raw message

Signature · 1 line
2.18.0
#4 lore raw

PATCH v3 1/1 misc: Add support for the Arm Versatile Express config bus

Add support for the Arm Versatile Express config bus that is being used for exposing various subsystems via a generic configuration bus. This driver adds support for generating transactions on this configuration bus and can be used by other drivers to abstract the communication with the actual function providers.

---

Changelog:
- v3: Added MAINTAINERS entry and Reviewed-by tag
- v2: removed #define DEBUG line leftover

 MAINTAINERS                    |   7 ++
 drivers/misc/Kconfig           |   8 +++
 drivers/misc/Makefile          |   1 +
 drivers/misc/vexpress_config.c | 128 +++++++++++++++++++++++++++++++++
 4 files changed, 144 insertions(+)
 create mode 100644 drivers/misc/vexpress_config.c
MAINTAINERS +7 -0
index ea21d59f1e..613d7b29a0 100644
@@ -286,6 +286,13 @@ F:	arch/arm/mach-uniphier/
 F:	configs/uniphier_*_defconfig
 N:	uniphier
 
+ARM VERSATILE EXPRESS DRIVERS
+M:	Liviu Dudau <[email protected]>
+S:	Maintained
+T:	git git://github.com/ARM-software/u-boot.git
+F:	drivers/misc/vexpress_config.c
+N:	vexpress
+
 ARM ZYNQ
 M:	Michal Simek <[email protected]>
 S:	Maintained
drivers/misc/Kconfig +8 -0
index bfa5c91687..78dc9264f9 100644
@@ -41,6 +41,14 @@ config ROCKCHIP_EFUSE
 	  extended (by porting the read function from the Linux kernel sources)
 	  to support other recent Rockchip devices.
 
+config VEXPRESS_CONFIG
+	bool "Enable support for Arm Versatile Express config bus"
+	depends on MISC
+	help
+	  If you say Y here, you will get support for accessing the
+	  configuration bus on the Arm Versatile Express boards via
+	  a sysreg driver.
+
 config CMD_CROS_EC
 	bool "Enable crosec command"
 	depends on CROS_EC
drivers/misc/Makefile +1 -0
index da4666fdfc..50b52f9aa5 100644
@@ -55,4 +55,5 @@ obj-$(CONFIG_STM32MP_FUSE) += stm32mp_fuse.o
 obj-$(CONFIG_SYS_DPAA_QBMAN) += fsl_portals.o
 obj-$(CONFIG_GDSYS_IOEP) += gdsys_ioep.o
 obj-$(CONFIG_GDSYS_RXAUI_CTRL) += gdsys_rxaui_ctrl.o
+obj-$(CONFIG_VEXPRESS_CONFIG) += vexpress_config.o
 obj-$(CONFIG_MPC83XX_SERDES) += mpc83xx_serdes.o
drivers/misc/vexpress_config.c new file +128 -0

128 lines not on this page · raw message

Signature · 1 line
2.18.0
#5 lore raw

PATCH v3 1/1 misc: Add support for the Arm Versatile Express config bus

Quoted 9 lines · Liviu Dudau

Add support for the Arm Versatile Express config bus that is being used for exposing various subsystems via a generic configuration bus. This driver adds support for generating transactions on this configuration bus and can be used by other drivers to abstract the communication with the actual function providers.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181006/d0bb12b2/attachment.sig>