Skip to contentSkip to conversation

ARM: da850evm: Remove DM_I2C_COMPAT

PATCH Superseded Adam Ford 2 participants 4 messages Sep 30, 2018 – Oct 7, 2018

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Adam Ford

author
#0 lore raw

PATCH 1/1 ARM: da850evm: Remove DM_I2C_COMPAT

The da850evm does not need this enabled, so this removes a notice that appears during compile time that says "Please remove"

configs/da850_am18xxevm_defconfig +0 -1
index 6745cd10fa..c3d7cff18e 100644
@@ -39,7 +39,6 @@ CONFIG_ENV_IS_IN_SPI_FLASH=y
 CONFIG_DM=y
 CONFIG_DA8XX_GPIO=y
 CONFIG_DM_I2C=y
-CONFIG_DM_I2C_COMPAT=y
 CONFIG_SYS_I2C_DAVINCI=y
 CONFIG_MTD_DEVICE=y
 CONFIG_MTD_PARTITIONS=y
configs/da850evm_direct_nor_defconfig +0 -1
index 8ea522af93..b7423034db 100644
@@ -40,7 +40,6 @@ CONFIG_DM=y
 CONFIG_BLK=y
 CONFIG_DA8XX_GPIO=y
 CONFIG_DM_I2C=y
-CONFIG_DM_I2C_COMPAT=y
 CONFIG_SYS_I2C_DAVINCI=y
 # CONFIG_MMC is not set
 CONFIG_MTD_NOR_FLASH=y
include/configs/da850evm.h +0 -1
index 319f6aadf5..167bd4b5c4 100644
@@ -26,7 +26,6 @@
 #undef CONFIG_DM_SPI
 #undef CONFIG_DM_SPI_FLASH
 #undef CONFIG_DM_I2C
-#undef CONFIG_DM_I2C_COMPAT
 #endif
 /*
  * SoC Configuration
Signature · 1 line
2.17.1
#1 lore raw
Quoted 5 lines · Adam Ford

The da850evm does not need this enabled, so this removes a notice that appears during compile time that says "Please remove"

NAK, this breaks da850_am18xxevm which, ahem, you're listed as the maintainer of :)

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181006/7f24714e/attachment.sig>
author
#2 lore raw
Quoted 4 lines · Tom Rini

On Sun, Sep 30, 2018 at 09:20:13AM -0500, Adam Ford wrote:

Quoted 9 lines
Quoted 5 lines

The da850evm does not need this enabled, so this removes a notice that appears during compile time that says "Please remove"

NAK, this breaks da850_am18xxevm which, ahem, you're listed as the maintainer of :)

(facepalm) I don't know what I was thinking. I must have had something else going which made it compile.

On a separate note, I'd like to relinquish maintainership of just da850_am18xxevm since I don't have that hardware, and it was not made by Logic PD. The other remaining boards I have, so I can continue to do that. Looking at the maintainer readme stuff, I cannot tell of the proper syntax to orphan just one defconfig since they appear to me sharing a lot of the same code.

Can you off me a suggestion? I could just delete it from the list of boards I maintain, but it seems like, it should be moved into it's own category, but I don't want to imply the rest have been orphaned.

adam

Quoted 2 lines

--
Tom

#3 lore raw
Quoted 24 lines · Adam Ford
Quoted 4 lines · Tom Rini

On Sun, Sep 30, 2018 at 09:20:13AM -0500, Adam Ford wrote:

Quoted 9 lines
Quoted 5 lines

The da850evm does not need this enabled, so this removes a notice that appears during compile time that says "Please remove"

NAK, this breaks da850_am18xxevm which, ahem, you're listed as the maintainer of :)

(facepalm) I don't know what I was thinking. I must have had something else going which made it compile.

On a separate note, I'd like to relinquish maintainership of just da850_am18xxevm since I don't have that hardware, and it was not made by Logic PD. The other remaining boards I have, so I can continue to do that. Looking at the maintainer readme stuff, I cannot tell of the proper syntax to orphan just one defconfig since they appear to me sharing a lot of the same code.

Quoted 3 lines

Can you off me a suggestion? I could just delete it from the list of boards I maintain, but it seems like, it should be moved into it's own category, but I don't want to imply the rest have been orphaned.

I think you'll need to re-org the file to have a new entry just for that board and mark it as orphaned. Thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181007/7625a3ee/attachment.sig>