ARM: dts: imx6qdl-udoo: Add Pincfgs for UART4

PATCH New Markus Kueffner 4 participants 7 messages Oct 4, 2018 – Oct 11, 2018

Subsystems (2)

Device tree bindings Arm i.MX and Layerscape

lore

Share & tools

lore

Markus Kueffner

author

2018-10-04 21:28 UTC #0 lore raw

PATCH 1/1 ARM: dts: imx6qdl-udoo: Add Pincfgs for UART4

From: Markus Kueffner <[email protected]>

Add Pincfgs for UART4 to enable Communication with the onboard SAM3X

Signed-off-by Markus Kueffner <[email protected]>

---
 arch/arm/boot/dts/imx6qdl-udoo.dtsi | 13 +++++++++++++
 1 file changed, 13 insertions(+)

arch/arm/boot/dts/imx6qdl-udoo.dtsi +13 -0

index 4f27861..5614170 100644
@@ -195,6 +195,13 @@
 			>;
 		};
 
+		pinctrl_uart4: uart4grp {
+			fsl,pins = <
+				MX6QDL_PAD_KEY_COL0__UART4_TX_DATA	0x1b0b1
+				MX6QDL_PAD_KEY_ROW0__UART4_RX_DATA	0x1b0b1
+			>;
+		};
+
 		pinctrl_usbh: usbhgrp {
 			fsl,pins = <
 				MX6QDL_PAD_GPIO_17__GPIO7_IO12 0x80000000

@@ -265,6 +272,12 @@
 	status = "okay";
 };
 
+&uart4 { // iMX6-Arduino internal serial port - ttymxc3
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_uart4>;
+	status = "okay";
+};
+
 &usbh1 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_usbh>;

Signature · 1 line

2.7.4

Shawn Guo

2018-10-08 06:05 UTC #1 lore raw

PATCH 1/1 ARM: dts: imx6qdl-udoo: Add Pincfgs for UART4

Add a few udoo board users for comment.

Quoted 43 lines · Markus Kueffner

From: Markus Kueffner <[email protected]>

Add Pincfgs for UART4 to enable Communication with the onboard SAM3X

Signed-off-by Markus Kueffner <[email protected]>

---
 arch/arm/boot/dts/imx6qdl-udoo.dtsi | 13 +++++++++++++
 1 file changed, 13 insertions(+)

arch/arm/boot/dts/imx6qdl-udoo.dtsi +13 -0

index 4f27861..5614170 100644
@@ -195,6 +195,13 @@
 			>;
 		};
 
+		pinctrl_uart4: uart4grp {
+			fsl,pins = <
+				MX6QDL_PAD_KEY_COL0__UART4_TX_DATA	0x1b0b1
+				MX6QDL_PAD_KEY_ROW0__UART4_RX_DATA	0x1b0b1
+			>;
+		};
+
 		pinctrl_usbh: usbhgrp {
 			fsl,pins = <
 				MX6QDL_PAD_GPIO_17__GPIO7_IO12 0x80000000

@@ -265,6 +272,12 @@
 	status = "okay";
 };
 
+&uart4 { // iMX6-Arduino internal serial port - ttymxc3
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_uart4>;
+	status = "okay";
+};
+
 &usbh1 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_usbh>;

Signature · 1 line

2.7.4

Maciej S. Szmigiero

2018-10-10 21:57 UTC #2 lore raw

PATCH 1/1 ARM: dts: imx6qdl-udoo: Add Pincfgs for UART4

Quoted 6 lines · Shawn Guo

Add a few udoo board users for comment.
Quoted 3 lines · Markus Kueffner
From: Markus Kueffner <[email protected]>
Add Pincfgs for UART4 to enable Communication with the onboard SAM3X

Although I can't test this patch on a real board, verifying it with UDOO schematic and docs suggests that this change does make sense.

Maciej

Fabio Estevam

reviewer

2018-10-08 20:51 UTC #3 lore raw

PATCH 1/1 ARM: dts: imx6qdl-udoo: Add Pincfgs for UART4

In reply to Markus Kueffner

Quoted 6 lines · Markus Kueffner

From: Markus Kueffner <[email protected]>
Add Pincfgs for UART4 to enable Communication with the onboard SAM3X
Signed-off-by Markus Kueffner <[email protected]>

Looks good as per the schematics:

Reviewed-by Fabio Estevam <[email protected]>

Quoted 1 line

+&uart4 { // iMX6-Arduino internal serial port - ttymxc3

Minor nit: // style comment should be avoided.

Actually the whole comment could de dropped IMHO.

Markus Kueffner

author

2018-10-10 08:19 UTC #4 lore raw

PATCH 1/1 ARM: dts: imx6qdl-udoo: Add Pincfgs for UART4

Quoted 1 line

From b25738867245688e0a1eafeb78379efc6a73b66e Mon Sep 17 00:00:00 2001

From: Markus Kueffner <[email protected]>
Date: Wed, 10 Oct 2018 08:32:09 +0200
Subject: [PATCH v2] ARM: dts: imx6qdl-udoo: Add Pincfgs for UART4

Add Pincfgs for UART4 to enable Communication with the onboard SAM3X

Signed-off-by Markus Kueffner <[email protected]>

---
Changes in v2:
- Removed // style Comment.

 arch/arm/boot/dts/imx6qdl-udoo.dtsi | 13 +++++++++++++
 1 file changed, 13 insertions(+)

arch/arm/boot/dts/imx6qdl-udoo.dtsi +13 -0

index 4f27861..40d1b0d 100644
@@ -195,6 +195,13 @@
 			>;
 		};
 
+		pinctrl_uart4: uart4grp {
+			fsl,pins = <
+				MX6QDL_PAD_KEY_COL0__UART4_TX_DATA	0x1b0b1
+				MX6QDL_PAD_KEY_ROW0__UART4_RX_DATA	0x1b0b1
+			>;
+		};
+
 		pinctrl_usbh: usbhgrp {
 			fsl,pins = <
 				MX6QDL_PAD_GPIO_17__GPIO7_IO12 0x80000000

@@ -265,6 +272,12 @@
 	status = "okay";
 };
 
+&uart4 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_uart4>;
+	status = "okay";
+};
+
 &usbh1 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_usbh>;

Signature · 1 line

2.1.4

Fabio Estevam

reviewer

2018-10-10 22:20 UTC #5 lore raw

PATCH 1/1 ARM: dts: imx6qdl-udoo: Add Pincfgs for UART4

Quoted 9 lines · Markus Kueffner

From b25738867245688e0a1eafeb78379efc6a73b66e Mon Sep 17 00:00:00 2001
From: Markus Kueffner <[email protected]>
Date: Wed, 10 Oct 2018 08:32:09 +0200
Subject: [PATCH v2] ARM: dts: imx6qdl-udoo: Add Pincfgs for UART4
Add Pincfgs for UART4 to enable Communication with the onboard SAM3X
Signed-off-by Markus Kueffner <[email protected]>

Reviewed-by Fabio Estevam <[email protected]>

Shawn Guo

Applied

2018-10-11 13:12 UTC #6 lore raw

PATCH 1/1 ARM: dts: imx6qdl-udoo: Add Pincfgs for UART4

In reply to Markus Kueffner

Quoted 7 lines · Markus Kueffner

From: Markus Kueffner <[email protected]>
Date: Wed, 10 Oct 2018 08:32:09 +0200
Subject: [PATCH v2] ARM: dts: imx6qdl-udoo: Add Pincfgs for UART4
Add Pincfgs for UART4 to enable Communication with the onboard SAM3X
Signed-off-by Markus Kueffner <[email protected]>

Applied, thanks.