Skip to contentSkip to conversation

utils/get-developers: add -e flag to only list email addresses for git send-email

PATCH New Peter Korsgaard 3 participants 6 messages Oct 8, 2018 – Oct 21, 2018

lore
Share & tools
lore

Peter Korsgaard

author
#0 lore raw

PATCH 1/1 utils/get-developers: add -e flag to only list email addresses for git send-email

When called with a list of patches, get-developers prints the entire git send-email invocation line:

./utils/get-developers 0001-git-security-bump-to-version-2.16.5.patch
git send-email --to buildroot at buildroot.org --cc "Matt Weber <[email protected]>"

This may be handy when creating an entire patch series and editing a cover letter, but it does mean that this has to be explicitly executed and get-developers cannot be used directly by the --cc-cmd option of git send-email to automatically CC affected developers.

So add an -e flag to only let get-developers print the email addresses of the affected developers in the one-email-per-line format expected by git send-email, similar to how get_maintainer.pl works in the Linux kernel.

With this and a suitable git configuration:

git config sendemail.to buildroot at buildroot.org git config sendemail.ccCmd "$(pwd)/utils/get-developers -e"

You can simply do:

git send-email master

To automatically mail the buildroot list and CC affected developers on patches.

Signed-off-by Peter Korsgaard <[email protected]>
---
 utils/get-developers | 16 +++++++++++-----
 1 file changed, 11 insertions(+), 5 deletions(-)
utils/get-developers +11 -5
index f525ff2226..9135b41662 100755
@@ -18,6 +18,8 @@ def parse_args():
                         help='find developers in charge of these files')
     parser.add_argument('-c', dest='check', action='store_const',
                         const=True, help='list files not handled by any developer')
+    parser.add_argument('-e', dest='email', action='store_const',
+                        const=True, help='only list affected developer email addresses')
     return parser.parse_args()
 
 

@@ -90,12 +92,16 @@ def __main__():
                 if i in dev.infras:
                     matching_devs.add(dev.name)
 
-        result = "--to buildroot at buildroot.org"
-        for dev in matching_devs:
-            result += " --cc \"%s\"" % dev
+        if args.email:
+            for dev in matching_devs:
+                print dev
+        else:
+            result = "--to buildroot at buildroot.org"
+            for dev in matching_devs:
+                result += " --cc \"%s\"" % dev
 
-        if result != "":
-            print("git send-email %s" % result)
+            if result != "":
+                print("git send-email %s" % result)
 
 
 __main__()
Signature · 1 line
2.11.0
#1 lore raw

PATCH 1/1 utils/get-developers: add -e flag to only list email addresses for git send-email

Hello,

Quoted 20 lines · Peter Korsgaard

When called with a list of patches, get-developers prints the entire git send-email invocation line:

./utils/get-developers 0001-git-security-bump-to-version-2.16.5.patch
git send-email --to buildroot at buildroot.org --cc "Matt Weber <[email protected]>"

This may be handy when creating an entire patch series and editing a cover letter, but it does mean that this has to be explicitly executed and get-developers cannot be used directly by the --cc-cmd option of git send-email to automatically CC affected developers.

So add an -e flag to only let get-developers print the email addresses of the affected developers in the one-email-per-line format expected by git send-email, similar to how get_maintainer.pl works in the Linux kernel.

With this and a suitable git configuration:

git config sendemail.to buildroot at buildroot.org git config sendemail.ccCmd "$(pwd)/utils/get-developers -e"

Quoted 8 lines

You can simply do:

git send-email master

To automatically mail the buildroot list and CC affected developers on patches.

Signed-off-by Peter Korsgaard <[email protected]>
Acked-by Thomas Petazzoni <[email protected]>

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
Applied
#2 lore raw

PATCH 1/1 utils/get-developers: add -e flag to only list email addresses for git send-email

In reply to Peter Korsgaard

Hello,

Quoted 24 lines · Peter Korsgaard

When called with a list of patches, get-developers prints the entire git send-email invocation line:

./utils/get-developers 0001-git-security-bump-to-version-2.16.5.patch
git send-email --to buildroot at buildroot.org --cc "Matt Weber <[email protected]>"

This may be handy when creating an entire patch series and editing a cover letter, but it does mean that this has to be explicitly executed and get-developers cannot be used directly by the --cc-cmd option of git send-email to automatically CC affected developers.

So add an -e flag to only let get-developers print the email addresses of the affected developers in the one-email-per-line format expected by git send-email, similar to how get_maintainer.pl works in the Linux kernel.

With this and a suitable git configuration:

git config sendemail.to buildroot at buildroot.org git config sendemail.ccCmd "$(pwd)/utils/get-developers -e"

You can simply do:

git send-email master

Quoted 7 lines

To automatically mail the buildroot list and CC affected developers on patches.

Signed-off-by Peter Korsgaard <[email protected]>
---
 utils/get-developers | 16 +++++++++++-----
 1 file changed, 11 insertions(+), 5 deletions(-)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#3 lore raw

PATCH 1/1 utils/get-developers: add -e flag to only list email addresses for git send-email

In reply to Peter Korsgaard

Hi Peter,

On 8/10/18 09:43, Peter Korsgaard wrote:
[snip]

Quoted 11 lines

With this and a suitable git configuration:

git config sendemail.to buildroot at buildroot.org git config sendemail.ccCmd "$(pwd)/utils/get-developers -e"

You can simply do:

git send-email master

To automatically mail the buildroot list and CC affected developers on patches.

Could you add this fragment to docs/manual/contribute.txt as well?

Regards,
Arnout

Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
author
#4 lore raw

PATCH 1/1 utils/get-developers: add -e flag to only list email addresses for git send-email

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Arnout" == Arnout Vandecappelle <[email protected]> writes:

Hi,

Quoted 4 lines
Quoted 2 lines

To automatically mail the buildroot list and CC affected developers on patches.

Could you add this fragment to docs/manual/contribute.txt as well?

Sure:

https://patchwork.ozlabs.org/patch/981092/

Signature · 1 line
Bye, Peter Korsgaard
author
#5 lore raw

PATCH 1/1 utils/get-developers: add -e flag to only list email addresses for git send-email

In reply to Peter Korsgaard
Quoted 22 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Peter" == Peter Korsgaard <[email protected]> writes:

When called with a list of patches, get-developers prints the entire git send-email invocation line:

./utils/get-developers 0001-git-security-bump-to-version-2.16.5.patch
git send-email --to buildroot at buildroot.org --cc "Matt Weber <[email protected]>"

This may be handy when creating an entire patch series and editing a cover letter, but it does mean that this has to be explicitly executed and get-developers cannot be used directly by the --cc-cmd option of git send-email to automatically CC affected developers.

So add an -e flag to only let get-developers print the email addresses of the affected developers in the one-email-per-line format expected by git send-email, similar to how get_maintainer.pl works in the Linux kernel.

With this and a suitable git configuration:

git config sendemail.to buildroot at buildroot.org git config sendemail.ccCmd "$(pwd)/utils/get-developers -e"

Quoted 8 lines

You can simply do:

git send-email master

To automatically mail the buildroot list and CC affected developers on patches.

Signed-off-by Peter Korsgaard <[email protected]>

Committed to 2018.02.x and 2018.08.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard