Skip to contentSkip to conversation

staging: erofs: adds a space around '*'

PATCH In review Daeseok Youn 2 participants 3 messages Oct 8, 2018 – Oct 9, 2018 Staging

lore
Share & tools
lore

Daeseok Youn

author
#0 lore raw

PATCH 1/1 staging: erofs: adds a space around '*'

fix checkpatch.pl error:
ERROR: need consistent spacing around '*' (ctx:WxV)
+ memcpy(vin + PAGE_SIZE *i, t, PAGE_SIZE);

Signed-off-by Daeseok Youn <daeseok.youn at gmail.com>
---
 drivers/staging/erofs/unzip_vle_lz4.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/erofs/unzip_vle_lz4.c +1 -1
index f5b665f..501cfe0 100644
@@ -181,7 +181,7 @@ int z_erofs_vle_unzip_vmap(struct page **compressed_pages,
 		for (i = 0; i < clusterpages; ++i) {
 			void *t = kmap_atomic(compressed_pages[i]);
 
-			memcpy(vin + PAGE_SIZE *i, t, PAGE_SIZE);
+			memcpy(vin + PAGE_SIZE * i, t, PAGE_SIZE);
 			kunmap_atomic(t);
 		}
 	} else if (clusterpages == 1)
Signature · 1 line
2.7.4
#1 lore raw

Hi,

Quoted 15 lines · Daeseok Youn

fix checkpatch.pl error:
ERROR: need consistent spacing around '*' (ctx:WxV)
+ memcpy(vin + PAGE_SIZE *i, t, PAGE_SIZE);

Signed-off-by Daeseok Youn <daeseok.youn at gmail.com>
---
 drivers/staging/erofs/unzip_vle_lz4.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/erofs/unzip_vle_lz4.c +0 -0
index f5b665f..501cfe0 100644

drivers/staging/erofs/unzip_vle_lz4.c int z_erofs_vle_unzip_vmap(struct page **compressed_pages, · line 187

Quoted 8 lines
drivers/staging/erofs/unzip_vle_lz4.c +1 -1
@@ -181,7 +181,7 @@ int z_erofs_vle_unzip_vmap(struct page **compressed_pages,
 		for (i = 0; i < clusterpages; ++i) {
 			void *t = kmap_atomic(compressed_pages[i]);
 
-			memcpy(vin + PAGE_SIZE *i, t, PAGE_SIZE);
+			memcpy(vin + PAGE_SIZE * i, t, PAGE_SIZE);
 			kunmap_atomic(t);
 		}
 	} else if (clusterpages == 1)

This exact fix was applied to linux-next some days ago:

commit ea0b2d429bd82ec152d286a0c026ebcaa4154ccc

Make sure you are working from linux-next rather than from mainline.

See this link: https://www.kernel.org/doc/man-pages/linux-next.html

Thanks
--
Gustavo

author
#2 lore raw

2018? 10? 8? (?) ?? 9:37, Gustavo A. R. Silva <gustavo at embeddedor.com>?? ??:

Quoted 21 lines

Hi,

Quoted 17 lines · Daeseok Youn

fix checkpatch.pl error:
ERROR: need consistent spacing around '*' (ctx:WxV)
+ memcpy(vin + PAGE_SIZE *i, t, PAGE_SIZE);

Signed-off-by Daeseok Youn <daeseok.youn at gmail.com>
---
 drivers/staging/erofs/unzip_vle_lz4.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/erofs/unzip_vle_lz4.c +0 -0
index f5b665f..501cfe0 100644
@@ -181,7 +181,7 @@ int z_erofs_vle_unzip_vmap(struct page **compressed_pages,
              for (i = 0; i < clusterpages; ++i) {
                      void *t = kmap_atomic(compressed_pages[i]);
Quoted 7 lines

drivers/staging/erofs/unzip_vle_lz4.c int z_erofs_vle_unzip_vmap(struct page **compressed_pages, · line 187

Quoted 6 lines
drivers/staging/erofs/unzip_vle_lz4.c +1 -1
-                     memcpy(vin + PAGE_SIZE *i, t, PAGE_SIZE);
+                     memcpy(vin + PAGE_SIZE * i, t, PAGE_SIZE);
                      kunmap_atomic(t);
              }
      } else if (clusterpages == 1)

Hi Gustavo,

Thanks for letting me know the patch.

Quoted 3 lines

This exact fix was applied to linux-next some days ago:

commit ea0b2d429bd82ec152d286a0c026ebcaa4154ccc

yes, you're right.

Quoted 2 lines

Make sure you are working from linux-next rather than from mainline.

I got the linux kernel source from the staging-next tree than linux-next. I knew that the patches related to staging should be merged into staging-tree first. But I didn't update the source tree to get latest.

Quoted 3 lines

See this link: https://www.kernel.org/doc/man-pages/linux-next.html

Thanks.
Regards,
Daeseok Youn.

Quoted 3 lines

Thanks
--
Gustavo