Skip to contentSkip to conversation

isdn/gigaset/isocdata: mark expected switch fall-through

PATCH Applied Gustavo A. R. Silva 2 participants 2 messages Oct 8, 2018

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 isdn/gigaset/isocdata: mark expected switch fall-through

Notice that in this particular case, I replaced the "--v-- fall through --v--" comment with a proper "fall through", which is what GCC is expecting to find.

This fix is part of the ongoing efforts to enabling -Wimplicit-fallthrough

---
 drivers/isdn/gigaset/isocdata.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/isdn/gigaset/isocdata.c +1 -1
index 97e00118..f9264ba 100644
@@ -906,7 +906,7 @@ static void cmd_loop(unsigned char *src, int numbytes, struct inbuf_t *inbuf)
 				cs->respdata[0] = 0;
 				break;
 			}
-			/* --v-- fall through --v-- */
+			/* fall through */
 		case '\r':
 			/* end of message line, pass to response handler */
 			if (cbytes >= MAX_RESP_SIZE) {
Signature · 1 line
2.7.4
maintainer Applied
#1 lore raw

From: "Gustavo A. R. Silva" <[email protected]>
Date: Mon, 8 Oct 2018 14:15:39 +0200

Quoted 9 lines

Notice that in this particular case, I replaced the "--v-- fall through --v--" comment with a proper "fall through", which is what GCC is expecting to find.

This fix is part of the ongoing efforts to enabling -Wimplicit-fallthrough

Applied to net-next.