Skip to contentSkip to conversation

rtnetlink: Update comment in rtnl_stats_dump regarding strict data checking

PATCH Applied David Ahern 2 participants 2 messages Oct 9, 2018 – Oct 11, 2018

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

David Ahern

author
#0 lore raw

PATCH 1/1 rtnetlink: Update comment in rtnl_stats_dump regarding strict data checking

From: David Ahern <[email protected]>

The NLM_F_DUMP_PROPER_HDR netlink flag was replaced by a setsockopt. Update the comment in rtnl_stats_dump.

Fixes 841891ec0c65 ("rtnetlink: Update rtnl_stats_dump for strict data checking")
Reported-by Christian Brauner <[email protected]>
Signed-off-by David Ahern <[email protected]>
---
 net/core/rtnetlink.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
net/core/rtnetlink.c +2 -2
index c894c4af8981..6406e26171ff 100644
@@ -4775,8 +4775,8 @@ static int rtnl_stats_dump(struct sk_buff *skb, struct netlink_callback *cb)
 
 	ifsm = nlmsg_data(cb->nlh);
 
-	/* only requests using NLM_F_DUMP_PROPER_HDR can pass data to
-	 * influence the dump. The legacy exception is filter_mask.
+	/* only requests using strict checks can pass data to influence
+	 * the dump. The legacy exception is filter_mask.
 	 */
 	if (cb->strict_check) {
 		if (ifsm->pad1 || ifsm->pad2 || ifsm->ifindex) {
Signature · 1 line
2.11.0