Skip to contentSkip to conversation

perl-sys-cpu fixes

PATCH New Christopher McCrory 2 participants 5 messages Sep 27, 2018 – Oct 8, 2018

lore
Share & tools
lore

Christopher McCrory

author
#0 lore raw

cover perl-sys-cpu fixes

The second patch has
- #include <sys/unistd.h>
because it is redundant with glibc, and doesn't exist with musl and uclib. Does anyone know if it is needed on other platforms?

Christopher McCrory (2):
perl-sys-cpu: disable static builds
perl-sys-cpu: remove extraneous include

 package/perl-sys-cpu/0001-remove-extraneous-include.patch | 10 ++++++++++
 package/perl-sys-cpu/Config.in                            |  4 ++++
 2 files changed, 14 insertions(+)
 create mode 100644 package/perl-sys-cpu/0001-remove-extraneous-include.patch
Signature · 1 line
2.14.4
author
#1 lore raw

PATCH 1/2 perl-sys-cpu: disable static builds

Disable static builds like other perl modules
fixes autobuild failures

Signed-off-by Christopher McCrory <[email protected]>
---
 package/perl-sys-cpu/Config.in | 4 ++++
 1 file changed, 4 insertions(+)
package/perl-sys-cpu/Config.in +4 -0
index a604945740..8306b371dc 100644
@@ -1,5 +1,9 @@
 config BR2_PACKAGE_PERL_SYS_CPU
 	bool "perl-sys-cpu"
+	depends on !BR2_STATIC_LIBS
 	help
 	  Perl module for getting information about the system CPU
 	  (Sys::CPU).
+
+comment "perl-sys-cpu needs a toolchain w/ dynamic library"
+	depends on BR2_STATIC_LIBS
Signature · 1 line
2.14.4
#2 lore raw

PATCH 1/2 perl-sys-cpu: disable static builds

Hello,

Quoted 7 lines · Christopher McCrory

Disable static builds like other perl modules
fixes autobuild failures

Signed-off-by Christopher McCrory <[email protected]>
---
 package/perl-sys-cpu/Config.in | 4 ++++
 1 file changed, 4 insertions(+)

Your commit log was missing a reference to the autobuilder failure being fixed. I've added that and applied.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
author
#3 lore raw

PATCH 2/2 perl-sys-cpu: remove extraneous include

In reply to Christopher McCrory

remove extraneous include <sys/unistd.h>
in glibc this points back to include unistd.h
neither musl, nor uclib have it.

Signed-off-by Christopher McCrory <[email protected]>
---
 package/perl-sys-cpu/0001-remove-extraneous-include.patch | 10 ++++++++++
 1 file changed, 10 insertions(+)
 create mode 100644 package/perl-sys-cpu/0001-remove-extraneous-include.patch
package/perl-sys-cpu/0001-remove-extraneous-include.patch new file +10 -0
new file mode 100644
index 0000000000..2ef11a0226
@@ -0,0 +1,10 @@
+--- perl-sys-cpu-0.52/CPU.xs.orig	2018-09-18 10:23:48.473223024 -0700
++++ perl-sys-cpu-0.52/CPU.xs	2018-09-18 10:24:40.973670159 -0700
+@@ -24,7 +24,6 @@
+  #include <winreg.h>
+ #else                /* other (try unix) */
+  #include <unistd.h>
+- #include <sys/unistd.h>
+ #endif
+ #if defined(__sun) || defined(__sun__) 
+  #include <sys/processor.h>
Signature · 1 line
2.14.4
#4 lore raw

PATCH 2/2 perl-sys-cpu: remove extraneous include

Hello,

Quoted 5 lines · Christopher McCrory

remove extraneous include <sys/unistd.h>
in glibc this points back to include unistd.h
neither musl, nor uclib have it.

Signed-off-by Christopher McCrory <[email protected]>

The patch below was missing a description, and the commit log was lacking a reference to the autobuilder failure being fixed. I've fixed both issues, and applied. Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com