Skip to contentSkip to conversation

failsafe: use prefix for set_burst_fn

PATCH Applied Stephen Hemminger 3 participants 3 messages Oct 8, 2018 – Oct 9, 2018 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 failsafe: use prefix for set_burst_fn

All other visible functions in failsafe driver have 'failsafe_' prefix.

---
 drivers/net/failsafe/failsafe_ether.c   | 2 +-
 drivers/net/failsafe/failsafe_private.h | 4 ++--
 drivers/net/failsafe/failsafe_rxtx.c    | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)
drivers/net/failsafe/failsafe_ether.c +1 -1
index 51c96f78ba71..b0376c931c63 100644
@@ -571,7 +571,7 @@ failsafe_eth_rmv_event_callback(uint16_t port_id __rte_unused,
 	/* Switch as soon as possible tx_dev. */
 	fs_switch_dev(sdev->fs_dev, sdev);
 	/* Use safe bursts in any case. */
-	set_burst_fn(sdev->fs_dev, 1);
+	failsafe_set_burst_fn(sdev->fs_dev, 1);
 	/*
 	 * Async removal, the sub-PMD will try to unregister
 	 * the callback at the source of the current thread context.
drivers/net/failsafe/failsafe_private.h +2 -2
index abbe73e872fa..7845c68fed16 100644
@@ -190,7 +190,7 @@ int failsafe_hotplug_alarm_cancel(struct rte_eth_dev *dev);
 
 /* RX / TX */
 
-void set_burst_fn(struct rte_eth_dev *dev, int force_safe);
+void failsafe_set_burst_fn(struct rte_eth_dev *dev, int force_safe);
 
 uint16_t failsafe_rx_burst(void *rxq,
 		struct rte_mbuf **rx_pkts, uint16_t nb_pkts);
@@ -470,7 +470,7 @@ fs_switch_dev(struct rte_eth_dev *dev,
 	} else {
 		return;
 	}
-	set_burst_fn(dev, 0);
+	failsafe_set_burst_fn(dev, 0);
 	rte_wmb();
 }
 
drivers/net/failsafe/failsafe_rxtx.c +1 -1
index 7bd0f963e5da..034f47b87f83 100644
@@ -29,7 +29,7 @@ fs_tx_unsafe(struct sub_device *sdev)
 }
 
 void
-set_burst_fn(struct rte_eth_dev *dev, int force_safe)
+failsafe_set_burst_fn(struct rte_eth_dev *dev, int force_safe)
 {
 	struct sub_device *sdev;
 	uint8_t i;
Signature · 1 line
2.19.1
Acked-by on v1 1/1
#1 lore raw
Quoted 4 lines · Stephen Hemminger

All other visible functions in failsafe driver have 'failsafe_' prefix.

Quoted 6 lines
---
 drivers/net/failsafe/failsafe_ether.c   | 2 +-
 drivers/net/failsafe/failsafe_private.h | 4 ++--
 drivers/net/failsafe/failsafe_rxtx.c    | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)
Signature · 2 lines
Gaëtan Rivet
6WIND