Skip to contentSkip to conversation

xen/pvh: increase early stack size

PATCH In review Roger Pau Monne 2 participants 5 messages Oct 9, 2018 – Oct 10, 2018

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xen/pvh: increase early stack size

While booting on an AMD EPYC box the stack canary would detect stack overflows when using the current PVH early stack size (256). Switch to using the value defined by BOOT_STACK_SIZE, which prevents the stack overflow.

---
Cc: Boris Ostrovsky <[email protected]>
Cc: Juergen Gross <[email protected]>
Cc: [email protected]

---
 arch/x86/xen/xen-pvh.S | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/xen/xen-pvh.S +1 -1
index ca2d3b2bf2af..58722a052f9c 100644
@@ -181,7 +181,7 @@ canary:
 	.fill 48, 1, 0
 
 early_stack:
-	.fill 256, 1, 0
+	.fill BOOT_STACK_SIZE, 1, 0
 early_stack_end:
 
 	ELFNOTE(Xen, XEN_ELFNOTE_PHYS32_ENTRY,
Signature · 1 line
2.19.0
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · Roger Pau Monne

While booting on an AMD EPYC box the stack canary would detect stack overflows when using the current PVH early stack size (256). Switch to using the value defined by BOOT_STACK_SIZE, which prevents the stack overflow.

I'll add a "Cc: stable" when committing.

Juergen

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

maintainer Reviewed-by on v1 1/1
#2 lore raw
In reply to Roger Pau Monne
Quoted 6 lines · Roger Pau Monne

While booting on an AMD EPYC box the stack canary would detect stack overflows when using the current PVH early stack size (256). Switch to using the value defined by BOOT_STACK_SIZE, which prevents the stack overflow.

I'll add a "Cc: stable" when committing.

Juergen

maintainer
#3 lore raw
In reply to Roger Pau Monne
Quoted 6 lines · Roger Pau Monne

While booting on an AMD EPYC box the stack canary would detect stack overflows when using the current PVH early stack size (256). Switch to using the value defined by BOOT_STACK_SIZE, which prevents the stack overflow.

Committed to xen.tip for-linus-4.20

Juergen

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

maintainer
#4 lore raw
In reply to Roger Pau Monne
Quoted 6 lines · Roger Pau Monne

While booting on an AMD EPYC box the stack canary would detect stack overflows when using the current PVH early stack size (256). Switch to using the value defined by BOOT_STACK_SIZE, which prevents the stack overflow.

Committed to xen.tip for-linus-4.20

Juergen