EDAC, dsm_edac: Wrap ACPI DSM methods for address translation
Luck, Tony
maintainerPATCH 4/5 EDAC, dsm_edac: Wrap ACPI DSM methods for address translation
Quoted 25 lines · Rafael J. Wysocki
Well, it looks reasonable, one question though (below).
Quoted 8 lines
drivers/acpi/Kconfig +0
-0@@ -498,6 +498,16 @@ config ACPI_EXTLOG driver adds support for that functionality with corresponding tracepoint which carries that information to userspace.drivers/acpi/Kconfig config ACPI_EXTLOG · line 510
Quoted 10 lines
drivers/acpi/Kconfig +10
-0+config ACPI_ADXL + bool "Physical address to DIMM address translation" + def_bool n + help + Enable interface that calls into BIOS using a DSM (device + specific method) to convert system physical addresses + to DIMM (socket, channel, rank, dimm, etc.). + Only available on some servers. + Used by newer EDAC drivers. +I wonder if the extra config option is really needed. I guess it is useful for the "tinification" people, but then can it simply depend on something else we already have?
Quoted 1 line
Distros will set it to "Y" anyway.
I was planning on having the EDAC driver(s) that need this do a
select ACPI_ADXL
That way the tinification people are happy, and distros that include EDAC will set it without any other changes.
Quoted 4 lines
drivers/acpi/Kconfig config ACPI_EXTLOG · line 511
Quoted 1 line
drivers/acpi/Kconfig +1
-0+#define ACPI_ADXL_PATH "\\_SB.ADXL"It would be good to add a comment to say where the ADXL object is defined.
Can you expand on what you want here? My naive ACPI knowledge thought that "\\_SB.ADXL" was a "pathname" saying that the ADXL device is part of the "SB" (is that System Board?).
Are you asking which platforms include this?
Qiuxu has tested this. So I can re-post to linux-acpi for any other comments from the community.
Procedure question. If you like this, can you "Ack" it and let Boris take it through his tree. The changes to the Skylake EDAC driver are dependent on this, so we need to have the commits apply in the right order.
Thanks
-Tony