Skip to contentSkip to conversation

hwmon: (npcm-750-pwm-fan): Change initial pwm target to 255

PATCH In review Kun Yi 2 participants 3 messages Oct 8, 2018 – Oct 10, 2018

Subsystems (2)
Hardware monitoring Arm/nuvoton npcm architecture
lore
Share & tools
lore

Kun Yi

author
#0 lore raw

PATCH 1/1 hwmon: (npcm-750-pwm-fan): Change initial pwm target to 255

Change initial PWM target to 255 to prevent overheating, for example when BMC hangs in userspace or when userspace fan control application is not implemented yet.

Signed-off-by Kun Yi <[email protected]>
---
 drivers/hwmon/npcm750-pwm-fan.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/hwmon/npcm750-pwm-fan.c +1 -1
index 96634fd54e0b..c0fab54c0094 100644
@@ -52,7 +52,7 @@
 
 /* Define the Counter Register, value = 100 for match 100% */
 #define NPCM7XX_PWM_COUNTER_DEFAULT_NUM		255
-#define NPCM7XX_PWM_CMR_DEFAULT_NUM		127
+#define NPCM7XX_PWM_CMR_DEFAULT_NUM		255
 #define NPCM7XX_PWM_CMR_MAX			255
 
 /* default all PWM channels PRESCALE2 = 1 */
Signature · 1 line
2.19.0.605.g01d371f741-goog
maintainer
#1 lore raw
Quoted 5 lines · Kun Yi

Change initial PWM target to 255 to prevent overheating, for example when BMC hangs in userspace or when userspace fan control application is not implemented yet.

Signed-off-by Kun Yi <[email protected]>

Makes sense to me, and in line with other drivers. Applied to hwmon-next.

Thanks,
Guenter

Quoted 17 lines
---
 drivers/hwmon/npcm750-pwm-fan.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/hwmon/npcm750-pwm-fan.c +1 -1
index 96634fd54e0b..c0fab54c0094 100644
@@ -52,7 +52,7 @@
 
 /* Define the Counter Register, value = 100 for match 100% */
 #define NPCM7XX_PWM_COUNTER_DEFAULT_NUM		255
-#define NPCM7XX_PWM_CMR_DEFAULT_NUM		127
+#define NPCM7XX_PWM_CMR_DEFAULT_NUM		255
 #define NPCM7XX_PWM_CMR_MAX			255
 
 /* default all PWM channels PRESCALE2 = 1 */
author
#2 lore raw

Great, thanks!

Quoted 30 lines · Guenter Roeck
Quoted 5 lines · Kun Yi

Change initial PWM target to 255 to prevent overheating, for example when BMC hangs in userspace or when userspace fan control application is not implemented yet.

Signed-off-by Kun Yi <[email protected]>

Makes sense to me, and in line with other drivers. Applied to hwmon-next.

Thanks,
Guenter

Quoted 17 lines
---
 drivers/hwmon/npcm750-pwm-fan.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/hwmon/npcm750-pwm-fan.c +1 -1
index 96634fd54e0b..c0fab54c0094 100644
@@ -52,7 +52,7 @@
 
 /* Define the Counter Register, value = 100 for match 100% */
 #define NPCM7XX_PWM_COUNTER_DEFAULT_NUM              255
-#define NPCM7XX_PWM_CMR_DEFAULT_NUM          127
+#define NPCM7XX_PWM_CMR_DEFAULT_NUM          255
 #define NPCM7XX_PWM_CMR_MAX                  255
 
 /* default all PWM channels PRESCALE2 = 1 */
Signature · 2 lines
Regards,
Kun