Skip to contentSkip to conversation

pigpio: depends on BR2_TOOLCHAIN_HAS_THREADS

PATCH New Grzegorz Blach 2 participants 3 messages Oct 11, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pigpio: depends on BR2_TOOLCHAIN_HAS_THREADS

piogpio needs pthreads

---
 package/pigpio/Config.in | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
package/pigpio/Config.in +3 -2
index fee496b2ef..2180ab0de6 100644
@@ -1,6 +1,7 @@
 config BR2_PACKAGE_PIGPIO
 	bool "pigpio"
 	depends on BR2_aarch64 || BR2_arm
+	depends on BR2_TOOLCHAIN_HAS_THREADS
 	depends on !BR2_STATIC_LIBS
 	help
 	  Pigpio is a library for the Raspberry Pi which allows
@@ -8,6 +9,6 @@ config BR2_PACKAGE_PIGPIO
 
 	  http://abyz.me.uk/rpi/pigpio/
 
-comment "pigpio needs a toolchain w/ dynamic library"
+comment "pigpio needs a toolchain w/ threads, dynamic library"
 	depends on BR2_aarch64 || BR2_arm
-	depends on !BR2_STATIC_LIBS
+	depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS
Signature · 1 line
2.17.2
#1 lore raw

PATCH 1/1 pigpio: depends on BR2_TOOLCHAIN_HAS_THREADS

Hello,

Quoted 6 lines · Grzegorz Blach

piogpio needs pthreads

---
 package/pigpio/Config.in | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Thanks for your patch. When a patch fixes a build issue detected by the autobuilders, we always add a reference to the autobuilder failure in the commit log, like this:

"""
Fixes:

http://autobuild.buildroot.net/results/2f64c993db402decf92a5f8010033acdbc6b884f/
"""

I've fixed the commit log with this additional information before applying, but I wanted to let you know for your future contributions!

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH 1/1 pigpio: depends on BR2_TOOLCHAIN_HAS_THREADS

Quoted 14 lines · Thomas Petazzoni

Hello,

Quoted 6 lines · Grzegorz Blach

piogpio needs pthreads

---
  package/pigpio/Config.in | 5 +++--
  1 file changed, 3 insertions(+), 2 deletions(-)

Thanks for your patch. When a patch fixes a build issue detected by the autobuilders, we always add a reference to the autobuilder failure in the commit log, like this:

Quoted 9 lines

"""
Fixes:

   http://autobuild.buildroot.net/results/2f64c993db402decf92a5f8010033acdbc6b884f/

"""

I've fixed the commit log with this additional information before applying, but I wanted to let you know for your future contributions!

Ok, I'll remember that.

Quoted 4 lines

Thanks,

Thomas