FAILED: patch "[PATCH] mm: treat indirectly reclaimable memory as free in overcommit" failed to apply to 4.16-stable tree
Subsystems (3)
[email protected]
maintainerThe patch below does not apply to the 4.16-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.
thanks,
greg k-h
------------------ original commit in Linus's tree ------------------
Quoted 1 line
From
d79f7aa496fc94d763f67b833a1f36f4c171176fMon Sep 17 00:00:00 2001
From: Roman Gushchin <[email protected]>
Date: Tue, 10 Apr 2018 16:27:47 -0700
Subject: [PATCH] mm: treat indirectly reclaimable memory as free in overcommit
logic
Indirectly reclaimable memory can consume a significant part of total memory and it's actually reclaimable (it will be released under actual memory pressure).
So, the overcommit logic should treat it as free.
Otherwise, it's possible to cause random system-wide memory allocation failures by consuming a significant amount of memory by indirectly reclaimable memory, e.g. dentry external names.
If overcommit policy GUESS is used, it might be used for denial of service attack under some conditions.
The following program illustrates the approach. It causes the kernel to allocate an unreclaimable kmalloc-256 chunk for each stat() call, so that at some point the overcommit logic may start blocking large allocation system-wide.
int main()
{
char buf[256];
unsigned long i;
struct stat statbuf;
buf[0] = '/';
for (i = 1; i < sizeof(buf); i++)
buf[i] = '_';
for (i = 0; 1; i++) {
sprintf(&buf[248], "%8lu", i);
stat(buf, &statbuf);
}
return 0;
}This patch in combination with related indirectly reclaimable memory patches closes this issue.
mm/util.c +7 -0
@@ -667,6 +667,13 @@ int __vm_enough_memory(struct mm_struct *mm, long pages, int cap_sys_admin)*/ free +=global_node_page_state (NR_SLAB_RECLAIMABLE ); +/* +* Part of the kernel memory, which can be released +* under memory pressure. +*/ + free +=global_node_page_state ( +NR_INDIRECTLY_RECLAIMABLE_BYTES ) >>PAGE_SHIFT ; +/* * Leave reserved pages. The pages are not for anonymous pages. */
Quoted 9 lines · On Sat, May 12, 2018 at 03:35:59PM +0200, [email protected] wrote:
The patch below does not apply to the 4.16-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.thanks,
greg k-h
Hi, Greg!
This patch is a part of the following patchset:7aaf77272358 mm: don't show nr_indirectly_reclaimable in /proc/vmstat d79f7aa496fc mm: treat indirectly reclaimable memory as free in overcommit logic f1782c9bc547 dcache: account external names as indirectly reclaimable memory 034ebf65c3c2 mm: treat indirectly reclaimable memory as available in MemAvailable eb59254608bc mm: introduce NR_INDIRECTLY_RECLAIMABLE_BYTES
It should be backported as a whole. It applies cleanly on 4.16-stable, and with a minor trivial adjustment to 4.14-stable.
Thank you!
Roman
Greg KH
maintainerQuoted 20 lines · Roman Gushchin
Quoted 9 lines · On Sat, May 12, 2018 at 03:35:59PM +0200, [email protected] wrote:
The patch below does not apply to the 4.16-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.thanks,
greg k-h
Hi, Greg!
This patch is a part of the following patchset:
7aaf77272358mm: don't shownr_indirectly_reclaimablein/proc/vmstatd79f7aa496fcmm: treat indirectly reclaimable memory as free in overcommit logicf1782c9bc547dcache: account external names as indirectly reclaimable memory034ebf65c3c2mm: treat indirectly reclaimable memory as available in MemAvailableeb59254608bcmm: introduceNR_INDIRECTLY_RECLAIMABLE_BYTES
Quoted 2 lines
It should be backported as a whole. It applies cleanly on 4.16-stable, and with a minor trivial adjustment to 4.14-stable.
Sorry for the long delay, digging out of my stable backlog...
Anyway, is this still needed for 4.14-stable?
thanks,
greg k-h
Quoted 21 lines · Greg KH
Quoted 20 lines · Roman Gushchin
Quoted 9 lines · On Sat, May 12, 2018 at 03:35:59PM +0200, [email protected] wrote:
The patch below does not apply to the 4.16-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.thanks,
greg k-h
Hi, Greg!
This patch is a part of the following patchset:
7aaf77272358mm: don't shownr_indirectly_reclaimablein/proc/vmstatd79f7aa496fcmm: treat indirectly reclaimable memory as free in overcommit logicf1782c9bc547dcache: account external names as indirectly reclaimable memory034ebf65c3c2mm: treat indirectly reclaimable memory as available in MemAvailableeb59254608bcmm: introduceNR_INDIRECTLY_RECLAIMABLE_BYTES
Quoted 6 lines
Quoted 2 lines
It should be backported as a whole. It applies cleanly on 4.16-stable, and with a minor trivial adjustment to 4.14-stable.
Sorry for the long delay, digging out of my stable backlog...
Anyway, is this still needed for 4.14-stable?
There is a security issue, which these patches are closing. It allows to cause a system-wide memory allocation failure, if overcommit logic is enabled and it's possible to create negative dentries (e.g. asking httpd for non-existing files). The issue is very old and exists in most stable branches, so Idk how bad is to leave it open in 4.14.
Anyway, please, let me know if I can help somehow.
Thanks!
Greg KH
maintainerQuoted 27 lines · Roman Gushchin
Quoted 26 lines · Greg KH
Quoted 20 lines · Roman Gushchin
Quoted 9 lines · On Sat, May 12, 2018 at 03:35:59PM +0200, [email protected] wrote:
The patch below does not apply to the 4.16-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.thanks,
greg k-h
Hi, Greg!
This patch is a part of the following patchset:
7aaf77272358mm: don't shownr_indirectly_reclaimablein/proc/vmstatd79f7aa496fcmm: treat indirectly reclaimable memory as free in overcommit logicf1782c9bc547dcache: account external names as indirectly reclaimable memory034ebf65c3c2mm: treat indirectly reclaimable memory as available in MemAvailableeb59254608bcmm: introduceNR_INDIRECTLY_RECLAIMABLE_BYTESQuoted 2 lines
It should be backported as a whole. It applies cleanly on 4.16-stable, and with a minor trivial adjustment to 4.14-stable.
Sorry for the long delay, digging out of my stable backlog...
Quoted 8 lines
Quoted 1 line
Anyway, is this still needed for 4.14-stable?
There is a security issue, which these patches are closing. It allows to cause a system-wide memory allocation failure, if overcommit logic is enabled and it's possible to create negative dentries (e.g. asking httpd for non-existing files). The issue is very old and exists in most stable branches, so Idk how bad is to leave it open in 4.14.
Anyway, please, let me know if I can help somehow.
Ok, all now queued up, let's see how it goes :)
thanks,
greg k-h