Skip to contentSkip to conversation

xerces: fix buid with older cmake

PATCH New Fabrice Fontaine 2 participants 2 messages Oct 11, 2018

lore
Share & tools
lore

Fabrice Fontaine

author
#0 lore raw

PATCH 1/1 xerces: fix buid with older cmake

Old version of cmake break cross-compilation when FindThreads is used because of a try_run call. Add a workaround that avoids try_run.

cmake bug report: https://gitlab.kitware.com/cmake/cmake/issues/16920

Fixes:
- http://autobuild.buildroot.org/results/784918c58310474e8b4a0b42850a55ba35a1a19e

Signed-off-by Fabrice Fontaine <[email protected]>
---
 package/xerces/xerces.mk | 5 +++++
 1 file changed, 5 insertions(+)
package/xerces/xerces.mk +5 -0
index 906e4b663c..c75a8b0d35 100644
@@ -17,6 +17,11 @@ endef
 
 XERCES_POST_PATCH_HOOKS += XERCES_DISABLE_SAMPLES
 
+# Before CMake 3.10, passing THREADS_PTHREAD_ARG=OFF was needed to
+# disable a try_run() call in the FindThreads tests, which caused a
+# build failure when cross-compiling.
+XERCES_CONF_OPTS += -DTHREADS_PTHREAD_ARG=OFF
+
 ifeq ($(BR2_PACKAGE_ICU),y)
 XERCES_DEPENDENCIES += icu
 endif
Signature · 1 line
2.17.1
Applied
#1 lore raw

PATCH 1/1 xerces: fix buid with older cmake

Hello,

Quoted 5 lines · Fabrice Fontaine

Old version of cmake break cross-compilation when FindThreads is used because of a try_run call. Add a workaround that avoids try_run.

cmake bug report: https://gitlab.kitware.com/cmake/cmake/issues/16920

Quoted 7 lines

Fixes:
- http://autobuild.buildroot.org/results/784918c58310474e8b4a0b42850a55ba35a1a19e

Signed-off-by Fabrice Fontaine <[email protected]>
---
 package/xerces/xerces.mk | 5 +++++
 1 file changed, 5 insertions(+)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com