Skip to contentSkip to conversation

leftover INIT_DEBUG stuff

PATCH In review Stephen Hemminger 2 participants 6 messages Oct 12, 2018 – Oct 15, 2018 Network drivers

lore
Share & tools
lore

Stephen Hemminger

author
#0 lore raw

cover leftover INIT_DEBUG stuff

Was looking around and found some leftover references to old INIT_DEBUG configurations.

Stephen Hemminger (3):
doc: remove INIT_DEBUG from ena
doc: liquidio remove documentation for old config options
qede: remove #ifdef for INIT_DEBUG

 doc/guides/nics/ena.rst        | 4 ----
 doc/guides/nics/liquidio.rst   | 8 --------
 drivers/net/qede/qede_ethdev.c | 9 +--------
 3 files changed, 1 insertion(+), 20 deletions(-)
Signature · 1 line
2.19.1
author
#1 lore raw

PATCH 1/3 doc: remove INIT_DEBUG from ena

The ena driver has used dynamic log type to enable init debugging since 18.05 but the documentation still has leftover mention of the config option.

Signed-off-by Stephen Hemminger <[email protected]>
---
 doc/guides/nics/ena.rst | 4 ----
 1 file changed, 4 deletions(-)
doc/guides/nics/ena.rst +0 -4
index 695960d4c9f8..34c48575bf71 100644
@@ -113,10 +113,6 @@ Configuration information
    * **CONFIG_RTE_LIBRTE_ENA_PMD** (default y): Enables or disables inclusion
      of the ENA PMD driver in the DPDK compilation.
 
-
-   * **CONFIG_RTE_LIBRTE_ENA_DEBUG_INIT** (default y): Enables or disables debug
-     logging of device initialization within the ENA PMD driver.
-
    * **CONFIG_RTE_LIBRTE_ENA_DEBUG_RX** (default n): Enables or disables debug
      logging of RX logic within the ENA PMD driver.
Signature · 1 line
2.19.1
author
#2 lore raw

PATCH 2/3 doc: liquidio remove documentation for old config options

In reply to Stephen Hemminger

The config options for init and debug driver were replaced by dynamic log levels.

Signed-off-by Stephen Hemminger <[email protected]>
---
 doc/guides/nics/liquidio.rst | 8 --------
 1 file changed, 8 deletions(-)
doc/guides/nics/liquidio.rst +0 -8
index 87b42cdc4835..e2a38004d0d6 100644
@@ -30,14 +30,6 @@ Please note that enabling debugging options may affect system performance.
 
   Toggle compilation of LiquidIO PMD.
 
-- ``CONFIG_RTE_LIBRTE_LIO_DEBUG_DRIVER`` (default ``n``)
-
-  Toggle display of generic debugging messages.
-
-- ``CONFIG_RTE_LIBRTE_LIO_DEBUG_INIT`` (default ``n``)
-
-  Toggle display of initialization related messages.
-
 - ``CONFIG_RTE_LIBRTE_LIO_DEBUG_RX`` (default ``n``)
 
   Toggle display of receive fast path run-time messages.
Signature · 1 line
2.19.1
author
#3 lore raw

PATCH 3/3 qede: remove #ifdef for INIT_DEBUG

In reply to Stephen Hemminger

Now that logging of initialization is controlled by dynamic debug level, remove the #ifdef for RTE_LIBRTE_QEDE_DEBUG_INIT since that config option does not exist in common_base and is not documented.

Signed-off-by Stephen Hemminger <[email protected]>
---
 drivers/net/qede/qede_ethdev.c | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)
drivers/net/qede/qede_ethdev.c +1 -8
index 18d244a9367c..5745832b98a3 100644
@@ -1380,14 +1380,11 @@ qede_link_update(struct rte_eth_dev *eth_dev, __rte_unused int wait_to_complete)
 
 static void qede_promiscuous_enable(struct rte_eth_dev *eth_dev)
 {
-#ifdef RTE_LIBRTE_QEDE_DEBUG_INIT
 	struct qede_dev *qdev = eth_dev->data->dev_private;
 	struct ecore_dev *edev = &qdev->edev;
+	enum qed_filter_rx_mode_type type = QED_FILTER_RX_MODE_TYPE_PROMISC;
 
 	PMD_INIT_FUNC_TRACE(edev);
-#endif
-
-	enum qed_filter_rx_mode_type type = QED_FILTER_RX_MODE_TYPE_PROMISC;
 
 	if (rte_eth_allmulticast_get(eth_dev->data->port_id) == 1)
 		type |= QED_FILTER_RX_MODE_TYPE_MULTI_PROMISC;

@@ -1397,12 +1394,10 @@ static void qede_promiscuous_enable(struct rte_eth_dev *eth_dev)
 
 static void qede_promiscuous_disable(struct rte_eth_dev *eth_dev)
 {
-#ifdef RTE_LIBRTE_QEDE_DEBUG_INIT
 	struct qede_dev *qdev = eth_dev->data->dev_private;
 	struct ecore_dev *edev = &qdev->edev;
 
 	PMD_INIT_FUNC_TRACE(edev);
-#endif
 
 	if (rte_eth_allmulticast_get(eth_dev->data->port_id) == 1)
 		qed_configure_filter_rx_mode(eth_dev,

@@ -2648,12 +2643,10 @@ static int qede_eth_dev_init(struct rte_eth_dev *eth_dev)
 
 static int qede_dev_common_uninit(struct rte_eth_dev *eth_dev)
 {
-#ifdef RTE_LIBRTE_QEDE_DEBUG_INIT
 	struct qede_dev *qdev = eth_dev->data->dev_private;
 	struct ecore_dev *edev = &qdev->edev;
 
 	PMD_INIT_FUNC_TRACE(edev);
-#endif
 
 	/* only uninitialize in the primary process */
 	if (rte_eal_process_type() != RTE_PROC_PRIMARY)
Signature · 1 line
2.19.1
Reviewed-by on the v1 series
#4 lore raw
In reply to Stephen Hemminger
Quoted 7 lines · Stephen Hemminger

Was looking around and found some leftover references to old INIT_DEBUG configurations.

Stephen Hemminger (3):
doc: remove INIT_DEBUG from ena
doc: liquidio remove documentation for old config options
qede: remove #ifdef for INIT_DEBUG

For series,

Reviewed-by Ferruh Yigit <[email protected]>
#5 lore raw
Quoted 11 lines · Ferruh Yigit
Quoted 7 lines · Stephen Hemminger

Was looking around and found some leftover references to old INIT_DEBUG configurations.

Stephen Hemminger (3):
doc: remove INIT_DEBUG from ena
doc: liquidio remove documentation for old config options
qede: remove #ifdef for INIT_DEBUG

For series,

Reviewed-by Ferruh Yigit <[email protected]>

Series applied to dpdk-next-net/master, thanks.