Skip to contentSkip to conversation

drm/msm/gpu: Fix a couple memory leaks in debugfs

PATCH New Dan Carpenter 1 participant 1 message Oct 13, 2018

Subsystems (4)
DRM drivers Arm Qualcomm mailing list Kernel janitors DRM driver for Qualcomm display hardware
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 drm/msm/gpu: Fix a couple memory leaks in debugfs

The msm_gpu_open() function should free "show_priv" on error or it causes static checker warnings.

Fixes 4f776f4511c7 ("drm/msm/gpu: Convert the GPU show function to use the GPU state")
Signed-off-by Dan Carpenter <[email protected]>
---
 drivers/gpu/drm/msm/msm_debugfs.c | 15 +++++++++++----
 1 file changed, 11 insertions(+), 4 deletions(-)
drivers/gpu/drm/msm/msm_debugfs.c +11 -4
index f0da0d3c8a80..d756436c1fcd 100644
@@ -84,7 +84,7 @@ static int msm_gpu_open(struct inode *inode, struct file *file)
 
 	ret = mutex_lock_interruptible(&dev->struct_mutex);
 	if (ret)
-		return ret;
+		goto free_priv;
 
 	pm_runtime_get_sync(&gpu->pdev->dev);
 	show_priv->state = gpu->funcs->gpu_state_get(gpu);

@@ -94,13 +94,20 @@ static int msm_gpu_open(struct inode *inode, struct file *file)
 
 	if (IS_ERR(show_priv->state)) {
 		ret = PTR_ERR(show_priv->state);
-		kfree(show_priv);
-		return ret;
+		goto free_priv;
 	}
 
 	show_priv->dev = dev;
 
-	return single_open(file, msm_gpu_show, show_priv);
+	ret = single_open(file, msm_gpu_show, show_priv);
+	if (ret)
+		goto free_priv;
+
+	return 0;
+
+free_priv:
+	kfree(show_priv);
+	return ret;
 }
 
 static const struct file_operations msm_gpu_fops = {
Signature · 6 lines
2.18.0

_______________________________________________
Freedreno mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/freedreno