Skip to contentSkip to conversation

doc: rcu: Fix code listing in performance and scalability requirements

PATCH In review Joel Fernandes (Google) 2 participants 2 messages Oct 15, 2018

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 doc: rcu: Fix code listing in performance and scalability requirements

The code listing under this section has a quick quiz that says line 19 uses rcu_access_pointer, but the code listing itself does not. Fix this.

---
 .../RCU/Design/Requirements/Requirements.html    |  2 +-
 kernel/sys.c                                     | 16 ++++++++++++++++
 2 files changed, 17 insertions(+), 1 deletion(-)
Documentation/RCU/Design/Requirements/Requirements.html +1 -1
index 4fae55056c1d..f74a2233865c 100644
@@ -1596,7 +1596,7 @@ used in place of <tt>synchronize_rcu()</tt> as follows:
 16   struct foo *p;
 17
 18   spin_lock(&amp;gp_lock);
-19   p = rcu_dereference(gp);
+19   p = rcu_access_pointer(gp);
 20   if (!p) {
 21     spin_unlock(&amp;gp_lock);
 22     return false;
Signature · 1 line
2.19.0.605.g01d371f741-goog
#1 lore raw
Quoted 4 lines · Joel Fernandes (Google)

The code listing under this section has a quick quiz that says line 19 uses rcu_access_pointer, but the code listing itself does not. Fix this.

Good eyes! Queued for the merge window after this coming one, thank you!

Thanx, Paul

Quoted 21 lines
---
 .../RCU/Design/Requirements/Requirements.html    |  2 +-
 kernel/sys.c                                     | 16 ++++++++++++++++
 2 files changed, 17 insertions(+), 1 deletion(-)
Documentation/RCU/Design/Requirements/Requirements.html +1 -1
index 4fae55056c1d..f74a2233865c 100644
@@ -1596,7 +1596,7 @@ used in place of <tt>synchronize_rcu()</tt> as follows:
 16   struct foo *p;
 17
 18   spin_lock(&amp;gp_lock);
-19   p = rcu_dereference(gp);
+19   p = rcu_access_pointer(gp);
 20   if (!p) {
 21     spin_unlock(&amp;gp_lock);
 22     return false;
Signature · 1 line
2.19.0.605.g01d371f741-goog