xfs_scrub: lack of kernel support is not a service failure
PATCH 1/1 xfs_scrub: lack of kernel support is not a service failure
From: Darrick J. Wong <[email protected]>
Don't treat a lack of kernel support for scrubbing as an automated service failure because we have not actually determined that there's anything wrong with the filesystem.
Signed-off-by Darrick J. Wong <[email protected]>
--- scrub/xfs_scrub.c | 6 ++++++ 1 file changed, 6 insertions(+)
scrub/xfs_scrub.c +6 -0
@@ -779,9 +779,15 @@ main(* for capturing all the log messages if the scrub fails, because the * fail service uses the service name to gather log messages for the * error report. +* +* Note: We don't count a lack of kernel support as a service failure +* because we haven't determined that there's anything wrong with the +* filesystem. */ if (is_service) {sleep (2 ); +if (!ctx.scrub_setup_succeeded) +return 0 ;if (ret !=SCRUB_RET_SUCCESS )return 1 ; }
Quoted 7 lines · Darrick J. Wong
From: Darrick J. Wong <[email protected]>
Don't treat a lack of kernel support for scrubbing as an automated service failure because we have not actually determined that there's anything wrong with the filesystem.
Signed-off-by Darrick J. Wong <[email protected]>
makes sense to me
Reviewed-by Eric Sandeen <[email protected]>
Quoted 25 lines
--- scrub/xfs_scrub.c | 6 ++++++ 1 file changed, 6 insertions(+)scrub/xfs_scrub.c +6
-0@@ -779,9 +779,15 @@ main(* for capturing all the log messages if the scrub fails, because the * fail service uses the service name to gather log messages for the * error report. +* +* Note: We don't count a lack of kernel support as a service failure +* because we haven't determined that there's anything wrong with the +* filesystem. */ if (is_service) {sleep (2 ); +if (!ctx.scrub_setup_succeeded) +return 0 ;if (ret !=SCRUB_RET_SUCCESS )return 1 ; }