Skip to contentSkip to conversation

dt-bindings: misc: bk4: Add device tree binding for Liebherr's BK4 SPI bus

PATCH Applied Lukasz Majewski 4 participants 8 messages Sep 27, 2018 – Oct 15, 2018 Device tree bindings

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dt-bindings: misc: bk4: Add device tree binding for Liebherr's BK4 SPI bus

Add Device Tree binding document for Liebherr's BK4 external SPI bus.

---
 Documentation/devicetree/bindings/misc/lwn-bk4.txt | 26 ++++++++++++++++++++++
 1 file changed, 26 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/misc/lwn-bk4.txt
Documentation/devicetree/bindings/misc/lwn-bk4.txt new file +26 -0
new file mode 100644
index 000000000000..d6a8c188c087
@@ -0,0 +1,26 @@
+* Liebherr's BK4 controller external SPI
+
+A device which handles data acquisition from compatible industrial
+peripherals.
+The SPI is used for data and management purposes in both master and
+slave modes.
+
+Required properties:
+
+- compatible : Should be "lwn,bk4"
+
+Required SPI properties:
+
+- reg : Should be address of the device chip select within
+  the controller.
+
+- spi-max-frequency : Maximum SPI clocking speed of device in Hz, should be
+  30MHz at most for the Liebherr's BK4 external bus.
+
+Example:
+
+spidev0: spi@0 {
+	compatible = "lwn,bk4";
+	spi-max-frequency = <30000000>;
+	reg = <0>;
+};
Signature · 1 line
2.11.0
#1 lore raw

Dear All,

Quoted 2 lines

Add Device Tree binding document for Liebherr's BK4 external SPI bus.

Gentle ping...

Quoted 30 lines
---
 Documentation/devicetree/bindings/misc/lwn-bk4.txt | 26
++++++++++++++++++++++ 1 file changed, 26 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/misc/lwn-bk4.txt
(quoted diff) +0 -0

b/Documentation/devicetree/bindings/misc/lwn-bk4.txt new file mode 100644 index 000000000000..d6a8c188c087

Documentation/devicetree/bindings/misc/lwn-bk4.txt new file +17 -0
@@ -0,0 +1,26 @@
+* Liebherr's BK4 controller external SPI
+
+A device which handles data acquisition from compatible industrial
+peripherals.
+The SPI is used for data and management purposes in both master and
+slave modes.
+
+Required properties:
+
+- compatible : Should be "lwn,bk4"
+
+Required SPI properties:
+
+- reg : Should be address of the device chip select within
+  the controller.
+
+- spi-max-frequency : Maximum SPI clocking speed of device in Hz,

should be

Documentation/devicetree/bindings/misc/lwn-bk4.txt line 26

Quoted 9 lines
Documentation/devicetree/bindings/misc/lwn-bk4.txt new file +9 -0
+  30MHz at most for the Liebherr's BK4 external bus.
+
+Example:
+
+spidev0: spi@0 {
+	compatible = "lwn,bk4";
+	spi-max-frequency = <30000000>;
+	reg = <0>;
+};

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [email protected]

#2 lore raw
In reply to Lukasz Majewski
Quoted 3 lines · Lukasz Majewski

Add Device Tree binding document for Liebherr's BK4 external SPI bus.

There should really be a patch series consisting of this one and spidev change [1].

Since spidev has already been picked up, having a series including this and dts change would be the second option. With DT folks' ACK, I can send bindings change together with DTS using it.

Shawn

[1] https://lkml.org/lkml/2018/9/28/48

Quoted 40 lines
---
 Documentation/devicetree/bindings/misc/lwn-bk4.txt | 26 ++++++++++++++++++++++
 1 file changed, 26 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/misc/lwn-bk4.txt
Documentation/devicetree/bindings/misc/lwn-bk4.txt new file +26 -0
new file mode 100644
index 000000000000..d6a8c188c087
@@ -0,0 +1,26 @@
+* Liebherr's BK4 controller external SPI
+
+A device which handles data acquisition from compatible industrial
+peripherals.
+The SPI is used for data and management purposes in both master and
+slave modes.
+
+Required properties:
+
+- compatible : Should be "lwn,bk4"
+
+Required SPI properties:
+
+- reg : Should be address of the device chip select within
+  the controller.
+
+- spi-max-frequency : Maximum SPI clocking speed of device in Hz, should be
+  30MHz at most for the Liebherr's BK4 external bus.
+
+Example:
+
+spidev0: spi@0 {
+	compatible = "lwn,bk4";
+	spi-max-frequency = <30000000>;
+	reg = <0>;
+};
Signature · 1 line
2.11.0
#3 lore raw

Hi Shawn,

Quoted 12 lines · Lukasz Majewski
Quoted 4 lines

Add Device Tree binding document for Liebherr's BK4 external SPI bus.

There should really be a patch series consisting of this one and spidev change [1].

Since spidev has already been picked up, having a series including this and dts change would be the second option. With DT folks' ACK, I can send bindings change together with DTS using it.

Any option will work for me :-).

Quoted 39 lines

Shawn

[1] https://lkml.org/lkml/2018/9/28/48

Quoted 34 lines
---
 Documentation/devicetree/bindings/misc/lwn-bk4.txt | 26
++++++++++++++++++++++ 1 file changed, 26 insertions(+)
 create mode 100644

Documentation/devicetree/bindings/misc/lwn-bk4.txt

(quoted diff) +0 -0

b/Documentation/devicetree/bindings/misc/lwn-bk4.txt new file mode 100644 index 000000000000..d6a8c188c087

Documentation/devicetree/bindings/misc/lwn-bk4.txt new file +17 -0
@@ -0,0 +1,26 @@
+* Liebherr's BK4 controller external SPI
+
+A device which handles data acquisition from compatible industrial
+peripherals.
+The SPI is used for data and management purposes in both master and
+slave modes.
+
+Required properties:
+
+- compatible : Should be "lwn,bk4"
+
+Required SPI properties:
+
+- reg : Should be address of the device chip select within
+  the controller.
+
+- spi-max-frequency : Maximum SPI clocking speed of device in Hz,

should be

Documentation/devicetree/bindings/misc/lwn-bk4.txt new file +4 -0
+  30MHz at most for the Liebherr's BK4 external bus.
+
+Example:
+
Quoted 8 lines
Quoted 8 lines
Documentation/devicetree/bindings/misc/lwn-bk4.txt new file +5 -0
+spidev0: spi@0 {
+	compatible = "lwn,bk4";
+	spi-max-frequency = <30000000>;
+	reg = <0>;
+};
Signature · 1 line
2.11.0

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [email protected]

#4 lore raw

Dear All,

Quoted 8 lines

Hi Shawn,

Quoted 6 lines · Lukasz Majewski
Quoted 4 lines

Add Device Tree binding document for Liebherr's BK4 external SPI bus.

Quoted 8 lines
Quoted 6 lines

There should really be a patch series consisting of this one and spidev change [1].

Since spidev has already been picked up, having a series including this and dts change would be the second option. With DT folks' ACK, I can send bindings change together with DTS using it.

Any option will work for me :-).

Gentle ping on this patch (as corresponding DTS file has been already pulled by Shawn).

Thanks in advance,

Quoted 52 lines
Quoted 40 lines

Shawn

[1] https://lkml.org/lkml/2018/9/28/48

Quoted 34 lines
---
 Documentation/devicetree/bindings/misc/lwn-bk4.txt | 26
++++++++++++++++++++++ 1 file changed, 26 insertions(+)
 create mode 100644

Documentation/devicetree/bindings/misc/lwn-bk4.txt

(quoted diff) +0 -0

b/Documentation/devicetree/bindings/misc/lwn-bk4.txt new file mode 100644 index 000000000000..d6a8c188c087

Documentation/devicetree/bindings/misc/lwn-bk4.txt new file +3 -0
@@ -0,0 +1,26 @@
+* Liebherr's BK4 controller external SPI
+
+A device which handles data acquisition from compatible

industrial +peripherals.
+The SPI is used for data and management purposes in both master and +slave modes.

Documentation/devicetree/bindings/misc/lwn-bk4.txt new file +11 -0
+
+Required properties:
+
+- compatible : Should be "lwn,bk4"
+
+Required SPI properties:
+
+- reg : Should be address of the device chip select within
+  the controller.
+
+- spi-max-frequency : Maximum SPI clocking speed of device in Hz,

should be

Documentation/devicetree/bindings/misc/lwn-bk4.txt new file +4 -0
+  30MHz at most for the Liebherr's BK4 external bus.
+
+Example:
+
Quoted 8 lines
Quoted 8 lines
Documentation/devicetree/bindings/misc/lwn-bk4.txt new file +5 -0
+spidev0: spi@0 {
+	compatible = "lwn,bk4";
+	spi-max-frequency = <30000000>;
+	reg = <0>;
+};
Signature · 1 line
2.11.0

Best regards,

Quoted 7 lines

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [email protected]

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [email protected]

#5 lore raw
Quoted 2 lines · Lukasz Majewski

Gentle ping on this patch (as corresponding DTS file has been already pulled by Shawn).

Please don't send content free pings and please allow a reasonable time for review. People get busy, go on holiday, attend conferences and so on so unless there is some reason for urgency (like critical bug fixes) please allow at least a couple of weeks for review. If there have been review comments then people may be waiting for those to be addressed.

Sending content free pings adds to the mail volume (if they are seen at all) which is often the problem and since they can't be reviewed directly if something has gone wrong you'll have to resend the patches anyway, so sending again is generally a better approach though there are some other maintainers who like them - if in doubt look at how patches for the subsystem are normally handled.

maintainer Applied
#6 lore raw
In reply to Lukasz Majewski
Quoted 7 lines · Lukasz Majewski

Add Device Tree binding document for Liebherr's BK4 external SPI bus.

---
 Documentation/devicetree/bindings/misc/lwn-bk4.txt | 26 ++++++++++++++++++++++
 1 file changed, 26 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/misc/lwn-bk4.txt

Applied.

To add to Mark's comments, the status of binding patches can be checked on patchwork[1]. There's no reason for pings to me. If it is in the "New" state, I will get to it and you can see where you are in the queue. ATM, I'm rather backed up.

Rob

[1] https://patchwork.ozlabs.org/project/devicetree-bindings/list/

#7 lore raw

Hi All,

Quoted 11 lines · Lukasz Majewski
Quoted 9 lines

Add Device Tree binding document for Liebherr's BK4 external SPI bus.

---
 Documentation/devicetree/bindings/misc/lwn-bk4.txt | 26
++++++++++++++++++++++ 1 file changed, 26 insertions(+)
 create mode 100644

Documentation/devicetree/bindings/misc/lwn-bk4.txt

Quoted 6 lines

Applied.

To add to Mark's comments, the status of binding patches can be checked on patchwork[1]. There's no reason for pings to me. If it is in the "New" state, I will get to it and you can see where you are in the queue. ATM, I'm rather backed up.

Thanks for explanation and the hint regarding patchwork usage.

Quoted 4 lines

Rob

[1] https://patchwork.ozlabs.org/project/devicetree-bindings/list/

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [email protected]