qt5location: copy PositioningQuick.so* for QtQuick
A message that is not in the archive (sent off-list or not yet received): 20181015190217.GA31890@blarch
PATCH 1/1 qt5location: copy PositioningQuick.so* for QtQuick
Hello Alexander,
Quoted 13 lines · On Mon, 15 Oct 2018 21:02:17 +0200, Alexander 'z33ky' Hirsch…
The Location module for QtQuick depends on this library, which was not being copied in the build rule.
Signed-off-by Alexander 'z33ky' Hirsch <[email protected]>--- package/qt5/qt5location/qt5location.mk | 4 ++++ 1 file changed, 4 insertions(+)package/qt5/qt5location/qt5location.mk +0
-0
package/qt5/qt5location/qt5location.mk define QT5LOCATION_INSTALL_TARGET_LOCATION · line 46
Quoted 3 lines
package/qt5/qt5location/qt5location.mk +0
-0@@ -44,6 +44,9 @@ define QT5LOCATION_INSTALL_TARGET_LOCATION cp -dpf $(STAGING_DIR)/usr/lib/libQt5Location.so.* $(TARGET_DIR)/usr/lib cp -dpfr $(STAGING_DIR)/usr/lib/qt/plugins/geoservices $(TARGET_DIR)/usr/lib/qt/plugins/ endef
Should depend on BR2_PACKAGE_QT5_VERSION_LATEST because the library is not build/installed in the Qt5.6.x case:
+ ifeq ($(BR2_PACKAGE_QT5_VERSION_LATEST),y)
package/qt5/qt5location/qt5location.mk define QT5LOCATION_INSTALL_TARGET_LOCATION · line 49
Quoted 3 lines
package/qt5/qt5location/qt5location.mk +3
-0+define QT5LOCATION_INSTALL_TARGET_POSITION_QUICK + cp -dpf $(STAGING_DIR)/usr/lib/libQt5PositioningQuick.so.* $(TARGET_DIR)/usr/lib +endef
+ endif
Thanks for the patch, mind to resend with the changes?
Regards,
Peter
Quoted 11 lines
package/qt5/qt5location/qt5location.mk +1
-0ifeq ($(BR2_PACKAGE_QT5BASE_EXAMPLES),y) define QT5LOCATION_INSTALL_TARGET_EXAMPLES cp -dpfr $(STAGING_DIR)/usr/lib/qt/examples/location $(TARGET_DIR)/usr/lib/qt/examples/@@ -59,6 +62,7 @@ endef define QT5LOCATION_INSTALL_TARGET_CMDS $(QT5LOCATION_INSTALL_TARGET_POSITION) + $(QT5LOCATION_INSTALL_TARGET_POSITION_QUICK) $(QT5LOCATION_INSTALL_TARGET_LOCATION) $(QT5LOCATION_INSTALL_TARGET_QMLS) $(QT5LOCATION_INSTALL_TARGET_EXAMPLES)
PATCH 1/1 qt5location: copy PositioningQuick.so* for QtQuick
Quoted 42 lines · Peter Seiderer
Hello Alexander,
Quoted 13 lines · On Mon, 15 Oct 2018 21:02:17 +0200, Alexander 'z33ky' Hirsch…
The Location module for QtQuick depends on this library, which was not being copied in the build rule.
Signed-off-by Alexander 'z33ky' Hirsch <[email protected]>--- package/qt5/qt5location/qt5location.mk | 4 ++++ 1 file changed, 4 insertions(+)package/qt5/qt5location/qt5location.mk +0
-0package/qt5/qt5location/qt5location.mk define QT5LOCATION_INSTALL_TARGET_LOCATION · line 46
Quoted 3 lines
package/qt5/qt5location/qt5location.mk +0
-0@@ -44,6 +44,9 @@ define QT5LOCATION_INSTALL_TARGET_LOCATION cp -dpf $(STAGING_DIR)/usr/lib/libQt5Location.so.* $(TARGET_DIR)/usr/lib cp -dpfr $(STAGING_DIR)/usr/lib/qt/plugins/geoservices $(TARGET_DIR)/usr/lib/qt/plugins/ endefShould depend on
BR2_PACKAGE_QT5_VERSION_LATESTbecause the library is not build/installed in the Qt5.6.x case:+ ifeq ($(BR2_PACKAGE_QT5_VERSION_LATEST),y)
package/qt5/qt5location/qt5location.mk define QT5LOCATION_INSTALL_TARGET_LOCATION · line 49
Quoted 3 lines
package/qt5/qt5location/qt5location.mk +3
-0+define QT5LOCATION_INSTALL_TARGET_POSITION_QUICK + cp -dpf $(STAGING_DIR)/usr/lib/libQt5PositioningQuick.so.* $(TARGET_DIR)/usr/lib +endef+ endif
Thanks for the patch, mind to resend with the changes?
Regards,
PeterQuoted 5 lines
package/qt5/qt5location/qt5location.mk +0
-0ifeq ($(BR2_PACKAGE_QT5BASE_EXAMPLES),y) define QT5LOCATION_INSTALL_TARGET_EXAMPLES cp -dpfr $(STAGING_DIR)/usr/lib/qt/examples/location $(TARGET_DIR)/usr/lib/qt/examples/@@ -59,6 +62,7 @@ endef
Quoted 7 lines
package/qt5/qt5location/qt5location.mk endef · line 68
Quoted 6 lines
package/qt5/qt5location/qt5location.mk +1
-0define QT5LOCATION_INSTALL_TARGET_CMDS $(QT5LOCATION_INSTALL_TARGET_POSITION) + $(QT5LOCATION_INSTALL_TARGET_POSITION_QUICK) $(QT5LOCATION_INSTALL_TARGET_LOCATION) $(QT5LOCATION_INSTALL_TARGET_QMLS) $(QT5LOCATION_INSTALL_TARGET_EXAMPLES)
Sure, thanks for the review.
Wouldn't it be better to check if QT5LOCATION_VERSION >= 5.11 though? That seems to be the version where this library was added.
Regards
Alexander
PATCH 1/1 qt5location: copy PositioningQuick.so* for QtQuick
Hello Alexander,
Quoted 51 lines · On Mon, 15 Oct 2018 23:22:20 +0200, Alexander 'z33ky' Hirsch…
Quoted 42 lines · Peter Seiderer
Hello Alexander,
Quoted 13 lines · On Mon, 15 Oct 2018 21:02:17 +0200, Alexander 'z33ky' Hirsch…
The Location module for QtQuick depends on this library, which was not being copied in the build rule.
Signed-off-by Alexander 'z33ky' Hirsch <[email protected]>--- package/qt5/qt5location/qt5location.mk | 4 ++++ 1 file changed, 4 insertions(+)package/qt5/qt5location/qt5location.mk +0
-0package/qt5/qt5location/qt5location.mk define QT5LOCATION_INSTALL_TARGET_LOCATION · line 46
Quoted 3 lines
package/qt5/qt5location/qt5location.mk +0
-0@@ -44,6 +44,9 @@ define QT5LOCATION_INSTALL_TARGET_LOCATION cp -dpf $(STAGING_DIR)/usr/lib/libQt5Location.so.* $(TARGET_DIR)/usr/lib cp -dpfr $(STAGING_DIR)/usr/lib/qt/plugins/geoservices $(TARGET_DIR)/usr/lib/qt/plugins/ endefShould depend on
BR2_PACKAGE_QT5_VERSION_LATESTbecause the library is not build/installed in the Qt5.6.x case:+ ifeq ($(BR2_PACKAGE_QT5_VERSION_LATEST),y)
package/qt5/qt5location/qt5location.mk define QT5LOCATION_INSTALL_TARGET_LOCATION · line 49
Quoted 3 lines
package/qt5/qt5location/qt5location.mk +3
-0+define QT5LOCATION_INSTALL_TARGET_POSITION_QUICK + cp -dpf $(STAGING_DIR)/usr/lib/libQt5PositioningQuick.so.* $(TARGET_DIR)/usr/lib +endef+ endif
Thanks for the patch, mind to resend with the changes?
Regards,
PeterQuoted 5 lines
package/qt5/qt5location/qt5location.mk +0
-0ifeq ($(BR2_PACKAGE_QT5BASE_EXAMPLES),y) define QT5LOCATION_INSTALL_TARGET_EXAMPLES cp -dpfr $(STAGING_DIR)/usr/lib/qt/examples/location $(TARGET_DIR)/usr/lib/qt/examples/@@ -59,6 +62,7 @@ endefQuoted 7 lines
package/qt5/qt5location/qt5location.mk endef · line 68
Quoted 6 lines
package/qt5/qt5location/qt5location.mk +1
-0define QT5LOCATION_INSTALL_TARGET_CMDS $(QT5LOCATION_INSTALL_TARGET_POSITION) + $(QT5LOCATION_INSTALL_TARGET_POSITION_QUICK) $(QT5LOCATION_INSTALL_TARGET_LOCATION) $(QT5LOCATION_INSTALL_TARGET_QMLS) $(QT5LOCATION_INSTALL_TARGET_EXAMPLES)
Quoted 2 lines
Sure, thanks for the review.
Wouldn't it be better to check ifQT5LOCATION_VERSION>= 5.11 though? That seems to be the version where this library was added.
In principle your are right with your suggestion, but the current way to express this one in buildroot is the dump BR2_PACKAGE_QT5_VERSION_LATEST check ;-)
Regards,
Peter
Quoted 7 lines
Regards
Alexander
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot