drm: Shift * to be adjacent to pointer name
Subsystems (2)
PATCH 1/1 drm: Shift * to be adjacent to pointer name
Shift * to be adjacent to pointer name to follow Linux coding style. Issue found with checkpatch.pl
ERROR: "foo * bar" should be "foo *bar"
--- drivers/gpu/drm/drm_memory.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/gpu/drm/drm_memory.c +5 -5
@@ -51,7 +51,7 @@#endif static void *agp_remap (unsigned long offset,unsigned long size, -struct drm_device * dev) +struct drm_device *dev) {unsigned long i, num_pages =PAGE_ALIGN (size) /PAGE_SIZE ;
@@ -94,26 +94,26 @@ static void *agp_remap(unsigned long offset, unsigned long size, }/** Wrapper around agp_free_memory() */ -void drm_free_agp (struct agp_memory * handle,int pages) +void drm_free_agp (struct agp_memory *handle,int pages) {agp_free_memory (handle); }/** Wrapper around agp_bind_memory() */ -int drm_bind_agp (struct agp_memory * handle,unsigned int start) +int drm_bind_agp (struct agp_memory *handle,unsigned int start) {return agp_bind_memory (handle, start); }/** Wrapper around agp_unbind_memory() */ -int drm_unbind_agp (struct agp_memory * handle) +int drm_unbind_agp (struct agp_memory *handle) {return agp_unbind_memory (handle); }#else /* CONFIG_AGP */ static inline void *agp_remap (unsigned long offset,unsigned long size, -struct drm_device * dev) +struct drm_device *dev) {return NULL ; }
Signature · 1 line
1.9.1
Quoted 3 lines · Mamta Shukla
Shift * to be adjacent to pointer name to follow Linux coding style. Issue found with checkpatch.pl
ERROR: "foo * bar" should be "foo *bar"
The patch looks OK, but at this point, you know how to send a patch, so it would be better to focus on changes that are more complex than whitespace issues.
julia
Quoted 60 lines
Signed-off-by Mamta Shukla <[email protected]>--- drivers/gpu/drm/drm_memory.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)drivers/gpu/drm/drm_memory.c +5
-6@@ -51,7 +51,7 @@#endif static void *agp_remap (unsigned long offset,unsigned long size, -struct drm_device * dev) +struct drm_device *dev) {unsigned long i, num_pages =PAGE_ALIGN (size) /PAGE_SIZE ;@@ -94,26 +94,26 @@ static void *agp_remap(unsigned long offset, unsigned long size, }/** Wrapper around agp_free_memory() */ -void drm_free_agp (struct agp_memory * handle,int pages) +void drm_free_agp (struct agp_memory *handle,int pages) {agp_free_memory (handle); }/** Wrapper around agp_bind_memory() */ -int drm_bind_agp (struct agp_memory * handle,unsigned int start) +int drm_bind_agp (struct agp_memory *handle,unsigned int start) {return agp_bind_memory (handle, start); }/** Wrapper around agp_unbind_memory() */ -int drm_unbind_agp (struct agp_memory * handle) +int drm_unbind_agp (struct agp_memory *handle) {return agp_unbind_memory (handle); }#else /* CONFIG_AGP */ static inline void *agp_remap (unsigned long offset,unsigned long size, -struct drm_device * dev) +struct drm_device *dev) {return NULL ; } --1.9.1
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20181015212644.GA28579%40armorer.
For more options, visit https://groups.google.com/d/optout.
Quoted 11 lines · Julia Lawall
Quoted 3 lines · Mamta Shukla
Shift * to be adjacent to pointer name to follow Linux coding style. Issue found with checkpatch.pl
ERROR: "foo * bar" should be "foo *bar"The patch looks OK, but at this point, you know how to send a patch, so it would be better to focus on changes that are more complex than whitespace issues.
Can't hurt to test-drive patch submission to a non-outreachy mailing list with something simple :-)
Thanks for your patch, applied to drm-misc-next (for 4.21/5.1 most likely).
-Daniel
Quoted 64 lines
julia
Quoted 60 lines
Signed-off-by Mamta Shukla <[email protected]>--- drivers/gpu/drm/drm_memory.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)drivers/gpu/drm/drm_memory.c +5
-6@@ -51,7 +51,7 @@#endif static void *agp_remap (unsigned long offset,unsigned long size, -struct drm_device * dev) +struct drm_device *dev) {unsigned long i, num_pages =PAGE_ALIGN (size) /PAGE_SIZE ;@@ -94,26 +94,26 @@ static void *agp_remap(unsigned long offset, unsigned long size, }/** Wrapper around agp_free_memory() */ -void drm_free_agp (struct agp_memory * handle,int pages) +void drm_free_agp (struct agp_memory *handle,int pages) {agp_free_memory (handle); }/** Wrapper around agp_bind_memory() */ -int drm_bind_agp (struct agp_memory * handle,unsigned int start) +int drm_bind_agp (struct agp_memory *handle,unsigned int start) {return agp_bind_memory (handle, start); }/** Wrapper around agp_unbind_memory() */ -int drm_unbind_agp (struct agp_memory * handle) +int drm_unbind_agp (struct agp_memory *handle) {return agp_unbind_memory (handle); }#else /* CONFIG_AGP */ static inline void *agp_remap (unsigned long offset,unsigned long size, -struct drm_device * dev) +struct drm_device *dev) {return NULL ; } --1.9.1
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20181015212644.GA28579%40armorer.
For more options, visit https://groups.google.com/d/optout.
Signature · 3 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch