perf segmentation fault from NULL dereference
Hi,
I am seeing this perf crash on my arm64-based system:
root at localhost:~# ./perf_debug_ record -e armv8_pmuv3_0/br_mis_pred/ sleep 1
perf: Segmentation fault
Obtained 9 stack frames.
./perf_debug_() [0x4c5ef8]
[0xffff82ba267c]
./perf_debug_() [0x4bc5a8]
./perf_debug_() [0x419550]
./perf_debug_() [0x41a928]
./perf_debug_() [0x472f58]
./perf_debug_() [0x473210]
./perf_debug_() [0x4070f4] /lib/aarch64-linux-gnu/libc.so.6(__libc_start_main+0xe0) [0xffff8294c8a0] Segmentation fault (core dumped)
I find 'cycles' event is fine.
I bisected the issue to here:
commit bfd8f72c2778f5bd63dc9eb6d23bd7a0d99cff6d (HEAD, refs/bisect/bad)
Author: Andi Kleen <[email protected]> Date: Fri Nov 17 13:42:58 2017 -0800
perf record: Synthesize unit/scale/... in event update
Move the code to synthesize event updates for scale/unit/cpus to a common utility file, and use it both from stat and record.
This allows to access scale and other extra qualifiers from perf
script.
Link:
http://lkml.kernel.org/r/20171117214300.32746-2-andi at firstfloor.org
I am suspicious that this is a real issue, as this patch has been in mainline for some time...
This simple change fixes the issue me:
tools/perf/util/header.c +0 -0
@@ -3576,7 +3576,7 @@ int perf_event__process_feature(struct perf_tool
*tool,
int max, err;
u16 type;- if (!evsel->own_cpus)
+ if (!evsel->own_cpus || !(evsel->attr.read_format &PERF_FORMAT_ID)) // roundabout check for !evsel->id
return 0;
ev = cpu_map_data__alloc(evsel->own_cpus, &size, &type, &max);It turns out that evsel->id is NULL on a call to perf_event__process_feature(), which upsets this code:
ev->header.type = PERF_RECORD_EVENT_UPDATE;
ev->header.size = (u16)size;
ev->type = PERF_EVENT_UPDATE__CPUS;
ev->id = evsel->id[0];Please me let me know if a valid issue so we can get a fix in.
Apologies for crying wolf if I'm off the mark.
Cheers,
John
Quoted 1 line
Please me let me know if a valid issue so we can get a fix in.
If it crashes it must be a valid issue of course.
But I'm not sure about your bisect. Hard to see how my patch could cause this. Sometimes bisects go wrong.
You verified by just reverting the patch?
First thing I would also try is to run with valgrind or ASan and see if it reports anything.
-Andi
Quoted 7 lines · Andi Kleen
Quoted 1 line
Please me let me know if a valid issue so we can get a fix in.
If it crashes it must be a valid issue of course.
But I'm not sure about your bisect. Hard to see how my patch could cause this. Sometimes bisects go wrong.
You verified by just reverting the patch?
It no longer reverts cleanly. And the previous patch - 4ca69ca9db3a - did not have this crash:
root at localhost:~# ./perf_debug_ record -e armv8_pmuv3_0/br_mis_pred/ sleep 1 [ perf record: Woken up 1 times to write data ]
[ perf record: Captured and wrote 0.001 MB perf.data (6 samples) ] root at localhost:~#
Quoted 3 lines
First thing I would also try is to run with valgrind or ASan and see if it reports anything.
Here's the valgrind output:
root at localhost:~#valgrind --leak-check=yes ./perf_debug_ record -e armv8_pmuv3_0/br_mis_pred/ sleep 1
==16025== Memcheck, a memory error detector
==16025== Copyright (C) 2002-2015, and GNU GPL'd, by Julian Seward et al. ==16025== Using Valgrind-3.11.0 and LibVEX; rerun with -h for copyright info ==16025== Command: ./perf_debug_ record -e armv8_pmuv3_0/br_mis_pred/ sleep 1
==16025==
--16025-- WARNING: unhandled arm64-linux syscall: 168
--16025-- You may be able to write your own handler.
--16025-- Read the file README_MISSING_SYSCALL_OR_IOCTL. --16025-- Nevertheless we consider this a bug. Please report --16025-- it at http://valgrind.org/support/bug_reports.html.
--16025-- WARNING: unhandled arm64-linux syscall: 241
--16025-- You may be able to write your own handler.
--16025-- Read the file README_MISSING_SYSCALL_OR_IOCTL. --16025-- Nevertheless we consider this a bug. Please report --16025-- it at http://valgrind.org/support/bug_reports.html.perf_event_open(..., PERF_FLAG_FD_CLOEXEC) failed with unexpected error 38 (Function not implemented)
--16025-- WARNING: unhandled arm64-linux syscall: 241
--16025-- You may be able to write your own handler.
--16025-- Read the file README_MISSING_SYSCALL_OR_IOCTL. --16025-- Nevertheless we consider this a bug. Please report --16025-- it at http://valgrind.org/support/bug_reports.html.perf_event_open(..., 0) failed unexpectedly with error 38 (Function not implemented)
--16025-- WARNING: unhandled arm64-linux syscall: 241
--16025-- You may be able to write your own handler.
--16025-- Read the file README_MISSING_SYSCALL_OR_IOCTL. --16025-- Nevertheless we consider this a bug. Please report --16025-- it at http://valgrind.org/support/bug_reports.html.
--16025-- WARNING: unhandled arm64-linux syscall: 241
--16025-- You may be able to write your own handler.
--16025-- Read the file README_MISSING_SYSCALL_OR_IOCTL. --16025-- Nevertheless we consider this a bug. Please report --16025-- it at http://valgrind.org/support/bug_reports.html.
--16025-- WARNING: unhandled arm64-linux syscall: 241
--16025-- You may be able to write your own handler.
--16025-- Read the file README_MISSING_SYSCALL_OR_IOCTL. --16025-- Nevertheless we consider this a bug. Please report --16025-- it at http://valgrind.org/support/bug_reports.html.
--16025-- WARNING: unhandled arm64-linux syscall: 241
--16025-- You may be able to write your own handler.
--16025-- Read the file README_MISSING_SYSCALL_OR_IOCTL. --16025-- Nevertheless we consider this a bug. Please report --16025-- it at http://valgrind.org/support/bug_reports.html.
Error:
The sys_perf_event_open() syscall returned with 38 (Function not implemented) for event (armv8_pmuv3_0/br_mis_pred/)./bin/dmesg | grep -i perf may provide additional information.
==16059==
==16059== Process terminating with default action of signal 15 (SIGTERM)
==16059== at 0x486F974: __read_nocancel (syscall-template.S:84) ==16059== by 0x48D02F: read (unistd.h:44) ==16059== by 0x48D02F: perf_evlist__prepare_workload (evlist.c:1471) ==16059== by 0x41AB0F: __cmd_record (builtin-record.c:898) ==16059== by 0x41AB0F: cmd_record (builtin-record.c:1873) ==16059== by 0x476C7F: run_builtin (perf.c:302) ==16059== by 0x476F37: handle_internal_command (perf.c:354) ==16059== by 0x407093: run_argv (perf.c:398) ==16059== by 0x407093: main (perf.c:520)
==16059==
==16059== HEAP SUMMARY:
==16059== in use at exit: 56,239 bytes in 226 blocks
==16059== total heap usage: 1,164 allocs, 938 frees, 2,238,979 bytes
allocated
==16059==
==16059== 12 bytes in 1 blocks are definitely lost in loss record 1 of 6
==16059== at 0x4844B88: malloc (in/usr/lib/valgrind/vgpreload_memcheck-arm64-linux.so)
==16059==
==16059== 344 bytes in 5 blocks are possibly lost in loss record 3 of 6
==16059== at 0x4846CFC: calloc (in/usr/lib/valgrind/vgpreload_memcheck-arm64-linux.so)
==16059==
==16059== 5,736 bytes in 125 blocks are possibly lost in loss record 4 of 6
==16059== at 0x4844B88: malloc (in/usr/lib/valgrind/vgpreload_memcheck-arm64-linux.so)
==16059==
==16059== LEAK SUMMARY:
==16059== definitely lost: 12 bytes in 1 blocks
==16059== indirectly lost: 0 bytes in 0 blocks
==16059== possibly lost: 6,080 bytes in 130 blocks
==16059== still reachable: 50,147 bytes in 95 blocks
==16059== suppressed: 0 bytes in 0 blocks
==16059== Reachable blocks (those to which a pointer was found) are not shown.
==16059== To see them, rerun with: --leak-check=full --show-leak-kinds=all ==16059==
==16059== For counts of detected and suppressed errors, rerun with: -v ==16059== ERROR SUMMARY: 3 errors from 3 contexts (suppressed: 0 from 0) ==16025== Warning: invalid file descriptor -1 in syscall close() ==16025== Warning: invalid file descriptor -1 in syscall close() ==16025== Warning: invalid file descriptor -1 in syscall close() ==16025== Warning: invalid file descriptor -1 in syscall close() ==16025== Warning: invalid file descriptor -1 in syscall close() ==16025== Warning: invalid file descriptor -1 in syscall close() ==16025== Warning: invalid file descriptor -1 in syscall close() ==16025== Warning: invalid file descriptor -1 in syscall close() ==16025== Warning: invalid file descriptor -1 in syscall close() ==16025== Warning: invalid file descriptor -1 in syscall close() ==16025== Warning: invalid file descriptor -1 in syscall close() ==16025== Warning: invalid file descriptor -1 in syscall close() ==16025== Warning: invalid file descriptor -1 in syscall close() ==16025== Warning: invalid file descriptor -1 in syscall close() ==16025== Warning: invalid file descriptor -1 in syscall close() ==16025== Warning: invalid file descriptor -1 in syscall close() ==16025== Warning: invalid file descriptor -1 in syscall close() ==16025== Warning: invalid file descriptor -1 in syscall close() ==16025== Warning: invalid file descriptor -1 in syscall close() ==16025== Warning: invalid file descriptor -1 in syscall close() ==16025== Warning: invalid file descriptor -1 in syscall close() ==16025== Warning: invalid file descriptor -1 in syscall close() ==16025== Warning: invalid file descriptor -1 in syscall close() ==16025== Warning: invalid file descriptor -1 in syscall close() ==16025== Warning: invalid file descriptor -1 in syscall close() ==16025== Warning: invalid file descriptor -1 in syscall close() ==16025== Warning: invalid file descriptor -1 in syscall close() ==16025== Warning: invalid file descriptor -1 in syscall close() ==16025== Warning: invalid file descriptor -1 in syscall close() ==16025== Warning: invalid file descriptor -1 in syscall close() ==16025== Warning: invalid file descriptor -1 in syscall close() ==16025== Warning: invalid file descriptor -1 in syscall close() ==16025== Warning: invalid file descriptor -1 in syscall close() ==16025== Warning: invalid file descriptor -1 in syscall close() ==16025== Warning: invalid file descriptor -1 in syscall close() ==16025== Warning: invalid file descriptor -1 in syscall close() ==16025== Warning: invalid file descriptor -1 in syscall close() ==16025== Warning: invalid file descriptor -1 in syscall close() ==16025== Warning: invalid file descriptor -1 in syscall close() ==16025== Warning: invalid file descriptor -1 in syscall close() ==16025== Warning: invalid file descriptor -1 in syscall close() ==16025== Warning: invalid file descriptor -1 in syscall close() ==16025== Warning: invalid file descriptor -1 in syscall close() ==16025== Warning: invalid file descriptor -1 in syscall close() ==16025== Warning: invalid file descriptor -1 in syscall close() ==16025== Warning: invalid file descriptor -1 in syscall close() ==16025== Warning: invalid file descriptor -1 in syscall close() ==16025== Warning: invalid file descriptor -1 in syscall close() ==16025== Warning: invalid file descriptor -1 in syscall close() ==16025== Warning: invalid file descriptor -1 in syscall close() ==16025== Warning: invalid file descriptor -1 in syscall close() ==16025== Warning: invalid file descriptor -1 in syscall close() ==16025== Warning: invalid file descriptor -1 in syscall close() ==16025== Warning: invalid file descriptor -1 in syscall close() ==16025== Warning: invalid file descriptor -1 in syscall close() ==16025== Warning: invalid file descriptor -1 in syscall close() ==16025== Warning: invalid file descriptor -1 in syscall close() ==16025== Warning: invalid file descriptor -1 in syscall close() ==16025== Warning: invalid file descriptor -1 in syscall close() ==16025== Warning: invalid file descriptor -1 in syscall close() ==16025== Warning: invalid file descriptor -1 in syscall close() ==16025== Warning: invalid file descriptor -1 in syscall close() ==16025== Warning: invalid file descriptor -1 in syscall close() ==16025== Warning: invalid file descriptor -1 in syscall close() ==16025==
==16025== HEAP SUMMARY:
==16025== in use at exit: 26,640 bytes in 209 blocks
==16025== total heap usage: 1,202 allocs, 993 frees, 2,455,112 bytes
allocated
==16025==
==16025== 328 bytes in 7 blocks are definitely lost in loss record 2 of 6
==16025== at 0x4844B88: malloc (in/usr/lib/valgrind/vgpreload_memcheck-arm64-linux.so)
==16025==
==16025== 344 bytes in 5 blocks are possibly lost in loss record 3 of 6
==16025== at 0x4846CFC: calloc (in/usr/lib/valgrind/vgpreload_memcheck-arm64-linux.so)
==16025==
==16025== 6,000 bytes in 126 blocks are possibly lost in loss record 5 of 6
==16025== at 0x4844B88: malloc (in/usr/lib/valgrind/vgpreload_memcheck-arm64-linux.so)
==16025==
==16025== LEAK SUMMARY:
==16025== definitely lost: 328 bytes in 7 blocks
==16025== indirectly lost: 0 bytes in 0 blocks
==16025== possibly lost: 6,344 bytes in 131 blocks
==16025== still reachable: 19,968 bytes in 71 blocks
==16025== suppressed: 0 bytes in 0 blocks
==16025== Reachable blocks (those to which a pointer was found) are not shown.
==16025== To see them, rerun with: --leak-check=full --show-leak-kinds=all ==16025==
==16025== For counts of detected and suppressed errors, rerun with: -v ==16025== ERROR SUMMARY: 3 errors from 3 contexts (suppressed: 0 from 0) root at localhost:~#
(pretty much the same as previous patch)
Cheers,
John
Quoted 5 lines
-Andi
.
Quoted 61 lines · John Garry
Hi,
I am seeing this perf crash on my arm64-based system:
root at localhost:~# ./perf_debug_ record -e armv8_pmuv3_0/br_mis_pred/ sleep 1
perf: Segmentation fault
Obtained 9 stack frames.
./perf_debug_() [0x4c5ef8]
[0xffff82ba267c]
./perf_debug_() [0x4bc5a8]
./perf_debug_() [0x419550]
./perf_debug_() [0x41a928]
./perf_debug_() [0x472f58]
./perf_debug_() [0x473210]
./perf_debug_() [0x4070f4] /lib/aarch64-linux-gnu/libc.so.6(__libc_start_main+0xe0) [0xffff8294c8a0] Segmentation fault (core dumped)I find 'cycles' event is fine.
I bisected the issue to here:
commitbfd8f72c2778f5bd63dc9eb6d23bd7a0d99cff6d(HEAD, refs/bisect/bad)Author: Andi Kleen <[email protected]> Date: Fri Nov 17 13:42:58 2017 -0800perf record: Synthesize unit/scale/... in event update
Move the code to synthesize event updates for scale/unit/cpus to a common utility file, and use it both from stat and record.
This allows to access scale and other extra qualifiers from perf script.
Signed-off-by Andi Kleen <[email protected]>Acked-by Jiri Olsa <[email protected]>Link:
http://lkml.kernel.org/r/20171117214300.32746-2-andi at firstfloor.orgSigned-off-by Arnaldo Carvalho de Melo <[email protected]>I am suspicious that this is a real issue, as this patch has been in mainline for some time...
This simple change fixes the issue me:
tools/perf/util/header.c +1
-1@@ -3576,7 +3576,7 @@ int perf_event__process_feature(struct perf_tool *tool, int max, err;u16 type; -if (!evsel->own_cpus) +if (!evsel->own_cpus || !(evsel->attr.read_format &PERF_FORMAT_ID ))// roundabout check for !evsel->id
return 0; ev = cpu_map_data__alloc(evsel->own_cpus, &size, &type, &max);It turns out that
evsel->idis NULL on a call toperf_event__process_feature(), which upsets this code:
Quoted 6 lines
ev->header.type = PERF_RECORD_EVENT_UPDATE; ev->header.size = (u16)size; ev->type = PERF_EVENT_UPDATE__CPUS; ev->id = evsel->id[0];Please me let me know if a valid issue so we can get a fix in.
yea, I can see how we can get here with event having its own CPUs, and we allocate the id array later at the time we map the event
I wonder instead of skipping on this feature, we should allocate the id array, like below
I did not test that.. need to find the server having event with its own cpus.. also need to make sure evsel->cpus is the way to go in here
thanks,
jirka
---
tools/perf/util/header.c +1 -0
@@ -29,6 +29,7 @@#include "symbol.h" #include "debug.h" #include "cpumap.h" +#include "thread_map.h" #include "pmu.h" #include "vdso.h" #include "strbuf.h"
@@ -3579,6 +3580,11 @@ perf_event__synthesize_event_update_cpus(struct perf_tool *tool,
if (!evsel->own_cpus) return 0;
+ if (!evsel->id ||
+ perf_evsel__alloc_id(evsel, cpu_map__nr(evsel->cpus),
+ thread_map__nr(evsel->threads)))
+ return -ENOMEM;
+
ev = cpu_map_data__alloc(evsel->own_cpus, &size, &type, &max); if (!ev) return -ENOMEM;
Quoted 35 lines
Quoted 24 lines
I am suspicious that this is a real issue, as this patch has been in mainline for some time...
This simple change fixes the issue me:
tools/perf/util/header.c +1
-1@@ -3576,7 +3576,7 @@ int perf_event__process_feature(struct perf_tool *tool, int max, err;u16 type; -if (!evsel->own_cpus) +if (!evsel->own_cpus || !(evsel->attr.read_format &PERF_FORMAT_ID ))// roundabout check for !evsel->id
return 0; ev = cpu_map_data__alloc(evsel->own_cpus, &size, &type, &max);It turns out that
evsel->idis NULL on a call toperf_event__process_feature(), which upsets this code:Quoted 6 lines
ev->header.type = PERF_RECORD_EVENT_UPDATE; ev->header.size = (u16)size; ev->type = PERF_EVENT_UPDATE__CPUS; ev->id = evsel->id[0];Please me let me know if a valid issue so we can get a fix in.
yea, I can see how we can get here with event having its own CPUs, and we allocate the id array later at the time we map the event
Quoted 7 lines
I wonder instead of skipping on this feature, we should allocate the id array, like below
I did not test that.. need to find the server having event with its own cpus.. also need to make sure
evsel->cpusis the way to go in here
Thanks for the fix, but I got this:
root at localhost:~# ./perf_debug_ record -e armv8_pmuv3_0/br_mis_pred/ sleep 1 Couldn't synthesize evsel cpus.
root at localhost:~#
Quoted 18 lines
thanks,
jirka---
tools/perf/util/header.c +1
-0@@ -29,6 +29,7 @@#include "symbol.h" #include "debug.h" #include "cpumap.h" +#include "thread_map.h" #include "pmu.h" #include "vdso.h" #include "strbuf.h"
tools/perf/util/header.c perf_event__synthesize_event_update_cpus(struct perf_tool *tool, · line 3583
Quoted 4 lines
tools/perf/util/header.c +1
-0@@ -3579,6 +3580,11 @@ perf_event__synthesize_event_update_cpus(struct perf_tool *tool,if (!evsel->own_cpus)return 0 ; + if (!evsel->id ||
for my test, evsel->id is NULL
tools/perf/util/header.c perf_event__synthesize_event_update_cpus(struct perf_tool *tool, · line 3585
Quoted 2 lines
tools/perf/util/header.c +2
-0+perf_evsel__alloc_id (evsel,cpu_map__nr (evsel->cpus), + thread_map__nr(evsel->threads)))
and then this function is not called as we return immediately. So did you really want this:
if (!evsel->id && perf_evsel__alloc_id(...))
return -ENOMEM;
This looks to work:
root at localhost:~# ./perf_debug_ record -e armv8_pmuv3_0/br_mis_pred/ sleep 1 [ perf record: Woken up 1 times to write data ]
[ perf record: Captured and wrote 0.001 MB perf.data (7 samples) ] root at localhost:~# ./perf_debug_ report
# To display the perf.data header info, please use --header/--header-only option
#
#
# Total Lost Samples: 0
#
# Samples: 7 of event 'armv8_pmuv3_0/br_mis_pred/'
# Event count (approx.): 8260
#
# Overhead Command Shared Object Symbol
# ........ ....... ................. ......................
#
78.28% sleep libc-2.23.so [.] 0x00000000000faef0
20.53% sleep [kernel.kallsyms] [k] vmacache_find
1.09% sleep [kernel.kallsyms] [k] find_vma
0.10% perf_de [kernel.kallsyms] [k] perf_event_exec#
# (Cannot load tips.txt file, please install perf!) #
root at localhost:~#
Quoted 8 lines
tools/perf/util/header.c +2
-0+return -ENOMEM ; + ev =cpu_map_data__alloc (evsel->own_cpus, &size, &type, &max);if (!ev)return -ENOMEM ;.
Thanks,
John
On Tue, Oct 02, 2018 at 11:41:36AM +0100, John Garry wrote:
SNIP
Quoted 23 lines
Quoted 16 lines
---
tools/perf/util/header.c +1
-0@@ -29,6 +29,7 @@#include "symbol.h" #include "debug.h" #include "cpumap.h" +#include "thread_map.h" #include "pmu.h" #include "vdso.h" #include "strbuf.h" tools/perf/util/header.c perf_event__synthesize_event_update_cpus(struct perf_tool *tool, · line 3583
Quoted 4 lines
tools/perf/util/header.c +1
-0@@ -3579,6 +3580,11 @@ perf_event__synthesize_event_update_cpus(struct perf_tool *tool,if (!evsel->own_cpus)return 0 ; + if (!evsel->id ||for my test,
evsel->idis NULL
Quoted 8 lines
tools/perf/util/header.c perf_event__synthesize_event_update_cpus(struct perf_tool *tool, · line 3585
Quoted 2 lines
tools/perf/util/header.c +2
-0+perf_evsel__alloc_id (evsel,cpu_map__nr (evsel->cpus), + thread_map__nr(evsel->threads)))and then this function is not called as we return immediately. So did you really want this:
if (!evsel->id &&
perf_evsel__alloc_id(...))return -ENOMEM;
ugh.. yes ;-) thanks for the fix.. I'll double
check the logic and post the patch this week
jirka
Quoted 44 lines
This looks to work:
root at localhost:~# ./perf_debug_ record -e armv8_pmuv3_0/br_mis_pred/ sleep 1 [ perf record: Woken up 1 times to write data ]
[ perf record: Captured and wrote 0.001 MB perf.data (7 samples) ] root at localhost:~# ./perf_debug_ report
# To display the perf.data header info, please use --header/--header-only option
#
#
# Total Lost Samples: 0
#
# Samples: 7 of event 'armv8_pmuv3_0/br_mis_pred/'
# Event count (approx.): 8260
## Overhead Command Shared Object Symbol # ........ ....... ................. ...................... # 78.28% sleep libc-2.23.so [.] 0x00000000000faef0 20.53% sleep [kernel.kallsyms] [k] vmacache_find 1.09% sleep [kernel.kallsyms] [k] find_vma 0.10% perf_de [kernel.kallsyms] [k] perf_event_exec#
# (Cannot load tips.txt file, please install perf!) #
root at localhost:~#Quoted 8 lines
tools/perf/util/header.c +2
-0+return -ENOMEM ; + ev =cpu_map_data__alloc (evsel->own_cpus, &size, &type, &max);if (!ev)return -ENOMEM ;.
Thanks,
John
PATCH 1/1 perf tools: Allocate id array in perf_event__synthesize_event_update_cpus
Quoted 33 lines · Jiri Olsa
On Tue, Oct 02, 2018 at 11:41:36AM +0100, John Garry wrote:
SNIP
Quoted 29 lines
Quoted 16 lines
---
tools/perf/util/header.c +1
-0@@ -29,6 +29,7 @@#include "symbol.h" #include "debug.h" #include "cpumap.h" +#include "thread_map.h" #include "pmu.h" #include "vdso.h" #include "strbuf.h" tools/perf/util/header.c perf_event__synthesize_event_update_cpus(struct perf_tool *tool, · line 3583
Quoted 4 lines
tools/perf/util/header.c +1
-0@@ -3579,6 +3580,11 @@ perf_event__synthesize_event_update_cpus(struct perf_tool *tool,if (!evsel->own_cpus)return 0 ; + if (!evsel->id ||for my test,
evsel->idis NULLtools/perf/util/header.c perf_event__synthesize_event_update_cpus(struct perf_tool *tool, · line 3585
Quoted 2 lines
tools/perf/util/header.c +2
-0+perf_evsel__alloc_id (evsel,cpu_map__nr (evsel->cpus), + thread_map__nr(evsel->threads)))and then this function is not called as we return immediately. So did you really want this:
Quoted 5 lines
Quoted 2 lines
if (!evsel->id &&
perf_evsel__alloc_id(...))return -ENOMEM;ugh.. yes ;-) thanks for the fix.. I'll double
check the logic and post the patch this week
actualy, we also need to populate those ids ;-)
so calling perf_evsel__store_ids instead..
attaching the full patch
thanks,
jirka
---
John reported crash when recording on an event under pmu with cpumask defined:
root at localhost:~# ./perf_debug_ record -e armv8_pmuv3_0/br_mis_pred/ sleep 1
perf: Segmentation fault
Obtained 9 stack frames.
./perf_debug_() [0x4c5ef8]
[0xffff82ba267c]
./perf_debug_() [0x4bc5a8]
./perf_debug_() [0x419550]
./perf_debug_() [0x41a928]
./perf_debug_() [0x472f58]
./perf_debug_() [0x473210]
./perf_debug_() [0x4070f4] /lib/aarch64-linux-gnu/libc.so.6(__libc_start_main+0xe0) [0xffff8294c8a0] Segmentation fault (core dumped)
We synthesize an update event that needs to touch the evsel id array, which is not defined at that time. Fixing this by allocating the array and getting IDs before it's used.
--- tools/perf/util/header.c | 4 ++++ 1 file changed, 4 insertions(+)
tools/perf/util/header.c +4 -0
@@ -29,6 +29,7 @@#include "symbol.h" #include "debug.h" #include "cpumap.h" +#include "thread_map.h" #include "pmu.h" #include "vdso.h" #include "strbuf.h"
@@ -3579,6 +3580,9 @@ perf_event__synthesize_event_update_cpus(struct perf_tool *tool,if (!evsel->own_cpus)return 0 ; +if (!evsel->id &&perf_evsel__store_ids (evsel, evsel->evlist)) +return -ENOMEM ; + ev =cpu_map_data__alloc (evsel->own_cpus, &size, &type, &max);if (!ev)return -ENOMEM ;
Signature · 1 line
2.17.1
Re: [PATCH] perf tools: Allocate id array in perf_event__synthesize_event_update_cpus
Quoted 40 lines · Jiri Olsa
Quoted 33 lines · Jiri Olsa
On Tue, Oct 02, 2018 at 11:41:36AM +0100, John Garry wrote:
SNIP
Quoted 29 lines
Quoted 16 lines
---
tools/perf/util/header.c +1
-0@@ -29,6 +29,7 @@#include "symbol.h" #include "debug.h" #include "cpumap.h" +#include "thread_map.h" #include "pmu.h" #include "vdso.h" #include "strbuf.h" tools/perf/util/header.c perf_event__synthesize_event_update_cpus(struct perf_tool *tool, · line 3583
Quoted 4 lines
tools/perf/util/header.c +1
-0@@ -3579,6 +3580,11 @@ perf_event__synthesize_event_update_cpus(struct perf_tool *tool,if (!evsel->own_cpus)return 0 ; + if (!evsel->id ||for my test,
evsel->idis NULLtools/perf/util/header.c perf_event__synthesize_event_update_cpus(struct perf_tool *tool, · line 3585
Quoted 2 lines
tools/perf/util/header.c +2
-0+perf_evsel__alloc_id (evsel,cpu_map__nr (evsel->cpus), + thread_map__nr(evsel->threads)))and then this function is not called as we return immediately. So did you really want this:
Quoted 5 lines
Quoted 2 lines
if (!evsel->id &&
perf_evsel__alloc_id(...))return -ENOMEM;ugh.. yes ;-) thanks for the fix.. I'll double
check the logic and post the patch this week
Quoted 7 lines
actualy, we also need to populate those ids ;-)
so callingperf_evsel__store_idsinstead..
attaching the full patchthanks,
jirka
Hi Jirka,
Can you please double-check your new patch, as I'm getting this now:
root at localhost:~# ./perf_debug record -e armv8_pmuv3_0/br_mis_pred/ sleep 1 [ perf record: Woken up 1 times to write data ]
[ perf record: Captured and wrote 0.001 MB perf.data (6 samples) ] root at localhost:~# ./perf_debug report0xe8 [0]: failed to process type: 461
Error:
failed to process sample
# To display the perf.data header info, please use --header/--header-only option
#
root at localhost:~#
Thanks,
John
Quoted 53 lines
---
John reported crash when recording on an event under pmu with cpumask defined:root at localhost:~# ./perf_debug_ record -e armv8_pmuv3_0/br_mis_pred/ sleep 1
perf: Segmentation fault
Obtained 9 stack frames.
./perf_debug_() [0x4c5ef8]
[0xffff82ba267c]
./perf_debug_() [0x4bc5a8]
./perf_debug_() [0x419550]
./perf_debug_() [0x41a928]
./perf_debug_() [0x472f58]
./perf_debug_() [0x473210]
./perf_debug_() [0x4070f4] /lib/aarch64-linux-gnu/libc.so.6(__libc_start_main+0xe0) [0xffff8294c8a0] Segmentation fault (core dumped)We synthesize an update event that needs to touch the evsel id array, which is not defined at that time. Fixing this by allocating the array and getting IDs before it's used.
Reported-by John Garry <[email protected]>Link http://lkml.kernel.org/n/tip-8x4n7o34yheigoxm1jibflm6 at git.kernel.orgSigned-off-by Jiri Olsa <[email protected]>--- tools/perf/util/header.c | 4 ++++ 1 file changed, 4 insertions(+)tools/perf/util/header.c +4
-0@@ -29,6 +29,7 @@#include "symbol.h" #include "debug.h" #include "cpumap.h" +#include "thread_map.h" #include "pmu.h" #include "vdso.h" #include "strbuf.h" @@ -3579,6 +3580,9 @@ perf_event__synthesize_event_update_cpus(struct perf_tool *tool,if (!evsel->own_cpus)return 0 ; +if (!evsel->id &&perf_evsel__store_ids (evsel, evsel->evlist)) +return -ENOMEM ; + ev =cpu_map_data__alloc (evsel->own_cpus, &size, &type, &max);if (!ev)return -ENOMEM ;
Re: [PATCH] perf tools: Allocate id array in perf_event__synthesize_event_update_cpus
Quoted 51 lines · John Garry
Quoted 40 lines · Jiri Olsa
Quoted 33 lines · Jiri Olsa
On Tue, Oct 02, 2018 at 11:41:36AM +0100, John Garry wrote:
SNIP
Quoted 29 lines
Quoted 16 lines
---
tools/perf/util/header.c +1
-0@@ -29,6 +29,7 @@#include "symbol.h" #include "debug.h" #include "cpumap.h" +#include "thread_map.h" #include "pmu.h" #include "vdso.h" #include "strbuf.h" tools/perf/util/header.c perf_event__synthesize_event_update_cpus(struct perf_tool *tool, · line 3583
Quoted 4 lines
tools/perf/util/header.c +1
-0@@ -3579,6 +3580,11 @@ perf_event__synthesize_event_update_cpus(struct perf_tool *tool,if (!evsel->own_cpus)return 0 ; + if (!evsel->id ||for my test,
evsel->idis NULLtools/perf/util/header.c perf_event__synthesize_event_update_cpus(struct perf_tool *tool, · line 3585
Quoted 2 lines
tools/perf/util/header.c +2
-0+perf_evsel__alloc_id (evsel,cpu_map__nr (evsel->cpus), + thread_map__nr(evsel->threads)))and then this function is not called as we return immediately. So did you really want this:
Quoted 5 lines
Quoted 2 lines
if (!evsel->id &&
perf_evsel__alloc_id(...))return -ENOMEM;ugh.. yes ;-) thanks for the fix.. I'll double
check the logic and post the patch this weekQuoted 7 lines
actualy, we also need to populate those ids ;-)
so callingperf_evsel__store_idsinstead..
attaching the full patchthanks,
jirkaHi Jirka,
Quoted 12 lines
Can you please double-check your new patch, as I'm getting this now:
root at localhost:~# ./perf_debug record -e armv8_pmuv3_0/br_mis_pred/ sleep 1 [ perf record: Woken up 1 times to write data ]
[ perf record: Captured and wrote 0.001 MB perf.data (6 samples) ] root at localhost:~# ./perf_debug report0xe8[0]: failed to process type: 461
Error:
failed to process sample
# To display the perf.data header info, please use --header/--header-only option
#
root at localhost:~#
ok, I need to get a machine to test this.. but it looks like any sample-able events with cpumask are in arm :-\ will try to get some..
jirka
PATCH 1/1 perf tools: Store ids for events with their own cpus perf_event__synthesize_event_update_cpus
Quoted 65 lines · Jiri Olsa
Quoted 51 lines · John Garry
Quoted 40 lines · Jiri Olsa
Quoted 33 lines · Jiri Olsa
On Tue, Oct 02, 2018 at 11:41:36AM +0100, John Garry wrote:
SNIP
Quoted 29 lines
Quoted 16 lines
---
tools/perf/util/header.c +1
-0@@ -29,6 +29,7 @@#include "symbol.h" #include "debug.h" #include "cpumap.h" +#include "thread_map.h" #include "pmu.h" #include "vdso.h" #include "strbuf.h" tools/perf/util/header.c perf_event__synthesize_event_update_cpus(struct perf_tool *tool, · line 3583
Quoted 4 lines
tools/perf/util/header.c +1
-0@@ -3579,6 +3580,11 @@ perf_event__synthesize_event_update_cpus(struct perf_tool *tool,if (!evsel->own_cpus)return 0 ; + if (!evsel->id ||for my test,
evsel->idis NULLtools/perf/util/header.c perf_event__synthesize_event_update_cpus(struct perf_tool *tool, · line 3585
Quoted 2 lines
tools/perf/util/header.c +2
-0+perf_evsel__alloc_id (evsel,cpu_map__nr (evsel->cpus), + thread_map__nr(evsel->threads)))and then this function is not called as we return immediately. So did you really want this:
Quoted 5 lines
Quoted 2 lines
if (!evsel->id &&
perf_evsel__alloc_id(...))return -ENOMEM;ugh.. yes ;-) thanks for the fix.. I'll double
check the logic and post the patch this weekQuoted 7 lines
actualy, we also need to populate those ids ;-)
so callingperf_evsel__store_idsinstead..
attaching the full patchthanks,
jirkaHi Jirka,
Quoted 12 lines
Can you please double-check your new patch, as I'm getting this now:
root at localhost:~# ./perf_debug record -e armv8_pmuv3_0/br_mis_pred/ sleep 1 [ perf record: Woken up 1 times to write data ]
[ perf record: Captured and wrote 0.001 MB perf.data (6 samples) ] root at localhost:~# ./perf_debug report0xe8[0]: failed to process type: 461
Error:
failed to process sample
# To display the perf.data header info, please use --header/--header-only option
#
root at localhost:~#
Quoted 3 lines
ok, I need to get a machine to test this.. but it looks like any sample-able events with cpumask are in arm :-\ will try to get some..
got an arm server and patch below works for me.. could you please test?
thanks,
jirka
---
John reported crash when recording on an event under pmu with cpumask defined:
root at localhost:~# ./perf_debug_ record -e armv8_pmuv3_0/br_mis_pred/ sleep 1
perf: Segmentation fault
Obtained 9 stack frames.
./perf_debug_() [0x4c5ef8]
[0xffff82ba267c]
./perf_debug_() [0x4bc5a8]
./perf_debug_() [0x419550]
./perf_debug_() [0x41a928]
./perf_debug_() [0x472f58]
./perf_debug_() [0x473210]
./perf_debug_() [0x4070f4] /lib/aarch64-linux-gnu/libc.so.6(__libc_start_main+0xe0) [0xffff8294c8a0] Segmentation fault (core dumped)
We synthesize an update event that needs to touch the evsel id array, which is not defined at that time. Fixing this by forcing the id allocation for events with theeir own cpus.
--- tools/perf/builtin-report.c | 1 + tools/perf/util/evsel.c | 3 +++ 2 files changed, 4 insertions(+)
tools/perf/builtin-report.c +1 -0
@@ -980,6 +980,7 @@ int cmd_report(int argc, const char **argv) .id_index = perf_event__process_id_index, .auxtrace_info = perf_event__process_auxtrace_info, .auxtrace = perf_event__process_auxtrace, + .event_update = perf_event__process_event_update, .feature = process_feature_event, .ordered_events = true, .ordering_requires_timestamps = true,
tools/perf/util/evsel.c +3 -0
@@ -1088,6 +1088,9 @@ void perf_evsel__config(struct perf_evsel *evsel, struct record_opts *opts, attr->exclude_user =1 ; } +if (evsel->own_cpus) + evsel->attr.read_format |=PERF_FORMAT_ID ; +/* * Apply event specific term settings, * it overloads any global configuration.
Signature · 1 line
2.17.1
Re: [PATCH] perf tools: Store ids for events with their own cpus perf_event__synthesize_event_update_cpus
Quoted 15 lines
Quoted 15 lines
Quoted 14 lines
Hi Jirka,
Can you please double-check your new patch, as I'm getting this now:
root at localhost:~# ./perf_debug record -e armv8_pmuv3_0/br_mis_pred/ sleep 1 [ perf record: Woken up 1 times to write data ]
[ perf record: Captured and wrote 0.001 MB perf.data (6 samples) ] root at localhost:~# ./perf_debug report0xe8[0]: failed to process type: 461
Error:
failed to process sample
# To display the perf.data header info, please use --header/--header-only option
#
root at localhost:~#
Quoted 6 lines
Quoted 3 lines
ok, I need to get a machine to test this.. but it looks like any sample-able events with cpumask are in arm :-\ will try to get some..
got an arm server and patch below works for me.. could you please test?
Cool, so this works ok:
root at localhost:~# ./perf_debug record -e armv8_pmuv3_0/br_mis_pred/ sleep 1 [ perf record: Woken up 1 times to write data ]
[ perf record: Captured and wrote 0.002 MB perf.data (6 samples) ] root at localhost:~# ./perf_debug report
# To display the perf.data header info, please use --header/--header-only option
#
#
# Total Lost Samples: 0
#
# Samples: 6 of event 'armv8_pmuv3_0/br_mis_pred/'
# Event count (approx.): 3369
#
# Overhead Command Shared Object Symbol
# ........ ....... ................. ...................
#
94.81% sleep [kernel.kallsyms] [k] memcmp
4.87% sleep [kernel.kallsyms] [k] tlb_flush_mmu
0.33% perf_de [kernel.kallsyms] [k] perf_event_exec#
# (Cannot load tips.txt file, please install perf!) #
root at localhost:~#
Quoted 23 lines
thanks,
jirka---
John reported crash when recording on an event under pmu with cpumask defined:
root at localhost:~# ./perf_debug_ record -e armv8_pmuv3_0/br_mis_pred/ sleep 1
perf: Segmentation fault
Obtained 9 stack frames.
./perf_debug_() [0x4c5ef8]
[0xffff82ba267c]
./perf_debug_() [0x4bc5a8]
./perf_debug_() [0x419550]
./perf_debug_() [0x41a928]
./perf_debug_() [0x472f58]
./perf_debug_() [0x473210]
./perf_debug_() [0x4070f4] /lib/aarch64-linux-gnu/libc.so.6(__libc_start_main+0xe0) [0xffff8294c8a0] Segmentation fault (core dumped)
Quoted 6 lines
We synthesize an update event that needs to touch the evsel id array, which is not defined at that time. Fixing this by forcing the id allocation for events with theeir own cpus.
Reported-by John Garry <[email protected]>Link http://lkml.kernel.org/n/tip-8x4n7o34yheigoxm1jibflm6 at git.kernel.org
In terms of adding to stable, LT v4.14 is not affected, but 4.18.x is.
Thanks,
John
Quoted 33 lines
Signed-off-by Jiri Olsa <[email protected]>--- tools/perf/builtin-report.c | 1 + tools/perf/util/evsel.c | 3 +++ 2 files changed, 4 insertions(+)tools/perf/builtin-report.c +1
-0@@ -980,6 +980,7 @@ int cmd_report(int argc, const char **argv) .id_index = perf_event__process_id_index, .auxtrace_info = perf_event__process_auxtrace_info, .auxtrace = perf_event__process_auxtrace, + .event_update = perf_event__process_event_update, .feature = process_feature_event, .ordered_events = true, .ordering_requires_timestamps = true,tools/perf/util/evsel.c +3
-0@@ -1088,6 +1088,9 @@ void perf_evsel__config(struct perf_evsel *evsel, struct record_opts *opts, attr->exclude_user =1 ; } +if (evsel->own_cpus) + evsel->attr.read_format |=PERF_FORMAT_ID ; +/* * Apply event specific term settings, * it overloads any global configuration.
Re: [PATCH] perf tools: Store ids for events with their own cpus perf_event__synthesize_event_update_cpus
On Thu, Oct 04, 2018 at 10:20:39AM +0100, John Garry wrote:
SNIP
Quoted 7 lines
Quoted 6 lines
We synthesize an update event that needs to touch the evsel id array, which is not defined at that time. Fixing this by forcing the id allocation for events with theeir own cpus.
Reported-by John Garry <[email protected]>Link http://lkml.kernel.org/n/tip-8x4n7o34yheigoxm1jibflm6 at git.kernel.org
Quoted 6 lines
Tested-by John Garry <[email protected]>In terms of adding to stable, LT v4.14 is not affected, but 4.18.x is.
Thanks,
John
Arnaldo, could you please pick up this one
thanks,
jirka
Quoted 36 lines
Quoted 34 lines
Signed-off-by Jiri Olsa <[email protected]>--- tools/perf/builtin-report.c | 1 + tools/perf/util/evsel.c | 3 +++ 2 files changed, 4 insertions(+)tools/perf/builtin-report.c +1
-0@@ -980,6 +980,7 @@ int cmd_report(int argc, const char **argv) .id_index = perf_event__process_id_index, .auxtrace_info = perf_event__process_auxtrace_info, .auxtrace = perf_event__process_auxtrace, + .event_update = perf_event__process_event_update, .feature = process_feature_event, .ordered_events = true, .ordering_requires_timestamps = true,tools/perf/util/evsel.c +3
-0@@ -1088,6 +1088,9 @@ void perf_evsel__config(struct perf_evsel *evsel, struct record_opts *opts, attr->exclude_user =1 ; } +if (evsel->own_cpus) + evsel->attr.read_format |=PERF_FORMAT_ID ; +/* * Apply event specific term settings, * it overloads any global configuration.
Re: [PATCH] perf tools: Store ids for events with their own cpus perf_event__synthesize_event_update_cpus
Quoted 7 lines · Jiri Olsa
On Thu, Oct 04, 2018 at 10:20:39AM +0100, John Garry wrote:
SNIP
Quoted 3 lines
Quoted 3 lines
We synthesize an update event that needs to touch the evsel id array, which is not defined at that time. Fixing this by forcing the id allocation for events with theeir own cpus.
/s/theeir/their/
Quoted 4 lines
Quoted 4 lines
Quoted 3 lines
Reported-by John Garry <[email protected]>Link http://lkml.kernel.org/n/tip-8x4n7o34yheigoxm1jibflm6 at git.kernel.org
Quoted 9 lines
Quoted 6 lines
Tested-by John Garry <[email protected]>In terms of adding to stable, LT v4.14 is not affected, but 4.18.x is.
Thanks,
JohnArnaldo, could you please pick up this one
Just a friendly reminder on this patch.
How about re-send with an updated commit message also?
Thanks,
John
Quoted 47 lines
thanks,
jirkaQuoted 27 lines
Quoted 27 lines
Signed-off-by Jiri Olsa <[email protected]>--- tools/perf/builtin-report.c | 1 + tools/perf/util/evsel.c | 3 +++ 2 files changed, 4 insertions(+)tools/perf/builtin-report.c +1
-0@@ -980,6 +980,7 @@ int cmd_report(int argc, const char **argv) .id_index = perf_event__process_id_index, .auxtrace_info = perf_event__process_auxtrace_info, .auxtrace = perf_event__process_auxtrace, + .event_update = perf_event__process_event_update, .feature = process_feature_event, .ordered_events = true, .ordering_requires_timestamps = true,tools/perf/util/evsel.c +0
-0@@ -1088,6 +1088,9 @@ void perf_evsel__config(struct perf_evsel *evsel, struct record_opts *opts, attr->exclude_user =1 ; }Quoted 9 lines
tools/perf/util/evsel.c void perf_evsel__config(struct perf_evsel *evsel, struct record_opts *opts, · line 1096
Quoted 7 lines
tools/perf/util/evsel.c +3
-0+if (evsel->own_cpus) + evsel->attr.read_format |=PERF_FORMAT_ID ; +/* * Apply event specific term settings, * it overloads any global configuration. _______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel.
Arnaldo Carvalho de Melo
maintainerRe: [PATCH] perf tools: Store ids for events with their own cpus perf_event__synthesize_event_update_cpus
Em Fri, Oct 12, 2018 at 02:25:49PM +0100, John Garry escreveu:
Quoted 22 lines · Jiri Olsa
Quoted 7 lines · John Garry
SNIP
Quoted 3 lines
Quoted 3 lines
We synthesize an update event that needs to touch the evsel id array, which is not defined at that time. Fixing this by forcing the id allocation for events with theeir own cpus.
/s/theeir/their/
Quoted 11 lines
Quoted 10 lines
Quoted 3 lines
Reported-by John Garry <[email protected]>Link http://lkml.kernel.org/n/tip-8x4n7o34yheigoxm1jibflm6 at git.kernel.orgTested-by John Garry <[email protected]>In terms of adding to stable, LT v4.14 is not affected, but 4.18.x is.
Thanks,
John
Quoted 6 lines
Quoted 2 lines
Arnaldo, could you please pick up this one
Just a friendly reminder on this patch.
How about re-send with an updated commit message also?
I'll fix up the commit message and apply, thanks.
- Arnaldo
Quoted 51 lines
Thanks,
JohnQuoted 47 lines
thanks,
jirkaQuoted 27 lines
Quoted 27 lines
Signed-off-by Jiri Olsa <[email protected]>--- tools/perf/builtin-report.c | 1 + tools/perf/util/evsel.c | 3 +++ 2 files changed, 4 insertions(+)tools/perf/builtin-report.c +1
-0@@ -980,6 +980,7 @@ int cmd_report(int argc, const char **argv) .id_index = perf_event__process_id_index, .auxtrace_info = perf_event__process_auxtrace_info, .auxtrace = perf_event__process_auxtrace, + .event_update = perf_event__process_event_update, .feature = process_feature_event, .ordered_events = true, .ordering_requires_timestamps = true,tools/perf/util/evsel.c +0
-0@@ -1088,6 +1088,9 @@ void perf_evsel__config(struct perf_evsel *evsel, struct record_opts *opts, attr->exclude_user =1 ; }Quoted 9 lines
tools/perf/util/evsel.c void perf_evsel__config(struct perf_evsel *evsel, struct record_opts *opts, · line 1096
Quoted 7 lines
tools/perf/util/evsel.c +3
-0+if (evsel->own_cpus) + evsel->attr.read_format |=PERF_FORMAT_ID ; +/* * Apply event specific term settings, * it overloads any global configuration. _______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel.
Re: [PATCH] perf tools: Store ids for events with their own cpus perf_event__synthesize_event_update_cpus
Quoted 23 lines · Arnaldo Carvalho de Melo
Em Fri, Oct 12, 2018 at 02:25:49PM +0100, John Garry escreveu:
Quoted 22 lines · Jiri Olsa
Quoted 7 lines · John Garry
SNIP
Quoted 3 lines
Quoted 3 lines
We synthesize an update event that needs to touch the evsel id array, which is not defined at that time. Fixing this by forcing the id allocation for events with theeir own cpus.
/s/theeir/their/
Quoted 11 lines
Quoted 10 lines
Quoted 3 lines
Reported-by John Garry <[email protected]>Link http://lkml.kernel.org/n/tip-8x4n7o34yheigoxm1jibflm6 at git.kernel.orgTested-by John Garry <[email protected]>In terms of adding to stable, LT v4.14 is not affected, but 4.18.x is.
Thanks,
John
Quoted 9 lines
Quoted 6 lines
Quoted 2 lines
Arnaldo, could you please pick up this one
Just a friendly reminder on this patch.
How about re-send with an updated commit message also?
I'll fix up the commit message and apply, thanks.
Much appreciated.
BTW, I think that we should add a fixes tag. But I'm not sure if this patch fixes the commit I bisected to earlier (bfd8f72c2778f5bd63d), or that same commit just exposed some latent bug.
Jirka, Andi, Do you know?
Thanks,
John
Quoted 56 lines
- Arnaldo
Quoted 51 lines
Thanks,
JohnQuoted 47 lines
thanks,
jirkaQuoted 27 lines
Quoted 27 lines
Signed-off-by Jiri Olsa <[email protected]>--- tools/perf/builtin-report.c | 1 + tools/perf/util/evsel.c | 3 +++ 2 files changed, 4 insertions(+)tools/perf/builtin-report.c +1
-0@@ -980,6 +980,7 @@ int cmd_report(int argc, const char **argv) .id_index = perf_event__process_id_index, .auxtrace_info = perf_event__process_auxtrace_info, .auxtrace = perf_event__process_auxtrace, + .event_update = perf_event__process_event_update, .feature = process_feature_event, .ordered_events = true, .ordering_requires_timestamps = true,tools/perf/util/evsel.c +0
-0@@ -1088,6 +1088,9 @@ void perf_evsel__config(struct perf_evsel *evsel, struct record_opts *opts, attr->exclude_user =1 ; }Quoted 9 lines
tools/perf/util/evsel.c void perf_evsel__config(struct perf_evsel *evsel, struct record_opts *opts, · line 1096
Quoted 7 lines
tools/perf/util/evsel.c +3
-0+if (evsel->own_cpus) + evsel->attr.read_format |=PERF_FORMAT_ID ; +/* * Apply event specific term settings, * it overloads any global configuration. _______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel.
.
Re: [PATCH] perf tools: Store ids for events with their own cpus perf_event__synthesize_event_update_cpus
Quoted 34 lines · John Garry
Quoted 23 lines · Arnaldo Carvalho de Melo
Em Fri, Oct 12, 2018 at 02:25:49PM +0100, John Garry escreveu:
Quoted 22 lines · Jiri Olsa
Quoted 7 lines · John Garry
SNIP
Quoted 3 lines
Quoted 3 lines
We synthesize an update event that needs to touch the evsel id array, which is not defined at that time. Fixing this by forcing the id allocation for events with theeir own cpus.
/s/theeir/their/
Quoted 11 lines
Quoted 10 lines
Quoted 3 lines
Reported-by John Garry <[email protected]>Link http://lkml.kernel.org/n/tip-8x4n7o34yheigoxm1jibflm6 at git.kernel.orgTested-by John Garry <[email protected]>In terms of adding to stable, LT v4.14 is not affected, but 4.18.x is.
Thanks,
JohnQuoted 9 lines
Quoted 6 lines
Quoted 2 lines
Arnaldo, could you please pick up this one
Just a friendly reminder on this patch.
How about re-send with an updated commit message also?
I'll fix up the commit message and apply, thanks.
Quoted 7 lines
Much appreciated.
BTW, I think that we should add a fixes tag. But I'm not sure if this patch fixes the commit I bisected to earlier (
bfd8f72c2778f5bd63d), or that same commit just exposed some latent bug.Jirka, Andi, Do you know?
yes, that commit moved it to record, which resulted in this fault
Arnaldo, could you please add:
thanks,
jirka
tip-bot for Jiri Olsa
merge bot[tip:perf/urgent] perf evsel: Store ids for events with their own cpus perf_event__synthesize_event_update_cpus
In reply to Jiri Olsaperf evsel: Store ids for events with their own cpus perf_event__synthesize_event_update_cpus
Commit-ID: 4ab8455f8bd83298bf7f67ab9357e3b1cc765c7d Gitweb: https://git.kernel.org/tip/4ab8455f8bd83298bf7f67ab9357e3b1cc765c7d Author: Jiri Olsa <[email protected]> AuthorDate: Wed, 3 Oct 2018 23:20:52 +0200 Committer: Arnaldo Carvalho de Melo <[email protected]> CommitDate: Tue, 16 Oct 2018 08:18:52 -0300
perf evsel: Store ids for events with their own cpus perf_event__synthesize_event_update_cpus
John reported crash when recording on an event under PMU with cpumask defined:
root@localhost:~# ./perf_debug_ record -e armv8_pmuv3_0/br_mis_pred/ sleep 1 perf: Segmentation fault Obtained 9 stack frames. ./perf_debug_() [0x4c5ef8] [0xffff82ba267c] ./perf_debug_() [0x4bc5a8] ./perf_debug_() [0x419550] ./perf_debug_() [0x41a928] ./perf_debug_() [0x472f58] ./perf_debug_() [0x473210] ./perf_debug_() [0x4070f4] /lib/aarch64-linux-gnu/libc.so.6(__libc_start_main+0xe0) [0xffff8294c8a0] Segmentation fault (core dumped)
We synthesize an update event that needs to touch the evsel id array, which is not defined at that time. Fixing this by forcing the id allocation for events with their own cpus.
--- tools/perf/builtin-report.c | 1 + tools/perf/util/evsel.c | 3 +++ 2 files changed, 4 insertions(+)
tools/perf/builtin-report.c +1 -0
@@ -981,6 +981,7 @@ int cmd_report(int argc, const char **argv) .id_index = perf_event__process_id_index, .auxtrace_info = perf_event__process_auxtrace_info, .auxtrace = perf_event__process_auxtrace, + .event_update = perf_event__process_event_update, .feature = process_feature_event, .ordered_events = true, .ordering_requires_timestamps = true,
tools/perf/util/evsel.c +3 -0
@@ -1089,6 +1089,9 @@ void perf_evsel__config(struct perf_evsel *evsel, struct record_opts *opts, attr->exclude_user =1 ; } +if (evsel->own_cpus) + evsel->attr.read_format |=PERF_FORMAT_ID ; +/* * Apply event specific term settings, * it overloads any global configuration.