rtc: tegra: Propagate errors from platform_get_irq()
Subsystems (2)
PATCH 1/1 rtc: tegra: Propagate errors from platform_get_irq()
From: Thierry Reding <[email protected]>
Instead of confusingly returning -EBUSY on failure to obtain an interrupt, propagate the real error code. While at it, let the user know why the interrupt could not be acquired.
Signed-off-by Thierry Reding <[email protected]>
--- drivers/rtc/rtc-tegra.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-)
drivers/rtc/rtc-tegra.c +7 -3
@@ -322,9 +322,13 @@ static int __init tegra_rtc_probe(struct platform_device *pdev)if (IS_ERR (info->rtc_base))return PTR_ERR (info->rtc_base); - info->tegra_rtc_irq =platform_get_irq (pdev,0 ); -if (info->tegra_rtc_irq <=0 ) -return -EBUSY ; + ret =platform_get_irq (pdev,0 ); +if (ret <=0 ) { +dev_err (&pdev->dev,"failed to get platform IRQ: %d\n" , ret); +return ret; + } + + info->tegra_rtc_irq = ret; info->clk =devm_clk_get (&pdev->dev,NULL );if (IS_ERR (info->clk))
Signature · 1 line
2.19.0
Quoted 11 lines · Thierry Reding
From: Thierry Reding <[email protected]>
Instead of confusingly returning
-EBUSYon failure to obtain an interrupt, propagate the real error code. While at it, let the user know why the interrupt could not be acquired.Signed-off-by Thierry Reding <[email protected]>--- drivers/rtc/rtc-tegra.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-)
Applied, thanks.
Signature · 3 lines
Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com