patch "staging: MAINTAINERS: remove obsolete IPX staging directory" added to staging-testing

DISCUSSION Joe Perches 2 participants 3 messages Oct 16, 2018 1 message not in the archive

Subsystems (2)

Networking Network drivers

lore

Share & tools

lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Joe Perches

author

2018-10-16 11:43 UTC #1 lore raw

Quoted 3 lines · On Tue, 2018-10-16 at 12:46 +0200, [email protected] wrote:

This is a note to let you know that I've just added the patch titled
staging: MAINTAINERS: remove obsolete IPX staging directoryts

[]

Quoted 8 lines

From dd71c89b2c1ae049d2018107e9d7a41261db3f7b Mon Sep 17 00:00:00 2001
From: Greg Kroah-Hartman <[email protected]>
Date: Tue, 16 Oct 2018 12:45:13 +0200
Subject: staging: MAINTAINERS: remove obsolete IPX staging directory
The IPX code was removed from staging back in November 2017, but the MAINTAINERS entry stuck around. Remove the invalid directory from the file as it does not actually point to anything anymore.

As the uapi ipx file still exists but the functionality has been removed, perhaps some compiler message like

#pragma message "IPX functionality removed as of linux kernel v4.18"

should be added to the uapi file.

Quoted 10 lines

MAINTAINERS +0 -0

[]

MAINTAINERS +0 -1

@@ -7672,7 +7672,6 @@ IPX NETWORK LAYER
 L:	[email protected]
 S:	Obsolete
 F:	include/uapi/linux/ipx.h
-F:	drivers/staging/ipx/
 
 IRQ DOMAINS (IRQ NUMBER MAPPING LIBRARY)
 M:	Marc Zyngier <[email protected]>

Greg KH

2018-10-16 11:51 UTC #2 lore raw

Quoted 14 lines · Joe Perches

Quoted 3 lines · On Tue, 2018-10-16 at 12:46 +0200, [email protected] wrote:
This is a note to let you know that I've just added the patch titled
staging: MAINTAINERS: remove obsolete IPX staging directoryts
[]
Quoted 8 lines
From dd71c89b2c1ae049d2018107e9d7a41261db3f7b Mon Sep 17 00:00:00 2001
From: Greg Kroah-Hartman <[email protected]>
Date: Tue, 16 Oct 2018 12:45:13 +0200
Subject: staging: MAINTAINERS: remove obsolete IPX staging directory
The IPX code was removed from staging back in November 2017, but the MAINTAINERS entry stuck around. Remove the invalid directory from the file as it does not actually point to anything anymore.

Quoted 6 lines

As the uapi ipx file still exists but the functionality has been removed, perhaps some compiler message like
#pragma message "IPX functionality removed as of linux kernel v4.18"
should be added to the uapi file.

Eventually those files should be removed by the networking developers. It will take a bit of work for them to do it, it's not a straight "delete the file" work.

thanks,

greg k-h

Joe Perches

author

2018-10-16 17:11 UTC #3 lore raw

Quoted 18 lines · Greg KH

Quoted 17 lines · Joe Perches
Quoted 3 lines · On Tue, 2018-10-16 at 12:46 +0200, [email protected] wrote:
This is a note to let you know that I've just added the patch titled
staging: MAINTAINERS: remove obsolete IPX staging directoryts
[]
Quoted 8 lines
From dd71c89b2c1ae049d2018107e9d7a41261db3f7b Mon Sep 17 00:00:00 2001
From: Greg Kroah-Hartman <[email protected]>
Date: Tue, 16 Oct 2018 12:45:13 +0200
Subject: staging: MAINTAINERS: remove obsolete IPX staging directory
The IPX code was removed from staging back in November 2017, but the MAINTAINERS entry stuck around. Remove the invalid directory from the file as it does not actually point to anything anymore.
As the uapi ipx file still exists but the functionality has been removed, perhaps some compiler message like

Quoted 7 lines

Quoted 3 lines
#pragma message "IPX functionality removed as of linux kernel v4.18"
should be added to the uapi file.
Eventually those files should be removed by the networking developers. It will take a bit of work for them to do it, it's not a straight "delete the file" work.

I understand that, but it's not the point.

#pragma message might still be useful because,
in the meantime, anyone
actually including the
uapi file would get some heads-up notification
that IPX doesn't work here anymore.