builtin/submodule--helper: remove debugging leftover tracing

PATCH In review Stefan Beller 2 participants 2 messages Oct 16, 2018 – Oct 17, 2018

Share & tools

Stefan Beller

author

2018-10-16 23:45 UTC #0 lore raw

PATCH 1/1 builtin/submodule--helper: remove debugging leftover tracing

I noticed 74d4731da1 (submodule--helper: replace connect-gitdir-workingtree by ensure-core-worktree, 2018-08-13) had two leftover debugging statements when reading The coverage report [1]. Remove them.

https://public-inbox.org/git/[email protected]/

Signed-off-by Stefan Beller <[email protected]>

---

To be applied on (or squashed into the tip of)
sb/submodule-update-in-c

 builtin/submodule--helper.c | 2 --
 1 file changed, 2 deletions(-)

builtin/submodule--helper.c +0 -2

index 5c9d1fb496..c7d3841ffc 100644
@@ -1459,7 +1459,6 @@ static void determine_submodule_update_strategy(struct repository *r,
 	key = xstrfmt("submodule.%s.update", sub->name);
 
 	if (update) {
-		trace_printf("parsing update");
 		if (parse_submodule_update_strategy(update, out) < 0)
 			die(_("Invalid update mode '%s' for submodule path '%s'"),
 				update, path);

@@ -1468,7 +1467,6 @@ static void determine_submodule_update_strategy(struct repository *r,
 			die(_("Invalid update mode '%s' configured for submodule path '%s'"),
 				val, path);
 	} else if (sub->update_strategy.type != SM_UPDATE_UNSPECIFIED) {
-		trace_printf("loaded thing");
 		out->type = sub->update_strategy.type;
 		out->command = sub->update_strategy.command;
 	} else

Signature · 1 line

2.19.0

Jonathan Nieder

Reviewed-by on v1 1/1

2018-10-17 02:52 UTC #1 lore raw

Quoted 10 lines · Stefan Beller

I noticed 74d4731da1 (submodule--helper: replace connect-gitdir-workingtree by ensure-core-worktree, 2018-08-13) had two leftover debugging statements when reading The coverage report [1]. Remove them.
https://public-inbox.org/git/[email protected]/
Signed-off-by Stefan Beller <[email protected]>
---
 builtin/submodule--helper.c | 2 --
 1 file changed, 2 deletions(-)

Doh. Glad you caught it!

Is there some reference for The Coverage Report other than the mailing list? E.g. I suspect a reference to

make coverage-test
make coverage-report

would be useful to readers finding this commit later.

Quoted 2 lines

To be applied on (or squashed into the tip of)
sb/submodule-update-in-c

Looks like that's already in "master", so not a candidate for squashing.

Reviewed-by Jonathan Nieder <[email protected]>