Input: xen-kbdfront - mark expected switch fall-through
Subsystems (2)
PATCH 1/1 Input: xen-kbdfront - mark expected switch fall-through
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
Notice that in this particular case, I placed the "fall through" part at the beginning of the code comment, which is what GCC is expecting to find.
Addresses-Coverity-ID: 114757 ("Missing break in switch")
Signed-off-by Gustavo A. R. Silva <[email protected]>
--- drivers/input/misc/xen-kbdfront.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/input/misc/xen-kbdfront.c +1 -1
@@ -524,7 +524,7 @@ static void xenkbd_backend_changed(struct xenbus_device *dev,case XenbusStateClosed:if (dev->state == XenbusStateClosed)break ; -/* Missed the backend's CLOSING state -- fallthrough */ +/* fall through - Missed the backend's CLOSING state */ case XenbusStateClosing:xenbus_frontend_closed (dev);break ;
Signature · 1 line
2.7.4
Quoted 9 lines · Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
Notice that in this particular case, I placed the "fall through" part at the beginning of the code comment, which is what GCC is expecting to find.
Addresses-Coverity-ID: 114757 ("Missing break in switch")
Signed-off-by Gustavo A. R. Silva <[email protected]>
Applied, thank you.
Quoted 20 lines
--- drivers/input/misc/xen-kbdfront.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/input/misc/xen-kbdfront.c +1
-1@@ -524,7 +524,7 @@ static void xenkbd_backend_changed(struct xenbus_device *dev,case XenbusStateClosed:if (dev->state == XenbusStateClosed)break ; -/* Missed the backend's CLOSING state -- fallthrough */ +/* fall through - Missed the backend's CLOSING state */ case XenbusStateClosing:xenbus_frontend_closed (dev);break ;Signature · 1 line
2.7.4
Signature · 1 line
Dmitry