Update release notes for container power policies
PATCH 1/1 Update release notes for container power policies
--- doc/guides/rel_notes/release_18_11.rst | 7 +++++++ 1 file changed, 7 insertions(+)
doc/guides/rel_notes/release_18_11.rst +7 -0
@@ -88,6 +88,13 @@ New Features the specified port. The port must be stopped before the command call in order to reconfigure queues. +* **Added JSON power policy interface for containers .** + + Extended the Power Library and vm_power_manger sample app to allow power + policies to be submitted via a FIFO using JSON formatted strings. Previously + limited to Virtual Machines, this feature extends power policy functionality + to containers and host applications that need to have their cores frequency + controlled based on the rules contained in the policy. API Changes -----------
Signature · 1 line
2.17.1
17/10/2018 13:23, David Hunt:
Quoted 4 lines
Signed-off-by David Hunt <[email protected]>--- doc/guides/rel_notes/release_18_11.rst | 7 +++++++ 1 file changed, 7 insertions(+)
Why this patch is alone? It is for a change already applied? If you forgot the release notes, you should add a Fixes: line so we know which code change it refers.
Thanks
Quoted 8 lines
doc/guides/rel_notes/release_18_11.rst +0
-0@@ -88,6 +88,13 @@ New Features the specified port. The port must be stopped before the command call in order to reconfigure queues.
doc/guides/rel_notes/release_18_11.rst New Features · line 100
Quoted 10 lines
doc/guides/rel_notes/release_18_11.rst +7
-0+* **Added JSON power policy interface for containers .** + + Extended the Power Library and vm_power_manger sample app to allow power + policies to be submitted via a FIFO using JSON formatted strings. Previously + limited to Virtual Machines, this feature extends power policy functionality + to containers and host applications that need to have their cores frequency + controlled based on the rules contained in the policy. API Changes -----------
You must keep a double blank line before before next heading.
Anyway you should move it before testpmd note, as explained in the comment:
Suggested order in release notes items:
* Core libs (EAL, mempool, ring, mbuf, buses)
* Device abstraction libs and PMDs
- ethdev (lib, PMDs)
- cryptodev (lib, PMDs)
- eventdev (lib, PMDs)
- etc
* Other libs
* Apps, Examples, Tools (if significative)
Hi Thomas,
Quoted 9 lines · Thomas Monjalon
17/10/2018 13:23, David Hunt:
Quoted 4 lines
Signed-off-by David Hunt <[email protected]>--- doc/guides/rel_notes/release_18_11.rst | 7 +++++++ 1 file changed, 7 insertions(+)Why this patch is alone? It is for a change already applied? If you forgot the release notes, you should add a Fixes: line so we know which code change it refers.
Thanks
The related patch set is not merged yet, so I could not add a Fixes: line. This is in reference to one of the patch sets I mentioned in an email to you yesterday.
http://patches.dpdk.org/project/dpdk/list/?series=1628
Quoted 20 lines
Quoted 8 lines
doc/guides/rel_notes/release_18_11.rst +0
-0@@ -88,6 +88,13 @@ New Features the specified port. The port must be stopped before the command call in order to reconfigure queues.doc/guides/rel_notes/release_18_11.rst New Features · line 100
Quoted 10 lines
doc/guides/rel_notes/release_18_11.rst +7
-0+* **Added JSON power policy interface for containers .** + + Extended the Power Library and vm_power_manger sample app to allow power + policies to be submitted via a FIFO using JSON formatted strings. Previously + limited to Virtual Machines, this feature extends power policy functionality + to containers and host applications that need to have their cores frequency + controlled based on the rules contained in the policy. API Changes -----------You must keep a double blank line before before next heading.
Quoted 12 lines
Anyway you should move it before testpmd note, as explained in the comment:
Suggested order in release notes items:
* Core libs (EAL, mempool, ring, mbuf, buses)
* Device abstraction libs and PMDs
- ethdev (lib, PMDs)
- cryptodev (lib, PMDs)
- eventdev (lib, PMDs)
- etc
* Other libs
* Apps, Examples, Tools (if significative)
I can hold off uploading a v2 of this patch until the main patch set is merged? Then I can add in a Fixes: line and make your suggested changes.
Regards,
Dave.
Hunt, David:
Quoted 49 lines · Thomas Monjalon
Quoted 9 lines
17/10/2018 13:23, David Hunt:
Quoted 4 lines
Signed-off-by David Hunt <[email protected]>--- doc/guides/rel_notes/release_18_11.rst | 7 +++++++ 1 file changed, 7 insertions(+)Why this patch is alone? It is for a change already applied? If you forgot the release notes, you should add a Fixes: line so we know which code change it refers.
ThanksThe related patch set is not merged yet, so I could not add a Fixes: line. This is in reference to one of the patch sets I mentioned in an email to you yesterday.
http://patches.dpdk.org/project/dpdk/list/?series=1628Quoted 20 lines
Quoted 8 lines
doc/guides/rel_notes/release_18_11.rst +0
-0@@ -88,6 +88,13 @@ New Features the specified port. The port must be stopped before the command call in order to reconfigure queues.doc/guides/rel_notes/release_18_11.rst New Features · line 100
Quoted 10 lines
doc/guides/rel_notes/release_18_11.rst +7
-0+* **Added JSON power policy interface for containers .** + + Extended the Power Library and vm_power_manger sample app to allow power + policies to be submitted via a FIFO using JSON formatted strings. Previously + limited to Virtual Machines, this feature extends power policy functionality + to containers and host applications that need to have their cores frequency + controlled based on the rules contained in the policy. API Changes -----------You must keep a double blank line before before next heading.
Quoted 11 lines
Anyway you should move it before testpmd note, as explained in the comment:
Suggested order in release notes items:
* Core libs (EAL, mempool, ring, mbuf, buses)
* Device abstraction libs and PMDs
- ethdev (lib, PMDs)
- cryptodev (lib, PMDs)
- eventdev (lib, PMDs)
- etc
* Other libs
* Apps, Examples, Tools (if significative)
Quoted 3 lines
I can hold off uploading a v2 of this patch until the main patch set is merged? Then I can
add in a Fixes: line and make your suggested changes.
In this case, it is a lot better to integrate it with one of the patches of your series, maybe with the doc patch?
Quoted 48 lines · Thomas Monjalon
Hunt, David:
Quoted 47 lines · Thomas Monjalon
Quoted 9 lines
17/10/2018 13:23, David Hunt:
Quoted 4 lines
Signed-off-by David Hunt <[email protected]>--- doc/guides/rel_notes/release_18_11.rst | 7 +++++++ 1 file changed, 7 insertions(+)Why this patch is alone? It is for a change already applied? If you forgot the release notes, you should add a Fixes: line so we know which code change it refers.
ThanksThe related patch set is not merged yet, so I could not add a Fixes: line. This is in reference to one of the patch sets I mentioned in an email to you yesterday.
http://patches.dpdk.org/project/dpdk/list/?series=1628Quoted 31 lines
Quoted 8 lines
doc/guides/rel_notes/release_18_11.rst +0
-0@@ -88,6 +88,13 @@ New Features the specified port. The port must be stopped before the command call in order to reconfigure queues.doc/guides/rel_notes/release_18_11.rst New Features · line 100
Quoted 10 lines
doc/guides/rel_notes/release_18_11.rst +7
-0+* **Added JSON power policy interface for containers .** + + Extended the Power Library and vm_power_manger sample app to allow power + policies to be submitted via a FIFO using JSON formatted strings. Previously + limited to Virtual Machines, this feature extends power policy functionality + to containers and host applications that need to have their cores frequency + controlled based on the rules contained in the policy. API Changes -----------You must keep a double blank line before before next heading.
Anyway you should move it before testpmd note, as explained in the comment:
Suggested order in release notes items:
* Core libs (EAL, mempool, ring, mbuf, buses)
* Device abstraction libs and PMDs
- ethdev (lib, PMDs)
- cryptodev (lib, PMDs)
- eventdev (lib, PMDs)
- etc
* Other libs
* Apps, Examples, Tools (if significative)
Quoted 5 lines
Quoted 3 lines
I can hold off uploading a v2 of this patch until the main patch set is merged? Then I can
add in a Fixes: line and make your suggested changes.In this case, it is a lot better to integrate it with one of the patches of your series, maybe with the doc patch?
Sure. Sounds like the best option. I'll upload shortly.
Thanks,
Dave.