Skip to contentSkip to conversation

scripts/gdb: fix lx-version

PATCH In review Du Changbin 3 participants 3 messages Oct 17, 2018 – Nov 5, 2018 GDB kernel debugging helper scripts

lore
Share & tools
lore

Du Changbin

author
#0 lore raw

PATCH v3 1/1 scripts/gdb: fix lx-version

For current gdb version (has tested with 7.3 and 8.1), 'lx-version' only prints one character.
(gdb) lx-version
L(gdb)

This can be fixed by casting 'linux_banner' as (char *).
(gdb) lx-version
Linux version 4.19.0-rc1+ (changbin@acer) (gcc version 7.3.0 (Ubuntu 7.3.0-16ubuntu3)) #21 SMP Sat Sep 1 21:43:30 CST 2018

Signed-off-by Du Changbin <[email protected]>
---
 scripts/gdb/linux/proc.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/gdb/linux/proc.py +1 -1
index 086d27223c0c..0aebd7565b03 100644
@@ -41,7 +41,7 @@ class LxVersion(gdb.Command):
 
     def invoke(self, arg, from_tty):
         # linux_banner should contain a newline
-        gdb.write(gdb.parse_and_eval("linux_banner").string())
+        gdb.write(gdb.parse_and_eval("(char *)linux_banner").string())
 
 LxVersion()
Signature · 1 line
2.17.1
Reviewed-by on v3 1/1
#1 lore raw

Hi Du,

Thank you for the updated patch,

Quoted 10 lines · Du Changbin

For current gdb version (has tested with 7.3 and 8.1), 'lx-version' only prints one character.
(gdb) lx-version
L(gdb)

This can be fixed by casting 'linux_banner' as (char *).
(gdb) lx-version
Linux version 4.19.0-rc1+ (changbin@acer) (gcc version 7.3.0 (Ubuntu 7.3.0-16ubuntu3)) #21 SMP Sat Sep 1 21:43:30 CST 2018

Signed-off-by Du Changbin <[email protected]>

I'll update the upstream GDB bugzilla [0] regarding this issue - but I think we need a workaround here, and this is it.

Fixes 2d061d999424 ("scripts/gdb: add version command")
Reviewed-by Kieran Bingham <[email protected]>

And for reference, this already has an early LGTM from Jan as well.

[0] https://sourceware.org/bugzilla/show_bug.cgi?id=20077

Quoted 16 lines
---
 scripts/gdb/linux/proc.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/gdb/linux/proc.py +1 -1
index 086d27223c0c..0aebd7565b03 100644
@@ -41,7 +41,7 @@ class LxVersion(gdb.Command):
 
     def invoke(self, arg, from_tty):
         # linux_banner should contain a newline
-        gdb.write(gdb.parse_and_eval("linux_banner").string())
+        gdb.write(gdb.parse_and_eval("(char *)linux_banner").string())
 
 LxVersion()
Signature · 3 lines
Regards
--
Kieran
maintainer Acked-by
#2 lore raw
Quoted 19 lines · Kieran Bingham

Hi Du,

Thank you for the updated patch,

Quoted 10 lines · Du Changbin

For current gdb version (has tested with 7.3 and 8.1), 'lx-version' only prints one character.
(gdb) lx-version
L(gdb)

This can be fixed by casting 'linux_banner' as (char *).
(gdb) lx-version
Linux version 4.19.0-rc1+ (changbin@acer) (gcc version 7.3.0 (Ubuntu 7.3.0-16ubuntu3)) #21 SMP Sat Sep 1 21:43:30 CST 2018

Signed-off-by Du Changbin <[email protected]>

I'll update the upstream GDB bugzilla [0] regarding this issue - but I think we need a workaround here, and this is it.

Quoted 7 lines
Fixes 2d061d999424 ("scripts/gdb: add version command")
Reviewed-by Kieran Bingham <[email protected]>

And for reference, this already has an early LGTM from Jan as well.

[0] https://sourceware.org/bugzilla/show_bug.cgi?id=20077

Acked-by Jan Kiszka <[email protected]>

Jan

Quoted 18 lines
Quoted 16 lines
---
  scripts/gdb/linux/proc.py | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
scripts/gdb/linux/proc.py +1 -1
index 086d27223c0c..0aebd7565b03 100644
@@ -41,7 +41,7 @@ class LxVersion(gdb.Command):
 
      def invoke(self, arg, from_tty):
          # linux_banner should contain a newline
-        gdb.write(gdb.parse_and_eval("linux_banner").string())
+        gdb.write(gdb.parse_and_eval("(char *)linux_banner").string())
 
  LxVersion()
Signature · 2 lines
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux