Skip to contentSkip to conversation

powerpc: Add missing include <asm/stacktrace.h>

PATCH In review Mathieu Malaterre 2 participants 3 messages Oct 17, 2018 – Oct 18, 2018 PowerPC

lore
Share & tools
lore

Mathieu Malaterre

author
#0 lore raw

PATCH 1/1 powerpc: Add missing include <asm/stacktrace.h>

In commit 88b0fe175735 ("powerpc: Add show_user_instructions()") the function show_user_instructions was added.

This commit adds an include of header file <asm/stacktrace.h> to provide the missing function prototype. Silence the following gcc warning (treated as error with W=1):

arch/powerpc/kernel/process.c:1302:6: error: no previous prototype for ‘show_user_instructions’ [-Werror=missing-prototypes]

Signed-off-by Mathieu Malaterre <[email protected]>
---
 arch/powerpc/kernel/process.c | 1 +
 1 file changed, 1 insertion(+)
arch/powerpc/kernel/process.c +1 -0
index bb6ac471a784..1c64491e9702 100644
@@ -65,6 +65,7 @@
 #include <asm/livepatch.h>
 #include <asm/cpu_has_feature.h>
 #include <asm/asm-prototypes.h>
+#include <asm/stacktrace.h>
 
 #include <linux/kprobes.h>
 #include <linux/kdebug.h>
Signature · 1 line
2.11.0
#1 lore raw

Le 17/10/2018 à 21:25, Mathieu Malaterre a écrit :

Quoted 10 lines

In commit 88b0fe175735 ("powerpc: Add show_user_instructions()") the function show_user_instructions was added.

This commit adds an include of header file <asm/stacktrace.h> to provide the missing function prototype. Silence the following gcc warning (treated as error with W=1):

arch/powerpc/kernel/process.c:1302:6: error: no previous prototype for ‘show_user_instructions’ [-Werror=missing-prototypes]

Signed-off-by Mathieu Malaterre <[email protected]>

This is already fixed, see https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=c9386bfd37d37f29588de9ea9add455510049c33

Christophe

Quoted 17 lines
---
  arch/powerpc/kernel/process.c | 1 +
  1 file changed, 1 insertion(+)
arch/powerpc/kernel/process.c +1 -0
index bb6ac471a784..1c64491e9702 100644
@@ -65,6 +65,7 @@
  #include <asm/livepatch.h>
  #include <asm/cpu_has_feature.h>
  #include <asm/asm-prototypes.h>
+#include <asm/stacktrace.h>
 
  #include <linux/kprobes.h>
  #include <linux/kdebug.h>
author
#2 lore raw
Quoted 11 lines · Christophe LEROY
Quoted 7 lines · Mathieu Malaterre

In commit 88b0fe175735 ("powerpc: Add show_user_instructions()") the function show_user_instructions was added.

This commit adds an include of header file <asm/stacktrace.h> to provide the missing function prototype. Silence the following gcc warning (treated as error with W=1):

Quoted 6 lines
Quoted 3 lines

arch/powerpc/kernel/process.c:1302:6: error: no previous prototype for ‘show_user_instructions’ [-Werror=missing-prototypes]

Signed-off-by Mathieu Malaterre <[email protected]>

This is already fixed, see
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=c9386bfd37d37f29588de9ea9add455510049c33

Excellent !

Sorry for the noise :(

Quoted 19 lines

Christophe

Quoted 17 lines
---
  arch/powerpc/kernel/process.c | 1 +
  1 file changed, 1 insertion(+)
arch/powerpc/kernel/process.c +1 -0
index bb6ac471a784..1c64491e9702 100644
@@ -65,6 +65,7 @@
  #include <asm/livepatch.h>
  #include <asm/cpu_has_feature.h>
  #include <asm/asm-prototypes.h>
+#include <asm/stacktrace.h>
 
  #include <linux/kprobes.h>
  #include <linux/kdebug.h>