Analogix ANX6345 RGB-(e)DP bridge support
Subsystems (7)
cover Analogix ANX6345 RGB-(e)DP bridge support
This patchset brings the support for Analogix ANX6345 RGB-(e)DP bridge, which is used by some Allwinner A64 laptops, such as Pinebook and Olimex TERES-I.
It reuses some definitions from the ANX78xx driver that already exists in the kernel tree, but the driver code itself is rewritten, because the big difference between ANX6345 and ANX78xx.
This patchset also enables the bridge on Pinebook and TERES-I, and a temporary workaround patch (do not merge) for the dot clock accuracy problem of sun4i-drm.
This patchset assumes some fixes ([1], [2] and [3]) are already applied, without them the patchset cannot be tested on the A64 devices mentioned above.
[1] https://patchwork.kernel.org/patch/10628827/
[2] https://patchwork.kernel.org/patch/10628825/
[3] https://patchwork.kernel.org/patch/10646791/
Chen-Yu Tsai (1):
[DO NOT MERGE] drm/sun4i: rgb: Add 5% tolerance to dot clock frequency
check
Icenowy Zheng (8):
drm/bridge: move ANA78xx driver to analogix subdirectory drm/bridge: split some definitions of ANX78xx to dedicated headers drm/bridge: extract some Analogix I2C DP common code
dt-bindings: Add ANX6345 DP/eDP transmitter binding drm/bridge: Add Analogix anx6345 support
arm64: allwinner: a64: add pinmux for RGB666 LCD
arm64: allwinner: a64: enable ANX6345 bridge on Pinebook
arm64: allwinner: a64: enable ANX6345 bridge on TERES-I
.../bindings/display/bridge/anx6345.txt | 39 +
.../dts/allwinner/sun50i-a64-pinebook.dts | 43 +
.../boot/dts/allwinner/sun50i-a64-teres-i.dts | 40 +-
arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 9 +
drivers/gpu/drm/bridge/Kconfig | 10 -
drivers/gpu/drm/bridge/Makefile | 4 +-
drivers/gpu/drm/bridge/analogix-anx78xx.h | 719 ---------------
drivers/gpu/drm/bridge/analogix/Kconfig | 25 +
drivers/gpu/drm/bridge/analogix/Makefile | 4 +
.../drm/bridge/analogix/analogix-anx6345.c | 862 ++++++++++++++++++
.../bridge/{ => analogix}/analogix-anx78xx.c | 146 +--
.../drm/bridge/analogix/analogix-anx78xx.h | 265 ++++++
.../drm/bridge/analogix/analogix-i2c-dptx.c | 169 ++++
.../drm/bridge/analogix/analogix-i2c-dptx.h | 258 ++++++
.../bridge/analogix/analogix-i2c-txcommon.h | 240 +++++
drivers/gpu/drm/sun4i/sun4i_rgb.c | 5 +-
16 files changed, 1956 insertions(+), 882 deletions(-)
create mode 100644 Documentation/devicetree/bindings/display/bridge/anx6345.txt
delete mode 100644 drivers/gpu/drm/bridge/analogix-anx78xx.h
create mode 100644 drivers/gpu/drm/bridge/analogix/analogix-anx6345.c
rename drivers/gpu/drm/bridge/{ => analogix}/analogix-anx78xx.c (90%)
create mode 100644 drivers/gpu/drm/bridge/analogix/analogix-anx78xx.h
create mode 100644 drivers/gpu/drm/bridge/analogix/analogix-i2c-dptx.c
create mode 100644 drivers/gpu/drm/bridge/analogix/analogix-i2c-dptx.h
create mode 100644 drivers/gpu/drm/bridge/analogix/analogix-i2c-txcommon.hSignature · 1 line
2.18.1
PATCH 1/9 drm/bridge: move ANA78xx driver to analogix subdirectory
As ANA78xx chips are designed and produced by Analogix Semiconductor, Inc, move their driver codes into analogix subdirectory.
---
drivers/gpu/drm/bridge/Kconfig | 10 ----------
drivers/gpu/drm/bridge/Makefile | 4 ++--
drivers/gpu/drm/bridge/analogix/Kconfig | 10 ++++++++++
drivers/gpu/drm/bridge/analogix/Makefile | 1 +
.../gpu/drm/bridge/{ => analogix}/analogix-anx78xx.c | 0
.../gpu/drm/bridge/{ => analogix}/analogix-anx78xx.h | 0
6 files changed, 13 insertions(+), 12 deletions(-)
rename drivers/gpu/drm/bridge/{ => analogix}/analogix-anx78xx.c (100%)
rename drivers/gpu/drm/bridge/{ => analogix}/analogix-anx78xx.h (100%)drivers/gpu/drm/bridge/Kconfig +0 -10
@@ -15,16 +15,6 @@ config DRM_PANEL_BRIDGE menu "Display Interface Bridges" depends on DRM && DRM_BRIDGE -config DRM_ANALOGIX_ANX78XX - tristate "Analogix ANX78XX bridge" - select DRM_KMS_HELPER - select REGMAP_I2C - ---help--- - ANX78XX is an ultra-low Full-HD SlimPort transmitter - designed for portable devices. The ANX78XX transforms - the HDMI output of an application processor to MyDP - or DisplayPort. - config DRM_CDNS_DSI tristate "Cadence DPI/DSI bridge" select DRM_KMS_HELPER
drivers/gpu/drm/bridge/Makefile +2 -2
@@ -1,5 +1,4 @@ # SPDX-License-Identifier: GPL-2.0 -obj-$(CONFIG_DRM_ANALOGIX_ANX78XX) += analogix-anx78xx.o obj-$(CONFIG_DRM_CDNS_DSI) += cdns-dsi.o obj-$(CONFIG_DRM_DUMB_VGA_DAC) += dumb-vga-dac.o obj-$(CONFIG_DRM_LVDS_ENCODER) += lvds-encoder.o
@@ -12,8 +11,9 @@ obj-$(CONFIG_DRM_SII9234) += sii9234.o obj-$(CONFIG_DRM_THINE_THC63LVD1024) += thc63lvd1024.o obj-$(CONFIG_DRM_TOSHIBA_TC358764) += tc358764.o obj-$(CONFIG_DRM_TOSHIBA_TC358767) += tc358767.o -obj-$(CONFIG_DRM_ANALOGIX_DP) += analogix/ obj-$(CONFIG_DRM_I2C_ADV7511) += adv7511/ obj-$(CONFIG_DRM_TI_SN65DSI86) += ti-sn65dsi86.o obj-$(CONFIG_DRM_TI_TFP410) += ti-tfp410.o + +obj-y += analogix/ obj-y += synopsys/
drivers/gpu/drm/bridge/analogix/Kconfig +10 -0
@@ -1,3 +1,13 @@ config DRM_ANALOGIX_DP tristate depends on DRM + +config DRM_ANALOGIX_ANX78XX + tristate "Analogix ANX78XX bridge" + select DRM_KMS_HELPER + select REGMAP_I2C + ---help--- + ANX78XX is an ultra-low Full-HD SlimPort transmitter + designed for portable devices. The ANX78XX transforms + the HDMI output of an application processor to MyDP + or DisplayPort.
drivers/gpu/drm/bridge/analogix/Makefile +1 -0
@@ -1,2 +1,3 @@ analogix_dp-objs := analogix_dp_core.o analogix_dp_reg.o obj-$(CONFIG_DRM_ANALOGIX_DP) += analogix_dp.o +obj-$(CONFIG_DRM_ANALOGIX_ANX78XX) += analogix-anx78xx.o
drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c renamed from drivers/gpu/drm/bridge/analogix-anx78xx.c +0 -0
drivers/gpu/drm/bridge/analogix/analogix-anx78xx.h renamed from drivers/gpu/drm/bridge/analogix-anx78xx.h +0 -0
Signature · 1 line
2.18.1
Re: [PATCH 1/9] drm/bridge: move ANA78xx driver to analogix subdirectory
Hi Icenowy,
Thank you for the patch.
Quoted 82 lines · On Thursday, 18 October 2018 10:33:19 EEST Icenowy Zheng wrote:
As ANA78xx chips are designed and produced by Analogix Semiconductor, Inc, move their driver codes into analogix subdirectory.
Signed-off-by Icenowy Zheng <[email protected]>--- drivers/gpu/drm/bridge/Kconfig | 10 ---------- drivers/gpu/drm/bridge/Makefile | 4 ++-- drivers/gpu/drm/bridge/analogix/Kconfig | 10 ++++++++++ drivers/gpu/drm/bridge/analogix/Makefile | 1 + .../gpu/drm/bridge/{ => analogix}/analogix-anx78xx.c | 0 .../gpu/drm/bridge/{ => analogix}/analogix-anx78xx.h | 0 6 files changed, 13 insertions(+), 12 deletions(-) rename drivers/gpu/drm/bridge/{ => analogix}/analogix-anx78xx.c (100%) rename drivers/gpu/drm/bridge/{ => analogix}/analogix-anx78xx.h (100%)drivers/gpu/drm/bridge/Kconfig +0
-10@@ -15,16 +15,6 @@ config DRM_PANEL_BRIDGE menu "Display Interface Bridges" depends on DRM && DRM_BRIDGE -config DRM_ANALOGIX_ANX78XX - tristate "Analogix ANX78XX bridge" - select DRM_KMS_HELPER - select REGMAP_I2C - ---help--- - ANX78XX is an ultra-low Full-HD SlimPort transmitter - designed for portable devices. The ANX78XX transforms - the HDMI output of an application processor to MyDP - or DisplayPort. - config DRM_CDNS_DSI tristate "Cadence DPI/DSI bridge" select DRM_KMS_HELPER(quoted diff) +0
-0b/drivers/gpu/drm/bridge/Makefile index
4934fcf5a6f8..a6c7dd7727ea100644drivers/gpu/drm/bridge/Makefile +2
-2@@ -1,5 +1,4 @@ # SPDX-License-Identifier: GPL-2.0 -obj-$(CONFIG_DRM_ANALOGIX_ANX78XX) += analogix-anx78xx.o obj-$(CONFIG_DRM_CDNS_DSI) += cdns-dsi.o obj-$(CONFIG_DRM_DUMB_VGA_DAC) += dumb-vga-dac.o obj-$(CONFIG_DRM_LVDS_ENCODER) += lvds-encoder.o@@ -12,8 +11,9 @@ obj-$(CONFIG_DRM_SII9234) += sii9234.o obj-$(CONFIG_DRM_THINE_THC63LVD1024) += thc63lvd1024.o obj-$(CONFIG_DRM_TOSHIBA_TC358764) += tc358764.o obj-$(CONFIG_DRM_TOSHIBA_TC358767) += tc358767.o -obj-$(CONFIG_DRM_ANALOGIX_DP) += analogix/ obj-$(CONFIG_DRM_I2C_ADV7511) += adv7511/ obj-$(CONFIG_DRM_TI_SN65DSI86) += ti-sn65dsi86.o obj-$(CONFIG_DRM_TI_TFP410) += ti-tfp410.o + +obj-y += analogix/ obj-y += synopsys/(quoted diff) +0
-0b/drivers/gpu/drm/bridge/analogix/Kconfig index
80f286fa3a69..27b37aa2ea77100644drivers/gpu/drm/bridge/analogix/Kconfig +10
-0@@ -1,3 +1,13 @@ config DRM_ANALOGIX_DP tristate depends on DRM + +config DRM_ANALOGIX_ANX78XX + tristate "Analogix ANX78XX bridge" + select DRM_KMS_HELPER + select REGMAP_I2C + ---help--- + ANX78XX is an ultra-low Full-HD SlimPort transmitter + designed for portable devices. The ANX78XX transforms + the HDMI output of an application processor to MyDP + or DisplayPort.(quoted diff) +0
-0b/drivers/gpu/drm/bridge/analogix/Makefile index
cd4010ba6890..eb41be845055100644
drivers/gpu/drm/bridge/analogix/Makefile line 3
Quoted 3 lines
drivers/gpu/drm/bridge/analogix/Makefile +1
-0@@ -1,2 +1,3 @@ analogix_dp-objs := analogix_dp_core.o analogix_dp_reg.o obj-$(CONFIG_DRM_ANALOGIX_DP) += analogix_dp.o +obj-$(CONFIG_DRM_ANALOGIX_ANX78XX) += analogix-anx78xx.o
This makes sense to me. I would have tried to keep the Kconfig and Makefile entries alphabetically sorted, but that's not a big deal. With or without the sorting,
Quoted 8 lines
(quoted diff) +0
-0
b/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.csimilarity index 100% rename fromdrivers/gpu/drm/bridge/analogix-anx78xx.c
rename todrivers/gpu/drm/bridge/analogix/analogix-anx78xx.c(quoted diff) +0
-0
b/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.hsimilarity index 100% rename fromdrivers/gpu/drm/bridge/analogix-anx78xx.h
rename todrivers/gpu/drm/bridge/analogix/analogix-anx78xx.h
Signature · 3 lines
Regards, Laurent Pinchart
PATCH 2/9 drm/bridge: split some definitions of ANX78xx to dedicated headers
In reply to Icenowy ZhengSome definitions currently in analogix-anx78xx.h are not restricted to the ANX78xx series, but also applicable to other DisplayPort transmitters by Analogix.
Split out them to dedicated headers, and make analogix-anx78xx.h include them.
--- .../drm/bridge/analogix/analogix-anx78xx.h | 464 +----------------- .../drm/bridge/analogix/analogix-i2c-dptx.h | 248 ++++++++++ .../bridge/analogix/analogix-i2c-txcommon.h | 237 +++++++++ 3 files changed, 490 insertions(+), 459 deletions(-) create mode 100644 drivers/gpu/drm/bridge/analogix/analogix-i2c-dptx.h create mode 100644 drivers/gpu/drm/bridge/analogix/analogix-i2c-txcommon.h
drivers/gpu/drm/bridge/analogix/analogix-anx78xx.h +5 -459
@@ -15,9 +15,12 @@#ifndef __ANX78xx_H#define __ANX78xx_H -#define TX_P0 0x70 +#include "analogix-i2c-dptx.h" +#include "analogix-i2c-txcommon.h" + +#define TX_P0 ANALOGIX_I2C_DPTX#define TX_P1 0x7a -#define TX_P2 0x72 +#define TX_P2 ANALOGIX_I2C_TXCOMMON#define RX_P0 0x7e#define RX_P1 0x80
@@ -225,463 +228,6 @@#define SP_CLEAR_AVMUTE BIT(4)#define SP_SET_AVMUTE BIT(0) -/***************************************************************/ -/* Register definition of device address 0x70 */ -/***************************************************************/ - -/* HDCP Status Register */ -#define SP_TX_HDCP_STATUS_REG 0x00 -#define SP_AUTH_FAIL BIT(5) -#define SP_AUTHEN_PASS BIT(1) - -/* HDCP Control Register 0 */ -#define SP_HDCP_CTRL0_REG 0x01 -#define SP_RX_REPEATER BIT(6) -#define SP_RE_AUTH BIT(5) -#define SP_SW_AUTH_OK BIT(4) -#define SP_HARD_AUTH_EN BIT(3) -#define SP_HDCP_ENC_EN BIT(2) -#define SP_BKSV_SRM_PASS BIT(1) -#define SP_KSVLIST_VLD BIT(0) -/* HDCP Function Enabled */ -#define SP_HDCP_FUNCTION_ENABLED (BIT(0) | BIT(1) | BIT(2) | BIT(3)) - -/* HDCP Receiver BSTATUS Register 0 */ -#define SP_HDCP_RX_BSTATUS0_REG 0x1b -/* HDCP Receiver BSTATUS Register 1 */ -#define SP_HDCP_RX_BSTATUS1_REG 0x1c - -/* HDCP Embedded "Blue Screen" Content Registers */ -#define SP_HDCP_VID0_BLUE_SCREEN_REG 0x2c -#define SP_HDCP_VID1_BLUE_SCREEN_REG 0x2d -#define SP_HDCP_VID2_BLUE_SCREEN_REG 0x2e - -/* HDCP Wait R0 Timing Register */ -#define SP_HDCP_WAIT_R0_TIME_REG 0x40 - -/* HDCP Link Integrity Check Timer Register */ -#define SP_HDCP_LINK_CHECK_TIMER_REG 0x41 - -/* HDCP Repeater Ready Wait Timer Register */ -#define SP_HDCP_RPTR_RDY_WAIT_TIME_REG 0x42 - -/* HDCP Auto Timer Register */ -#define SP_HDCP_AUTO_TIMER_REG 0x51 - -/* HDCP Key Status Register */ -#define SP_HDCP_KEY_STATUS_REG 0x5e - -/* HDCP Key Command Register */ -#define SP_HDCP_KEY_COMMAND_REG 0x5f -#define SP_DISABLE_SYNC_HDCP BIT(2) - -/* OTP Memory Key Protection Registers */ -#define SP_OTP_KEY_PROTECT1_REG 0x60 -#define SP_OTP_KEY_PROTECT2_REG 0x61 -#define SP_OTP_KEY_PROTECT3_REG 0x62 -#define SP_OTP_PSW1 0xa2 -#define SP_OTP_PSW2 0x7e -#define SP_OTP_PSW3 0xc6 - -/* DP System Control Registers */ -#define SP_DP_SYSTEM_CTRL_BASE (0x80 - 1) -/* Bits for DP System Control Register 2 */ -#define SP_CHA_STA BIT(2) -/* Bits for DP System Control Register 3 */ -#define SP_HPD_STATUS BIT(6) -#define SP_STRM_VALID BIT(2) -/* Bits for DP System Control Register 4 */ -#define SP_ENHANCED_MODE BIT(3) - -/* DP Video Control Register */ -#define SP_DP_VIDEO_CTRL_REG 0x84 -#define SP_COLOR_F_MASK 0x06 -#define SP_COLOR_F_SHIFT 1 -#define SP_BPC_MASK 0xe0 -#define SP_BPC_SHIFT 5 -# define SP_BPC_6BITS 0x00 -# define SP_BPC_8BITS 0x01 -# define SP_BPC_10BITS 0x02 -# define SP_BPC_12BITS 0x03 - -/* DP Audio Control Register */ -#define SP_DP_AUDIO_CTRL_REG 0x87 -#define SP_AUD_EN BIT(0) - -/* 10us Pulse Generate Timer Registers */ -#define SP_I2C_GEN_10US_TIMER0_REG 0x88 -#define SP_I2C_GEN_10US_TIMER1_REG 0x89 - -/* Packet Send Control Register */ -#define SP_PACKET_SEND_CTRL_REG 0x90 -#define SP_AUD_IF_UP BIT(7) -#define SP_AVI_IF_UD BIT(6) -#define SP_MPEG_IF_UD BIT(5) -#define SP_SPD_IF_UD BIT(4) -#define SP_AUD_IF_EN BIT(3) -#define SP_AVI_IF_EN BIT(2) -#define SP_MPEG_IF_EN BIT(1) -#define SP_SPD_IF_EN BIT(0) - -/* DP HDCP Control Register */ -#define SP_DP_HDCP_CTRL_REG 0x92 -#define SP_AUTO_EN BIT(7) -#define SP_AUTO_START BIT(5) -#define SP_LINK_POLLING BIT(1) - -/* DP Main Link Bandwidth Setting Register */ -#define SP_DP_MAIN_LINK_BW_SET_REG 0xa0 -#define SP_LINK_BW_SET_MASK 0x1f -#define SP_INITIAL_SLIM_M_AUD_SEL BIT(5) - -/* DP Training Pattern Set Register */ -#define SP_DP_TRAINING_PATTERN_SET_REG 0xa2 - -/* DP Lane 0 Link Training Control Register */ -#define SP_DP_LANE0_LT_CTRL_REG 0xa3 -#define SP_TX_SW_SET_MASK 0x1b -#define SP_MAX_PRE_REACH BIT(5) -#define SP_MAX_DRIVE_REACH BIT(4) -#define SP_PRE_EMP_LEVEL1 BIT(3) -#define SP_DRVIE_CURRENT_LEVEL1 BIT(0) - -/* DP Link Training Control Register */ -#define SP_DP_LT_CTRL_REG 0xa8 -#define SP_LT_ERROR_TYPE_MASK 0x70 -# define SP_LT_NO_ERROR 0x00 -# define SP_LT_AUX_WRITE_ERROR 0x01 -# define SP_LT_MAX_DRIVE_REACHED 0x02 -# define SP_LT_WRONG_LANE_COUNT_SET 0x03 -# define SP_LT_LOOP_SAME_5_TIME 0x04 -# define SP_LT_CR_FAIL_IN_EQ 0x05 -# define SP_LT_EQ_LOOP_5_TIME 0x06 -#define SP_LT_EN BIT(0) - -/* DP CEP Training Control Registers */ -#define SP_DP_CEP_TRAINING_CTRL0_REG 0xa9 -#define SP_DP_CEP_TRAINING_CTRL1_REG 0xaa - -/* DP Debug Register 1 */ -#define SP_DP_DEBUG1_REG 0xb0 -#define SP_DEBUG_PLL_LOCK BIT(4) -#define SP_POLLING_EN BIT(1) - -/* DP Polling Control Register */ -#define SP_DP_POLLING_CTRL_REG 0xb4 -#define SP_AUTO_POLLING_DISABLE BIT(0) - -/* DP Link Debug Control Register */ -#define SP_DP_LINK_DEBUG_CTRL_REG 0xb8 -#define SP_M_VID_DEBUG BIT(5) -#define SP_NEW_PRBS7 BIT(4) -#define SP_INSERT_ER BIT(1) -#define SP_PRBS31_EN BIT(0) - -/* AUX Misc control Register */ -#define SP_AUX_MISC_CTRL_REG 0xbf - -/* DP PLL control Register */ -#define SP_DP_PLL_CTRL_REG 0xc7 -#define SP_PLL_RST BIT(6) - -/* DP Analog Power Down Register */ -#define SP_DP_ANALOG_POWER_DOWN_REG 0xc8 -#define SP_CH0_PD BIT(0) - -/* DP Misc Control Register */ -#define SP_DP_MISC_CTRL_REG 0xcd -#define SP_EQ_TRAINING_LOOP BIT(6) - -/* DP Extra I2C Device Address Register */ -#define SP_DP_EXTRA_I2C_DEV_ADDR_REG 0xce -#define SP_I2C_STRETCH_DISABLE BIT(7) - -#define SP_I2C_EXTRA_ADDR 0x50 - -/* DP Downspread Control Register 1 */ -#define SP_DP_DOWNSPREAD_CTRL1_REG 0xd0 - -/* DP M Value Calculation Control Register */ -#define SP_DP_M_CALCULATION_CTRL_REG 0xd9 -#define SP_M_GEN_CLK_SEL BIT(0) - -/* AUX Channel Access Status Register */ -#define SP_AUX_CH_STATUS_REG 0xe0 -#define SP_AUX_STATUS 0x0f - -/* AUX Channel DEFER Control Register */ -#define SP_AUX_DEFER_CTRL_REG 0xe2 -#define SP_DEFER_CTRL_EN BIT(7) - -/* DP Buffer Data Count Register */ -#define SP_BUF_DATA_COUNT_REG 0xe4 -#define SP_BUF_DATA_COUNT_MASK 0x1f -#define SP_BUF_CLR BIT(7) - -/* DP AUX Channel Control Register 1 */ -#define SP_DP_AUX_CH_CTRL1_REG 0xe5 -#define SP_AUX_TX_COMM_MASK 0x0f -#define SP_AUX_LENGTH_MASK 0xf0 -#define SP_AUX_LENGTH_SHIFT 4 - -/* DP AUX CH Address Register 0 */ -#define SP_AUX_ADDR_7_0_REG 0xe6 - -/* DP AUX CH Address Register 1 */ -#define SP_AUX_ADDR_15_8_REG 0xe7 - -/* DP AUX CH Address Register 2 */ -#define SP_AUX_ADDR_19_16_REG 0xe8 -#define SP_AUX_ADDR_19_16_MASK 0x0f - -/* DP AUX Channel Control Register 2 */ -#define SP_DP_AUX_CH_CTRL2_REG 0xe9 -#define SP_AUX_SEL_RXCM BIT(6) -#define SP_AUX_CHSEL BIT(3) -#define SP_AUX_PN_INV BIT(2) -#define SP_ADDR_ONLY BIT(1) -#define SP_AUX_EN BIT(0) - -/* DP Video Stream Control InfoFrame Register */ -#define SP_DP_3D_VSC_CTRL_REG 0xea -#define SP_INFO_FRAME_VSC_EN BIT(0) - -/* DP Video Stream Data Byte 1 Register */ -#define SP_DP_VSC_DB1_REG 0xeb - -/* DP AUX Channel Control Register 3 */ -#define SP_DP_AUX_CH_CTRL3_REG 0xec -#define SP_WAIT_COUNTER_7_0_MASK 0xff - -/* DP AUX Channel Control Register 4 */ -#define SP_DP_AUX_CH_CTRL4_REG 0xed - -/* DP AUX Buffer Data Registers */ -#define SP_DP_BUF_DATA0_REG 0xf0 - -/***************************************************************/ -/* Register definition of device address 0x72 */ -/***************************************************************/ - -/* -* Core Register Definitions -*/ - -/* Device ID Low Byte Register */ -#define SP_DEVICE_IDL_REG 0x02 - -/* Device ID High Byte Register */ -#define SP_DEVICE_IDH_REG 0x03 - -/* Device version register */ -#define SP_DEVICE_VERSION_REG 0x04 - -/* Power Down Control Register */ -#define SP_POWERDOWN_CTRL_REG 0x05 -#define SP_REGISTER_PD BIT(7) -#define SP_HDCP_PD BIT(5) -#define SP_AUDIO_PD BIT(4) -#define SP_VIDEO_PD BIT(3) -#define SP_LINK_PD BIT(2) -#define SP_TOTAL_PD BIT(1) - -/* Reset Control Register 1 */ -#define SP_RESET_CTRL1_REG 0x06 -#define SP_MISC_RST BIT(7) -#define SP_VIDCAP_RST BIT(6) -#define SP_VIDFIF_RST BIT(5) -#define SP_AUDFIF_RST BIT(4) -#define SP_AUDCAP_RST BIT(3) -#define SP_HDCP_RST BIT(2) -#define SP_SW_RST BIT(1) -#define SP_HW_RST BIT(0) - -/* Reset Control Register 2 */ -#define SP_RESET_CTRL2_REG 0x07 -#define SP_AUX_RST BIT(2) -#define SP_SERDES_FIFO_RST BIT(1) -#define SP_I2C_REG_RST BIT(0) - -/* Video Control Register 1 */ -#define SP_VID_CTRL1_REG 0x08 -#define SP_VIDEO_EN BIT(7) -#define SP_VIDEO_MUTE BIT(2) -#define SP_DE_GEN BIT(1) -#define SP_DEMUX BIT(0) - -/* Video Control Register 2 */ -#define SP_VID_CTRL2_REG 0x09 -#define SP_IN_COLOR_F_MASK 0x03 -#define SP_IN_YC_BIT_SEL BIT(2) -#define SP_IN_BPC_MASK 0x70 -#define SP_IN_BPC_SHIFT 4 -# define SP_IN_BPC_12BIT 0x03 -# define SP_IN_BPC_10BIT 0x02 -# define SP_IN_BPC_8BIT 0x01 -# define SP_IN_BPC_6BIT 0x00 -#define SP_IN_D_RANGE BIT(7) - -/* Video Control Register 3 */ -#define SP_VID_CTRL3_REG 0x0a -#define SP_HPD_OUT BIT(6) - -/* Video Control Register 5 */ -#define SP_VID_CTRL5_REG 0x0c -#define SP_CSC_STD_SEL BIT(7) -#define SP_XVYCC_RNG_LMT BIT(6) -#define SP_RANGE_Y2R BIT(5) -#define SP_CSPACE_Y2R BIT(4) -#define SP_RGB_RNG_LMT BIT(3) -#define SP_Y_RNG_LMT BIT(2) -#define SP_RANGE_R2Y BIT(1) -#define SP_CSPACE_R2Y BIT(0) - -/* Video Control Register 6 */ -#define SP_VID_CTRL6_REG 0x0d -#define SP_TEST_PATTERN_EN BIT(7) -#define SP_VIDEO_PROCESS_EN BIT(6) -#define SP_VID_US_MODE BIT(3) -#define SP_VID_DS_MODE BIT(2) -#define SP_UP_SAMPLE BIT(1) -#define SP_DOWN_SAMPLE BIT(0) - -/* Video Control Register 8 */ -#define SP_VID_CTRL8_REG 0x0f -#define SP_VID_VRES_TH BIT(0) - -/* Total Line Status Low Byte Register */ -#define SP_TOTAL_LINE_STAL_REG 0x24 - -/* Total Line Status High Byte Register */ -#define SP_TOTAL_LINE_STAH_REG 0x25 - -/* Active Line Status Low Byte Register */ -#define SP_ACT_LINE_STAL_REG 0x26 - -/* Active Line Status High Byte Register */ -#define SP_ACT_LINE_STAH_REG 0x27 - -/* Vertical Front Porch Status Register */ -#define SP_V_F_PORCH_STA_REG 0x28 - -/* Vertical SYNC Width Status Register */ -#define SP_V_SYNC_STA_REG 0x29 - -/* Vertical Back Porch Status Register */ -#define SP_V_B_PORCH_STA_REG 0x2a - -/* Total Pixel Status Low Byte Register */ -#define SP_TOTAL_PIXEL_STAL_REG 0x2b - -/* Total Pixel Status High Byte Register */ -#define SP_TOTAL_PIXEL_STAH_REG 0x2c - -/* Active Pixel Status Low Byte Register */ -#define SP_ACT_PIXEL_STAL_REG 0x2d - -/* Active Pixel Status High Byte Register */ -#define SP_ACT_PIXEL_STAH_REG 0x2e - -/* Horizontal Front Porch Status Low Byte Register */ -#define SP_H_F_PORCH_STAL_REG 0x2f - -/* Horizontal Front Porch Statys High Byte Register */ -#define SP_H_F_PORCH_STAH_REG 0x30 - -/* Horizontal SYNC Width Status Low Byte Register */ -#define SP_H_SYNC_STAL_REG 0x31 - -/* Horizontal SYNC Width Status High Byte Register */ -#define SP_H_SYNC_STAH_REG 0x32 - -/* Horizontal Back Porch Status Low Byte Register */ -#define SP_H_B_PORCH_STAL_REG 0x33 - -/* Horizontal Back Porch Status High Byte Register */ -#define SP_H_B_PORCH_STAH_REG 0x34 - -/* InfoFrame AVI Packet DB1 Register */ -#define SP_INFOFRAME_AVI_DB1_REG 0x70 - -/* Bit Control Specific Register */ -#define SP_BIT_CTRL_SPECIFIC_REG 0x80 -#define SP_BIT_CTRL_SELECT_SHIFT 1 -#define SP_ENABLE_BIT_CTRL BIT(0) - -/* InfoFrame Audio Packet DB1 Register */ -#define SP_INFOFRAME_AUD_DB1_REG 0x83 - -/* InfoFrame MPEG Packet DB1 Register */ -#define SP_INFOFRAME_MPEG_DB1_REG 0xb0 - -/* Audio Channel Status Registers */ -#define SP_AUD_CH_STATUS_BASE 0xd0 - -/* Audio Channel Num Register 5 */ -#define SP_I2S_CHANNEL_NUM_MASK 0xe0 -# define SP_I2S_CH_NUM_1 (0x00 << 5) -# define SP_I2S_CH_NUM_2 (0x01 << 5) -# define SP_I2S_CH_NUM_3 (0x02 << 5) -# define SP_I2S_CH_NUM_4 (0x03 << 5) -# define SP_I2S_CH_NUM_5 (0x04 << 5) -# define SP_I2S_CH_NUM_6 (0x05 << 5) -# define SP_I2S_CH_NUM_7 (0x06 << 5) -# define SP_I2S_CH_NUM_8 (0x07 << 5) -#define SP_EXT_VUCP BIT(2) -#define SP_VBIT BIT(1) -#define SP_AUDIO_LAYOUT BIT(0) - -/* Analog Debug Register 2 */ -#define SP_ANALOG_DEBUG2_REG 0xdd -#define SP_FORCE_SW_OFF_BYPASS 0x20 -#define SP_XTAL_FRQ 0x1c -# define SP_XTAL_FRQ_19M2 (0x00 << 2) -# define SP_XTAL_FRQ_24M (0x01 << 2) -# define SP_XTAL_FRQ_25M (0x02 << 2) -# define SP_XTAL_FRQ_26M (0x03 << 2) -# define SP_XTAL_FRQ_27M (0x04 << 2) -# define SP_XTAL_FRQ_38M4 (0x05 << 2) -# define SP_XTAL_FRQ_52M (0x06 << 2) -#define SP_POWERON_TIME_1P5MS 0x03 - -/* Analog Control 0 Register */ -#define SP_ANALOG_CTRL0_REG 0xe1 - -/* Common Interrupt Status Register 1 */ -#define SP_COMMON_INT_STATUS_BASE (0xf1 - 1) -#define SP_PLL_LOCK_CHG 0x40 - -/* Common Interrupt Status Register 2 */ -#define SP_COMMON_INT_STATUS2 0xf2 -#define SP_HDCP_AUTH_CHG BIT(1) -#define SP_HDCP_AUTH_DONE BIT(0) - -#define SP_HDCP_LINK_CHECK_FAIL BIT(0) - -/* Common Interrupt Status Register 4 */ -#define SP_COMMON_INT_STATUS4_REG 0xf4 -#define SP_HPD_IRQ BIT(6) -#define SP_HPD_ESYNC_ERR BIT(4) -#define SP_HPD_CHG BIT(2) -#define SP_HPD_LOST BIT(1) -#define SP_HPD_PLUG BIT(0) - -/* DP Interrupt Status Register */ -#define SP_DP_INT_STATUS1_REG 0xf7 -#define SP_TRAINING_FINISH BIT(5) -#define SP_POLLING_ERR BIT(4) - -/* Common Interrupt Mask Register */ -#define SP_COMMON_INT_MASK_BASE (0xf8 - 1) - -#define SP_COMMON_INT_MASK4_REG 0xfb - -/* DP Interrupts Mask Register */ -#define SP_DP_INT_MASK1_REG 0xfe - -/* Interrupt Control Register */ -#define SP_INT_CTRL_REG 0xff -/***************************************************************/ /* Register definition of device address 0x7a */ /***************************************************************/
drivers/gpu/drm/bridge/analogix/analogix-i2c-dptx.h new file +248 -0
248 lines not on this page · raw message
drivers/gpu/drm/bridge/analogix/analogix-i2c-txcommon.h new file +237 -0
237 lines not on this page · raw message
Signature · 1 line
2.18.1
PATCH 3/9 drm/bridge: extract some Analogix I2C DP common code
In reply to Icenowy ZhengSome code can be shared within different DP bridges by Analogix.
Extract them to a new module.
--- drivers/gpu/drm/bridge/analogix/Kconfig | 4 + drivers/gpu/drm/bridge/analogix/Makefile | 2 + .../drm/bridge/analogix/analogix-anx78xx.c | 146 +-------------- .../drm/bridge/analogix/analogix-i2c-dptx.c | 169 ++++++++++++++++++ .../drm/bridge/analogix/analogix-i2c-dptx.h | 2 + 5 files changed, 178 insertions(+), 145 deletions(-) create mode 100644 drivers/gpu/drm/bridge/analogix/analogix-i2c-dptx.c
drivers/gpu/drm/bridge/analogix/Kconfig +4 -0
@@ -2,8 +2,12 @@ config DRM_ANALOGIX_DP tristate depends on DRM +config DRM_ANALOGIX_DP_I2C + tristate + config DRM_ANALOGIX_ANX78XX tristate "Analogix ANX78XX bridge" + select DRM_ANALOGIX_DP_I2C select DRM_KMS_HELPER select REGMAP_I2C ---help---
drivers/gpu/drm/bridge/analogix/Makefile +2 -0
@@ -1,3 +1,5 @@ analogix_dp-objs := analogix_dp_core.o analogix_dp_reg.o +analogix_dp_i2c-objs := analogix-i2c-dptx.o obj-$(CONFIG_DRM_ANALOGIX_DP) += analogix_dp.o +obj-$(CONFIG_DRM_ANALOGIX_DP_I2C) += analogix_dp_i2c.o obj-$(CONFIG_DRM_ANALOGIX_ANX78XX) += analogix-anx78xx.o
drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c +1 -145
162 lines not on this page · raw message
drivers/gpu/drm/bridge/analogix/analogix-i2c-dptx.c new file +169 -0
169 lines not on this page · raw message
drivers/gpu/drm/bridge/analogix/analogix-i2c-dptx.h +2 -0
@@ -245,4 +245,6 @@/* DP AUX Buffer Data Registers */ #define SP_DP_BUF_DATA0_REG 0xf0 +ssize_t anx_aux_transfer (struct regmap *map_dptx,struct drm_dp_aux_msg *msg); +#endif
Signature · 1 line
2.18.1
PATCH 4/9 dt-bindings: Add ANX6345 DP/eDP transmitter binding
In reply to Icenowy ZhengThe ANX6345 is an ultra-low power DisplayPort/eDP transmitter designed for portable devices.
Add a binding document for it.
--- .../bindings/display/bridge/anx6345.txt | 39 +++++++++++++++++++ 1 file changed, 39 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/bridge/anx6345.txt
Documentation/devicetree/bindings/display/bridge/anx6345.txt new file +39 -0
@@ -0,0 +1,39 @@ +Analogix ANX6345 eDP Transmitter +-------------------------------- + +The ANX6345 is an ultra-low power Full-HD eDP transmitter designed for +portable devices. + +Required properties: + + - compatible : "analogix,anx6345" + - reg : I2C address of the device + - reset-gpios : Which GPIO to use for reset + +Optional properties: + + - dvdd12-supply : Regulator for 1.2V digital core power. + - dvdd25-supply : Regulator for 2.5V digital core power. + - panel-supply : Regulator for the power of the panel. + - edid : verbatim EDID data block describing attached + panel, only used when the panel has no EDID info. + - Video port for RGB input, using the DT bindings defined in [1]. + +[1]: Documentation/devicetree/bindings/media/video-interfaces.txt + +Example: + +anx6345: anx6345@38 { + compatible = "analogix,anx6345"; + reg = <0x38>; + reset-gpios = <&pio 3 24 GPIO_ACTIVE_HIGH>; /* PD24 */ + panel-supply = <®_dc1sw>; + dvdd25-supply = <®_dldo2>; + dvdd12-supply = <®_fldo1>; + + port { + anx6345_in: endpoint { + remote-endpoint = <&tcon0_out_anx6345>; + }; + }; +};
Signature · 1 line
2.18.1
Laurent Pinchart
reviewerRe: [PATCH 4/9] dt-bindings: Add ANX6345 DP/eDP transmitter binding
Hi Icenowy,
Thank you for the patch.
Quoted 25 lines · On Thursday, 18 October 2018 10:33:22 EEST Icenowy Zheng wrote:
The ANX6345 is an ultra-low power DisplayPort/eDP transmitter designed for portable devices.
Add a binding document for it.
Signed-off-by Icenowy Zheng <[email protected]>--- .../bindings/display/bridge/anx6345.txt | 39 +++++++++++++++++++ 1 file changed, 39 insertions(+) create mode 100644
Documentation/devicetree/bindings/display/bridge/anx6345.txt(quoted diff) +0
-0
b/Documentation/devicetree/bindings/display/bridge/anx6345.txtnew file mode 100644
index 000000000000..0689d4eb5f65Documentation/devicetree/bindings/display/bridge/anx6345.txt new file +6
-0@@ -0,0 +1,39 @@ +Analogix ANX6345 eDP Transmitter +-------------------------------- + +The ANX6345 is an ultra-low power Full-HD eDP transmitter designed for +portable devices. +
Documentation/devicetree/bindings/display/bridge/anx6345.txt line 16
Quoted 10 lines
Documentation/devicetree/bindings/display/bridge/anx6345.txt new file +10
-0+Required properties: + + - compatible : "analogix,anx6345" + - reg : I2C address of the device + - reset-gpios : Which GPIO to use for reset + +Optional properties: + + - dvdd12-supply : Regulator for 1.2V digital core power. + - dvdd25-supply : Regulator for 2.5V digital core power.
Shouldn't these to supplies be mandatory ?
Documentation/devicetree/bindings/display/bridge/anx6345.txt line 17
Quoted 1 line
Documentation/devicetree/bindings/display/bridge/anx6345.txt new file +1
-0+ - panel-supply : Regulator for the power of the panel.
Shouldn't the panel supply for specified in the DT node of the panel ?
Documentation/devicetree/bindings/display/bridge/anx6345.txt line 19
Quoted 2 lines
Documentation/devicetree/bindings/display/bridge/anx6345.txt new file +2
-0+ - edid : verbatim EDID data block describing attached + panel, only used when the panel has no EDID info.
This should also be specified in the panel DT node.
Documentation/devicetree/bindings/display/bridge/anx6345.txt line 20
Quoted 1 line
Documentation/devicetree/bindings/display/bridge/anx6345.txt new file +1
-0+ - Video port for RGB input, using the DT bindings defined in [1].
I think you should also add a port for the output.
Quoted 18 lines
Documentation/devicetree/bindings/display/bridge/anx6345.txt new file +18
-0+[1]: Documentation/devicetree/bindings/media/video-interfaces.txt + +Example: + +anx6345: anx6345@38 { + compatible = "analogix,anx6345"; + reg = <0x38>; + reset-gpios = <&pio 3 24 GPIO_ACTIVE_HIGH>; /* PD24 */ + panel-supply = <®_dc1sw>; + dvdd25-supply = <®_dldo2>; + dvdd12-supply = <®_fldo1>; + + port { + anx6345_in: endpoint { + remote-endpoint = <&tcon0_out_anx6345>; + }; + }; +};
Signature · 3 lines
Regards, Laurent Pinchart
Re: [PATCH 4/9] dt-bindings: Add ANX6345 DP/eDP transmitter binding
Quoted 39 lines · 在 2018-10-18四的 11:53 +0300,Laurent Pinchart写道:
Hi Icenowy,
Thank you for the patch.
Quoted 34 lines · On Thursday, 18 October 2018 10:33:22 EEST Icenowy Zheng wrote:
The ANX6345 is an ultra-low power DisplayPort/eDP transmitter designed
for portable devices.Add a binding document for it.
Signed-off-by Icenowy Zheng <[email protected]>--- .../bindings/display/bridge/anx6345.txt | 39 +++++++++++++++++++ 1 file changed, 39 insertions(+) create mode 100644
Documentation/devicetree/bindings/display/bridge/anx6345.txtdiff --git
a/Documentation/devicetree/bindings/display/bridge/anx6345.txtb/Documentation/devicetree/bindings/display/bridge/anx6345.txtnew file
mode 100644
index 000000000000..0689d4eb5f65Documentation/devicetree/bindings/display/bridge/anx6345.txt new file +4
-0@@ -0,0 +1,39 @@ +Analogix ANX6345 eDP Transmitter +-------------------------------- + +The ANX6345 is an ultra-low power Full-HD eDP transmitter designedfor
Documentation/devicetree/bindings/display/bridge/anx6345.txt new file +6
-0+portable devices. + +Required properties: + + - compatible : "analogix,anx6345" + - reg : I2C address of the device
Quoted 8 lines
Documentation/devicetree/bindings/display/bridge/anx6345.txt line 16
Quoted 6 lines
+ - reset-gpios : Which GPIO to use for reset
Documentation/devicetree/bindings/display/bridge/anx6345.txt new file +5
-0+ +Optional properties: + + - dvdd12-supply : Regulator for 1.2V digital core power. + - dvdd25-supply : Regulator for 2.5V digital core power.Shouldn't these to supplies be mandatory ?
Yes they should.
Quoted 5 lines
Quoted 2 lines
+ - panel-supply : Regulator for the power of the panel.
Shouldn't the panel supply for specified in the DT node of the panel ?
However, eDP panel can be probed, may vary on the same device, and we don't have a generic binding for it...
Quoted 11 lines
Quoted 5 lines
+ - edid : verbatim EDID data block describing
attachedDocumentation/devicetree/bindings/display/bridge/anx6345.txt new file +1
-0+ panel, only used when the panel has no EDIDinfo.
This should also be specified in the panel DT node.
Quoted 1 line
+ - Video port for RGB input, using the DT bindings defined in [1].
I think you should also add a port for the output.
What will it point to?
Quoted 21 lines
Quoted 19 lines
+[1]:
Documentation/devicetree/bindings/media/video-interfaces.txtDocumentation/devicetree/bindings/display/bridge/anx6345.txt new file +17
-0+ +Example: + +anx6345: anx6345@38 { + compatible = "analogix,anx6345"; + reg = <0x38>; + reset-gpios = <&pio 3 24 GPIO_ACTIVE_HIGH>; /* PD24 */ + panel-supply = <®_dc1sw>; + dvdd25-supply = <®_dldo2>; + dvdd12-supply = <®_fldo1>; + + port { + anx6345_in: endpoint { + remote-endpoint = <&tcon0_out_anx6345>; + }; + }; +};
Laurent Pinchart
reviewerRe: [PATCH 4/9] dt-bindings: Add ANX6345 DP/eDP transmitter binding
Hi Icenowy,
Quoted 49 lines · On Thursday, 18 October 2018 13:00:05 EEST Icenowy Zheng wrote:
Quoted 37 lines · 在 2018-10-18四的 11:53 +0300,Laurent Pinchart写道:
Quoted 36 lines · On Thursday, 18 October 2018 10:33:22 EEST Icenowy Zheng wrote:
The ANX6345 is an ultra-low power DisplayPort/eDP transmitter designed
for portable devices.Add a binding document for it.
Signed-off-by Icenowy Zheng <[email protected]>---
.../bindings/display/bridge/anx6345.txt | 39 +++++++++++++++++++1 file changed, 39 insertions(+) create mode 100644
Documentation/devicetree/bindings/display/bridge/anx6345.txtdiff --git
a/Documentation/devicetree/bindings/display/bridge/anx6345.txtb/Documentation/devicetree/bindings/display/bridge/anx6345.txtnew file
mode 100644
index 000000000000..0689d4eb5f65Documentation/devicetree/bindings/display/bridge/anx6345.txt new file +4
-0@@ -0,0 +1,39 @@ +Analogix ANX6345 eDP Transmitter +-------------------------------- + +The ANX6345 is an ultra-low power Full-HD eDP transmitter designedfor
Documentation/devicetree/bindings/display/bridge/anx6345.txt new file +6
-0+portable devices. + +Required properties: + + - compatible : "analogix,anx6345" + - reg : I2C address of the deviceQuoted 8 lines
Documentation/devicetree/bindings/display/bridge/anx6345.txt line 16
Quoted 6 lines
+ - reset-gpios : Which GPIO to use for reset
Documentation/devicetree/bindings/display/bridge/anx6345.txt new file +5
-0+ +Optional properties: + + - dvdd12-supply : Regulator for 1.2V digital core power. + - dvdd25-supply : Regulator for 2.5V digital core power.Shouldn't these to supplies be mandatory ?
Yes they should.
Quoted 7 lines
Quoted 4 lines
Quoted 1 line
+ - panel-supply : Regulator for the power of the panel.
Shouldn't the panel supply for specified in the DT node of the panel ?
However, eDP panel can be probed, may vary on the same device, and we don't have a generic binding for it...
Shouldn't we fix that ? :-)
Quoted 7 lines
Quoted 7 lines
Quoted 4 lines
+ - edid : verbatim EDID data block describing
attachedDocumentation/devicetree/bindings/display/bridge/anx6345.txt new file +1
-0+ panel, only used when the panel has no EDIDinfo.
This should also be specified in the panel DT node.
Quoted 5 lines
Quoted 3 lines
Quoted 1 line
+ - Video port for RGB input, using the DT bindings defined in [1].
I think you should also add a port for the output.
What will it point to?
The panel DT node ?
Quoted 18 lines
Quoted 18 lines
Quoted 18 lines
+[1]:
Documentation/devicetree/bindings/media/video-interfaces.txtDocumentation/devicetree/bindings/display/bridge/anx6345.txt new file +17
-0+ +Example: + +anx6345: anx6345@38 { + compatible = "analogix,anx6345"; + reg = <0x38>; + reset-gpios = <&pio 3 24 GPIO_ACTIVE_HIGH>; /* PD24 */ + panel-supply = <®_dc1sw>; + dvdd25-supply = <®_dldo2>; + dvdd12-supply = <®_fldo1>; + + port { + anx6345_in: endpoint { + remote-endpoint = <&tcon0_out_anx6345>; + }; + }; +};
Signature · 3 lines
Regards, Laurent Pinchart
Re: [PATCH 4/9] dt-bindings: Add ANX6345 DP/eDP transmitter binding
Quoted 65 lines · 在 2018-10-18四的 14:23 +0300,Laurent Pinchart写道:
Hi Icenowy,
Quoted 62 lines · On Thursday, 18 October 2018 13:00:05 EEST Icenowy Zheng wrote:
Quoted 43 lines · 在 2018-10-18四的 11:53 +0300,Laurent Pinchart写道:
Quoted 42 lines · On Thursday, 18 October 2018 10:33:22 EEST Icenowy Zheng wrote:
The ANX6345 is an ultra-low power DisplayPort/eDP transmitter designed
for portable devices.Add a binding document for it.
Signed-off-by Icenowy Zheng <[email protected]>---
.../bindings/display/bridge/anx6345.txt | 39+++++++++++++++++++
1 file changed, 39 insertions(+) create mode 100644
Documentation/devicetree/bindings/display/bridge/anx6345.txtdiff --git
a/Documentation/devicetree/bindings/display/bridge/anx6345.txtb/Documentation/devicetree/bindings/display/bridge/anx6345.txtnew
file
mode 100644
index 000000000000..0689d4eb5f65
---/dev/null
+++b/Documentation/devicetree/bindings/display/bridge/anx6345.txtDocumentation/devicetree/bindings/display/bridge/anx6345.txt new file +4
-0@@ -0,0 +1,39 @@ +Analogix ANX6345 eDP Transmitter +-------------------------------- + +The ANX6345 is an ultra-low power Full-HD eDP transmitterdesigned
forDocumentation/devicetree/bindings/display/bridge/anx6345.txt new file +8
-0+portable devices. + +Required properties: + + - compatible : "analogix,anx6345" + - reg : I2C address of the device + - reset-gpios : Which GPIO to use for reset +Quoted 8 lines
Quoted 6 lines
Documentation/devicetree/bindings/display/bridge/anx6345.txt new file +3
-0+Optional properties: + + - dvdd12-supply : Regulator for 1.2V digital corepower.
+ - dvdd25-supply : Regulator for 2.5V digital core
power.Shouldn't these to supplies be mandatory ?
Yes they should.
Quoted 6 lines
Quoted 2 lines
+ - panel-supply : Regulator for the power of
the panel.Shouldn't the panel supply for specified in the DT node of the panel
?
Quoted 5 lines
Quoted 3 lines
However, eDP panel can be probed, may vary on the same device, and we
don't have a generic binding for it...Shouldn't we fix that ? :-)
Maybe we should create a connector binding instead of a panel binding?
Quoted 40 lines
Quoted 10 lines
Quoted 10 lines
Quoted 7 lines
+ - edid : verbatim EDID data block
describing
attached(quoted diff) +1
-0+ panel, only used when the panel hasno EDID
info.This should also be specified in the panel DT node.
Quoted 6 lines
Quoted 4 lines
Quoted 2 lines
+ - Video port for RGB input, using the DT bindings defined in [1].
I think you should also add a port for the output.
What will it point to?
The panel DT node ?
Quoted 19 lines
Quoted 19 lines
Quoted 19 lines
+[1]:
Documentation/devicetree/bindings/media/video-interfaces.txtDocumentation/devicetree/bindings/display/bridge/anx6345.txt new file +17
-0+ +Example: + +anx6345: anx6345@38 { + compatible = "analogix,anx6345"; + reg = <0x38>; + reset-gpios = <&pio 3 24 GPIO_ACTIVE_HIGH>; /* PD24 */ + panel-supply = <®_dc1sw>; + dvdd25-supply = <®_dldo2>; + dvdd12-supply = <®_fldo1>; + + port { + anx6345_in: endpoint { + remote-endpoint = <&tcon0_out_anx6345>; + }; + }; +};
Rob Herring
maintainerRe: [PATCH 4/9] dt-bindings: Add ANX6345 DP/eDP transmitter binding
Quoted 66 lines · Icenowy Zheng
Quoted 65 lines · 在 2018-10-18四的 14:23 +0300,Laurent Pinchart写道:
Hi Icenowy,
Quoted 62 lines · On Thursday, 18 October 2018 13:00:05 EEST Icenowy Zheng wrote:
Quoted 43 lines · 在 2018-10-18四的 11:53 +0300,Laurent Pinchart写道:
Quoted 42 lines · On Thursday, 18 October 2018 10:33:22 EEST Icenowy Zheng wrote:
The ANX6345 is an ultra-low power DisplayPort/eDP transmitter designed
for portable devices.Add a binding document for it.
Signed-off-by Icenowy Zheng <[email protected]>---
.../bindings/display/bridge/anx6345.txt | 39+++++++++++++++++++
1 file changed, 39 insertions(+) create mode 100644
Documentation/devicetree/bindings/display/bridge/anx6345.txtdiff --git
a/Documentation/devicetree/bindings/display/bridge/anx6345.txtb/Documentation/devicetree/bindings/display/bridge/anx6345.txtnew
file
mode 100644
index 000000000000..0689d4eb5f65
---/dev/null
+++b/Documentation/devicetree/bindings/display/bridge/anx6345.txtDocumentation/devicetree/bindings/display/bridge/anx6345.txt new file +4
-0@@ -0,0 +1,39 @@ +Analogix ANX6345 eDP Transmitter +-------------------------------- + +The ANX6345 is an ultra-low power Full-HD eDP transmitterdesigned
forDocumentation/devicetree/bindings/display/bridge/anx6345.txt new file +8
-0+portable devices. + +Required properties: + + - compatible : "analogix,anx6345" + - reg : I2C address of the device + - reset-gpios : Which GPIO to use for reset +Quoted 8 lines
Quoted 6 lines
Documentation/devicetree/bindings/display/bridge/anx6345.txt new file +3
-0+Optional properties: + + - dvdd12-supply : Regulator for 1.2V digital corepower.
+ - dvdd25-supply : Regulator for 2.5V digital core
power.Shouldn't these to supplies be mandatory ?
Yes they should.
Quoted 6 lines
Quoted 2 lines
+ - panel-supply : Regulator for the power of
the panel.Shouldn't the panel supply for specified in the DT node of the panel
?
Quoted 7 lines
Quoted 5 lines
Quoted 3 lines
However, eDP panel can be probed, may vary on the same device, and we
don't have a generic binding for it...Shouldn't we fix that ? :-)
Maybe we should create a connector binding instead of a panel binding?
There's not any such thing as a standard eDP connector, is there? Otherwise, that's just creating a generic panel binding in disguise. Maybe if eDP interface is standardized enough in terms of power control, control lines, EDID at least sometimes present, etc., then we could have some sort of generic eDP panel/connector binding.
Rob
Signature · 3 lines
You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/[email protected] For more options, visit https://groups.google.com/d/optout.
Re: [PATCH 4/9] dt-bindings: Add ANX6345 DP/eDP transmitter binding
于 2018年10月26日 GMT+08:00 上午2:30:03, Rob Herring <[email protected]> 写到:
Quoted 77 lines · Icenowy Zheng
Quoted 18 lines · 在 2018-10-18四的 14:23 +0300,Laurent Pinchart写道:
Quoted 17 lines
Hi Icenowy,
Quoted 14 lines · On Thursday, 18 October 2018 13:00:05 EEST Icenowy Zheng wrote:
Quoted 13 lines · 在 2018-10-18四的 11:53 +0300,Laurent Pinchart写道:
Quoted 12 lines · On Thursday, 18 October 2018 10:33:22 EEST Icenowy Zheng wrote:
The ANX6345 is an ultra-low power DisplayPort/eDP transmitter designed
for portable devices.Add a binding document for it.
Signed-off-by Icenowy Zheng <[email protected]>---
.../bindings/display/bridge/anx6345.txt | 39+++++++++++++++++++
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
1 file changed, 39 insertions(+) create mode 100644
Documentation/devicetree/bindings/display/bridge/anx6345.txtdiff --git
a/Documentation/devicetree/bindings/display/bridge/anx6345.txtQuoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
b/Documentation/devicetree/bindings/display/bridge/anx6345.txtQuoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
new
file
mode 100644
index 000000000000..0689d4eb5f65
---/dev/null
+++
b/Documentation/devicetree/bindings/display/bridge/anx6345.txtQuoted 26 lines
Quoted 26 lines
Quoted 26 lines
Quoted 15 lines
Quoted 15 lines
Documentation/devicetree/bindings/display/bridge/anx6345.txt new file +4
-0@@ -0,0 +1,39 @@ +Analogix ANX6345 eDP Transmitter +-------------------------------- + +The ANX6345 is an ultra-low power Full-HD eDP transmitterdesigned
forDocumentation/devicetree/bindings/display/bridge/anx6345.txt new file +8
-0+portable devices. + +Required properties: + + - compatible : "analogix,anx6345" + - reg : I2C address of the device + - reset-gpios : Which GPIO to use for reset +Quoted 8 lines
Quoted 6 lines
Documentation/devicetree/bindings/display/bridge/anx6345.txt new file +3
-0+Optional properties: + + - dvdd12-supply : Regulator for 1.2V digital corepower.
+ - dvdd25-supply : Regulator for 2.5V digital core
power.Shouldn't these to supplies be mandatory ?
Yes they should.
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 6 lines
Quoted 2 lines
+ - panel-supply : Regulator for the power of
the panel.Shouldn't the panel supply for specified in the DT node of the panel
?However, eDP panel can be probed, may vary on the same device,
and
Quoted 5 lines
Quoted 4 lines
Quoted 2 lines
we
don't have a generic binding for it...Shouldn't we fix that ? :-)
Quoted 8 lines
Quoted 1 line
Maybe we should create a connector binding instead of a panel
binding?
There's not any such thing as a standard eDP connector, is there? Otherwise, that's just creating a generic panel binding in disguise. Maybe if eDP interface is standardized enough in terms of power control,
control lines, EDID at least sometimes present, etc., then we could
eDP has the same display signal set with DP, including AUX which carries DPCD and EDID (if present).
But I don't know whether other lines are standardized, including power, backlight, etc.
Quoted 9 lines
have
some sort of generic eDP panel/connector binding.Rob
_______________________________________________
linux-arm-kernel mailing list linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Signature · 3 lines
You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/[email protected] For more options, visit https://groups.google.com/d/optout.
PATCH 5/9 drm/bridge: Add Analogix anx6345 support
In reply to Icenowy ZhengThe ANX6345 is an ultra-low power DisplayPower/eDP transmitter designed for portable devices. This driver adds initial support for RGB to eDP mode, without HPD and interrupts, but with possibility to inject EDID. This is a configuration usually seen in eDP applications.
--- drivers/gpu/drm/bridge/analogix/Kconfig | 11 + drivers/gpu/drm/bridge/analogix/Makefile | 1 + .../drm/bridge/analogix/analogix-anx6345.c | 862 ++++++++++++++++++ .../drm/bridge/analogix/analogix-i2c-dptx.c | 2 +- .../drm/bridge/analogix/analogix-i2c-dptx.h | 8 + .../bridge/analogix/analogix-i2c-txcommon.h | 3 + 6 files changed, 886 insertions(+), 1 deletion(-) create mode 100644 drivers/gpu/drm/bridge/analogix/analogix-anx6345.c
drivers/gpu/drm/bridge/analogix/Kconfig +11 -0
@@ -15,3 +15,14 @@ config DRM_ANALOGIX_ANX78XX designed for portable devices. The ANX78XX transforms the HDMI output of an application processor to MyDP or DisplayPort. + +config DRM_ANALOGIX_ANX6345 + tristate "Analogix ANX6345 bridge" + select DRM_ANALOGIX_DP_I2C + select DRM_KMS_HELPER + select REGMAP_I2C + help + ANX6345 is an ultra-low Full-HD DisplayPort/eDP + transmitter designed for portable devices. The + ANX6345 transforms the LVTTL RGB output of an + application processor to eDP or DisplayPort.
drivers/gpu/drm/bridge/analogix/Makefile +1 -0
@@ -3,3 +3,4 @@ analogix_dp_i2c-objs := analogix-i2c-dptx.o obj-$(CONFIG_DRM_ANALOGIX_DP) += analogix_dp.o obj-$(CONFIG_DRM_ANALOGIX_DP_I2C) += analogix_dp_i2c.o obj-$(CONFIG_DRM_ANALOGIX_ANX78XX) += analogix-anx78xx.o +obj-$(CONFIG_DRM_ANALOGIX_ANX6345) += analogix-anx6345.o
drivers/gpu/drm/bridge/analogix/analogix-anx6345.c new file +862 -0
862 lines not on this page · raw message
drivers/gpu/drm/bridge/analogix/analogix-i2c-dptx.c +1 -1
@@ -117,7 +117,7 @@ ssize_t anx_aux_transfer(struct regmap *map_dptx, struct drm_dp_aux_msg *msg) else /* For non-zero-sized set the length field. */ ctrl1 |= (msg->size - 1) << SP_AUX_LENGTH_SHIFT; -if ((msg->request &DP_AUX_I2C_READ ) ==0 ) { +if ((msg->size >0 ) && ((msg->request &DP_AUX_I2C_READ ) ==0 )) {/* When WRITE | MOT write values to data buffer */ err = regmap_bulk_write(map_dptx, SP_DP_BUF_DATA0_REG, buffer,
drivers/gpu/drm/bridge/analogix/analogix-i2c-dptx.h +8 -0
@@ -75,7 +75,11 @@#define SP_CHA_STA BIT(2)/* Bits for DP System Control Register 3 */ #define SP_HPD_STATUS BIT(6) +#define SP_HPD_FORCE BIT(5) +#define SP_HPD_CTRL BIT(4)#define SP_STRM_VALID BIT(2) +#define SP_STRM_FORCE BIT(1) +#define SP_STRM_CTRL BIT(0)/* Bits for DP System Control Register 4 */ #define SP_ENHANCED_MODE BIT(3)
@@ -120,6 +124,9 @@#define SP_LINK_BW_SET_MASK 0x1f#define SP_INITIAL_SLIM_M_AUD_SEL BIT(5) +/* DP Lane Count Setting Register */ +#define SP_DP_LANE_COUNT_SET_REG 0xa1 +/* DP Training Pattern Set Register */ #define SP_DP_TRAINING_PATTERN_SET_REG 0xa2
@@ -133,6 +140,7 @@/* DP Link Training Control Register */ #define SP_DP_LT_CTRL_REG 0xa8 +#define SP_DP_LT_INPROGRESS 0x80#define SP_LT_ERROR_TYPE_MASK 0x70# define SP_LT_NO_ERROR 0x00# define SP_LT_AUX_WRITE_ERROR 0x01
drivers/gpu/drm/bridge/analogix/analogix-i2c-txcommon.h +3 -0
@@ -183,6 +183,9 @@#define SP_VBIT BIT(1)#define SP_AUDIO_LAYOUT BIT(0) +/* Analog Debug Register 1 */ +#define SP_ANALOG_DEBUG1_REG 0xdc +/* Analog Debug Register 2 */ #define SP_ANALOG_DEBUG2_REG 0xdd#define SP_FORCE_SW_OFF_BYPASS 0x20
Signature · 1 line
2.18.1
PATCH 6/9 arm64: allwinner: a64: add pinmux for RGB666 LCD
In reply to Icenowy ZhengAllwinner A64's TCON0 can output RGB666 LCD signal.
Add its pinmux.
--- arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 9 +++++++++ 1 file changed, 9 insertions(+)
arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi +9 -0
@@ -518,6 +518,15 @@ function = "i2c1"; }; + lcd_rgb666_pins: lcd-rgb666 { + pins = "PD0", "PD1", "PD2", "PD3", "PD4", + "PD5", "PD6", "PD7", "PD8", "PD9", + "PD10", "PD11", "PD12", "PD13", + "PD14", "PD15", "PD16", "PD17", + "PD18", "PD19", "PD20", "PD21"; + function = "lcd0"; + }; + mmc0_pins: mmc0-pins { pins = "PF0", "PF1", "PF2", "PF3", "PF4", "PF5";
Signature · 1 line
2.18.1
PATCH 7/9 arm64: allwinner: a64: enable ANX6345 bridge on Pinebook
In reply to Icenowy ZhengPinebook has an ANX6345 bridge connected to the RGB666 LCD output, and the I2C controlling signals are connected to R_I2C bus.
Enable it in the device tree, and add a usable EDID from the panel's datasheet (at least 14" Pinebook used a panel without EDID).
--- .../dts/allwinner/sun50i-a64-pinebook.dts | 43 +++++++++++++++++++ 1 file changed, 43 insertions(+)
arch/arm64/boot/dts/allwinner/sun50i-a64-pinebook.dts +43 -0
@@ -66,6 +66,10 @@ }; }; +&de { + status = "okay"; +}; + &ehci0 { phys = <&usbphy 0>; phy-names = "usb";
@@ -76,6 +80,10 @@ status = "okay"; }; +&mixer0 { + status = "okay"; +}; + &mmc0 { pinctrl-names = "default"; pinctrl-0 = <&mmc0_pins>;
@@ -127,6 +135,27 @@ status = "okay"; }; +&r_i2c { + pinctrl-names = "default"; + pinctrl-0 = <&r_i2c_pins_a>; + status = "okay"; + + anx6345: anx6345@38 { + compatible = "analogix,anx6345"; + reg = <0x38>; + reset-gpios = <&pio 3 24 GPIO_ACTIVE_HIGH>; /* PD24 */ + panel-supply = <®_dc1sw>; + dvdd25-supply = <®_dldo2>; + dvdd12-supply = <®_fldo1>; + + port { + anx6345_in: endpoint { + remote-endpoint = <&tcon0_out_anx6345>; + }; + }; + }; +}; + &r_rsb { status = "okay";
@@ -267,6 +296,20 @@ vcc-hdmi-supply = <®_dldo1>; }; +&tcon0 { + pinctrl-names = "default"; + pinctrl-0 = <&lcd_rgb666_pins>; + + status = "okay"; +}; + +&tcon0_out { + tcon0_out_anx6345: endpoint@0 { + reg = <0>; + remote-endpoint = <&anx6345_in>; + }; +}; + &uart0 { pinctrl-names = "default"; pinctrl-0 = <&uart0_pb_pins>;
Signature · 1 line
2.18.1
Re: [PATCH 7/9] arm64: allwinner: a64: enable ANX6345 bridge on Pinebook
Hi Icenowy,
Quoted 5 lines · PDT Icenowy Zheng
Pinebook has an ANX6345 bridge connected to the RGB666 LCD output, and the I2C controlling signals are connected to
R_I2Cbus.Enable it in the device tree, and add a usable EDID from the panel's datasheet (at least 14" Pinebook used a panel without EDID).
There's no EDID in dts and 14" Pinebook uses a panel with EDID. Is it leftover of old comment?
Regards,
Vasily
Quoted 82 lines
Signed-off-by Icenowy Zheng <[email protected]>--- .../dts/allwinner/sun50i-a64-pinebook.dts | 43 +++++++++++++++++++ 1 file changed, 43 insertions(+)(quoted diff) +0
-0
b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinebook.dtsindex77fac84797e9..d7c14d0d61f9100644arch/arm64/boot/dts/allwinner/sun50i-a64-pinebook.dts +43
-0@@ -66,6 +66,10 @@ }; }; +&de { + status = "okay"; +}; + &ehci0 { phys = <&usbphy 0>; phy-names = "usb";@@ -76,6 +80,10 @@ status = "okay"; }; +&mixer0 { + status = "okay"; +}; + &mmc0 { pinctrl-names = "default"; pinctrl-0 = <&mmc0_pins>;@@ -127,6 +135,27 @@ status = "okay"; }; +&r_i2c { + pinctrl-names = "default"; + pinctrl-0 = <&r_i2c_pins_a>; + status = "okay"; + + anx6345: anx6345@38 { + compatible = "analogix,anx6345"; + reg = <0x38>; + reset-gpios = <&pio 3 24 GPIO_ACTIVE_HIGH>; /* PD24 */ + panel-supply = <®_dc1sw>; + dvdd25-supply = <®_dldo2>; + dvdd12-supply = <®_fldo1>; + + port { + anx6345_in: endpoint { + remote-endpoint = <&tcon0_out_anx6345>; + }; + }; + }; +}; + &r_rsb { status = "okay";@@ -267,6 +296,20 @@ vcc-hdmi-supply = <®_dldo1>; }; +&tcon0 { + pinctrl-names = "default"; + pinctrl-0 = <&lcd_rgb666_pins>; + + status = "okay"; +}; + +&tcon0_out { + tcon0_out_anx6345: endpoint@0 { + reg = <0>; + remote-endpoint = <&anx6345_in>; + }; +}; + &uart0 { pinctrl-names = "default"; pinctrl-0 = <&uart0_pb_pins>;
Re: [PATCH 7/9] arm64: allwinner: a64: enable ANX6345 bridge on Pinebook
于 2018年10月18日 GMT+08:00 下午11:17:35, Vasily Khoruzhick <[email protected]> 写到:
Quoted 5 lines
Hi Icenowy,
Quoted 1 line · PDT Icenowy Zheng
Pinebook has an ANX6345 bridge connected to the RGB666 LCD output,
and
Quoted 8 lines
Quoted 4 lines
the I2C controlling signals are connected to
R_I2Cbus.Enable it in the device tree, and add a usable EDID from the panel's datasheet (at least 14" Pinebook used a panel without EDID).
There's no EDID in dts and 14" Pinebook uses a panel with EDID. Is it leftover
of old comment?
Yes, it is.
Quoted 87 lines
Regards,
VasilyQuoted 4 lines
Signed-off-by Icenowy Zheng <[email protected]>--- .../dts/allwinner/sun50i-a64-pinebook.dts | 43+++++++++++++++++++
Quoted 78 lines
1 file changed, 43 insertions(+)(quoted diff) +0
-0
b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinebook.dtsindex77fac84797e9..d7c14d0d61f9100644arch/arm64/boot/dts/allwinner/sun50i-a64-pinebook.dts +43
-0@@ -66,6 +66,10 @@ }; }; +&de { + status = "okay"; +}; + &ehci0 { phys = <&usbphy 0>; phy-names = "usb";@@ -76,6 +80,10 @@ status = "okay"; }; +&mixer0 { + status = "okay"; +}; + &mmc0 { pinctrl-names = "default"; pinctrl-0 = <&mmc0_pins>;@@ -127,6 +135,27 @@ status = "okay"; }; +&r_i2c { + pinctrl-names = "default"; + pinctrl-0 = <&r_i2c_pins_a>; + status = "okay"; + + anx6345: anx6345@38 { + compatible = "analogix,anx6345"; + reg = <0x38>; + reset-gpios = <&pio 3 24 GPIO_ACTIVE_HIGH>; /* PD24 */ + panel-supply = <®_dc1sw>; + dvdd25-supply = <®_dldo2>; + dvdd12-supply = <®_fldo1>; + + port { + anx6345_in: endpoint { + remote-endpoint = <&tcon0_out_anx6345>; + }; + }; + }; +}; + &r_rsb { status = "okay";@@ -267,6 +296,20 @@ vcc-hdmi-supply = <®_dldo1>; }; +&tcon0 { + pinctrl-names = "default"; + pinctrl-0 = <&lcd_rgb666_pins>; + + status = "okay"; +}; + +&tcon0_out { + tcon0_out_anx6345: endpoint@0 { + reg = <0>; + remote-endpoint = <&anx6345_in>; + }; +}; + &uart0 { pinctrl-names = "default"; pinctrl-0 = <&uart0_pb_pins>;
Signature · 3 lines
You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/[email protected] For more options, visit https://groups.google.com/d/optout.
PATCH 8/9 arm64: allwinner: a64: enable ANX6345 bridge on TERES-I
In reply to Icenowy ZhengTERES-I has an ANX6345 bridge connected to the RGB666 LCD output, and the I2C controlling signals are connected to I2C0 bus.
Enable it in the device tree.
--- .../boot/dts/allwinner/sun50i-a64-teres-i.dts | 40 +++++++++++++++++-- 1 file changed, 36 insertions(+), 4 deletions(-)
arch/arm64/boot/dts/allwinner/sun50i-a64-teres-i.dts +36 -4
@@ -72,20 +72,38 @@ }; }; +&de { + status = "okay"; +}; + &ehci1 { status = "okay"; }; -/* The ANX6345 eDP-bridge is on i2c0. There is no linux (mainline) - * driver for this chip at the moment, the bootloader initializes it. - * However it can be accessed with the i2c-dev driver from user space. - */ &i2c0 { clock-frequency = <100000>; pinctrl-names = "default"; pinctrl-0 = <&i2c0_pins>; status = "okay"; + + anx6345: anx6345@38 { + compatible = "analogix,anx6345"; + reg = <0x38>; + reset-gpios = <&pio 3 24 GPIO_ACTIVE_HIGH>; /* PD24 */ + dvdd25-supply = <®_dldo2>; + dvdd12-supply = <®_dldo3>; + + port { + anx6345_in: endpoint { + remote-endpoint = <&tcon0_out_anx6345>; + }; + }; + }; +}; + +&mixer0 { + status = "okay"; }; &mmc0 {
@@ -258,6 +276,20 @@ vcc-hdmi-supply = <®_dldo1>; }; +&tcon0 { + pinctrl-names = "default"; + pinctrl-0 = <&lcd_rgb666_pins>; + + status = "okay"; +}; + +&tcon0_out { + tcon0_out_anx6345: endpoint@0 { + reg = <0>; + remote-endpoint = <&anx6345_in>; + }; +}; + &uart0 { pinctrl-names = "default"; pinctrl-0 = <&uart0_pb_pins>;
Signature · 1 line
2.18.1
PATCH 9/9 drm/sun4i: rgb: Add 5% tolerance to dot clock frequency check
In reply to Icenowy ZhengFrom: Chen-Yu Tsai <[email protected]>
The panels shipped with Allwinner devices are very "generic", i.e. they do not have model numbers or reliable sources of information for the timings (that we know of) other than the fex files shipped on them. The dot clock frequency provided in the fex files have all been rounded to the nearest MHz, as that is the unit used in them.
We were using the simple panel "urt,umsh-8596md-t" as a substitute for the A13 Q8 tablets in the absence of a specific model for what may be many different but otherwise timing compatible panels. This was usable without any visual artifacts or side effects, until the dot clock rate check was added in commit bb43d40d7c83 ("drm/sun4i:
rgb: Validate the clock rate").
The reason this check fails is because the dotclock frequency for this model is 33.26 MHz, which is not achievable with our dot clock hardware, and the rate returned by clk_round_rate deviates slightly, causing the driver to reject the display mode.
The LCD panels have some tolerance on the dot clock frequency, even if it's not specified in their datasheets.
This patch adds a 5% tolerence to the dot clock check.
--- drivers/gpu/drm/sun4i/sun4i_rgb.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/gpu/drm/sun4i/sun4i_rgb.c +3 -2
@@ -92,13 +92,14 @@ static enum drm_mode_status sun4i_rgb_mode_valid(struct drm_encoder *crtc,DRM_DEBUG_DRIVER ("Vertical parameters OK\n" ); +/* Check against a 5% tolerance for the dot clock */ tcon->dclk_min_div =6 ; tcon->dclk_max_div =127 ; rounded_rate =clk_round_rate (tcon->dclk, rate); -if (rounded_rate < rate) +if (rounded_rate < rate *19 /20 )return MODE_CLOCK_LOW ; -if (rounded_rate > rate) +if (rounded_rate > rate *21 /20 )return MODE_CLOCK_HIGH ;DRM_DEBUG_DRIVER ("Clock rate OK\n" );
Signature · 1 line
2.18.1
Laurent Pinchart
reviewerRe: [PATCH 9/9] [DO NOT MERGE] drm/sun4i: rgb: Add 5% tolerance to dot clock frequency check
Hi Icenowy,
Thank you for the patch.
Quoted 20 lines · On Thursday, 18 October 2018 10:33:27 EEST Icenowy Zheng wrote:
From: Chen-Yu Tsai <[email protected]>
The panels shipped with Allwinner devices are very "generic", i.e. they do not have model numbers or reliable sources of information for the timings (that we know of) other than the fex files shipped on them. The dot clock frequency provided in the fex files have all been rounded to the nearest MHz, as that is the unit used in them.
We were using the simple panel "urt,umsh-8596md-t" as a substitute for the A13 Q8 tablets in the absence of a specific model for what may be many different but otherwise timing compatible panels. This was usable without any visual artifacts or side effects, until the dot clock rate check was added in commit
bb43d40d7c83("drm/sun4i:
rgb: Validate the clock rate").The reason this check fails is because the dotclock frequency for this model is 33.26 MHz, which is not achievable with our dot clock hardware, and the rate returned by
clk_round_ratedeviates slightly, causing the driver to reject the display mode.
Quoted 4 lines
The LCD panels have some tolerance on the dot clock frequency, even if it's not specified in their datasheets.
This patch adds a 5% tolerence to the dot clock check.
Why do you think this shouldn't be merged ?
Quoted 27 lines
Signed-off-by Chen-Yu Tsai <[email protected]>--- drivers/gpu/drm/sun4i/sun4i_rgb.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)(quoted diff) +0
-0
b/drivers/gpu/drm/sun4i/sun4i_rgb.cindexbf068da6b12e..23bdc449eacc100644drivers/gpu/drm/sun4i/sun4i_rgb.c +3
-2@@ -92,13 +92,14 @@ static enum drm_mode_status sun4i_rgb_mode_valid(struct drm_encoder *crtc,DRM_DEBUG_DRIVER ("Vertical parameters OK\n" ); +/* Check against a 5% tolerance for the dot clock */ tcon->dclk_min_div =6 ; tcon->dclk_max_div =127 ; rounded_rate =clk_round_rate (tcon->dclk, rate); -if (rounded_rate < rate) +if (rounded_rate < rate *19 /20 )return MODE_CLOCK_LOW ; -if (rounded_rate > rate) +if (rounded_rate > rate *21 /20 )return MODE_CLOCK_HIGH ;
DRM_DEBUG_DRIVER("Clock rate OK\n");
Signature · 3 lines
Regards, Laurent Pinchart
Re: [PATCH 9/9] [DO NOT MERGE] drm/sun4i: rgb: Add 5% tolerance to dot clock frequency check
Quoted 26 lines · Laurent Pinchart
Hi Icenowy,
Thank you for the patch.
Quoted 20 lines · On Thursday, 18 October 2018 10:33:27 EEST Icenowy Zheng wrote:
From: Chen-Yu Tsai <[email protected]>
The panels shipped with Allwinner devices are very "generic", i.e. they do not have model numbers or reliable sources of information for the timings (that we know of) other than the fex files shipped on them. The dot clock frequency provided in the fex files have all been rounded to the nearest MHz, as that is the unit used in them.
We were using the simple panel "urt,umsh-8596md-t" as a substitute for the A13 Q8 tablets in the absence of a specific model for what may be many different but otherwise timing compatible panels. This was usable without any visual artifacts or side effects, until the dot clock rate check was added in commit
bb43d40d7c83("drm/sun4i:
rgb: Validate the clock rate").The reason this check fails is because the dotclock frequency for this model is 33.26 MHz, which is not achievable with our dot clock hardware, and the rate returned by
clk_round_ratedeviates slightly, causing the driver to reject the display mode.
Quoted 6 lines
Quoted 4 lines
The LCD panels have some tolerance on the dot clock frequency, even if it's not specified in their datasheets.
This patch adds a 5% tolerence to the dot clock check.
Why do you think this shouldn't be merged ?
It pisses of a lot of people who really insist upon accurate timing. I think a better fix would be to have a dotclock range in drm_panel, and some magic to figure out which one of these we can actually do. Then tell userspace that this is the mode is should request. That way userspace knows what the actual dotclock/refresh rate is, and the panel still works.
-Daniel
Quoted 40 lines
Quoted 27 lines
Signed-off-by Chen-Yu Tsai <[email protected]>--- drivers/gpu/drm/sun4i/sun4i_rgb.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)(quoted diff) +0
-0
b/drivers/gpu/drm/sun4i/sun4i_rgb.cindexbf068da6b12e..23bdc449eacc100644drivers/gpu/drm/sun4i/sun4i_rgb.c +3
-2@@ -92,13 +92,14 @@ static enum drm_mode_status sun4i_rgb_mode_valid(struct drm_encoder *crtc,DRM_DEBUG_DRIVER ("Vertical parameters OK\n" ); +/* Check against a 5% tolerance for the dot clock */ tcon->dclk_min_div =6 ; tcon->dclk_max_div =127 ; rounded_rate =clk_round_rate (tcon->dclk, rate); -if (rounded_rate < rate) +if (rounded_rate < rate *19 /20 )return MODE_CLOCK_LOW ; -if (rounded_rate > rate) +if (rounded_rate > rate *21 /20 )return MODE_CLOCK_HIGH ;Quoted 1 line
DRM_DEBUG_DRIVER("Clock rate OK\n");--
Regards,Laurent Pinchart
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Signature · 3 lines
Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch
Re: [PATCH 9/9] [DO NOT MERGE] drm/sun4i: rgb: Add 5% tolerance to dot clock frequency check
Quoted 28 lines · Daniel Vetter
Quoted 26 lines · Laurent Pinchart
Hi Icenowy,
Thank you for the patch.
Quoted 20 lines · On Thursday, 18 October 2018 10:33:27 EEST Icenowy Zheng wrote:
From: Chen-Yu Tsai <[email protected]>
The panels shipped with Allwinner devices are very "generic", i.e. they do not have model numbers or reliable sources of information for the timings (that we know of) other than the fex files shipped on them. The dot clock frequency provided in the fex files have all been rounded to the nearest MHz, as that is the unit used in them.
We were using the simple panel "urt,umsh-8596md-t" as a substitute for the A13 Q8 tablets in the absence of a specific model for what may be many different but otherwise timing compatible panels. This was usable without any visual artifacts or side effects, until the dot clock rate check was added in commit
bb43d40d7c83("drm/sun4i:
rgb: Validate the clock rate").The reason this check fails is because the dotclock frequency for this model is 33.26 MHz, which is not achievable with our dot clock hardware, and the rate returned by
clk_round_ratedeviates slightly, causing the driver to reject the display mode.
Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
The LCD panels have some tolerance on the dot clock frequency, even if it's not specified in their datasheets.
This patch adds a 5% tolerence to the dot clock check.
Why do you think this shouldn't be merged ?
It pisses of a lot of people who really insist upon accurate timing.
It's not just about accurate timings. That 5% is a made-up limit, that never have really been confirmed by looking at the typical tolerancies of panels.
And while being to relaxed might make some panels work that are not working currently, it might also break some panels that currently work and won't now, and ideally, we should really be able to let those panels work if they can, and filter out resolutions if they can't.
Quoted 5 lines
I think a better fix would be to have a dotclock range in
drm_panel, and some magic to figure out which one of these we can actually do. Then tell userspace that this is the mode is should request. That way userspace knows what the actual dotclock/refresh rate is, and the panel still works.
It's not just about panels, but also bridges with EDID where the tolerancy is not exposed.
Maxime
Signature · 3 lines
Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
Laurent Pinchart
reviewerRe: [PATCH 9/9] [DO NOT MERGE] drm/sun4i: rgb: Add 5% tolerance to dot clock frequency check
Hello,
Quoted 41 lines · On Thursday, 18 October 2018 12:42:58 EEST Maxime Ripard wrote:
Quoted 22 lines · Daniel Vetter
Quoted 21 lines · Laurent Pinchart
Quoted 20 lines · On Thursday, 18 October 2018 10:33:27 EEST Icenowy Zheng wrote:
From: Chen-Yu Tsai <[email protected]>
The panels shipped with Allwinner devices are very "generic", i.e. they do not have model numbers or reliable sources of information for the timings (that we know of) other than the fex files shipped on them. The dot clock frequency provided in the fex files have all been rounded to the nearest MHz, as that is the unit used in them.
We were using the simple panel "urt,umsh-8596md-t" as a substitute for the A13 Q8 tablets in the absence of a specific model for what may be many different but otherwise timing compatible panels. This was usable without any visual artifacts or side effects, until the dot clock rate check was added in commit
bb43d40d7c83("drm/sun4i:
rgb: Validate the clock rate").The reason this check fails is because the dotclock frequency for this model is 33.26 MHz, which is not achievable with our dot clock hardware, and the rate returned by
clk_round_ratedeviates slightly, causing the driver to reject the display mode.Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
The LCD panels have some tolerance on the dot clock frequency, even if it's not specified in their datasheets.
This patch adds a 5% tolerence to the dot clock check.
Why do you think this shouldn't be merged ?
It pisses of a lot of people who really insist upon accurate timing.
It's not just about accurate timings. That 5% is a made-up limit, that never have really been confirmed by looking at the typical tolerancies of panels.
And while being to relaxed might make some panels work that are not working currently, it might also break some panels that currently work and won't now, and ideally, we should really be able to let those panels work if they can, and filter out resolutions if they can't.
Quoted 8 lines
Quoted 5 lines
I think a better fix would be to have a dotclock range in
drm_panel, and some magic to figure out which one of these we can actually do. Then tell userspace that this is the mode is should request. That way userspace knows what the actual dotclock/refresh rate is, and the panel still works.It's not just about panels, but also bridges with EDID where the tolerancy is not exposed.
Given that the tolerance is a property of the panel or bridge, I agree with Daniel that it should be implemented there, or at least in cooperation with drm_panel and drm_bridge.
Semi-related information, I think the CEA and VESA standards allow a 0.5% clock tolerance. What is the maximum clock frequency deviation required for this platform ?
Signature · 3 lines
Regards, Laurent Pinchart
Re: [PATCH 9/9] [DO NOT MERGE] drm/sun4i: rgb: Add 5% tolerance to dot clock frequency check
Quoted 50 lines · Laurent Pinchart
Hello,
Quoted 47 lines · On Thursday, 18 October 2018 12:42:58 EEST Maxime Ripard wrote:
Quoted 22 lines · Daniel Vetter
Quoted 21 lines · Laurent Pinchart
Quoted 20 lines · On Thursday, 18 October 2018 10:33:27 EEST Icenowy Zheng wrote:
From: Chen-Yu Tsai <[email protected]>
The panels shipped with Allwinner devices are very "generic", i.e. they do not have model numbers or reliable sources of information for the timings (that we know of) other than the fex files shipped on them. The dot clock frequency provided in the fex files have all been rounded to the nearest MHz, as that is the unit used in them.
We were using the simple panel "urt,umsh-8596md-t" as a substitute for the A13 Q8 tablets in the absence of a specific model for what may be many different but otherwise timing compatible panels. This was usable without any visual artifacts or side effects, until the dot clock rate check was added in commit
bb43d40d7c83("drm/sun4i:
rgb: Validate the clock rate").The reason this check fails is because the dotclock frequency for this model is 33.26 MHz, which is not achievable with our dot clock hardware, and the rate returned by
clk_round_ratedeviates slightly, causing the driver to reject the display mode.Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
The LCD panels have some tolerance on the dot clock frequency, even if it's not specified in their datasheets.
This patch adds a 5% tolerence to the dot clock check.
Why do you think this shouldn't be merged ?
It pisses of a lot of people who really insist upon accurate timing.
It's not just about accurate timings. That 5% is a made-up limit, that never have really been confirmed by looking at the typical tolerancies of panels.
And while being to relaxed might make some panels work that are not working currently, it might also break some panels that currently work and won't now, and ideally, we should really be able to let those panels work if they can, and filter out resolutions if they can't.
Quoted 5 lines
I think a better fix would be to have a dotclock range in
drm_panel, and some magic to figure out which one of these we can actually do. Then tell userspace that this is the mode is should request. That way userspace knows what the actual dotclock/refresh rate is, and the panel still works.
Quoted 6 lines
Quoted 2 lines
It's not just about panels, but also bridges with EDID where the tolerancy is not exposed.
Given that the tolerance is a property of the panel or bridge, I agree with Daniel that it should be implemented there, or at least in cooperation with
drm_panelanddrm_bridge.
How are we supposed to deal with panels without any documentation then?
Quoted 3 lines
Semi-related information, I think the CEA and VESA standards allow a 0.5% clock tolerance. What is the maximum clock frequency deviation required for this platform ?
Looks like it does indeed. That's definetely good to know.
Thanks!
Maxime
Signature · 3 lines
Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
Re: [PATCH 9/9] [DO NOT MERGE] drm/sun4i: rgb: Add 5% tolerance to dot clock frequency check
Quoted 86 lines · 在 2018-10-18四的 14:18 +0200,Maxime Ripard写道:
Quoted 73 lines · Laurent Pinchart
Hello,
Quoted 70 lines · On Thursday, 18 October 2018 12:42:58 EEST Maxime Ripard wrote:
Quoted 40 lines · Daniel Vetter
Quoted 39 lines · Laurent Pinchart
Quoted 37 lines · On Thursday, 18 October 2018 10:33:27 EEST Icenowy Zheng wrote:
From: Chen-Yu Tsai <[email protected]>
The panels shipped with Allwinner devices are very "generic", i.e.
they do not have model numbers or reliable sources of information
for the timings (that we know of) other than the fex files shipped
on them. The dot clock frequency provided in the fex files have all
been rounded to the nearest MHz, as that is the unit used in them.We were using the simple panel "urt,umsh-8596md-t" as a substitute
for the A13 Q8 tablets in the absence of a specific model for what
may be many different but otherwise timing compatible panels. This
was usable without any visual artifacts or side effects, until the
dot clock rate check was added in commitbb43d40d7c83("drm/sun4i:
rgb: Validate the clock rate").The reason this check fails is because the dotclock frequency for
this model is 33.26 MHz, which is not achievable with our dot clock
hardware, and the rate returned byclk_round_ratedeviates slightly,
causing the driver to reject the display mode.The LCD panels have some tolerance on the dot clock frequency, even
if it's not specified in their datasheets.Quoted 6 lines
Quoted 3 lines
Quoted 1 line
This patch adds a 5% tolerence to the dot clock check.
Why do you think this shouldn't be merged ?
It pisses of a lot of people who really insist upon accurate timing.
It's not just about accurate timings. That 5% is a made-up limit, that
never have really been confirmed by looking at the typical tolerancies
of panels.And while being to relaxed might make some panels work that are not
working currently, it might also break some panels that currently work
and won't now, and ideally, we should really be able to let those panels work if they can, and filter out resolutions if they can't.Quoted 7 lines
I think a better fix would be to have a dotclock range in
drm_panel,
and some magic to figure out which one of these we can actually do. Then tell userspace that this is the mode is should request. That way userspace knows what the actual dotclock/refresh
rate is, and the panel still works.Quoted 8 lines
Quoted 2 lines
It's not just about panels, but also bridges with EDID where the tolerancy is not exposed.
Given that the tolerance is a property of the panel or bridge, I agree with
Daniel that it should be implemented there, or at least in cooperation withdrm_panelanddrm_bridge.How are we supposed to deal with panels without any documentation then?
Quoted 7 lines
Quoted 5 lines
Semi-related information, I think the CEA and VESA standards allow a 0.5%
clock tolerance. What is the maximum clock frequency deviation required for
this platform ?Looks like it does indeed. That's definetely good to know.
Then maybe we can choose to allow 0.5% error when a bridge is attached?
Quoted 4 lines
Thanks!
Maxime
Signature · 3 lines
You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/[email protected] For more options, visit https://groups.google.com/d/optout.
Re: [PATCH 9/9] [DO NOT MERGE] drm/sun4i: rgb: Add 5% tolerance to dot clock frequency check
Quoted 93 lines · Icenowy Zheng
? 2018-10-18?? 14:18 +0200?Maxime Ripard???
Quoted 92 lines · Laurent Pinchart
Quoted 73 lines
Hello,
Quoted 70 lines · On Thursday, 18 October 2018 12:42:58 EEST Maxime Ripard wrote:
Quoted 40 lines · Daniel Vetter
Quoted 39 lines · Laurent Pinchart
Quoted 37 lines · On Thursday, 18 October 2018 10:33:27 EEST Icenowy Zheng wrote:
From: Chen-Yu Tsai <[email protected]>
The panels shipped with Allwinner devices are very "generic", i.e.
they do not have model numbers or reliable sources of information
for the timings (that we know of) other than the fex files shipped
on them. The dot clock frequency provided in the fex files have all
been rounded to the nearest MHz, as that is the unit used in them.We were using the simple panel "urt,umsh-8596md-t" as a substitute
for the A13 Q8 tablets in the absence of a specific model for what
may be many different but otherwise timing compatible panels. This
was usable without any visual artifacts or side effects, until the
dot clock rate check was added in commitbb43d40d7c83("drm/sun4i:
rgb: Validate the clock rate").The reason this check fails is because the dotclock frequency for
this model is 33.26 MHz, which is not achievable with our dot clock
hardware, and the rate returned byclk_round_ratedeviates slightly,
causing the driver to reject the display mode.The LCD panels have some tolerance on the dot clock frequency, even
if it's not specified in their datasheets.Quoted 6 lines
Quoted 3 lines
Quoted 1 line
This patch adds a 5% tolerence to the dot clock check.
Why do you think this shouldn't be merged ?
It pisses of a lot of people who really insist upon accurate timing.
It's not just about accurate timings. That 5% is a made-up limit, that
never have really been confirmed by looking at the typical tolerancies
of panels.And while being to relaxed might make some panels work that are not
working currently, it might also break some panels that currently work
and won't now, and ideally, we should really be able to let those panels work if they can, and filter out resolutions if they can't.Quoted 7 lines
I think a better fix would be to have a dotclock range in
drm_panel,
and some magic to figure out which one of these we can actually do. Then tell userspace that this is the mode is should request. That way userspace knows what the actual dotclock/refresh
rate is, and the panel still works.Quoted 8 lines
Quoted 2 lines
It's not just about panels, but also bridges with EDID where the tolerancy is not exposed.
Given that the tolerance is a property of the panel or bridge, I agree with
Daniel that it should be implemented there, or at least in cooperation withdrm_panelanddrm_bridge.How are we supposed to deal with panels without any documentation then?
Quoted 5 lines
Semi-related information, I think the CEA and VESA standards allow a 0.5%
clock tolerance. What is the maximum clock frequency deviation required for
this platform ?
Quoted 3 lines
Quoted 1 line
Looks like it does indeed. That's definetely good to know.
Then maybe we can choose to allow 0.5% error when a bridge is attached?
It doesn't fix the panel case, but that sounds reasonable yes
Maxime
Signature · 3 lines
Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
Laurent Pinchart
reviewerRe: [PATCH 9/9] [DO NOT MERGE] drm/sun4i: rgb: Add 5% tolerance to dot clock frequency check
In reply to Maxime RipardHi Maxime,
Quoted 49 lines · On Thursday, 18 October 2018 15:18:19 EEST Maxime Ripard wrote:
Quoted 48 lines · Laurent Pinchart
Quoted 47 lines · On Thursday, 18 October 2018 12:42:58 EEST Maxime Ripard wrote:
Quoted 22 lines · Daniel Vetter
Quoted 21 lines · Laurent Pinchart
Quoted 20 lines · On Thursday, 18 October 2018 10:33:27 EEST Icenowy Zheng wrote:
From: Chen-Yu Tsai <[email protected]>
The panels shipped with Allwinner devices are very "generic", i.e. they do not have model numbers or reliable sources of information for the timings (that we know of) other than the fex files shipped on them. The dot clock frequency provided in the fex files have all been rounded to the nearest MHz, as that is the unit used in them.
We were using the simple panel "urt,umsh-8596md-t" as a substitute for the A13 Q8 tablets in the absence of a specific model for what may be many different but otherwise timing compatible panels. This was usable without any visual artifacts or side effects, until the dot clock rate check was added in commit
bb43d40d7c83("drm/sun4i:
rgb: Validate the clock rate").The reason this check fails is because the dotclock frequency for this model is 33.26 MHz, which is not achievable with our dot clock hardware, and the rate returned by
clk_round_ratedeviates slightly, causing the driver to reject the display mode.Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
The LCD panels have some tolerance on the dot clock frequency, even if it's not specified in their datasheets.
This patch adds a 5% tolerence to the dot clock check.
Why do you think this shouldn't be merged ?
It pisses of a lot of people who really insist upon accurate timing.
It's not just about accurate timings. That 5% is a made-up limit, that never have really been confirmed by looking at the typical tolerancies of panels.
And while being to relaxed might make some panels work that are not working currently, it might also break some panels that currently work and won't now, and ideally, we should really be able to let those panels work if they can, and filter out resolutions if they can't.
Quoted 5 lines
I think a better fix would be to have a dotclock range in
drm_panel, and some magic to figure out which one of these we can actually do. Then tell userspace that this is the mode is should request. That way userspace knows what the actual dotclock/refresh rate is, and the panel still works.
Quoted 8 lines
Quoted 6 lines
Quoted 2 lines
It's not just about panels, but also bridges with EDID where the tolerancy is not exposed.
Given that the tolerance is a property of the panel or bridge, I agree with Daniel that it should be implemented there, or at least in cooperation with
drm_panelanddrm_bridge.How are we supposed to deal with panels without any documentation then?
We can only guess, but if the guess comes from the panel driver, it will at least not affect all panels and bridges, like this patch does.
Quoted 5 lines
Quoted 3 lines
Semi-related information, I think the CEA and VESA standards allow a 0.5% clock tolerance. What is the maximum clock frequency deviation required for this platform ?
Looks like it does indeed. That's definetely good to know.
Signature · 3 lines
Regards, Laurent Pinchart
Re: [PATCH 9/9] [DO NOT MERGE] drm/sun4i: rgb: Add 5% tolerance to dot clock frequency check
In reply to Laurent PinchartQuoted 3 lines · Laurent Pinchart
Given that the tolerance is a property of the panel or bridge, I agree with Daniel that it should be implemented there, or at least in cooperation with
drm_panelanddrm_bridge.
Clock tolerance is not specified in ANX6345 datasheet.
Quoted 3 lines
Semi-related information, I think the CEA and VESA standards allow a 0.5% clock tolerance. What is the maximum clock frequency deviation required for this platform ?
This particular platform requires ~1% deviation.
E.g. on Pinebook with 768p panel: requested clock: 73.0 MHz, real
clock: 72.296296 MHz (0.96%)
on Pinebook with 1080p panel: requested clock: 138.5 MHz, real clock:
138.461538 MHz (0.03%)
So unfortunately 0.5% is not enough.
Regards,
Vasily
Re: [PATCH 9/9] [DO NOT MERGE] drm/sun4i: rgb: Add 5% tolerance to dot clock frequency check
In reply to Maxime RipardQuoted 1 line
it might also break some panels that currently work and won't now,
Could you give a scenario where this happens? My reading of the patch says that it should only cause the display to be ON in more circumstances (i.e. in cases where it previously would stay OFF because of MODE_CLOCK_LOW or MODE_CLOCK_HIGH).
Stefan
Quoted 9 lines · Icenowy Zheng
This patchset brings the support for Analogix ANX6345 RGB-(e)DP bridge, which is used by some Allwinner A64 laptops, such as Pinebook and Olimex TERES-I.
It reuses some definitions from the ANX78xx driver that already exists in the kernel tree, but the driver code itself is rewritten, because the big difference between ANX6345 and ANX78xx.
Quoted 7 lines
This patchset also enables the bridge on Pinebook and TERES-I, and a temporary workaround patch (do not merge) for the dot clock accuracy problem of sun4i-drm.
This patchset assumes some fixes ([1], [2] and [3]) are already applied, without them the patchset cannot be tested on the A64 devices mentioned above.
For whole series:
Quoted 53 lines
[1] https://patchwork.kernel.org/patch/10628827/
[2] https://patchwork.kernel.org/patch/10628825/
[3] https://patchwork.kernel.org/patch/10646791/Chen-Yu Tsai (1):
[DO NOT MERGE] drm/sun4i: rgb: Add 5% tolerance to dot clock frequency
checkIcenowy Zheng (8):
drm/bridge: move ANA78xx driver to analogix subdirectory drm/bridge: split some definitions of ANX78xx to dedicated headers drm/bridge: extract some Analogix I2C DP common code
dt-bindings: Add ANX6345 DP/eDP transmitter binding drm/bridge: Add Analogix anx6345 support
arm64: allwinner: a64: add pinmux for RGB666 LCD
arm64: allwinner: a64: enable ANX6345 bridge on Pinebook
arm64: allwinner: a64: enable ANX6345 bridge on TERES-I.../bindings/display/bridge/anx6345.txt | 39 + .../dts/allwinner/sun50i-a64-pinebook.dts | 43 + .../boot/dts/allwinner/sun50i-a64-teres-i.dts | 40 +- arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 9 + drivers/gpu/drm/bridge/Kconfig | 10 - drivers/gpu/drm/bridge/Makefile | 4 +- drivers/gpu/drm/bridge/analogix-anx78xx.h | 719 --------------- drivers/gpu/drm/bridge/analogix/Kconfig | 25 + drivers/gpu/drm/bridge/analogix/Makefile | 4 + .../drm/bridge/analogix/analogix-anx6345.c | 862 ++++++++++++++++++ .../bridge/{ => analogix}/analogix-anx78xx.c | 146 +-- .../drm/bridge/analogix/analogix-anx78xx.h | 265 ++++++ .../drm/bridge/analogix/analogix-i2c-dptx.c | 169 ++++ .../drm/bridge/analogix/analogix-i2c-dptx.h | 258 ++++++ .../bridge/analogix/analogix-i2c-txcommon.h | 240 +++++ drivers/gpu/drm/sun4i/sun4i_rgb.c | 5 +- 16 files changed, 1956 insertions(+), 882 deletions(-) create mode 100644 Documentation/devicetree/bindings/display/bridge/anx6345.txt delete mode 100644 drivers/gpu/drm/bridge/analogix-anx78xx.h create mode 100644 drivers/gpu/drm/bridge/analogix/analogix-anx6345.c rename drivers/gpu/drm/bridge/{ => analogix}/analogix-anx78xx.c (90%) create mode 100644 drivers/gpu/drm/bridge/analogix/analogix-anx78xx.h create mode 100644 drivers/gpu/drm/bridge/analogix/analogix-i2c-dptx.c create mode 100644 drivers/gpu/drm/bridge/analogix/analogix-i2c-dptx.h create mode 100644 drivers/gpu/drm/bridge/analogix/analogix-i2c-txcommon.h--
2.18.1_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Quoted 4 lines · Icenowy Zheng
This patchset brings the support for Analogix ANX6345 RGB-(e)DP bridge, which is used by some Allwinner A64 laptops, such as Pinebook and Olimex TERES-I.
So what's the status here? I'm working on the Teres-I and I find myself recreating the chunks in this patchset almost verbatim (only DT so far), one by one, so there must be something right about them ;-)
Whose turn is it?
Torsten
Quoted 7 lines · Torsten Duwe
Quoted 4 lines · Icenowy Zheng
This patchset brings the support for Analogix ANX6345 RGB-(e)DP bridge, which is used by some Allwinner A64 laptops, such as Pinebook and Olimex TERES-I.
Quoted 5 lines
So what's the status here? I'm working on the Teres-I and I find myself recreating the chunks in this patchset almost verbatim (only DT so far), one by one, so there must be something right about them ;-)
Whose turn is it?
I've sent v2 yesterday, however I tested it only on Pinebook.
Quoted 8 lines
Torsten
_______________________________________________
linux-arm-kernel mailing list linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
v2 cover Analogix ANX6345 RGB-(e)DP bridge support
This patchset brings support for Analogix ANX6345 RGB-(e)DP bridge, which is used by some Allwinner A64 laptops, such as Pinebook and Olimex TERES-I.
It reuses some definitions from ANX78xx driver that already exists in the kernel tree, but the driver code itself is rewritten due to significant difference between ANX6345 and ANX78xx.
This patchset also enables the bridge on Pinebook and TERES-I and adds 1% tolerance into dotclock check in sun4i driver in case if bridge is connected
v2: - sort Kconfig and Makefile entries alphabetically
- remove panel supply from anx6345
- add support for panels into anx6345 driver
- add compatible and binding for generic eDP panel
- replace patch that adds 5% tolerance for dotclock check in sun4i driver for panel and bridges with patch that adds 1% tolerance in case if bridge is connected.
Icenowy Zheng (8):
drm/bridge: move ANA78xx driver to analogix subdirectory drm/bridge: split some definitions of ANX78xx to dedicated headers drm/bridge: extract some Analogix I2C DP common code
dt-bindings: Add ANX6345 DP/eDP transmitter binding drm/bridge: Add Analogix anx6345 support
arm64: allwinner: a64: add pinmux for RGB666 LCD
arm64: allwinner: a64: enable LCD-related hardware for Pinebook
arm64: allwinner: a64: enable LCD-related hardware for TERES-I
Vasily Khoruzhick (4):
drm/sun4i: rgb: Add 1% tolerance to dclk frequency check when bridge
is connected
drm/panel: simple: don't fail if we don't have panel desc
dt-bindings: add binding for generic eDP panel
drm/panel: simple: add generic eDP panel
.../bindings/display/bridge/anx6345.txt | 56 ++
.../bindings/display/panel/panel-edp.txt | 7 +
.../dts/allwinner/sun50i-a64-pinebook.dts | 74 ++
.../boot/dts/allwinner/sun50i-a64-teres-i.dts | 71 +-
arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 9 +
drivers/gpu/drm/bridge/Kconfig | 10 -
drivers/gpu/drm/bridge/Makefile | 4 +-
drivers/gpu/drm/bridge/analogix-anx78xx.h | 719 ---------------
drivers/gpu/drm/bridge/analogix/Kconfig | 25 +
drivers/gpu/drm/bridge/analogix/Makefile | 4 +
.../drm/bridge/analogix/analogix-anx6345.c | 845 ++++++++++++++++++
.../bridge/{ => analogix}/analogix-anx78xx.c | 146 +--
.../drm/bridge/analogix/analogix-anx78xx.h | 265 ++++++
.../drm/bridge/analogix/analogix-i2c-dptx.c | 169 ++++
.../drm/bridge/analogix/analogix-i2c-dptx.h | 258 ++++++
.../bridge/analogix/analogix-i2c-txcommon.h | 240 +++++
drivers/gpu/drm/panel/panel-simple.c | 24 +-
drivers/gpu/drm/sun4i/sun4i_rgb.c | 16 +-
drivers/gpu/drm/sun4i/sun4i_tcon.h | 1 +
19 files changed, 2049 insertions(+), 894 deletions(-)
create mode 100644 Documentation/devicetree/bindings/display/bridge/anx6345.txt
create mode 100644 Documentation/devicetree/bindings/display/panel/panel-edp.txt
delete mode 100644 drivers/gpu/drm/bridge/analogix-anx78xx.h
create mode 100644 drivers/gpu/drm/bridge/analogix/analogix-anx6345.c
rename drivers/gpu/drm/bridge/{ => analogix}/analogix-anx78xx.c (90%)
create mode 100644 drivers/gpu/drm/bridge/analogix/analogix-anx78xx.h
create mode 100644 drivers/gpu/drm/bridge/analogix/analogix-i2c-dptx.c
create mode 100644 drivers/gpu/drm/bridge/analogix/analogix-i2c-dptx.h
create mode 100644 drivers/gpu/drm/bridge/analogix/analogix-i2c-txcommon.hSignature · 1 line
2.20.1
A message that is not in the archive (sent off-list or not yet received): 20190203185501.8958-1-anarsoul-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
PATCH RESEND v2 1/12 drm/bridge: move ANA78xx driver to analogix subdirectory
From: Icenowy Zheng <[email protected]>
As ANA78xx chips are designed and produced by Analogix Semiconductor, Inc, move their driver codes into analogix subdirectory.
---
drivers/gpu/drm/bridge/Kconfig | 10 ----------
drivers/gpu/drm/bridge/Makefile | 4 ++--
drivers/gpu/drm/bridge/analogix/Kconfig | 10 ++++++++++
drivers/gpu/drm/bridge/analogix/Makefile | 1 +
.../gpu/drm/bridge/{ => analogix}/analogix-anx78xx.c | 0
.../gpu/drm/bridge/{ => analogix}/analogix-anx78xx.h | 0
6 files changed, 13 insertions(+), 12 deletions(-)
rename drivers/gpu/drm/bridge/{ => analogix}/analogix-anx78xx.c (100%)
rename drivers/gpu/drm/bridge/{ => analogix}/analogix-anx78xx.h (100%)drivers/gpu/drm/bridge/Kconfig +0 -10
@@ -15,16 +15,6 @@ config DRM_PANEL_BRIDGE menu "Display Interface Bridges" depends on DRM && DRM_BRIDGE -config DRM_ANALOGIX_ANX78XX - tristate "Analogix ANX78XX bridge" - select DRM_KMS_HELPER - select REGMAP_I2C - ---help--- - ANX78XX is an ultra-low Full-HD SlimPort transmitter - designed for portable devices. The ANX78XX transforms - the HDMI output of an application processor to MyDP - or DisplayPort. - config DRM_CDNS_DSI tristate "Cadence DPI/DSI bridge" select DRM_KMS_HELPER
drivers/gpu/drm/bridge/Makefile +2 -2
@@ -1,5 +1,4 @@ # SPDX-License-Identifier: GPL-2.0 -obj-$(CONFIG_DRM_ANALOGIX_ANX78XX) += analogix-anx78xx.o obj-$(CONFIG_DRM_CDNS_DSI) += cdns-dsi.o obj-$(CONFIG_DRM_DUMB_VGA_DAC) += dumb-vga-dac.o obj-$(CONFIG_DRM_LVDS_ENCODER) += lvds-encoder.o
@@ -12,8 +11,9 @@ obj-$(CONFIG_DRM_SII9234) += sii9234.o obj-$(CONFIG_DRM_THINE_THC63LVD1024) += thc63lvd1024.o obj-$(CONFIG_DRM_TOSHIBA_TC358764) += tc358764.o obj-$(CONFIG_DRM_TOSHIBA_TC358767) += tc358767.o -obj-$(CONFIG_DRM_ANALOGIX_DP) += analogix/ obj-$(CONFIG_DRM_I2C_ADV7511) += adv7511/ obj-$(CONFIG_DRM_TI_SN65DSI86) += ti-sn65dsi86.o obj-$(CONFIG_DRM_TI_TFP410) += ti-tfp410.o + +obj-y += analogix/ obj-y += synopsys/
drivers/gpu/drm/bridge/analogix/Kconfig +10 -0
@@ -1,3 +1,13 @@ +config DRM_ANALOGIX_ANX78XX + tristate "Analogix ANX78XX bridge" + select DRM_KMS_HELPER + select REGMAP_I2C + help + ANX78XX is an ultra-low Full-HD SlimPort transmitter + designed for portable devices. The ANX78XX transforms + the HDMI output of an application processor to MyDP + or DisplayPort. + config DRM_ANALOGIX_DP tristate depends on DRM
drivers/gpu/drm/bridge/analogix/Makefile +1 -0
@@ -1,2 +1,3 @@ analogix_dp-objs := analogix_dp_core.o analogix_dp_reg.o +obj-$(CONFIG_DRM_ANALOGIX_ANX78XX) += analogix-anx78xx.o obj-$(CONFIG_DRM_ANALOGIX_DP) += analogix_dp.o
drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c renamed from drivers/gpu/drm/bridge/analogix-anx78xx.c +0 -0
drivers/gpu/drm/bridge/analogix/analogix-anx78xx.h renamed from drivers/gpu/drm/bridge/analogix-anx78xx.h +0 -0
Signature · 1 line
2.20.1
PATCH RESEND v2 2/12 drm/bridge: split some definitions of ANX78xx to dedicated headers
In reply to a message not in the archiveFrom: Icenowy Zheng <[email protected]>
Some definitions currently in analogix-anx78xx.h are not restricted to the ANX78xx series, but also applicable to other DisplayPort transmitters by Analogix.
Split out them to dedicated headers, and make analogix-anx78xx.h include them.
--- .../drm/bridge/analogix/analogix-anx78xx.h | 464 +----------------- .../drm/bridge/analogix/analogix-i2c-dptx.h | 248 ++++++++++ .../bridge/analogix/analogix-i2c-txcommon.h | 237 +++++++++ 3 files changed, 490 insertions(+), 459 deletions(-) create mode 100644 drivers/gpu/drm/bridge/analogix/analogix-i2c-dptx.h create mode 100644 drivers/gpu/drm/bridge/analogix/analogix-i2c-txcommon.h
drivers/gpu/drm/bridge/analogix/analogix-anx78xx.h +5 -459
@@ -15,9 +15,12 @@#ifndef __ANX78xx_H#define __ANX78xx_H -#define TX_P0 0x70 +#include "analogix-i2c-dptx.h" +#include "analogix-i2c-txcommon.h" + +#define TX_P0 ANALOGIX_I2C_DPTX#define TX_P1 0x7a -#define TX_P2 0x72 +#define TX_P2 ANALOGIX_I2C_TXCOMMON#define RX_P0 0x7e#define RX_P1 0x80
@@ -225,463 +228,6 @@#define SP_CLEAR_AVMUTE BIT(4)#define SP_SET_AVMUTE BIT(0) -/***************************************************************/ -/* Register definition of device address 0x70 */ -/***************************************************************/ - -/* HDCP Status Register */ -#define SP_TX_HDCP_STATUS_REG 0x00 -#define SP_AUTH_FAIL BIT(5) -#define SP_AUTHEN_PASS BIT(1) - -/* HDCP Control Register 0 */ -#define SP_HDCP_CTRL0_REG 0x01 -#define SP_RX_REPEATER BIT(6) -#define SP_RE_AUTH BIT(5) -#define SP_SW_AUTH_OK BIT(4) -#define SP_HARD_AUTH_EN BIT(3) -#define SP_HDCP_ENC_EN BIT(2) -#define SP_BKSV_SRM_PASS BIT(1) -#define SP_KSVLIST_VLD BIT(0) -/* HDCP Function Enabled */ -#define SP_HDCP_FUNCTION_ENABLED (BIT(0) | BIT(1) | BIT(2) | BIT(3)) - -/* HDCP Receiver BSTATUS Register 0 */ -#define SP_HDCP_RX_BSTATUS0_REG 0x1b -/* HDCP Receiver BSTATUS Register 1 */ -#define SP_HDCP_RX_BSTATUS1_REG 0x1c - -/* HDCP Embedded "Blue Screen" Content Registers */ -#define SP_HDCP_VID0_BLUE_SCREEN_REG 0x2c -#define SP_HDCP_VID1_BLUE_SCREEN_REG 0x2d -#define SP_HDCP_VID2_BLUE_SCREEN_REG 0x2e - -/* HDCP Wait R0 Timing Register */ -#define SP_HDCP_WAIT_R0_TIME_REG 0x40 - -/* HDCP Link Integrity Check Timer Register */ -#define SP_HDCP_LINK_CHECK_TIMER_REG 0x41 - -/* HDCP Repeater Ready Wait Timer Register */ -#define SP_HDCP_RPTR_RDY_WAIT_TIME_REG 0x42 - -/* HDCP Auto Timer Register */ -#define SP_HDCP_AUTO_TIMER_REG 0x51 - -/* HDCP Key Status Register */ -#define SP_HDCP_KEY_STATUS_REG 0x5e - -/* HDCP Key Command Register */ -#define SP_HDCP_KEY_COMMAND_REG 0x5f -#define SP_DISABLE_SYNC_HDCP BIT(2) - -/* OTP Memory Key Protection Registers */ -#define SP_OTP_KEY_PROTECT1_REG 0x60 -#define SP_OTP_KEY_PROTECT2_REG 0x61 -#define SP_OTP_KEY_PROTECT3_REG 0x62 -#define SP_OTP_PSW1 0xa2 -#define SP_OTP_PSW2 0x7e -#define SP_OTP_PSW3 0xc6 - -/* DP System Control Registers */ -#define SP_DP_SYSTEM_CTRL_BASE (0x80 - 1) -/* Bits for DP System Control Register 2 */ -#define SP_CHA_STA BIT(2) -/* Bits for DP System Control Register 3 */ -#define SP_HPD_STATUS BIT(6) -#define SP_STRM_VALID BIT(2) -/* Bits for DP System Control Register 4 */ -#define SP_ENHANCED_MODE BIT(3) - -/* DP Video Control Register */ -#define SP_DP_VIDEO_CTRL_REG 0x84 -#define SP_COLOR_F_MASK 0x06 -#define SP_COLOR_F_SHIFT 1 -#define SP_BPC_MASK 0xe0 -#define SP_BPC_SHIFT 5 -# define SP_BPC_6BITS 0x00 -# define SP_BPC_8BITS 0x01 -# define SP_BPC_10BITS 0x02 -# define SP_BPC_12BITS 0x03 - -/* DP Audio Control Register */ -#define SP_DP_AUDIO_CTRL_REG 0x87 -#define SP_AUD_EN BIT(0) - -/* 10us Pulse Generate Timer Registers */ -#define SP_I2C_GEN_10US_TIMER0_REG 0x88 -#define SP_I2C_GEN_10US_TIMER1_REG 0x89 - -/* Packet Send Control Register */ -#define SP_PACKET_SEND_CTRL_REG 0x90 -#define SP_AUD_IF_UP BIT(7) -#define SP_AVI_IF_UD BIT(6) -#define SP_MPEG_IF_UD BIT(5) -#define SP_SPD_IF_UD BIT(4) -#define SP_AUD_IF_EN BIT(3) -#define SP_AVI_IF_EN BIT(2) -#define SP_MPEG_IF_EN BIT(1) -#define SP_SPD_IF_EN BIT(0) - -/* DP HDCP Control Register */ -#define SP_DP_HDCP_CTRL_REG 0x92 -#define SP_AUTO_EN BIT(7) -#define SP_AUTO_START BIT(5) -#define SP_LINK_POLLING BIT(1) - -/* DP Main Link Bandwidth Setting Register */ -#define SP_DP_MAIN_LINK_BW_SET_REG 0xa0 -#define SP_LINK_BW_SET_MASK 0x1f -#define SP_INITIAL_SLIM_M_AUD_SEL BIT(5) - -/* DP Training Pattern Set Register */ -#define SP_DP_TRAINING_PATTERN_SET_REG 0xa2 - -/* DP Lane 0 Link Training Control Register */ -#define SP_DP_LANE0_LT_CTRL_REG 0xa3 -#define SP_TX_SW_SET_MASK 0x1b -#define SP_MAX_PRE_REACH BIT(5) -#define SP_MAX_DRIVE_REACH BIT(4) -#define SP_PRE_EMP_LEVEL1 BIT(3) -#define SP_DRVIE_CURRENT_LEVEL1 BIT(0) - -/* DP Link Training Control Register */ -#define SP_DP_LT_CTRL_REG 0xa8 -#define SP_LT_ERROR_TYPE_MASK 0x70 -# define SP_LT_NO_ERROR 0x00 -# define SP_LT_AUX_WRITE_ERROR 0x01 -# define SP_LT_MAX_DRIVE_REACHED 0x02 -# define SP_LT_WRONG_LANE_COUNT_SET 0x03 -# define SP_LT_LOOP_SAME_5_TIME 0x04 -# define SP_LT_CR_FAIL_IN_EQ 0x05 -# define SP_LT_EQ_LOOP_5_TIME 0x06 -#define SP_LT_EN BIT(0) - -/* DP CEP Training Control Registers */ -#define SP_DP_CEP_TRAINING_CTRL0_REG 0xa9 -#define SP_DP_CEP_TRAINING_CTRL1_REG 0xaa - -/* DP Debug Register 1 */ -#define SP_DP_DEBUG1_REG 0xb0 -#define SP_DEBUG_PLL_LOCK BIT(4) -#define SP_POLLING_EN BIT(1) - -/* DP Polling Control Register */ -#define SP_DP_POLLING_CTRL_REG 0xb4 -#define SP_AUTO_POLLING_DISABLE BIT(0) - -/* DP Link Debug Control Register */ -#define SP_DP_LINK_DEBUG_CTRL_REG 0xb8 -#define SP_M_VID_DEBUG BIT(5) -#define SP_NEW_PRBS7 BIT(4) -#define SP_INSERT_ER BIT(1) -#define SP_PRBS31_EN BIT(0) - -/* AUX Misc control Register */ -#define SP_AUX_MISC_CTRL_REG 0xbf - -/* DP PLL control Register */ -#define SP_DP_PLL_CTRL_REG 0xc7 -#define SP_PLL_RST BIT(6) - -/* DP Analog Power Down Register */ -#define SP_DP_ANALOG_POWER_DOWN_REG 0xc8 -#define SP_CH0_PD BIT(0) - -/* DP Misc Control Register */ -#define SP_DP_MISC_CTRL_REG 0xcd -#define SP_EQ_TRAINING_LOOP BIT(6) - -/* DP Extra I2C Device Address Register */ -#define SP_DP_EXTRA_I2C_DEV_ADDR_REG 0xce -#define SP_I2C_STRETCH_DISABLE BIT(7) - -#define SP_I2C_EXTRA_ADDR 0x50 - -/* DP Downspread Control Register 1 */ -#define SP_DP_DOWNSPREAD_CTRL1_REG 0xd0 - -/* DP M Value Calculation Control Register */ -#define SP_DP_M_CALCULATION_CTRL_REG 0xd9 -#define SP_M_GEN_CLK_SEL BIT(0) - -/* AUX Channel Access Status Register */ -#define SP_AUX_CH_STATUS_REG 0xe0 -#define SP_AUX_STATUS 0x0f - -/* AUX Channel DEFER Control Register */ -#define SP_AUX_DEFER_CTRL_REG 0xe2 -#define SP_DEFER_CTRL_EN BIT(7) - -/* DP Buffer Data Count Register */ -#define SP_BUF_DATA_COUNT_REG 0xe4 -#define SP_BUF_DATA_COUNT_MASK 0x1f -#define SP_BUF_CLR BIT(7) - -/* DP AUX Channel Control Register 1 */ -#define SP_DP_AUX_CH_CTRL1_REG 0xe5 -#define SP_AUX_TX_COMM_MASK 0x0f -#define SP_AUX_LENGTH_MASK 0xf0 -#define SP_AUX_LENGTH_SHIFT 4 - -/* DP AUX CH Address Register 0 */ -#define SP_AUX_ADDR_7_0_REG 0xe6 - -/* DP AUX CH Address Register 1 */ -#define SP_AUX_ADDR_15_8_REG 0xe7 - -/* DP AUX CH Address Register 2 */ -#define SP_AUX_ADDR_19_16_REG 0xe8 -#define SP_AUX_ADDR_19_16_MASK 0x0f - -/* DP AUX Channel Control Register 2 */ -#define SP_DP_AUX_CH_CTRL2_REG 0xe9 -#define SP_AUX_SEL_RXCM BIT(6) -#define SP_AUX_CHSEL BIT(3) -#define SP_AUX_PN_INV BIT(2) -#define SP_ADDR_ONLY BIT(1) -#define SP_AUX_EN BIT(0) - -/* DP Video Stream Control InfoFrame Register */ -#define SP_DP_3D_VSC_CTRL_REG 0xea -#define SP_INFO_FRAME_VSC_EN BIT(0) - -/* DP Video Stream Data Byte 1 Register */ -#define SP_DP_VSC_DB1_REG 0xeb - -/* DP AUX Channel Control Register 3 */ -#define SP_DP_AUX_CH_CTRL3_REG 0xec -#define SP_WAIT_COUNTER_7_0_MASK 0xff - -/* DP AUX Channel Control Register 4 */ -#define SP_DP_AUX_CH_CTRL4_REG 0xed - -/* DP AUX Buffer Data Registers */ -#define SP_DP_BUF_DATA0_REG 0xf0 - -/***************************************************************/ -/* Register definition of device address 0x72 */ -/***************************************************************/ - -/* -* Core Register Definitions -*/ - -/* Device ID Low Byte Register */ -#define SP_DEVICE_IDL_REG 0x02 - -/* Device ID High Byte Register */ -#define SP_DEVICE_IDH_REG 0x03 - -/* Device version register */ -#define SP_DEVICE_VERSION_REG 0x04 - -/* Power Down Control Register */ -#define SP_POWERDOWN_CTRL_REG 0x05 -#define SP_REGISTER_PD BIT(7) -#define SP_HDCP_PD BIT(5) -#define SP_AUDIO_PD BIT(4) -#define SP_VIDEO_PD BIT(3) -#define SP_LINK_PD BIT(2) -#define SP_TOTAL_PD BIT(1) - -/* Reset Control Register 1 */ -#define SP_RESET_CTRL1_REG 0x06 -#define SP_MISC_RST BIT(7) -#define SP_VIDCAP_RST BIT(6) -#define SP_VIDFIF_RST BIT(5) -#define SP_AUDFIF_RST BIT(4) -#define SP_AUDCAP_RST BIT(3) -#define SP_HDCP_RST BIT(2) -#define SP_SW_RST BIT(1) -#define SP_HW_RST BIT(0) - -/* Reset Control Register 2 */ -#define SP_RESET_CTRL2_REG 0x07 -#define SP_AUX_RST BIT(2) -#define SP_SERDES_FIFO_RST BIT(1) -#define SP_I2C_REG_RST BIT(0) - -/* Video Control Register 1 */ -#define SP_VID_CTRL1_REG 0x08 -#define SP_VIDEO_EN BIT(7) -#define SP_VIDEO_MUTE BIT(2) -#define SP_DE_GEN BIT(1) -#define SP_DEMUX BIT(0) - -/* Video Control Register 2 */ -#define SP_VID_CTRL2_REG 0x09 -#define SP_IN_COLOR_F_MASK 0x03 -#define SP_IN_YC_BIT_SEL BIT(2) -#define SP_IN_BPC_MASK 0x70 -#define SP_IN_BPC_SHIFT 4 -# define SP_IN_BPC_12BIT 0x03 -# define SP_IN_BPC_10BIT 0x02 -# define SP_IN_BPC_8BIT 0x01 -# define SP_IN_BPC_6BIT 0x00 -#define SP_IN_D_RANGE BIT(7) - -/* Video Control Register 3 */ -#define SP_VID_CTRL3_REG 0x0a -#define SP_HPD_OUT BIT(6) - -/* Video Control Register 5 */ -#define SP_VID_CTRL5_REG 0x0c -#define SP_CSC_STD_SEL BIT(7) -#define SP_XVYCC_RNG_LMT BIT(6) -#define SP_RANGE_Y2R BIT(5) -#define SP_CSPACE_Y2R BIT(4) -#define SP_RGB_RNG_LMT BIT(3) -#define SP_Y_RNG_LMT BIT(2) -#define SP_RANGE_R2Y BIT(1) -#define SP_CSPACE_R2Y BIT(0) - -/* Video Control Register 6 */ -#define SP_VID_CTRL6_REG 0x0d -#define SP_TEST_PATTERN_EN BIT(7) -#define SP_VIDEO_PROCESS_EN BIT(6) -#define SP_VID_US_MODE BIT(3) -#define SP_VID_DS_MODE BIT(2) -#define SP_UP_SAMPLE BIT(1) -#define SP_DOWN_SAMPLE BIT(0) - -/* Video Control Register 8 */ -#define SP_VID_CTRL8_REG 0x0f -#define SP_VID_VRES_TH BIT(0) - -/* Total Line Status Low Byte Register */ -#define SP_TOTAL_LINE_STAL_REG 0x24 - -/* Total Line Status High Byte Register */ -#define SP_TOTAL_LINE_STAH_REG 0x25 - -/* Active Line Status Low Byte Register */ -#define SP_ACT_LINE_STAL_REG 0x26 - -/* Active Line Status High Byte Register */ -#define SP_ACT_LINE_STAH_REG 0x27 - -/* Vertical Front Porch Status Register */ -#define SP_V_F_PORCH_STA_REG 0x28 - -/* Vertical SYNC Width Status Register */ -#define SP_V_SYNC_STA_REG 0x29 - -/* Vertical Back Porch Status Register */ -#define SP_V_B_PORCH_STA_REG 0x2a - -/* Total Pixel Status Low Byte Register */ -#define SP_TOTAL_PIXEL_STAL_REG 0x2b - -/* Total Pixel Status High Byte Register */ -#define SP_TOTAL_PIXEL_STAH_REG 0x2c - -/* Active Pixel Status Low Byte Register */ -#define SP_ACT_PIXEL_STAL_REG 0x2d - -/* Active Pixel Status High Byte Register */ -#define SP_ACT_PIXEL_STAH_REG 0x2e - -/* Horizontal Front Porch Status Low Byte Register */ -#define SP_H_F_PORCH_STAL_REG 0x2f - -/* Horizontal Front Porch Statys High Byte Register */ -#define SP_H_F_PORCH_STAH_REG 0x30 - -/* Horizontal SYNC Width Status Low Byte Register */ -#define SP_H_SYNC_STAL_REG 0x31 - -/* Horizontal SYNC Width Status High Byte Register */ -#define SP_H_SYNC_STAH_REG 0x32 - -/* Horizontal Back Porch Status Low Byte Register */ -#define SP_H_B_PORCH_STAL_REG 0x33 - -/* Horizontal Back Porch Status High Byte Register */ -#define SP_H_B_PORCH_STAH_REG 0x34 - -/* InfoFrame AVI Packet DB1 Register */ -#define SP_INFOFRAME_AVI_DB1_REG 0x70 - -/* Bit Control Specific Register */ -#define SP_BIT_CTRL_SPECIFIC_REG 0x80 -#define SP_BIT_CTRL_SELECT_SHIFT 1 -#define SP_ENABLE_BIT_CTRL BIT(0) - -/* InfoFrame Audio Packet DB1 Register */ -#define SP_INFOFRAME_AUD_DB1_REG 0x83 - -/* InfoFrame MPEG Packet DB1 Register */ -#define SP_INFOFRAME_MPEG_DB1_REG 0xb0 - -/* Audio Channel Status Registers */ -#define SP_AUD_CH_STATUS_BASE 0xd0 - -/* Audio Channel Num Register 5 */ -#define SP_I2S_CHANNEL_NUM_MASK 0xe0 -# define SP_I2S_CH_NUM_1 (0x00 << 5) -# define SP_I2S_CH_NUM_2 (0x01 << 5) -# define SP_I2S_CH_NUM_3 (0x02 << 5) -# define SP_I2S_CH_NUM_4 (0x03 << 5) -# define SP_I2S_CH_NUM_5 (0x04 << 5) -# define SP_I2S_CH_NUM_6 (0x05 << 5) -# define SP_I2S_CH_NUM_7 (0x06 << 5) -# define SP_I2S_CH_NUM_8 (0x07 << 5) -#define SP_EXT_VUCP BIT(2) -#define SP_VBIT BIT(1) -#define SP_AUDIO_LAYOUT BIT(0) - -/* Analog Debug Register 2 */ -#define SP_ANALOG_DEBUG2_REG 0xdd -#define SP_FORCE_SW_OFF_BYPASS 0x20 -#define SP_XTAL_FRQ 0x1c -# define SP_XTAL_FRQ_19M2 (0x00 << 2) -# define SP_XTAL_FRQ_24M (0x01 << 2) -# define SP_XTAL_FRQ_25M (0x02 << 2) -# define SP_XTAL_FRQ_26M (0x03 << 2) -# define SP_XTAL_FRQ_27M (0x04 << 2) -# define SP_XTAL_FRQ_38M4 (0x05 << 2) -# define SP_XTAL_FRQ_52M (0x06 << 2) -#define SP_POWERON_TIME_1P5MS 0x03 - -/* Analog Control 0 Register */ -#define SP_ANALOG_CTRL0_REG 0xe1 - -/* Common Interrupt Status Register 1 */ -#define SP_COMMON_INT_STATUS_BASE (0xf1 - 1) -#define SP_PLL_LOCK_CHG 0x40 - -/* Common Interrupt Status Register 2 */ -#define SP_COMMON_INT_STATUS2 0xf2 -#define SP_HDCP_AUTH_CHG BIT(1) -#define SP_HDCP_AUTH_DONE BIT(0) - -#define SP_HDCP_LINK_CHECK_FAIL BIT(0) - -/* Common Interrupt Status Register 4 */ -#define SP_COMMON_INT_STATUS4_REG 0xf4 -#define SP_HPD_IRQ BIT(6) -#define SP_HPD_ESYNC_ERR BIT(4) -#define SP_HPD_CHG BIT(2) -#define SP_HPD_LOST BIT(1) -#define SP_HPD_PLUG BIT(0) - -/* DP Interrupt Status Register */ -#define SP_DP_INT_STATUS1_REG 0xf7 -#define SP_TRAINING_FINISH BIT(5) -#define SP_POLLING_ERR BIT(4) - -/* Common Interrupt Mask Register */ -#define SP_COMMON_INT_MASK_BASE (0xf8 - 1) - -#define SP_COMMON_INT_MASK4_REG 0xfb - -/* DP Interrupts Mask Register */ -#define SP_DP_INT_MASK1_REG 0xfe - -/* Interrupt Control Register */ -#define SP_INT_CTRL_REG 0xff -/***************************************************************/ /* Register definition of device address 0x7a */ /***************************************************************/
drivers/gpu/drm/bridge/analogix/analogix-i2c-dptx.h new file +248 -0
248 lines not on this page · raw message
drivers/gpu/drm/bridge/analogix/analogix-i2c-txcommon.h new file +237 -0
237 lines not on this page · raw message
Signature · 1 line
2.20.1
PATCH RESEND v2 3/12 drm/bridge: extract some Analogix I2C DP common code
In reply to a message not in the archiveFrom: Icenowy Zheng <[email protected]>
Some code can be shared within different DP bridges by Analogix.
Extract them to a new module.
--- drivers/gpu/drm/bridge/analogix/Kconfig | 4 + drivers/gpu/drm/bridge/analogix/Makefile | 2 + .../drm/bridge/analogix/analogix-anx78xx.c | 146 +-------------- .../drm/bridge/analogix/analogix-i2c-dptx.c | 169 ++++++++++++++++++ .../drm/bridge/analogix/analogix-i2c-dptx.h | 2 + 5 files changed, 178 insertions(+), 145 deletions(-) create mode 100644 drivers/gpu/drm/bridge/analogix/analogix-i2c-dptx.c
drivers/gpu/drm/bridge/analogix/Kconfig +4 -0
@@ -1,5 +1,6 @@ config DRM_ANALOGIX_ANX78XX tristate "Analogix ANX78XX bridge" + select DRM_ANALOGIX_DP_I2C select DRM_KMS_HELPER select REGMAP_I2C help
@@ -11,3 +12,6 @@ config DRM_ANALOGIX_ANX78XX config DRM_ANALOGIX_DP tristate depends on DRM + +config DRM_ANALOGIX_DP_I2C + tristate
drivers/gpu/drm/bridge/analogix/Makefile +2 -0
@@ -1,3 +1,5 @@ analogix_dp-objs := analogix_dp_core.o analogix_dp_reg.o +analogix_dp_i2c-objs := analogix-i2c-dptx.o obj-$(CONFIG_DRM_ANALOGIX_ANX78XX) += analogix-anx78xx.o obj-$(CONFIG_DRM_ANALOGIX_DP) += analogix_dp.o +obj-$(CONFIG_DRM_ANALOGIX_DP_I2C) += analogix_dp_i2c.o
drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c +1 -145
162 lines not on this page · raw message
drivers/gpu/drm/bridge/analogix/analogix-i2c-dptx.c new file +169 -0
169 lines not on this page · raw message
drivers/gpu/drm/bridge/analogix/analogix-i2c-dptx.h +2 -0
@@ -245,4 +245,6 @@/* DP AUX Buffer Data Registers */ #define SP_DP_BUF_DATA0_REG 0xf0 +ssize_t anx_aux_transfer (struct regmap *map_dptx,struct drm_dp_aux_msg *msg); +#endif
Signature · 1 line
2.20.1
PATCH RESEND v2 4/12 dt-bindings: Add ANX6345 DP/eDP transmitter binding
In reply to a message not in the archiveFrom: Icenowy Zheng <[email protected]>
The ANX6345 is an ultra-low power DisplayPort/eDP transmitter designed for portable devices.
Add a binding document for it.
--- .../bindings/display/bridge/anx6345.txt | 56 +++++++++++++++++++ 1 file changed, 56 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/bridge/anx6345.txt
Documentation/devicetree/bindings/display/bridge/anx6345.txt new file +56 -0
@@ -0,0 +1,56 @@ +Analogix ANX6345 eDP Transmitter +-------------------------------- + +The ANX6345 is an ultra-low power Full-HD eDP transmitter designed for +portable devices. + +Required properties: + + - compatible : "analogix,anx6345" + - reg : I2C address of the device + - reset-gpios : Which GPIO to use for reset + +Optional properties: + + - dvdd12-supply : Regulator for 1.2V digital core power. + - dvdd25-supply : Regulator for 2.5V digital core power. + - Video ports for RGB input and eDP output using the DT bindings + defined in [1] + +[1]: Documentation/devicetree/bindings/media/video-interfaces.txt + +Example: + +anx6345: anx6345@38 { + compatible = "analogix,anx6345"; + reg = <0x38>; + reset-gpios = <&pio 3 24 GPIO_ACTIVE_HIGH>; /* PD24 */ + dvdd25-supply = <®_dldo2>; + dvdd12-supply = <®_fldo1>; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + anx6345_in: port@0 { + #address-cells = <1>; + #size-cells = <0>; + reg = <0>; + anx6345_in_tcon0: endpoint@0 { + reg = <0>; + remote-endpoint = <&tcon0_out_anx6345>; + }; + }; + + anx6345_out: port@1 { + #address-cells = <1>; + #size-cells = <0>; + reg = <1>; + + anx6345_out_panel: endpoint@0 { + reg = <0>; + remote-endpoint = <&panel_in_edp>; + }; + }; + }; +};
Signature · 1 line
2.20.1
PATCH RESEND v2 5/12 drm/bridge: Add Analogix anx6345 support
In reply to a message not in the archiveFrom: Icenowy Zheng <[email protected]>
The ANX6345 is an ultra-low power DisplayPower/eDP transmitter designed for portable devices. This driver adds initial support for RGB to eDP mode, without HPD and interrupts.
This is a configuration usually seen in eDP applications.
--- drivers/gpu/drm/bridge/analogix/Kconfig | 11 + drivers/gpu/drm/bridge/analogix/Makefile | 1 + .../drm/bridge/analogix/analogix-anx6345.c | 845 ++++++++++++++++++ .../drm/bridge/analogix/analogix-i2c-dptx.c | 2 +- .../drm/bridge/analogix/analogix-i2c-dptx.h | 8 + .../bridge/analogix/analogix-i2c-txcommon.h | 3 + 6 files changed, 869 insertions(+), 1 deletion(-) create mode 100644 drivers/gpu/drm/bridge/analogix/analogix-anx6345.c
drivers/gpu/drm/bridge/analogix/Kconfig +11 -0
@@ -1,3 +1,14 @@ +config DRM_ANALOGIX_ANX6345 + tristate "Analogix ANX6345 bridge" + select DRM_ANALOGIX_DP_I2C + select DRM_KMS_HELPER + select REGMAP_I2C + help + ANX6345 is an ultra-low Full-HD DisplayPort/eDP + transmitter designed for portable devices. The + ANX6345 transforms the LVTTL RGB output of an + application processor to eDP or DisplayPort. + config DRM_ANALOGIX_ANX78XX tristate "Analogix ANX78XX bridge" select DRM_ANALOGIX_DP_I2C
drivers/gpu/drm/bridge/analogix/Makefile +1 -0
@@ -1,5 +1,6 @@ analogix_dp-objs := analogix_dp_core.o analogix_dp_reg.o analogix_dp_i2c-objs := analogix-i2c-dptx.o +obj-$(CONFIG_DRM_ANALOGIX_ANX6345) += analogix-anx6345.o obj-$(CONFIG_DRM_ANALOGIX_ANX78XX) += analogix-anx78xx.o obj-$(CONFIG_DRM_ANALOGIX_DP) += analogix_dp.o obj-$(CONFIG_DRM_ANALOGIX_DP_I2C) += analogix_dp_i2c.o
drivers/gpu/drm/bridge/analogix/analogix-anx6345.c new file +845 -0
845 lines not on this page · raw message
drivers/gpu/drm/bridge/analogix/analogix-i2c-dptx.c +1 -1
@@ -117,7 +117,7 @@ ssize_t anx_aux_transfer(struct regmap *map_dptx, struct drm_dp_aux_msg *msg) else /* For non-zero-sized set the length field. */ ctrl1 |= (msg->size - 1) << SP_AUX_LENGTH_SHIFT; -if ((msg->request &DP_AUX_I2C_READ ) ==0 ) { +if ((msg->size >0 ) && ((msg->request &DP_AUX_I2C_READ ) ==0 )) {/* When WRITE | MOT write values to data buffer */ err = regmap_bulk_write(map_dptx, SP_DP_BUF_DATA0_REG, buffer,
drivers/gpu/drm/bridge/analogix/analogix-i2c-dptx.h +8 -0
@@ -75,7 +75,11 @@#define SP_CHA_STA BIT(2)/* Bits for DP System Control Register 3 */ #define SP_HPD_STATUS BIT(6) +#define SP_HPD_FORCE BIT(5) +#define SP_HPD_CTRL BIT(4)#define SP_STRM_VALID BIT(2) +#define SP_STRM_FORCE BIT(1) +#define SP_STRM_CTRL BIT(0)/* Bits for DP System Control Register 4 */ #define SP_ENHANCED_MODE BIT(3)
@@ -120,6 +124,9 @@#define SP_LINK_BW_SET_MASK 0x1f#define SP_INITIAL_SLIM_M_AUD_SEL BIT(5) +/* DP Lane Count Setting Register */ +#define SP_DP_LANE_COUNT_SET_REG 0xa1 +/* DP Training Pattern Set Register */ #define SP_DP_TRAINING_PATTERN_SET_REG 0xa2
@@ -133,6 +140,7 @@/* DP Link Training Control Register */ #define SP_DP_LT_CTRL_REG 0xa8 +#define SP_DP_LT_INPROGRESS 0x80#define SP_LT_ERROR_TYPE_MASK 0x70# define SP_LT_NO_ERROR 0x00# define SP_LT_AUX_WRITE_ERROR 0x01
drivers/gpu/drm/bridge/analogix/analogix-i2c-txcommon.h +3 -0
@@ -183,6 +183,9 @@#define SP_VBIT BIT(1)#define SP_AUDIO_LAYOUT BIT(0) +/* Analog Debug Register 1 */ +#define SP_ANALOG_DEBUG1_REG 0xdc +/* Analog Debug Register 2 */ #define SP_ANALOG_DEBUG2_REG 0xdd#define SP_FORCE_SW_OFF_BYPASS 0x20
Signature · 1 line
2.20.1
Re: [PATCH RESEND v2 05/12] drm/bridge: Add Analogix anx6345 support
First thing that struck me is that the chip's reset is actually low active
reset-gpios = <&pio 3 24 GPIO_ACTIVE_LOW>; /* PD24 */
^^^^
(please correct this in patches 11 and 12)
Consequently, you're using inverted values here in the driver:
Quoted 2 lines
(quoted diff) +2
-0+static void anx6345_poweron(struct anx6345 *anx6345) +{
[...]
drivers/gpu/drm/bridge/analogix/analogix-anx6345.c line 332
Quoted 1 line
drivers/gpu/drm/bridge/analogix/analogix-anx6345.c new file +1
-0+gpiod_set_value_cansleep (pdata->gpiod_reset,0 );
0 = reset on, ok.
drivers/gpu/drm/bridge/analogix/analogix-anx6345.c line 335
Quoted 3 lines
drivers/gpu/drm/bridge/analogix/analogix-anx6345.c new file +3
-0+usleep_range (1000 ,2000 ); + +gpiod_set_value_cansleep (pdata->gpiod_reset,1 );
1 = reset off, also fine.
Quoted 10 lines
drivers/gpu/drm/bridge/analogix/analogix-anx6345.c new file +10
-0+ +/* Power on registers module */ +anx6345_set_bits (anx6345->map[I2C_IDX_TXCOM ],SP_POWERDOWN_CTRL_REG , +SP_HDCP_PD |SP_AUDIO_PD |SP_VIDEO_PD |SP_LINK_PD ); +anx6345_clear_bits (anx6345->map[I2C_IDX_TXCOM ],SP_POWERDOWN_CTRL_REG , +SP_REGISTER_PD |SP_TOTAL_PD ); + + anx6345->powered = true; +} +
drivers/gpu/drm/bridge/analogix/analogix-anx6345.c line 355
Quoted 10 lines
drivers/gpu/drm/bridge/analogix/analogix-anx6345.c new file +10
-0+static void anx6345_poweroff (struct anx6345 *anx6345) +{ +struct anx6345_platform_data *pdata = &anx6345->pdata; +int err; + +if (WARN_ON (!anx6345->powered)) +return ; + +gpiod_set_value_cansleep (pdata->gpiod_reset,1 ); +usleep_range (1000 ,2000 );
This one got me a bit confused. Assert or deassert reset (again) before poweroff?
Please stick to the logical value of the reset line.
Torsten
PATCH RESEND v2 6/12 drm/sun4i: rgb: Add 1% tolerance to dclk frequency check when bridge is connected
In reply to a message not in the archiveClock rate check that was added in commit bb43d40d7c83 ("drm/sun4i: rgb:
Validate the clock rate") prevents some panel and bridges from working with sun4i driver.
Unfortunately, dotclock frequency for some modes are not achievable on sunxi hardware, and there's a slight deviation in rate returned by clk_round_rate(), so they fail this check.
Experiments show that panels and bridges work fine with this slight deviation, e.g. Pinebook that uses ANX6345 bridge with 768p eDP panel requests 73 MHz, gets 72.296MHz instead (0.96% difference) and works just fine.
This patch adds a 1% tolerence to the dot clock check when bridge is connected.
--- drivers/gpu/drm/sun4i/sun4i_rgb.c | 16 ++++++++++------ drivers/gpu/drm/sun4i/sun4i_tcon.h | 1 + 2 files changed, 11 insertions(+), 6 deletions(-)
drivers/gpu/drm/sun4i/sun4i_rgb.c +10 -6
@@ -61,6 +61,7 @@ static enum drm_mode_status sun4i_rgb_mode_valid(struct drm_encoder *crtc,u32 vsync = mode->vsync_end - mode->vsync_start;unsigned long rate = mode->clock *1000 ;long rounded_rate; +long tolerance =0 ;DRM_DEBUG_DRIVER ("Validating modes...\n" );
@@ -95,10 +96,14 @@ static enum drm_mode_status sun4i_rgb_mode_valid(struct drm_encoder *crtc, tcon->dclk_min_div =6 ; tcon->dclk_max_div =127 ; rounded_rate =clk_round_rate (tcon->dclk, rate); -if (rounded_rate < rate) +if (tcon->bridge) +/* Check against a 1% tolerance for the dot clock for bridge */ + tolerance = rate /100 ; + +if (rounded_rate < (rate - tolerance))return MODE_CLOCK_LOW ; -if (rounded_rate > rate) +if (rounded_rate > (rate + tolerance))return MODE_CLOCK_HIGH ;DRM_DEBUG_DRIVER ("Clock rate OK\n" );
@@ -172,7 +177,6 @@ static struct drm_encoder_funcs sun4i_rgb_enc_funcs = {int sun4i_rgb_init (struct drm_device *drm,struct sun4i_tcon *tcon) {struct drm_encoder *encoder; -struct drm_bridge *bridge;struct sun4i_rgb *rgb;int ret;
@@ -183,7 +187,7 @@ int sun4i_rgb_init(struct drm_device *drm, struct sun4i_tcon *tcon) encoder = &rgb->encoder; ret =drm_of_find_panel_or_bridge (tcon->dev->of_node,1 ,0 , - &tcon->panel, &bridge); + &tcon->panel, &tcon->bridge);if (ret) {dev_info (drm->dev,"No panel or bridge found... RGB output disabled\n" );return 0 ;
@@ -225,8 +229,8 @@ int sun4i_rgb_init(struct drm_device *drm, struct sun4i_tcon *tcon) } } -if (bridge) { - ret =drm_bridge_attach (encoder, bridge,NULL ); +if (tcon->bridge) { + ret =drm_bridge_attach (encoder, tcon->bridge,NULL );if (ret) {dev_err (drm->dev,"Couldn't attach our bridge\n" ); goto err_cleanup_connector;
drivers/gpu/drm/sun4i/sun4i_tcon.h +1 -0
@@ -258,6 +258,7 @@ struct sun4i_tcon {struct reset_control *lvds_rst;struct drm_panel *panel; +struct drm_bridge *bridge;/* Platform adjustments */ const struct sun4i_tcon_quirks *quirks;
Signature · 1 line
2.20.1
A message that is not in the archive (sent off-list or not yet received): 20190203185501.8958-7-anarsoul-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Re: [PATCH RESEND v2 06/12] drm/sun4i: rgb: Add 1% tolerance to dclk frequency check when bridge is connected
Hi,
Quoted 13 lines · Vasily Khoruzhick
Clock rate check that was added in commit
bb43d40d7c83("drm/sun4i: rgb:
Validate the clock rate") prevents some panel and bridges from working with sun4i driver.Unfortunately, dotclock frequency for some modes are not achievable on sunxi hardware, and there's a slight deviation in rate returned by
clk_round_rate(), so they fail this check.Experiments show that panels and bridges work fine with this slight deviation, e.g. Pinebook that uses ANX6345 bridge with 768p eDP panel requests 73 MHz, gets 72.296MHz instead (0.96% difference) and works just fine.
Quoted 4 lines
This patch adds a 1% tolerence to the dot clock check when bridge is connected.
Signed-off-by Vasily Khoruzhick <[email protected]>
I'm not sure we want to make exceptions for all the hardware combination we face, but we should go for something more generic (and easier to maintain instead).
IIRC, from the previous discussion, HDMI had a tolerancy requirement in the standard. Do you know if there's such a thing for eDP? That would solve the issue for all the eDP displays at once.
Maxime
Signature · 3 lines
Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
Re: [PATCH RESEND v2 06/12] drm/sun4i: rgb: Add 1% tolerance to dclk frequency check when bridge is connected
Quoted 22 lines · Maxime Ripard
Hi,
Quoted 13 lines · Vasily Khoruzhick
Clock rate check that was added in commit
bb43d40d7c83("drm/sun4i: rgb:
Validate the clock rate") prevents some panel and bridges from working with sun4i driver.Unfortunately, dotclock frequency for some modes are not achievable on sunxi hardware, and there's a slight deviation in rate returned by
clk_round_rate(), so they fail this check.Experiments show that panels and bridges work fine with this slight deviation, e.g. Pinebook that uses ANX6345 bridge with 768p eDP panel requests 73 MHz, gets 72.296MHz instead (0.96% difference) and works just fine.
Quoted 4 lines
This patch adds a 1% tolerence to the dot clock check when bridge is connected.
Signed-off-by Vasily Khoruzhick <[email protected]>
Quoted 7 lines
I'm not sure we want to make exceptions for all the hardware combination we face, but we should go for something more generic (and easier to maintain instead).
IIRC, from the previous discussion, HDMI had a tolerancy requirement in the standard. Do you know if there's such a thing for eDP? That would solve the issue for all the eDP displays at once.
I don't have access to eDP standard - vesa.org says it's available to members only.
Quoted 6 lines
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
A message that is not in the archive (sent off-list or not yet received): CA+E=qVfTfJ9E29gz83tdVGx5_KGWSQVJOAxKTzC+-n7=gdj0cA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org
Re: [PATCH RESEND v2 06/12] drm/sun4i: rgb: Add 1% tolerance to dclk frequency check when bridge is connected
于 2019年2月5日 GMT+08:00 上午12:26:43, Vasily Khoruzhick <[email protected]> 写到:
Quoted 34 lines
Quoted 5 lines · Maxime Ripard
Hi,
Quoted 1 line · Vasily Khoruzhick
Clock rate check that was added in commit
bb43d40d7c83("drm/sun4i:rgb:
Quoted 1 line
Quoted 1 line
Validate the clock rate") prevents some panel and bridges from
working with
Quoted 3 lines
Quoted 3 lines
sun4i driver.
Unfortunately, dotclock frequency for some modes are not achievable
on
Quoted 5 lines
Quoted 5 lines
sunxi hardware, and there's a slight deviation in rate returned by
clk_round_rate(), so they fail this check.Experiments show that panels and bridges work fine with this slight deviation, e.g. Pinebook that uses ANX6345 bridge with 768p eDP
panel
Quoted 1 line
Quoted 1 line
requests 73 MHz, gets 72.296MHz instead (0.96% difference) and
works just
Quoted 3 lines
Quoted 3 lines
fine.
This patch adds a 1% tolerence to the dot clock check when bridge
is
Quoted 8 lines
Quoted 3 lines
connected.
Signed-off-by Vasily Khoruzhick <[email protected]>I'm not sure we want to make exceptions for all the hardware combination we face, but we should go for something more generic (and easier to maintain instead).
Quoted 6 lines
Quoted 3 lines
IIRC, from the previous discussion, HDMI had a tolerancy requirement in the standard. Do you know if there's such a thing for eDP? That would solve the issue for all the eDP displays at once.
I don't have access to eDP standard - vesa.org says it's available to members only.
Try out to grab an old version?
I remember 1.0 is open.
Quoted 12 lines
Quoted 7 lines
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com_______________________________________________
linux-arm-kernel mailing list linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Signature · 6 lines
使用 K-9 Mail 发送自我的Android设备。 -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/[email protected] For more options, visit https://groups.google.com/d/optout.
A message that is not in the archive (sent off-list or not yet received): 0F6CBEA4-6DB6-40F1-A2FD-65101AF64F1F-h8G6r0blFSE@public.gmane.org
Re: Re: [PATCH RESEND v2 06/12] drm/sun4i: rgb: Add 1% tolerance to dclk frequency check when bridge is connected
Quoted 10 lines · Icenowy Zheng
Quoted 6 lines
Quoted 3 lines
IIRC, from the previous discussion, HDMI had a tolerancy requirement in the standard. Do you know if there's such a thing for eDP? That would solve the issue for all the eDP displays at once.
I don't have access to eDP standard - vesa.org says it's available to members only.
Try out to grab an old version?
I remember 1.0 is open.
I can't find anything regarding dot clock tolerance in DisplayPort specification.
A message that is not in the archive (sent off-list or not yet received): CA+E=qVd7yh=JNZSvrfY4Diu+VJWFK6yLUJ5MavBcZ8Cftn6f-Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org
Re: Re: [PATCH RESEND v2 06/12] drm/sun4i: rgb: Add 1% tolerance to dclk frequency check when bridge is connected
Quoted 8 lines · Vasily Khoruzhick
Quoted 7 lines · Icenowy Zheng
Quoted 6 lines
Quoted 3 lines
IIRC, from the previous discussion, HDMI had a tolerancy requirement in the standard. Do you know if there's such a thing for eDP? That would solve the issue for all the eDP displays at once.
I don't have access to eDP standard - vesa.org says it's available to members only.
Quoted 6 lines
Quoted 3 lines
Try out to grab an old version?
I remember 1.0 is open.
I can't find anything regarding dot clock tolerance in DisplayPort specification.
I guess since the DP is a VESA spec, it's probably .5%, just like on the EDID (well, CVT).
Maxime
Signature · 3 lines
Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
Re: Re: [PATCH RESEND v2 06/12] drm/sun4i: rgb: Add 1% tolerance to dclk frequency check when bridge is connected
Quoted 12 lines · Maxime Ripard
Quoted 10 lines · Vasily Khoruzhick
Quoted 9 lines · Icenowy Zheng
Quoted 6 lines
Quoted 3 lines
IIRC, from the previous discussion, HDMI had a tolerancy requirement in the standard. Do you know if there's such a thing for eDP? That would solve the issue for all the eDP displays at once.
I don't have access to eDP standard - vesa.org says it's available to members only.
Try out to grab an old version?
Quoted 7 lines
Quoted 4 lines
Quoted 1 line
I remember 1.0 is open.
I can't find anything regarding dot clock tolerance in DisplayPort specification.
I guess since the DP is a VESA spec, it's probably .5%, just like on the EDID (well, CVT).
Unfortunately that's not enough for Pinebook. It needs 1% for 768p panel.
Quoted 7 lines
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
Re: [linux-sunxi] Re: [PATCH RESEND v2 06/12] drm/sun4i: rgb: Add 1% tolerance to dclk frequency check when bridge is connected
Quoted 15 lines · Vasily Khoruzhick
Quoted 14 lines · Maxime Ripard
Quoted 12 lines · Vasily Khoruzhick
Quoted 10 lines · Icenowy Zheng
Quoted 6 lines
Quoted 3 lines
IIRC, from the previous discussion, HDMI had a tolerancy requirement in the standard. Do you know if there's such a thing for eDP? That would solve the issue for all the eDP displays at once.
I don't have access to eDP standard - vesa.org says it's available to members only.
Try out to grab an old version?
I remember 1.0 is open.
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
I can't find anything regarding dot clock tolerance in DisplayPort specification.
I guess since the DP is a VESA spec, it's probably .5%, just like on the EDID (well, CVT).
Unfortunately that's not enough for Pinebook. It needs 1% for 768p panel.
And that mode is stored in the EDID as a standard (or established) timing, or a detailed timing?
If the latter, then it should also provide the tolerancies as part of the panel timing description.
If the former, then what would be the advertised pixel clock and the one we can compute? Maybe we have a bug somewhere.
Maxime
Signature · 3 lines
Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [linux-sunxi] Re: [PATCH RESEND v2 06/12] drm/sun4i: rgb: Add 1% tolerance to dclk frequency check when bridge is connected
Quoted 22 lines · Maxime Ripard
Quoted 21 lines · Vasily Khoruzhick
Quoted 19 lines · Maxime Ripard
Quoted 8 lines · Vasily Khoruzhick
Quoted 7 lines · Icenowy Zheng
Quoted 6 lines
Quoted 3 lines
IIRC, from the previous discussion, HDMI had a tolerancy requirement in the standard. Do you know if there's such a thing for eDP? That would solve the issue for all the eDP displays at once.
I don't have access to eDP standard - vesa.org says it's available to members only.
Quoted 6 lines
Quoted 3 lines
Try out to grab an old version?
I remember 1.0 is open.
I can't find anything regarding dot clock tolerance in DisplayPort specification.
I guess since the DP is a VESA spec, it's probably .5%, just like on the EDID (well, CVT).
Quoted 8 lines
Quoted 2 lines
Unfortunately that's not enough for Pinebook. It needs 1% for 768p panel.
And that mode is stored in the EDID as a standard (or established) timing, or a detailed timing?
If the latter, then it should also provide the tolerancies as part of the panel timing description.
The simple-panel driver can, in addition to a struct drm_display_mode take a struct display_timings to specify the modes. These allow to define <minimum, typical, maximum> triplets for each parameter, which are usually found in panel datasheets.
Of course that's not going to help you much if all you have is EDID and if that doesn't provide tolerances.
Thierry
Quoted 9 lines
If the former, then what would be the advertised pixel clock and the one we can compute? Maybe we have a bug somewhere.
Maxime
Signature · 3 lines
Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
PATCH RESEND v2 7/12 drm/panel: simple: don't fail if we don't have panel desc
In reply to a message not in the archiveThis is preparation for addition of generic eDP panel that doesn't have any modes or delays defined.
--- drivers/gpu/drm/panel/panel-simple.c | 21 +++++++++++++-------- 1 file changed, 13 insertions(+), 8 deletions(-)
drivers/gpu/drm/panel/panel-simple.c +13 -8
@@ -176,7 +176,7 @@ static int panel_simple_disable(struct drm_panel *panel)backlight_update_status (p->backlight); } -if (p->desc->delay.disable) +if (p->desc && p->desc->delay.disable)msleep (p->desc->delay.disable); p->enabled = false;
@@ -195,7 +195,7 @@ static int panel_simple_unprepare(struct drm_panel *panel)regulator_disable (p->supply); -if (p->desc->delay.unprepare) +if (p->desc && p->desc->delay.unprepare)msleep (p->desc->delay.unprepare); p->prepared = false;
@@ -220,11 +220,13 @@ static int panel_simple_prepare(struct drm_panel *panel)gpiod_set_value_cansleep (p->enable_gpio,1 ); - delay = p->desc->delay.prepare; -if (p->no_hpd) - delay += p->desc->delay.hpd_absent_delay; -if (delay) -msleep (delay); +if (p->desc) { + delay = p->desc->delay.prepare; +if (p->no_hpd) + delay += p->desc->delay.hpd_absent_delay; +if (delay) +msleep (delay); + } p->prepared = true;
@@ -238,7 +240,7 @@ static int panel_simple_enable(struct drm_panel *panel)if (p->enabled)return 0 ; -if (p->desc->delay.enable) +if (p->desc && p->desc->delay.enable)msleep (p->desc->delay.enable);if (p->backlight) {
@@ -280,6 +282,9 @@ static int panel_simple_get_timings(struct drm_panel *panel,struct panel_simple *p =to_panel_simple (panel);unsigned int i; +if (!p->desc) +return 0 ; +if (p->desc->num_timings < num_timings) num_timings = p->desc->num_timings;
Signature · 1 line
2.20.1
PATCH RESEND v2 8/12 dt-bindings: add binding for generic eDP panel
In reply to a message not in the archiveeDP panels usually have EDID EEPROM, so there's no need to define panel width/height or any modes/timings in dts. But this panel still may have regulator and/or backlight.
--- .../devicetree/bindings/display/panel/panel-edp.txt | 7 +++++++ 1 file changed, 7 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/panel-edp.txt
Documentation/devicetree/bindings/display/panel/panel-edp.txt new file +7 -0
@@ -0,0 +1,7 @@ +Generic eDP Display Panel + +Required properties: + - compatible: "panel-edp" + +This binding is compatible with the simple-panel binding, which is specified +in simple-panel.txt in this directory.
Signature · 1 line
2.20.1
A message that is not in the archive (sent off-list or not yet received): 20190203185501.8958-9-anarsoul-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Re: [PATCH RESEND v2 08/12] dt-bindings: add binding for generic eDP panel
Quoted 9 lines · Vasily Khoruzhick
eDP panels usually have EDID EEPROM, so there's no need to define panel width/height or any modes/timings in dts. But this panel still may have regulator and/or backlight.
Signed-off-by Vasily Khoruzhick <[email protected]>--- .../devicetree/bindings/display/panel/panel-edp.txt | 7 +++++++ 1 file changed, 7 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/panel-edp.txt
Please don't try to make panels look more generic than they really are. You're going to have to provide a compatible string for your device that is more specific than "panel-edp". You claim that you don't need any extra information that is panel specific, but you don't know that now. We have in the past thought that we didn't need things like prepare delay, but then we ran into situations where we did need them.
Just do what everybody else does. Provide a specific compatible string and match on that in the panel-simple driver. Even if you can read all the video timings from an EDID EEPROM, you can still provide a mode in the panel descriptor to serve as a fallback if for example the EEPROM is faulty on some device.
Thierry
Re: [PATCH RESEND v2 08/12] dt-bindings: add binding for generic eDP panel
Quoted 19 lines · Thierry Reding
Quoted 9 lines · Vasily Khoruzhick
eDP panels usually have EDID EEPROM, so there's no need to define panel width/height or any modes/timings in dts. But this panel still may have regulator and/or backlight.
Signed-off-by Vasily Khoruzhick <[email protected]>--- .../devicetree/bindings/display/panel/panel-edp.txt | 7 +++++++ 1 file changed, 7 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/panel-edp.txtPlease don't try to make panels look more generic than they really are. You're going to have to provide a compatible string for your device that is more specific than "panel-edp". You claim that you don't need any extra information that is panel specific, but you don't know that now. We have in the past thought that we didn't need things like prepare delay, but then we ran into situations where we did need them.
Quoted 5 lines
Just do what everybody else does. Provide a specific compatible string and match on that in the panel-simple driver. Even if you can read all the video timings from an EDID EEPROM, you can still provide a mode in the panel descriptor to serve as a fallback if for example the EEPROM is faulty on some device.
Pinebook used several 768p panels that have slightly different timings and recent batch uses 1080p panel.
What panel descriptor should I use as fallback?
Quoted 1 line
Thierry
A message that is not in the archive (sent off-list or not yet received): CA+E=qVecudACOEXt74Kf=UA_F-uuHgEqHzKpYAq1ocMx3Sx+eQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org
Re: [PATCH RESEND v2 08/12] dt-bindings: add binding for generic eDP panel
Quoted 26 lines · Vasily Khoruzhick
Quoted 19 lines · Thierry Reding
Quoted 9 lines · Vasily Khoruzhick
eDP panels usually have EDID EEPROM, so there's no need to define panel width/height or any modes/timings in dts. But this panel still may have regulator and/or backlight.
Signed-off-by Vasily Khoruzhick <[email protected]>--- .../devicetree/bindings/display/panel/panel-edp.txt | 7 +++++++ 1 file changed, 7 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/panel-edp.txtPlease don't try to make panels look more generic than they really are. You're going to have to provide a compatible string for your device that is more specific than "panel-edp". You claim that you don't need any extra information that is panel specific, but you don't know that now. We have in the past thought that we didn't need things like prepare delay, but then we ran into situations where we did need them.
Quoted 5 lines
Just do what everybody else does. Provide a specific compatible string and match on that in the panel-simple driver. Even if you can read all the video timings from an EDID EEPROM, you can still provide a mode in the panel descriptor to serve as a fallback if for example the EEPROM is faulty on some device.
Quoted 4 lines
Pinebook used several 768p panels that have slightly different timings and recent batch uses 1080p panel.
What panel descriptor should I use as fallback?
You don't use panel descriptors as fallback. The simple-panel driver will bind to a panel device and use the corresponding descriptor. If your device tree contains the correct information, the descriptor is correct for the panel you have.
In other words you need to ensure that you have the correct panel in device tree for the board that you're using. This is exactly the same thing as for other devices.
One way to to this is to have separate device trees for each variant of the board that you want to support. Another variant may be to have a common device tree and then have some early firmware update the DTB with the correct panel information.
Thierry
Re: [PATCH RESEND v2 08/12] dt-bindings: add binding for generic eDP panel
Quoted 37 lines · Thierry Reding
Quoted 26 lines · Vasily Khoruzhick
Quoted 19 lines · Thierry Reding
Quoted 9 lines · Vasily Khoruzhick
eDP panels usually have EDID EEPROM, so there's no need to define panel width/height or any modes/timings in dts. But this panel still may have regulator and/or backlight.
Signed-off-by Vasily Khoruzhick <[email protected]>--- .../devicetree/bindings/display/panel/panel-edp.txt | 7 +++++++ 1 file changed, 7 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/panel-edp.txtPlease don't try to make panels look more generic than they really are. You're going to have to provide a compatible string for your device that is more specific than "panel-edp". You claim that you don't need any extra information that is panel specific, but you don't know that now. We have in the past thought that we didn't need things like prepare delay, but then we ran into situations where we did need them.
Quoted 5 lines
Just do what everybody else does. Provide a specific compatible string and match on that in the panel-simple driver. Even if you can read all the video timings from an EDID EEPROM, you can still provide a mode in the panel descriptor to serve as a fallback if for example the EEPROM is faulty on some device.
Quoted 4 lines
Pinebook used several 768p panels that have slightly different timings and recent batch uses 1080p panel.
What panel descriptor should I use as fallback?
You don't use panel descriptors as fallback. The simple-panel driver will bind to a panel device and use the corresponding descriptor. If your device tree contains the correct information, the descriptor is correct for the panel you have.
Quoted 8 lines
In other words you need to ensure that you have the correct panel in device tree for the board that you're using. This is exactly the same thing as for other devices.
One way to to this is to have separate device trees for each variant of the board that you want to support. Another variant may be to have a common device tree and then have some early firmware update the DTB with the correct panel information.
This would defeat the point of edp, which is to standardize the mess of panels (at least somewhat) and avoid having to change the DT/ACPI tables/firmware for every board you ship. Also, we do have DP quirking infrastructure already (using the OUI), I think if there's something that doesn't work then we should quirk it there.
What does make sense though imo is if we try not to stuff the edp panel into panel-simple, because it's anything like a simple dumb panel. There's also some integration awkwardness since with this panel you need to do dp aux/i2c transactions to get at the information (edid alone isn't good enough for edp), and I'm not sure how exactly that's supposed to be instantiated. Maybe a special function to instantiate an edp panel, which takes both a DT node and the dp_aux controller would be much better, instead of trying to auto-match against a DT compatible string and load a panel driver which is almost all fake.
Or we teach dp_aux to register itself and somehow teach panel-edp how it can get hold of the dp_aux channel it needs.
But fake mode in panel-simple sounds like the wrong approach. At least from our experience with i915 (and I think other drivers supporting edp), the standardization of panels for basic stuff at least worked. Self-refresh seems an entirely different story unfortunately ... but again quirking that for DP stuff should be done using the OUI I think. -Daniel
Signature · 3 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
A message that is not in the archive (sent off-list or not yet received): 20190204094012.GP3271-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org
Re: [PATCH RESEND v2 08/12] dt-bindings: add binding for generic eDP panel
Quoted 47 lines · Daniel Vetter
Quoted 37 lines · Thierry Reding
Quoted 26 lines · Vasily Khoruzhick
Quoted 19 lines · Thierry Reding
Quoted 9 lines · Vasily Khoruzhick
eDP panels usually have EDID EEPROM, so there's no need to define panel width/height or any modes/timings in dts. But this panel still may have regulator and/or backlight.
Signed-off-by Vasily Khoruzhick <[email protected]>--- .../devicetree/bindings/display/panel/panel-edp.txt | 7 +++++++ 1 file changed, 7 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/panel-edp.txtPlease don't try to make panels look more generic than they really are. You're going to have to provide a compatible string for your device that is more specific than "panel-edp". You claim that you don't need any extra information that is panel specific, but you don't know that now. We have in the past thought that we didn't need things like prepare delay, but then we ran into situations where we did need them.
Quoted 5 lines
Just do what everybody else does. Provide a specific compatible string and match on that in the panel-simple driver. Even if you can read all the video timings from an EDID EEPROM, you can still provide a mode in the panel descriptor to serve as a fallback if for example the EEPROM is faulty on some device.
Quoted 4 lines
Pinebook used several 768p panels that have slightly different timings and recent batch uses 1080p panel.
What panel descriptor should I use as fallback?
You don't use panel descriptors as fallback. The simple-panel driver will bind to a panel device and use the corresponding descriptor. If your device tree contains the correct information, the descriptor is correct for the panel you have.
Quoted 8 lines
In other words you need to ensure that you have the correct panel in device tree for the board that you're using. This is exactly the same thing as for other devices.
One way to to this is to have separate device trees for each variant of the board that you want to support. Another variant may be to have a common device tree and then have some early firmware update the DTB with the correct panel information.
Quoted 5 lines
This would defeat the point of edp, which is to standardize the mess of panels (at least somewhat) and avoid having to change the DT/ACPI tables/firmware for every board you ship. Also, we do have DP quirking infrastructure already (using the OUI), I think if there's something that doesn't work then we should quirk it there.
The problem is that while the attempt may have been to standardize, it failed. It doesn't take into account any of the details such as timing between things like powering up the display and enabling the backlight or similar. I don't know how you'd want to "quirk" those kinds of requirements because they are highly panel specific.
Quoted 10 lines
What does make sense though imo is if we try not to stuff the edp panel into panel-simple, because it's anything like a simple dumb panel. There's also some integration awkwardness since with this panel you need to do dp aux/i2c transactions to get at the information (edid alone isn't good enough for edp), and I'm not sure how exactly that's supposed to be instantiated. Maybe a special function to instantiate an edp panel, which takes both a DT node and the
dp_auxcontroller would be much better, instead of trying to auto-match against a DT compatible string and load a panel driver which is almost all fake.
Quoted 2 lines
Or we teach
dp_auxto register itself and somehow teach panel-edp how it can get hold of thedp_auxchannel it needs.
We already do that. drm_dp_aux registers as an I2C adapter that can be used to read EDID EEPROMs using I2C-over-AUX transactions. We already use that on some platforms.
Also note that simple-panel already supports getting video timings from EDID. If a DDC link is present in DT, the driver will load the modes from EDID and use them.
Quoted 5 lines
But fake mode in panel-simple sounds like the wrong approach. At least from our experience with i915 (and I think other drivers supporting edp), the standardization of panels for basic stuff at least worked. Self-refresh seems an entirely different story unfortunately ... but again quirking that for DP stuff should be done using the OUI I think.
I can imagine that on x86 platforms OEMs can also easily hide some of the necessary quirks in ACPI. None of that exists on ARM or other architectures that solely rely on device tree to describe the device. Since there's no way of specifying power sequences in DT (there have been attempts in the past to make that work, but they failed miserably) all we can do is match on a compatible string and encode the necessary logic in the driver. Luckily we haven't run into anything too fancy up to now and we've been able to make things work mostly with just a couple of fairly generic parameters.
Also note that initially people thought this wasn't going to be necessary and we only added the various "delay" parameters later on because it did turn out that not all panels are created equal.
Thierry
Re: [PATCH RESEND v2 08/12] dt-bindings: add binding for generic eDP panel
Quoted 54 lines · Thierry Reding
Quoted 47 lines · Daniel Vetter
Quoted 37 lines · Thierry Reding
Quoted 26 lines · Vasily Khoruzhick
Quoted 19 lines · Thierry Reding
Quoted 9 lines · Vasily Khoruzhick
eDP panels usually have EDID EEPROM, so there's no need to define panel width/height or any modes/timings in dts. But this panel still may have regulator and/or backlight.
Signed-off-by Vasily Khoruzhick <[email protected]>--- .../devicetree/bindings/display/panel/panel-edp.txt | 7 +++++++ 1 file changed, 7 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/panel-edp.txtPlease don't try to make panels look more generic than they really are. You're going to have to provide a compatible string for your device that is more specific than "panel-edp". You claim that you don't need any extra information that is panel specific, but you don't know that now. We have in the past thought that we didn't need things like prepare delay, but then we ran into situations where we did need them.
Quoted 5 lines
Just do what everybody else does. Provide a specific compatible string and match on that in the panel-simple driver. Even if you can read all the video timings from an EDID EEPROM, you can still provide a mode in the panel descriptor to serve as a fallback if for example the EEPROM is faulty on some device.
Quoted 4 lines
Pinebook used several 768p panels that have slightly different timings and recent batch uses 1080p panel.
What panel descriptor should I use as fallback?
You don't use panel descriptors as fallback. The simple-panel driver will bind to a panel device and use the corresponding descriptor. If your device tree contains the correct information, the descriptor is correct for the panel you have.
Quoted 8 lines
In other words you need to ensure that you have the correct panel in device tree for the board that you're using. This is exactly the same thing as for other devices.
One way to to this is to have separate device trees for each variant of the board that you want to support. Another variant may be to have a common device tree and then have some early firmware update the DTB with the correct panel information.
Quoted 5 lines
This would defeat the point of edp, which is to standardize the mess of panels (at least somewhat) and avoid having to change the DT/ACPI tables/firmware for every board you ship. Also, we do have DP quirking infrastructure already (using the OUI), I think if there's something that doesn't work then we should quirk it there.
Quoted 5 lines
The problem is that while the attempt may have been to standardize, it failed. It doesn't take into account any of the details such as timing between things like powering up the display and enabling the backlight or similar. I don't know how you'd want to "quirk" those kinds of requirements because they are highly panel specific.
Hm right, we get these from some firmware tables (and mix them with the spec one, since some of the firmware values are nonsense). I don't even know whether we can read the timings over dp aux somehow (you can power up the panel with some pessimistic values to figure those out, and you only need dp aux to work, which is much simpler than the entire panel).
Quoted 13 lines
Quoted 10 lines
What does make sense though imo is if we try not to stuff the edp panel into panel-simple, because it's anything like a simple dumb panel. There's also some integration awkwardness since with this panel you need to do dp aux/i2c transactions to get at the information (edid alone isn't good enough for edp), and I'm not sure how exactly that's supposed to be instantiated. Maybe a special function to instantiate an edp panel, which takes both a DT node and the
dp_auxcontroller would be much better, instead of trying to auto-match against a DT compatible string and load a panel driver which is almost all fake.Quoted 2 lines
Or we teach
dp_auxto register itself and somehow teach panel-edp how it can get hold of thedp_auxchannel it needs.
Quoted 7 lines
We already do that.
drm_dp_auxregisters as an I2C adapter that can be used to read EDID EEPROMs using I2C-over-AUX transactions. We already use that on some platforms.Also note that simple-panel already supports getting video timings from EDID. If a DDC link is present in DT, the driver will load the modes from EDID and use them.
Could we extend this to dp aux somehow? For edp you need the dp aux (which then gives you the ddc link automatically).
Quoted 16 lines
Quoted 5 lines
But fake mode in panel-simple sounds like the wrong approach. At least from our experience with i915 (and I think other drivers supporting edp), the standardization of panels for basic stuff at least worked. Self-refresh seems an entirely different story unfortunately ... but again quirking that for DP stuff should be done using the OUI I think.
I can imagine that on x86 platforms OEMs can also easily hide some of the necessary quirks in ACPI. None of that exists on ARM or other architectures that solely rely on device tree to describe the device. Since there's no way of specifying power sequences in DT (there have been attempts in the past to make that work, but they failed miserably) all we can do is match on a compatible string and encode the necessary logic in the driver. Luckily we haven't run into anything too fancy up to now and we've been able to make things work mostly with just a couple of fairly generic parameters.
Quoted 3 lines
Also note that initially people thought this wasn't going to be necessary and we only added the various "delay" parameters later on because it did turn out that not all panels are created equal.
Yeah this sucks, but oh well.
-Daniel
Signature · 3 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
A message that is not in the archive (sent off-list or not yet received): 20190204155909.GU3271-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org
Re: [PATCH RESEND v2 08/12] dt-bindings: add binding for generic eDP panel
Quoted 84 lines · Daniel Vetter
Quoted 54 lines · Thierry Reding
Quoted 47 lines · Daniel Vetter
Quoted 37 lines · Thierry Reding
Quoted 26 lines · Vasily Khoruzhick
Quoted 19 lines · Thierry Reding
Quoted 9 lines · Vasily Khoruzhick
eDP panels usually have EDID EEPROM, so there's no need to define panel width/height or any modes/timings in dts. But this panel still may have regulator and/or backlight.
Signed-off-by Vasily Khoruzhick <[email protected]>--- .../devicetree/bindings/display/panel/panel-edp.txt | 7 +++++++ 1 file changed, 7 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/panel-edp.txtPlease don't try to make panels look more generic than they really are. You're going to have to provide a compatible string for your device that is more specific than "panel-edp". You claim that you don't need any extra information that is panel specific, but you don't know that now. We have in the past thought that we didn't need things like prepare delay, but then we ran into situations where we did need them.
Quoted 5 lines
Just do what everybody else does. Provide a specific compatible string and match on that in the panel-simple driver. Even if you can read all the video timings from an EDID EEPROM, you can still provide a mode in the panel descriptor to serve as a fallback if for example the EEPROM is faulty on some device.
Quoted 4 lines
Pinebook used several 768p panels that have slightly different timings and recent batch uses 1080p panel.
What panel descriptor should I use as fallback?
You don't use panel descriptors as fallback. The simple-panel driver will bind to a panel device and use the corresponding descriptor. If your device tree contains the correct information, the descriptor is correct for the panel you have.
Quoted 8 lines
In other words you need to ensure that you have the correct panel in device tree for the board that you're using. This is exactly the same thing as for other devices.
One way to to this is to have separate device trees for each variant of the board that you want to support. Another variant may be to have a common device tree and then have some early firmware update the DTB with the correct panel information.
Quoted 5 lines
This would defeat the point of edp, which is to standardize the mess of panels (at least somewhat) and avoid having to change the DT/ACPI tables/firmware for every board you ship. Also, we do have DP quirking infrastructure already (using the OUI), I think if there's something that doesn't work then we should quirk it there.
Quoted 5 lines
The problem is that while the attempt may have been to standardize, it failed. It doesn't take into account any of the details such as timing between things like powering up the display and enabling the backlight or similar. I don't know how you'd want to "quirk" those kinds of requirements because they are highly panel specific.
Hm right, we get these from some firmware tables (and mix them with the spec one, since some of the firmware values are nonsense). I don't even know whether we can read the timings over dp aux somehow (you can power up the panel with some pessimistic values to figure those out, and you only need dp aux to work, which is much simpler than the entire panel).
Quoted 17 lines
Quoted 10 lines
What does make sense though imo is if we try not to stuff the edp panel into panel-simple, because it's anything like a simple dumb panel. There's also some integration awkwardness since with this panel you need to do dp aux/i2c transactions to get at the information (edid alone isn't good enough for edp), and I'm not sure how exactly that's supposed to be instantiated. Maybe a special function to instantiate an edp panel, which takes both a DT node and the
dp_auxcontroller would be much better, instead of trying to auto-match against a DT compatible string and load a panel driver which is almost all fake.Quoted 2 lines
Or we teach
dp_auxto register itself and somehow teach panel-edp how it can get hold of thedp_auxchannel it needs.We already do that.
drm_dp_auxregisters as an I2C adapter that can be used to read EDID EEPROMs using I2C-over-AUX transactions. We already use that on some platforms.
Quoted 6 lines
Quoted 3 lines
Also note that simple-panel already supports getting video timings from EDID. If a DDC link is present in DT, the driver will load the modes from EDID and use them.
Could we extend this to dp aux somehow? For edp you need the dp aux (which then gives you the ddc link automatically).
I suppose we could do that. We could introduce a new property that would allow the panel driver to get at the struct drm_dp_aux that can access the panel. I'm not sure how much that would buy us. I suppose the driver could go and use that drm_dp_aux to do I2C-over-AUX and ignore any ddc-bus property in device tree. A drm_dp_aux object could also be used to access DPCD if that's helpful.
The driver proposed here doesn't need access to DPCD, so I'm not sure that would immediately help.
Thierry
Re: [PATCH RESEND v2 08/12] dt-bindings: add binding for generic eDP panel
Quoted 99 lines · Thierry Reding
Quoted 84 lines · Daniel Vetter
Quoted 54 lines · Thierry Reding
Quoted 47 lines · Daniel Vetter
Quoted 37 lines · Thierry Reding
Quoted 26 lines · Vasily Khoruzhick
Quoted 19 lines · Thierry Reding
Quoted 9 lines · Vasily Khoruzhick
eDP panels usually have EDID EEPROM, so there's no need to define panel width/height or any modes/timings in dts. But this panel still may have regulator and/or backlight.
Signed-off-by Vasily Khoruzhick <[email protected]>--- .../devicetree/bindings/display/panel/panel-edp.txt | 7 +++++++ 1 file changed, 7 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/panel-edp.txtPlease don't try to make panels look more generic than they really are. You're going to have to provide a compatible string for your device that is more specific than "panel-edp". You claim that you don't need any extra information that is panel specific, but you don't know that now. We have in the past thought that we didn't need things like prepare delay, but then we ran into situations where we did need them.
Quoted 5 lines
Just do what everybody else does. Provide a specific compatible string and match on that in the panel-simple driver. Even if you can read all the video timings from an EDID EEPROM, you can still provide a mode in the panel descriptor to serve as a fallback if for example the EEPROM is faulty on some device.
Quoted 4 lines
Pinebook used several 768p panels that have slightly different timings and recent batch uses 1080p panel.
What panel descriptor should I use as fallback?
You don't use panel descriptors as fallback. The simple-panel driver will bind to a panel device and use the corresponding descriptor. If your device tree contains the correct information, the descriptor is correct for the panel you have.
Quoted 8 lines
In other words you need to ensure that you have the correct panel in device tree for the board that you're using. This is exactly the same thing as for other devices.
One way to to this is to have separate device trees for each variant of the board that you want to support. Another variant may be to have a common device tree and then have some early firmware update the DTB with the correct panel information.
Quoted 5 lines
This would defeat the point of edp, which is to standardize the mess of panels (at least somewhat) and avoid having to change the DT/ACPI tables/firmware for every board you ship. Also, we do have DP quirking infrastructure already (using the OUI), I think if there's something that doesn't work then we should quirk it there.
Quoted 5 lines
The problem is that while the attempt may have been to standardize, it failed. It doesn't take into account any of the details such as timing between things like powering up the display and enabling the backlight or similar. I don't know how you'd want to "quirk" those kinds of requirements because they are highly panel specific.
Hm right, we get these from some firmware tables (and mix them with the spec one, since some of the firmware values are nonsense). I don't even know whether we can read the timings over dp aux somehow (you can power up the panel with some pessimistic values to figure those out, and you only need dp aux to work, which is much simpler than the entire panel).
Quoted 17 lines
Quoted 10 lines
What does make sense though imo is if we try not to stuff the edp panel into panel-simple, because it's anything like a simple dumb panel. There's also some integration awkwardness since with this panel you need to do dp aux/i2c transactions to get at the information (edid alone isn't good enough for edp), and I'm not sure how exactly that's supposed to be instantiated. Maybe a special function to instantiate an edp panel, which takes both a DT node and the
dp_auxcontroller would be much better, instead of trying to auto-match against a DT compatible string and load a panel driver which is almost all fake.Quoted 2 lines
Or we teach
dp_auxto register itself and somehow teach panel-edp how it can get hold of thedp_auxchannel it needs.We already do that.
drm_dp_auxregisters as an I2C adapter that can be used to read EDID EEPROMs using I2C-over-AUX transactions. We already use that on some platforms.Quoted 6 lines
Quoted 3 lines
Also note that simple-panel already supports getting video timings from EDID. If a DDC link is present in DT, the driver will load the modes from EDID and use them.
Could we extend this to dp aux somehow? For edp you need the dp aux (which then gives you the ddc link automatically).
I suppose we could do that. We could introduce a new property that would allow the panel driver to get at the struct
drm_dp_auxthat can access the panel. I'm not sure how much that would buy us. I suppose the driver could go and use thatdrm_dp_auxto do I2C-over-AUX and ignore any ddc-bus property in device tree. Adrm_dp_auxobject could also be used to access DPCD if that's helpful.
Quoted 2 lines
The driver proposed here doesn't need access to DPCD, so I'm not sure that would immediately help.
You definitely need dp aux to drive edp. That's where a lot of the really important stuff is stored, and it sounds like on non-broken panels even the timings (we've never implemented that on i915 somehow). -Daniel
Signature · 3 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
Re: [PATCH RESEND v2 08/12] dt-bindings: add binding for generic eDP panel
Quoted 100 lines · Daniel Vetter
Quoted 99 lines · Thierry Reding
Quoted 84 lines · Daniel Vetter
Quoted 54 lines · Thierry Reding
Quoted 47 lines · Daniel Vetter
Quoted 37 lines · Thierry Reding
Quoted 26 lines · Vasily Khoruzhick
Quoted 19 lines · Thierry Reding
Quoted 9 lines · Vasily Khoruzhick
eDP panels usually have EDID EEPROM, so there's no need to define panel width/height or any modes/timings in dts. But this panel still may have regulator and/or backlight.
Signed-off-by Vasily Khoruzhick <[email protected]>--- .../devicetree/bindings/display/panel/panel-edp.txt | 7 +++++++ 1 file changed, 7 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/panel-edp.txtPlease don't try to make panels look more generic than they really are. You're going to have to provide a compatible string for your device that is more specific than "panel-edp". You claim that you don't need any extra information that is panel specific, but you don't know that now. We have in the past thought that we didn't need things like prepare delay, but then we ran into situations where we did need them.
Quoted 5 lines
Just do what everybody else does. Provide a specific compatible string and match on that in the panel-simple driver. Even if you can read all the video timings from an EDID EEPROM, you can still provide a mode in the panel descriptor to serve as a fallback if for example the EEPROM is faulty on some device.
Quoted 4 lines
Pinebook used several 768p panels that have slightly different timings and recent batch uses 1080p panel.
What panel descriptor should I use as fallback?
You don't use panel descriptors as fallback. The simple-panel driver will bind to a panel device and use the corresponding descriptor. If your device tree contains the correct information, the descriptor is correct for the panel you have.
Quoted 8 lines
In other words you need to ensure that you have the correct panel in device tree for the board that you're using. This is exactly the same thing as for other devices.
One way to to this is to have separate device trees for each variant of the board that you want to support. Another variant may be to have a common device tree and then have some early firmware update the DTB with the correct panel information.
Quoted 5 lines
This would defeat the point of edp, which is to standardize the mess of panels (at least somewhat) and avoid having to change the DT/ACPI tables/firmware for every board you ship. Also, we do have DP quirking infrastructure already (using the OUI), I think if there's something that doesn't work then we should quirk it there.
Quoted 5 lines
The problem is that while the attempt may have been to standardize, it failed. It doesn't take into account any of the details such as timing between things like powering up the display and enabling the backlight or similar. I don't know how you'd want to "quirk" those kinds of requirements because they are highly panel specific.
Hm right, we get these from some firmware tables (and mix them with the spec one, since some of the firmware values are nonsense). I don't even know whether we can read the timings over dp aux somehow (you can power up the panel with some pessimistic values to figure those out, and you only need dp aux to work, which is much simpler than the entire panel).
Quoted 17 lines
Quoted 10 lines
What does make sense though imo is if we try not to stuff the edp panel into panel-simple, because it's anything like a simple dumb panel. There's also some integration awkwardness since with this panel you need to do dp aux/i2c transactions to get at the information (edid alone isn't good enough for edp), and I'm not sure how exactly that's supposed to be instantiated. Maybe a special function to instantiate an edp panel, which takes both a DT node and the
dp_auxcontroller would be much better, instead of trying to auto-match against a DT compatible string and load a panel driver which is almost all fake.Quoted 2 lines
Or we teach
dp_auxto register itself and somehow teach panel-edp how it can get hold of thedp_auxchannel it needs.We already do that.
drm_dp_auxregisters as an I2C adapter that can be used to read EDID EEPROMs using I2C-over-AUX transactions. We already use that on some platforms.Quoted 6 lines
Quoted 3 lines
Also note that simple-panel already supports getting video timings from EDID. If a DDC link is present in DT, the driver will load the modes from EDID and use them.
Could we extend this to dp aux somehow? For edp you need the dp aux (which then gives you the ddc link automatically).
I suppose we could do that. We could introduce a new property that would allow the panel driver to get at the struct
drm_dp_auxthat can access the panel. I'm not sure how much that would buy us. I suppose the driver could go and use thatdrm_dp_auxto do I2C-over-AUX and ignore any ddc-bus property in device tree. Adrm_dp_auxobject could also be used to access DPCD if that's helpful.
Quoted 6 lines
Quoted 2 lines
The driver proposed here doesn't need access to DPCD, so I'm not sure that would immediately help.
You definitely need dp aux to drive edp. That's where a lot of the really important stuff is stored, and it sounds like on non-broken panels even the timings (we've never implemented that on i915 somehow).
I'm not sure I understand what you're saying here. I haven't worked with eDP panels in a while, but my recollection is that you can use DP AUX to read video timings over EDID. We provide support for that by exporting a DP AUX controller as I2C adapter (i.e. register with the I2C subsystem) and then that I2C adapter can be used to read the EDID. I wasn't aware that eDP panels additionally stored the video timings somewhere else.
What I meant above was that aside from the I2C-over-AUX for reading the EDID, this driver doesn't do anything else with DP AUX in order to turn the panel on. Looking at the eDP support we have on Tegra, there's a DPCD register (DP_SET_POWER) that needs to be written in order to take the sink device (i.e. panel) out of the power saving state. We do that as part of the connector implementation rather than within the panel driver. There are also additional registers such as DP_LINK_BW_SET that need to be programmed. I think this is also relevant to regular DP and detailed in the specification.
Given all the above, I'm beginning to think that Rob's right in that perhaps we shouldn't be treating eDP panels as panels, but rather to make them look more like DP monitors and make all this code part of the connector implementation. I think pretty much the only differences to regular DP are that we might require some lower-level resources that a DP monitor would usually have built-in (reset or power GPIOs, power supplies, backlight, ...).
I'm not sure if that's enough for eDP panels, though. For example the AUO B133HTN01 panel, used by the exynos5800-peach-pi, seems to be an eDP panel. But the driver also specifies a couple of additional delays which suggests that either it violates the eDP specification or that the eDP specification doesn't define any power sequencing delays that would've been needed. Or perhaps these delays are specified somewhere and the driver just doesn't use them?
Thierry
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH RESEND v2 08/12] dt-bindings: add binding for generic eDP panel
Quoted 108 lines · Thierry Reding
Quoted 100 lines · Daniel Vetter
Quoted 99 lines · Thierry Reding
Quoted 84 lines · Daniel Vetter
Quoted 54 lines · Thierry Reding
Quoted 47 lines · Daniel Vetter
Quoted 37 lines · Thierry Reding
Quoted 26 lines · Vasily Khoruzhick
Quoted 19 lines · Thierry Reding
Quoted 9 lines · Vasily Khoruzhick
eDP panels usually have EDID EEPROM, so there's no need to define panel width/height or any modes/timings in dts. But this panel still may have regulator and/or backlight.
Signed-off-by Vasily Khoruzhick <[email protected]>--- .../devicetree/bindings/display/panel/panel-edp.txt | 7 +++++++ 1 file changed, 7 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/panel-edp.txtPlease don't try to make panels look more generic than they really are. You're going to have to provide a compatible string for your device that is more specific than "panel-edp". You claim that you don't need any extra information that is panel specific, but you don't know that now. We have in the past thought that we didn't need things like prepare delay, but then we ran into situations where we did need them.
Quoted 5 lines
Just do what everybody else does. Provide a specific compatible string and match on that in the panel-simple driver. Even if you can read all the video timings from an EDID EEPROM, you can still provide a mode in the panel descriptor to serve as a fallback if for example the EEPROM is faulty on some device.
Quoted 4 lines
Pinebook used several 768p panels that have slightly different timings and recent batch uses 1080p panel.
What panel descriptor should I use as fallback?
You don't use panel descriptors as fallback. The simple-panel driver will bind to a panel device and use the corresponding descriptor. If your device tree contains the correct information, the descriptor is correct for the panel you have.
Quoted 8 lines
In other words you need to ensure that you have the correct panel in device tree for the board that you're using. This is exactly the same thing as for other devices.
One way to to this is to have separate device trees for each variant of the board that you want to support. Another variant may be to have a common device tree and then have some early firmware update the DTB with the correct panel information.
Quoted 5 lines
This would defeat the point of edp, which is to standardize the mess of panels (at least somewhat) and avoid having to change the DT/ACPI tables/firmware for every board you ship. Also, we do have DP quirking infrastructure already (using the OUI), I think if there's something that doesn't work then we should quirk it there.
Quoted 5 lines
The problem is that while the attempt may have been to standardize, it failed. It doesn't take into account any of the details such as timing between things like powering up the display and enabling the backlight or similar. I don't know how you'd want to "quirk" those kinds of requirements because they are highly panel specific.
Hm right, we get these from some firmware tables (and mix them with the spec one, since some of the firmware values are nonsense). I don't even know whether we can read the timings over dp aux somehow (you can power up the panel with some pessimistic values to figure those out, and you only need dp aux to work, which is much simpler than the entire panel).
Quoted 17 lines
Quoted 10 lines
What does make sense though imo is if we try not to stuff the edp panel into panel-simple, because it's anything like a simple dumb panel. There's also some integration awkwardness since with this panel you need to do dp aux/i2c transactions to get at the information (edid alone isn't good enough for edp), and I'm not sure how exactly that's supposed to be instantiated. Maybe a special function to instantiate an edp panel, which takes both a DT node and the
dp_auxcontroller would be much better, instead of trying to auto-match against a DT compatible string and load a panel driver which is almost all fake.Quoted 2 lines
Or we teach
dp_auxto register itself and somehow teach panel-edp how it can get hold of thedp_auxchannel it needs.We already do that.
drm_dp_auxregisters as an I2C adapter that can be used to read EDID EEPROMs using I2C-over-AUX transactions. We already use that on some platforms.Quoted 6 lines
Quoted 3 lines
Also note that simple-panel already supports getting video timings from EDID. If a DDC link is present in DT, the driver will load the modes from EDID and use them.
Could we extend this to dp aux somehow? For edp you need the dp aux (which then gives you the ddc link automatically).
I suppose we could do that. We could introduce a new property that would allow the panel driver to get at the struct
drm_dp_auxthat can access the panel. I'm not sure how much that would buy us. I suppose the driver could go and use thatdrm_dp_auxto do I2C-over-AUX and ignore any ddc-bus property in device tree. Adrm_dp_auxobject could also be used to access DPCD if that's helpful.Quoted 6 lines
Quoted 2 lines
The driver proposed here doesn't need access to DPCD, so I'm not sure that would immediately help.
You definitely need dp aux to drive edp. That's where a lot of the really important stuff is stored, and it sounds like on non-broken panels even the timings (we've never implemented that on i915 somehow).
Quoted 6 lines
I'm not sure I understand what you're saying here. I haven't worked with eDP panels in a while, but my recollection is that you can use DP AUX to read video timings over EDID. We provide support for that by exporting a DP AUX controller as I2C adapter (i.e. register with the I2C subsystem) and then that I2C adapter can be used to read the EDID. I wasn't aware that eDP panels additionally stored the video timings somewhere else.
I didn't know either, but understood Vasily's comment that this is possible. Haven't dug around in the specs though.
Quoted 18 lines
What I meant above was that aside from the I2C-over-AUX for reading the EDID, this driver doesn't do anything else with DP AUX in order to turn the panel on. Looking at the eDP support we have on Tegra, there's a DPCD register (
DP_SET_POWER) that needs to be written in order to take the sink device (i.e. panel) out of the power saving state. We do that as part of the connector implementation rather than within the panel driver. There are also additional registers such asDP_LINK_BW_SETthat need to be programmed. I think this is also relevant to regular DP and detailed in the specification.Given all the above, I'm beginning to think that Rob's right in that perhaps we shouldn't be treating eDP panels as panels, but rather to make them look more like DP monitors and make all this code part of the connector implementation. I think pretty much the only differences to regular DP are that we might require some lower-level resources that a DP monitor would usually have built-in (reset or power GPIOs, power supplies, backlight, ...).
Quoted 7 lines
I'm not sure if that's enough for eDP panels, though. For example the AUO B133HTN01 panel, used by the exynos5800-peach-pi, seems to be an eDP panel. But the driver also specifies a couple of additional delays which suggests that either it violates the eDP specification or that the eDP specification doesn't define any power sequencing delays that would've been needed. Or perhaps these delays are specified somewhere and the driver just doesn't use them?
I honestly don't know, but gut feeling also goes towards making edp something else than a dumb panel. There's a lot of stuff you need to do that overlaps with normal DP sinks, plus there's a lot of stuff (but not everything, or at least it needs some quirking sometimes) that you're supposed to autodiscover. But I'm not sure what's the best solution really is, since for i915 all the quirking we need is in some i915-specific tables (and I'm not even sure how much of that quirking is really necessary, and how much just convenience for us because the fw already did the hard work of poking the information out of the panel). -Daniel
Signature · 3 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
A message that is not in the archive (sent off-list or not yet received): 20190205163649.GG3271-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org
Re: [PATCH RESEND v2 08/12] dt-bindings: add binding for generic eDP panel
Quoted 117 lines · Daniel Vetter
Quoted 108 lines · Thierry Reding
Quoted 100 lines · Daniel Vetter
Quoted 99 lines · Thierry Reding
Quoted 84 lines · Daniel Vetter
Quoted 54 lines · Thierry Reding
Quoted 47 lines · Daniel Vetter
Quoted 37 lines · Thierry Reding
Quoted 26 lines · Vasily Khoruzhick
Quoted 19 lines · Thierry Reding
Quoted 9 lines · Vasily Khoruzhick
eDP panels usually have EDID EEPROM, so there's no need to define panel width/height or any modes/timings in dts. But this panel still may have regulator and/or backlight.
Signed-off-by Vasily Khoruzhick <[email protected]>--- .../devicetree/bindings/display/panel/panel-edp.txt | 7 +++++++ 1 file changed, 7 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/panel-edp.txtPlease don't try to make panels look more generic than they really are. You're going to have to provide a compatible string for your device that is more specific than "panel-edp". You claim that you don't need any extra information that is panel specific, but you don't know that now. We have in the past thought that we didn't need things like prepare delay, but then we ran into situations where we did need them.
Quoted 5 lines
Just do what everybody else does. Provide a specific compatible string and match on that in the panel-simple driver. Even if you can read all the video timings from an EDID EEPROM, you can still provide a mode in the panel descriptor to serve as a fallback if for example the EEPROM is faulty on some device.
Quoted 4 lines
Pinebook used several 768p panels that have slightly different timings and recent batch uses 1080p panel.
What panel descriptor should I use as fallback?
You don't use panel descriptors as fallback. The simple-panel driver will bind to a panel device and use the corresponding descriptor. If your device tree contains the correct information, the descriptor is correct for the panel you have.
Quoted 8 lines
In other words you need to ensure that you have the correct panel in device tree for the board that you're using. This is exactly the same thing as for other devices.
One way to to this is to have separate device trees for each variant of the board that you want to support. Another variant may be to have a common device tree and then have some early firmware update the DTB with the correct panel information.
Quoted 5 lines
This would defeat the point of edp, which is to standardize the mess of panels (at least somewhat) and avoid having to change the DT/ACPI tables/firmware for every board you ship. Also, we do have DP quirking infrastructure already (using the OUI), I think if there's something that doesn't work then we should quirk it there.
Quoted 5 lines
The problem is that while the attempt may have been to standardize, it failed. It doesn't take into account any of the details such as timing between things like powering up the display and enabling the backlight or similar. I don't know how you'd want to "quirk" those kinds of requirements because they are highly panel specific.
Hm right, we get these from some firmware tables (and mix them with the spec one, since some of the firmware values are nonsense). I don't even know whether we can read the timings over dp aux somehow (you can power up the panel with some pessimistic values to figure those out, and you only need dp aux to work, which is much simpler than the entire panel).
Quoted 17 lines
Quoted 10 lines
What does make sense though imo is if we try not to stuff the edp panel into panel-simple, because it's anything like a simple dumb panel. There's also some integration awkwardness since with this panel you need to do dp aux/i2c transactions to get at the information (edid alone isn't good enough for edp), and I'm not sure how exactly that's supposed to be instantiated. Maybe a special function to instantiate an edp panel, which takes both a DT node and the
dp_auxcontroller would be much better, instead of trying to auto-match against a DT compatible string and load a panel driver which is almost all fake.Quoted 2 lines
Or we teach
dp_auxto register itself and somehow teach panel-edp how it can get hold of thedp_auxchannel it needs.We already do that.
drm_dp_auxregisters as an I2C adapter that can be used to read EDID EEPROMs using I2C-over-AUX transactions. We already use that on some platforms.Quoted 6 lines
Quoted 3 lines
Also note that simple-panel already supports getting video timings from EDID. If a DDC link is present in DT, the driver will load the modes from EDID and use them.
Could we extend this to dp aux somehow? For edp you need the dp aux (which then gives you the ddc link automatically).
I suppose we could do that. We could introduce a new property that would allow the panel driver to get at the struct
drm_dp_auxthat can access the panel. I'm not sure how much that would buy us. I suppose the driver could go and use thatdrm_dp_auxto do I2C-over-AUX and ignore any ddc-bus property in device tree. Adrm_dp_auxobject could also be used to access DPCD if that's helpful.Quoted 6 lines
Quoted 2 lines
The driver proposed here doesn't need access to DPCD, so I'm not sure that would immediately help.
You definitely need dp aux to drive edp. That's where a lot of the really important stuff is stored, and it sounds like on non-broken panels even the timings (we've never implemented that on i915 somehow).
Quoted 6 lines
I'm not sure I understand what you're saying here. I haven't worked with eDP panels in a while, but my recollection is that you can use DP AUX to read video timings over EDID. We provide support for that by exporting a DP AUX controller as I2C adapter (i.e. register with the I2C subsystem) and then that I2C adapter can be used to read the EDID. I wasn't aware that eDP panels additionally stored the video timings somewhere else.
Quoted 2 lines
I didn't know either, but understood Vasily's comment that this is possible. Haven't dug around in the specs though.
It probes link capabilities such as lanes number and rate, see drm_dp_link_probe(),
I'm not sure if it's panel property or not.
Quoted 26 lines
Quoted 18 lines
What I meant above was that aside from the I2C-over-AUX for reading the EDID, this driver doesn't do anything else with DP AUX in order to turn the panel on. Looking at the eDP support we have on Tegra, there's a DPCD register (
DP_SET_POWER) that needs to be written in order to take the sink device (i.e. panel) out of the power saving state. We do that as part of the connector implementation rather than within the panel driver. There are also additional registers such asDP_LINK_BW_SETthat need to be programmed. I think this is also relevant to regular DP and detailed in the specification.Given all the above, I'm beginning to think that Rob's right in that perhaps we shouldn't be treating eDP panels as panels, but rather to make them look more like DP monitors and make all this code part of the connector implementation. I think pretty much the only differences to regular DP are that we might require some lower-level resources that a DP monitor would usually have built-in (reset or power GPIOs, power supplies, backlight, ...).
Quoted 7 lines
I'm not sure if that's enough for eDP panels, though. For example the AUO B133HTN01 panel, used by the exynos5800-peach-pi, seems to be an eDP panel. But the driver also specifies a couple of additional delays which suggests that either it violates the eDP specification or that the eDP specification doesn't define any power sequencing delays that would've been needed. Or perhaps these delays are specified somewhere and the driver just doesn't use them?
Quoted 14 lines
I honestly don't know, but gut feeling also goes towards making edp something else than a dumb panel. There's a lot of stuff you need to do that overlaps with normal DP sinks, plus there's a lot of stuff (but not everything, or at least it needs some quirking sometimes) that you're supposed to autodiscover. But I'm not sure what's the best solution really is, since for i915 all the quirking we need is in some i915-specific tables (and I'm not even sure how much of that quirking is really necessary, and how much just convenience for us because the fw already did the hard work of poking the information out of the panel). -Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Re: [PATCH RESEND v2 08/12] dt-bindings: add binding for generic eDP panel
In reply to Thierry RedingQuoted 126 lines · Thierry Reding
Quoted 100 lines · Daniel Vetter
Quoted 99 lines · Thierry Reding
Quoted 84 lines · Daniel Vetter
Quoted 54 lines · Thierry Reding
Quoted 47 lines · Daniel Vetter
Quoted 37 lines · Thierry Reding
Quoted 26 lines · Vasily Khoruzhick
Quoted 19 lines · Thierry Reding
Quoted 9 lines · Vasily Khoruzhick
eDP panels usually have EDID EEPROM, so there's no need to define panel width/height or any modes/timings in dts. But this panel still may have regulator and/or backlight.
Signed-off-by Vasily Khoruzhick <[email protected]>--- .../devicetree/bindings/display/panel/panel-edp.txt | 7 +++++++ 1 file changed, 7 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/panel-edp.txtPlease don't try to make panels look more generic than they really are. You're going to have to provide a compatible string for your device that is more specific than "panel-edp". You claim that you don't need any extra information that is panel specific, but you don't know that now. We have in the past thought that we didn't need things like prepare delay, but then we ran into situations where we did need them.
Quoted 5 lines
Just do what everybody else does. Provide a specific compatible string and match on that in the panel-simple driver. Even if you can read all the video timings from an EDID EEPROM, you can still provide a mode in the panel descriptor to serve as a fallback if for example the EEPROM is faulty on some device.
Quoted 4 lines
Pinebook used several 768p panels that have slightly different timings and recent batch uses 1080p panel.
What panel descriptor should I use as fallback?
You don't use panel descriptors as fallback. The simple-panel driver will bind to a panel device and use the corresponding descriptor. If your device tree contains the correct information, the descriptor is correct for the panel you have.
Quoted 8 lines
In other words you need to ensure that you have the correct panel in device tree for the board that you're using. This is exactly the same thing as for other devices.
One way to to this is to have separate device trees for each variant of the board that you want to support. Another variant may be to have a common device tree and then have some early firmware update the DTB with the correct panel information.
Quoted 5 lines
This would defeat the point of edp, which is to standardize the mess of panels (at least somewhat) and avoid having to change the DT/ACPI tables/firmware for every board you ship. Also, we do have DP quirking infrastructure already (using the OUI), I think if there's something that doesn't work then we should quirk it there.
Quoted 5 lines
The problem is that while the attempt may have been to standardize, it failed. It doesn't take into account any of the details such as timing between things like powering up the display and enabling the backlight or similar. I don't know how you'd want to "quirk" those kinds of requirements because they are highly panel specific.
Hm right, we get these from some firmware tables (and mix them with the spec one, since some of the firmware values are nonsense). I don't even know whether we can read the timings over dp aux somehow (you can power up the panel with some pessimistic values to figure those out, and you only need dp aux to work, which is much simpler than the entire panel).
Quoted 17 lines
Quoted 10 lines
What does make sense though imo is if we try not to stuff the edp panel into panel-simple, because it's anything like a simple dumb panel. There's also some integration awkwardness since with this panel you need to do dp aux/i2c transactions to get at the information (edid alone isn't good enough for edp), and I'm not sure how exactly that's supposed to be instantiated. Maybe a special function to instantiate an edp panel, which takes both a DT node and the
dp_auxcontroller would be much better, instead of trying to auto-match against a DT compatible string and load a panel driver which is almost all fake.Quoted 2 lines
Or we teach
dp_auxto register itself and somehow teach panel-edp how it can get hold of thedp_auxchannel it needs.We already do that.
drm_dp_auxregisters as an I2C adapter that can be used to read EDID EEPROMs using I2C-over-AUX transactions. We already use that on some platforms.Quoted 6 lines
Quoted 3 lines
Also note that simple-panel already supports getting video timings from EDID. If a DDC link is present in DT, the driver will load the modes from EDID and use them.
Could we extend this to dp aux somehow? For edp you need the dp aux (which then gives you the ddc link automatically).
I suppose we could do that. We could introduce a new property that would allow the panel driver to get at the struct
drm_dp_auxthat can access the panel. I'm not sure how much that would buy us. I suppose the driver could go and use thatdrm_dp_auxto do I2C-over-AUX and ignore any ddc-bus property in device tree. Adrm_dp_auxobject could also be used to access DPCD if that's helpful.Quoted 6 lines
Quoted 2 lines
The driver proposed here doesn't need access to DPCD, so I'm not sure that would immediately help.
You definitely need dp aux to drive edp. That's where a lot of the really important stuff is stored, and it sounds like on non-broken panels even the timings (we've never implemented that on i915 somehow).
I'm not sure I understand what you're saying here. I haven't worked with eDP panels in a while, but my recollection is that you can use DP AUX to read video timings over EDID. We provide support for that by exporting a DP AUX controller as I2C adapter (i.e. register with the I2C subsystem) and then that I2C adapter can be used to read the EDID. I wasn't aware that eDP panels additionally stored the video timings somewhere else.
What I meant above was that aside from the I2C-over-AUX for reading the EDID, this driver doesn't do anything else with DP AUX in order to turn the panel on. Looking at the eDP support we have on Tegra, there's a DPCD register (
DP_SET_POWER) that needs to be written in order to take the sink device (i.e. panel) out of the power saving state. We do that as part of the connector implementation rather than within the panel driver. There are also additional registers such asDP_LINK_BW_SETthat need to be programmed. I think this is also relevant to regular DP and detailed in the specification.
Quoted 7 lines
Given all the above, I'm beginning to think that Rob's right in that perhaps we shouldn't be treating eDP panels as panels, but rather to make them look more like DP monitors and make all this code part of the connector implementation. I think pretty much the only differences to regular DP are that we might require some lower-level resources that a DP monitor would usually have built-in (reset or power GPIOs, power supplies, backlight, ...).
I spent some time poking drm_connector code and I came to conclusion that it's not a good idea.
Basically edp-connector driver will duplicate simple-panel code and will bring extra complexity
into bridge driver for no benefit at all.
Also currently there are no stand-alone connector drivers, they all are part of display controller
driver.
One more thing to add is that I'm not sure that drm_connector is suitable for managing power
and backlight - I can't find appropriate callback in drm_connector_funcs to enable power and/or
backlight. Basically there's nothing similar to enable() or disable() from drm_bridge_funcs.
Quoted 7 lines
I'm not sure if that's enough for eDP panels, though. For example the AUO B133HTN01 panel, used by the exynos5800-peach-pi, seems to be an eDP panel. But the driver also specifies a couple of additional delays which suggests that either it violates the eDP specification or that the eDP specification doesn't define any power sequencing delays that would've been needed. Or perhaps these delays are specified somewhere and the driver just doesn't use them?
Sigh. We can't foresee any bizarre behavior some hardware may or may not have. Anyway,
can you propose something that can handle same hardware with different edp panels via
single software image (u-boot aka firmware is part of software image) and is acceptable
upstream?
Regards,
Vasily
Quoted 1 line
Thierry
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
A message that is not in the archive (sent off-list or not yet received): CA+E=qVcUsz=5s1+RqDdQ4Hm3_Q3jDFuZwuYXUuVx3ubFWmcG7w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org
Re: [PATCH RESEND v2 08/12] dt-bindings: add binding for generic eDP panel
Quoted 136 lines · Vasily Khoruzhick
Quoted 126 lines · Thierry Reding
Quoted 100 lines · Daniel Vetter
Quoted 99 lines · Thierry Reding
Quoted 84 lines · Daniel Vetter
Quoted 54 lines · Thierry Reding
Quoted 47 lines · Daniel Vetter
Quoted 37 lines · Thierry Reding
Quoted 26 lines · Vasily Khoruzhick
Quoted 19 lines · Thierry Reding
Quoted 9 lines · Vasily Khoruzhick
eDP panels usually have EDID EEPROM, so there's no need to define panel width/height or any modes/timings in dts. But this panel still may have regulator and/or backlight.
Signed-off-by Vasily Khoruzhick <[email protected]>--- .../devicetree/bindings/display/panel/panel-edp.txt | 7 +++++++ 1 file changed, 7 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/panel-edp.txtPlease don't try to make panels look more generic than they really are. You're going to have to provide a compatible string for your device that is more specific than "panel-edp". You claim that you don't need any extra information that is panel specific, but you don't know that now. We have in the past thought that we didn't need things like prepare delay, but then we ran into situations where we did need them.
Quoted 5 lines
Just do what everybody else does. Provide a specific compatible string and match on that in the panel-simple driver. Even if you can read all the video timings from an EDID EEPROM, you can still provide a mode in the panel descriptor to serve as a fallback if for example the EEPROM is faulty on some device.
Quoted 4 lines
Pinebook used several 768p panels that have slightly different timings and recent batch uses 1080p panel.
What panel descriptor should I use as fallback?
You don't use panel descriptors as fallback. The simple-panel driver will bind to a panel device and use the corresponding descriptor. If your device tree contains the correct information, the descriptor is correct for the panel you have.
Quoted 8 lines
In other words you need to ensure that you have the correct panel in device tree for the board that you're using. This is exactly the same thing as for other devices.
One way to to this is to have separate device trees for each variant of the board that you want to support. Another variant may be to have a common device tree and then have some early firmware update the DTB with the correct panel information.
Quoted 5 lines
This would defeat the point of edp, which is to standardize the mess of panels (at least somewhat) and avoid having to change the DT/ACPI tables/firmware for every board you ship. Also, we do have DP quirking infrastructure already (using the OUI), I think if there's something that doesn't work then we should quirk it there.
Quoted 5 lines
The problem is that while the attempt may have been to standardize, it failed. It doesn't take into account any of the details such as timing between things like powering up the display and enabling the backlight or similar. I don't know how you'd want to "quirk" those kinds of requirements because they are highly panel specific.
Hm right, we get these from some firmware tables (and mix them with the spec one, since some of the firmware values are nonsense). I don't even know whether we can read the timings over dp aux somehow (you can power up the panel with some pessimistic values to figure those out, and you only need dp aux to work, which is much simpler than the entire panel).
Quoted 17 lines
Quoted 10 lines
What does make sense though imo is if we try not to stuff the edp panel into panel-simple, because it's anything like a simple dumb panel. There's also some integration awkwardness since with this panel you need to do dp aux/i2c transactions to get at the information (edid alone isn't good enough for edp), and I'm not sure how exactly that's supposed to be instantiated. Maybe a special function to instantiate an edp panel, which takes both a DT node and the
dp_auxcontroller would be much better, instead of trying to auto-match against a DT compatible string and load a panel driver which is almost all fake.Quoted 2 lines
Or we teach
dp_auxto register itself and somehow teach panel-edp how it can get hold of thedp_auxchannel it needs.We already do that.
drm_dp_auxregisters as an I2C adapter that can be used to read EDID EEPROMs using I2C-over-AUX transactions. We already use that on some platforms.Quoted 6 lines
Quoted 3 lines
Also note that simple-panel already supports getting video timings from EDID. If a DDC link is present in DT, the driver will load the modes from EDID and use them.
Could we extend this to dp aux somehow? For edp you need the dp aux (which then gives you the ddc link automatically).
I suppose we could do that. We could introduce a new property that would allow the panel driver to get at the struct
drm_dp_auxthat can access the panel. I'm not sure how much that would buy us. I suppose the driver could go and use thatdrm_dp_auxto do I2C-over-AUX and ignore any ddc-bus property in device tree. Adrm_dp_auxobject could also be used to access DPCD if that's helpful.Quoted 6 lines
Quoted 2 lines
The driver proposed here doesn't need access to DPCD, so I'm not sure that would immediately help.
You definitely need dp aux to drive edp. That's where a lot of the really important stuff is stored, and it sounds like on non-broken panels even the timings (we've never implemented that on i915 somehow).
I'm not sure I understand what you're saying here. I haven't worked with eDP panels in a while, but my recollection is that you can use DP AUX to read video timings over EDID. We provide support for that by exporting a DP AUX controller as I2C adapter (i.e. register with the I2C subsystem) and then that I2C adapter can be used to read the EDID. I wasn't aware that eDP panels additionally stored the video timings somewhere else.
What I meant above was that aside from the I2C-over-AUX for reading the EDID, this driver doesn't do anything else with DP AUX in order to turn the panel on. Looking at the eDP support we have on Tegra, there's a DPCD register (
DP_SET_POWER) that needs to be written in order to take the sink device (i.e. panel) out of the power saving state. We do that as part of the connector implementation rather than within the panel driver. There are also additional registers such asDP_LINK_BW_SETthat need to be programmed. I think this is also relevant to regular DP and detailed in the specification.Quoted 7 lines
Given all the above, I'm beginning to think that Rob's right in that perhaps we shouldn't be treating eDP panels as panels, but rather to make them look more like DP monitors and make all this code part of the connector implementation. I think pretty much the only differences to regular DP are that we might require some lower-level resources that a DP monitor would usually have built-in (reset or power GPIOs, power supplies, backlight, ...).
Quoted 5 lines
I spent some time poking
drm_connectorcode and I came to conclusion that it's not a good idea.
Basically edp-connector driver will duplicate simple-panel code and will bring extra complexity
into bridge driver for no benefit at all.
I said this on irc, but for everyone's benefit, what's used in the kernel and the binding don't have to be aligned. I still think following a connector binding in DT makes sense even if the kernel implementation is actually a panel driver. Really, there's no difference in bindings between a connector node and panel node.
Quoted 3 lines
Also currently there are no stand-alone connector drivers, they all are part of display controller
driver.
Probably that is something to be refactored. I think we have lots of cases of:
if (is_connector)
// call connector func
else
// call panel funcOr maybe that was panel vs. bridge (then a connector)? It's been a while since I looked at this. In any case, each device in the chain shouldn't really have much knowledge as to what it is attached to.
Quoted 6 lines
One more thing to add is that I'm not sure that
drm_connectoris suitable for managing power
and backlight - I can't find appropriate callback indrm_connector_funcsto enable power and/or
backlight. Basically there's nothing similar toenable()ordisable()fromdrm_bridge_funcs.
Nobody has put the 5V supply on HDMI on a switchable regulator? It may need to be always on for HPD to work, but I wouldn't expect all board designers to get that right.
Quoted 10 lines
Quoted 7 lines
I'm not sure if that's enough for eDP panels, though. For example the AUO B133HTN01 panel, used by the exynos5800-peach-pi, seems to be an eDP panel. But the driver also specifies a couple of additional delays which suggests that either it violates the eDP specification or that the eDP specification doesn't define any power sequencing delays that would've been needed. Or perhaps these delays are specified somewhere and the driver just doesn't use them?
Sigh. We can't foresee any bizarre behavior some hardware may or may not have.
Bingo! You just summed up why we have specific compatibles.
Quoted 6 lines
Anyway,
can you propose something that can handle same hardware with different edp panels via
single software image (u-boot aka firmware is part of software image) and is acceptable
upstream?
compatible = "vendor,some-panel", "edp-connector";
Either you have to fixup the first string for the actual panel or have some testing up front that you don't need to. The kernel can start with only using the fallback string and if panel constraints turn out to be specified sufficiently, we'll never need to use the panel compatible.
Rob
A message that is not in the archive (sent off-list or not yet received): CAL_JsqKQ0EmyYGYvz__ZZGN7_6jLezevHWc+psn82Uy6hWZXMA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org
Re: [PATCH RESEND v2 08/12] dt-bindings: add binding for generic eDP panel
Quoted 196 lines · Rob Herring
Quoted 136 lines · Vasily Khoruzhick
Quoted 126 lines · Thierry Reding
Quoted 100 lines · Daniel Vetter
Quoted 99 lines · Thierry Reding
Quoted 84 lines · Daniel Vetter
Quoted 54 lines · Thierry Reding
Quoted 47 lines · Daniel Vetter
Quoted 37 lines · Thierry Reding
Quoted 26 lines · Vasily Khoruzhick
Quoted 19 lines · Thierry Reding
Quoted 9 lines · Vasily Khoruzhick
eDP panels usually have EDID EEPROM, so there's no need to define panel width/height or any modes/timings in dts. But this panel still may have regulator and/or backlight.
Signed-off-by Vasily Khoruzhick <[email protected]>--- .../devicetree/bindings/display/panel/panel-edp.txt | 7 +++++++ 1 file changed, 7 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/panel-edp.txtPlease don't try to make panels look more generic than they really are. You're going to have to provide a compatible string for your device that is more specific than "panel-edp". You claim that you don't need any extra information that is panel specific, but you don't know that now. We have in the past thought that we didn't need things like prepare delay, but then we ran into situations where we did need them.
Quoted 5 lines
Just do what everybody else does. Provide a specific compatible string and match on that in the panel-simple driver. Even if you can read all the video timings from an EDID EEPROM, you can still provide a mode in the panel descriptor to serve as a fallback if for example the EEPROM is faulty on some device.
Quoted 4 lines
Pinebook used several 768p panels that have slightly different timings and recent batch uses 1080p panel.
What panel descriptor should I use as fallback?
You don't use panel descriptors as fallback. The simple-panel driver will bind to a panel device and use the corresponding descriptor. If your device tree contains the correct information, the descriptor is correct for the panel you have.
Quoted 8 lines
In other words you need to ensure that you have the correct panel in device tree for the board that you're using. This is exactly the same thing as for other devices.
One way to to this is to have separate device trees for each variant of the board that you want to support. Another variant may be to have a common device tree and then have some early firmware update the DTB with the correct panel information.
Quoted 5 lines
This would defeat the point of edp, which is to standardize the mess of panels (at least somewhat) and avoid having to change the DT/ACPI tables/firmware for every board you ship. Also, we do have DP quirking infrastructure already (using the OUI), I think if there's something that doesn't work then we should quirk it there.
Quoted 5 lines
The problem is that while the attempt may have been to standardize, it failed. It doesn't take into account any of the details such as timing between things like powering up the display and enabling the backlight or similar. I don't know how you'd want to "quirk" those kinds of requirements because they are highly panel specific.
Hm right, we get these from some firmware tables (and mix them with the spec one, since some of the firmware values are nonsense). I don't even know whether we can read the timings over dp aux somehow (you can power up the panel with some pessimistic values to figure those out, and you only need dp aux to work, which is much simpler than the entire panel).
Quoted 17 lines
Quoted 10 lines
What does make sense though imo is if we try not to stuff the edp panel into panel-simple, because it's anything like a simple dumb panel. There's also some integration awkwardness since with this panel you need to do dp aux/i2c transactions to get at the information (edid alone isn't good enough for edp), and I'm not sure how exactly that's supposed to be instantiated. Maybe a special function to instantiate an edp panel, which takes both a DT node and the
dp_auxcontroller would be much better, instead of trying to auto-match against a DT compatible string and load a panel driver which is almost all fake.Quoted 2 lines
Or we teach
dp_auxto register itself and somehow teach panel-edp how it can get hold of thedp_auxchannel it needs.We already do that.
drm_dp_auxregisters as an I2C adapter that can be used to read EDID EEPROMs using I2C-over-AUX transactions. We already use that on some platforms.Quoted 6 lines
Quoted 3 lines
Also note that simple-panel already supports getting video timings from EDID. If a DDC link is present in DT, the driver will load the modes from EDID and use them.
Could we extend this to dp aux somehow? For edp you need the dp aux (which then gives you the ddc link automatically).
I suppose we could do that. We could introduce a new property that would allow the panel driver to get at the struct
drm_dp_auxthat can access the panel. I'm not sure how much that would buy us. I suppose the driver could go and use thatdrm_dp_auxto do I2C-over-AUX and ignore any ddc-bus property in device tree. Adrm_dp_auxobject could also be used to access DPCD if that's helpful.Quoted 6 lines
Quoted 2 lines
The driver proposed here doesn't need access to DPCD, so I'm not sure that would immediately help.
You definitely need dp aux to drive edp. That's where a lot of the really important stuff is stored, and it sounds like on non-broken panels even the timings (we've never implemented that on i915 somehow).
I'm not sure I understand what you're saying here. I haven't worked with eDP panels in a while, but my recollection is that you can use DP AUX to read video timings over EDID. We provide support for that by exporting a DP AUX controller as I2C adapter (i.e. register with the I2C subsystem) and then that I2C adapter can be used to read the EDID. I wasn't aware that eDP panels additionally stored the video timings somewhere else.
What I meant above was that aside from the I2C-over-AUX for reading the EDID, this driver doesn't do anything else with DP AUX in order to turn the panel on. Looking at the eDP support we have on Tegra, there's a DPCD register (
DP_SET_POWER) that needs to be written in order to take the sink device (i.e. panel) out of the power saving state. We do that as part of the connector implementation rather than within the panel driver. There are also additional registers such asDP_LINK_BW_SETthat need to be programmed. I think this is also relevant to regular DP and detailed in the specification.Quoted 7 lines
Given all the above, I'm beginning to think that Rob's right in that perhaps we shouldn't be treating eDP panels as panels, but rather to make them look more like DP monitors and make all this code part of the connector implementation. I think pretty much the only differences to regular DP are that we might require some lower-level resources that a DP monitor would usually have built-in (reset or power GPIOs, power supplies, backlight, ...).
Quoted 5 lines
I spent some time poking
drm_connectorcode and I came to conclusion that it's not a good idea.
Basically edp-connector driver will duplicate simple-panel code and will bring extra complexity
into bridge driver for no benefit at all.I said this on irc, but for everyone's benefit, what's used in the kernel and the binding don't have to be aligned. I still think following a connector binding in DT makes sense even if the kernel implementation is actually a panel driver. Really, there's no difference in bindings between a connector node and panel node.
Quoted 3 lines
Also currently there are no stand-alone connector drivers, they all are part of display controller
driver.Probably that is something to be refactored. I think we have lots of cases of:
if (
is_connector)// call connector func else // call panel funcOr maybe that was panel vs. bridge (then a connector)? It's been a while since I looked at this. In any case, each device in the chain shouldn't really have much knowledge as to what it is attached to.
Quoted 6 lines
One more thing to add is that I'm not sure that
drm_connectoris suitable for managing power
and backlight - I can't find appropriate callback indrm_connector_funcsto enable power and/or
backlight. Basically there's nothing similar toenable()ordisable()fromdrm_bridge_funcs.Nobody has put the 5V supply on HDMI on a switchable regulator? It may need to be always on for HPD to work, but I wouldn't expect all board designers to get that right.
Quoted 10 lines
Quoted 7 lines
I'm not sure if that's enough for eDP panels, though. For example the AUO B133HTN01 panel, used by the exynos5800-peach-pi, seems to be an eDP panel. But the driver also specifies a couple of additional delays which suggests that either it violates the eDP specification or that the eDP specification doesn't define any power sequencing delays that would've been needed. Or perhaps these delays are specified somewhere and the driver just doesn't use them?
Sigh. We can't foresee any bizarre behavior some hardware may or may not have.
Bingo! You just summed up why we have specific compatibles.
Quoted 6 lines
Anyway,
can you propose something that can handle same hardware with different edp panels via
single software image (u-boot aka firmware is part of software image) and is acceptable
upstream?
Quoted 4 lines
compatible = "vendor,some-panel", "edp-connector";
Either you have to fixup the first string for the actual panel or have some testing up front that you don't need to.
Where do I take actual panel compatible from?
Quoted 4 lines
The kernel can start
with only using the fallback string and if panel constraints turn out to be specified sufficiently, we'll never need to use the panel compatible.
So what panel compatible you want me to use if vendor used at least 3 different panels?
Introduce 2 more dts files (3 in total) even if they all work just fine with a single dts now?
Add one more dts once laptop vendor decides to change panel vendor?
Quoted 2 lines
Rob
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Re: [PATCH RESEND v2 08/12] dt-bindings: add binding for generic eDP panel
In reply to Thierry RedingQuoted 11 lines · Thierry Reding
Quoted 5 lines
Pinebook used several 768p panels that have slightly different timings and recent batch uses 1080p panel.
What panel descriptor should I use as fallback?
You don't use panel descriptors as fallback. The simple-panel driver will bind to a panel device and use the corresponding descriptor. If your device tree contains the correct information, the descriptor is correct for the panel you have.
Quoted 8 lines
In other words you need to ensure that you have the correct panel in device tree for the board that you're using. This is exactly the same thing as for other devices.
One way to to this is to have separate device trees for each variant of the board that you want to support. Another variant may be to have a common device tree and then have some early firmware update the DTB with the correct panel information.
That defeats the purpose of using eDP panels. Panel can identify itself and report what timings it supports.
If we use separate DTBs then users will have to figure out what panel is installed in their hardware and use appropriate software image - that's something I'd like to avoid.
I can add a descriptor for something like "pinebook eDP panel" if it works for you, but it won't have any display timings in it.
A message that is not in the archive (sent off-list or not yet received): CA+E=qVew+8__yrAud1gFnLQ8HCwDdGhVjV=c173HGvZxH=7zZQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org
Re: [PATCH RESEND v2 08/12] dt-bindings: add binding for generic eDP panel
Quoted 24 lines · Vasily Khoruzhick
Quoted 11 lines · Thierry Reding
Quoted 5 lines
Pinebook used several 768p panels that have slightly different timings and recent batch uses 1080p panel.
What panel descriptor should I use as fallback?
You don't use panel descriptors as fallback. The simple-panel driver will bind to a panel device and use the corresponding descriptor. If your device tree contains the correct information, the descriptor is correct for the panel you have.
Quoted 8 lines
In other words you need to ensure that you have the correct panel in device tree for the board that you're using. This is exactly the same thing as for other devices.
One way to to this is to have separate device trees for each variant of the board that you want to support. Another variant may be to have a common device tree and then have some early firmware update the DTB with the correct panel information.
That defeats the purpose of using eDP panels. Panel can identify itself and report what timings it supports.
Quoted 6 lines
If we use separate DTBs then users will have to figure out what panel is installed in their hardware and use appropriate software image - that's something I'd like to avoid.
I can add a descriptor for something like "pinebook eDP panel" if it works for you, but it won't have any display timings in it.
I'd like to point you to this:
http://sietch-tagr.blogspot.com/2016/04/display-panels-are-not-special.html
it addresses some of your questions. Hopefully that will also help you understand that this isn't only about display timings.
Thierry
Re: [PATCH RESEND v2 08/12] dt-bindings: add binding for generic eDP panel
In reply to Vasily KhoruzhickQuoted 17 lines · Vasily Khoruzhick
Quoted 15 lines · Thierry Reding
Quoted 5 lines
Pinebook used several 768p panels that have slightly different timings and recent batch uses 1080p panel.
What panel descriptor should I use as fallback?
You don't use panel descriptors as fallback. The simple-panel driver will bind to a panel device and use the corresponding descriptor. If your device tree contains the correct information, the descriptor is correct for the panel you have.
In other words you need to ensure that you have the correct panel in device tree for the board that you're using. This is exactly the same thing as for other devices.
Quoted 7 lines
Quoted 4 lines
One way to to this is to have separate device trees for each variant of the board that you want to support. Another variant may be to have a common device tree and then have some early firmware update the DTB with the correct panel information.
That defeats the purpose of using eDP panels. Panel can identify itself and report what timings it supports.
If you are confident that this works for all panels, then the firmware can identify the right panel and update the DTB with the correct information. If this doesn't work in the firmware, then it is not going to work in the kernel either and you are SOL without specific panel information in the DT.
Quoted 3 lines
If we use separate DTBs then users will have to figure out what panel is installed in their hardware and use appropriate software image - that's something I'd like to avoid.
I think Thierry meant either way this is a firmware problem. If you have a SKU per device and panel type, then the firmware just picks a dtb among a set.
Rob
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
A message that is not in the archive (sent off-list or not yet received): CAL_JsqLAODca_U94hCi9O3E6XiUjAYCoL7_0gkf_eMY0nnT8Ag-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org
Re: Re: [PATCH RESEND v2 08/12] dt-bindings: add binding for generic eDP panel
Quoted 24 lines · Rob Herring
Quoted 22 lines · Vasily Khoruzhick
Quoted 19 lines · Thierry Reding
Quoted 5 lines
Pinebook used several 768p panels that have slightly different timings and recent batch uses 1080p panel.
What panel descriptor should I use as fallback?
You don't use panel descriptors as fallback. The simple-panel driver will bind to a panel device and use the corresponding descriptor. If your device tree contains the correct information, the descriptor is correct for the panel you have.
In other words you need to ensure that you have the correct panel in device tree for the board that you're using. This is exactly the same thing as for other devices.
One way to to this is to have separate device trees for each variant of the board that you want to support. Another variant may be to have a common device tree and then have some early firmware update the DTB with the correct panel information.
Quoted 8 lines
Quoted 2 lines
That defeats the purpose of using eDP panels. Panel can identify itself and report what timings it supports.
If you are confident that this works for all panels, then the firmware can identify the right panel and update the DTB with the correct information. If this doesn't work in the firmware, then it is not going to work in the kernel either and you are SOL without specific panel information in the DT.
"firmware" is u-boot and on this platform it sits on the same physical media as OS (it's either microsd or eMMC).
I guess u-boot can fill in timings for kernel, but I don't see much point in it. If u-boot can't read EDID then same is true for kernel.
Quoted 7 lines
Quoted 3 lines
If we use separate DTBs then users will have to figure out what panel is installed in their hardware and use appropriate software image - that's something I'd like to avoid.
I think Thierry meant either way this is a firmware problem. If you have a SKU per device and panel type, then the firmware just picks a dtb among a set.
Unfortunately it's one SKU per multiple panels.
Quoted 1 line
Rob
Re: [PATCH RESEND v2 08/12] dt-bindings: add binding for generic eDP panel
In reply to Thierry RedingQuoted 38 lines · Thierry Reding
Quoted 26 lines · Vasily Khoruzhick
Quoted 19 lines · Thierry Reding
Quoted 9 lines · Vasily Khoruzhick
eDP panels usually have EDID EEPROM, so there's no need to define panel width/height or any modes/timings in dts. But this panel still may have regulator and/or backlight.
Signed-off-by Vasily Khoruzhick <[email protected]>--- .../devicetree/bindings/display/panel/panel-edp.txt | 7 +++++++ 1 file changed, 7 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/panel-edp.txtPlease don't try to make panels look more generic than they really are. You're going to have to provide a compatible string for your device that is more specific than "panel-edp". You claim that you don't need any extra information that is panel specific, but you don't know that now. We have in the past thought that we didn't need things like prepare delay, but then we ran into situations where we did need them.
Quoted 5 lines
Just do what everybody else does. Provide a specific compatible string and match on that in the panel-simple driver. Even if you can read all the video timings from an EDID EEPROM, you can still provide a mode in the panel descriptor to serve as a fallback if for example the EEPROM is faulty on some device.
Quoted 4 lines
Pinebook used several 768p panels that have slightly different timings and recent batch uses 1080p panel.
What panel descriptor should I use as fallback?
You don't use panel descriptors as fallback. The simple-panel driver will bind to a panel device and use the corresponding descriptor. If your device tree contains the correct information, the descriptor is correct for the panel you have.
Quoted 8 lines
In other words you need to ensure that you have the correct panel in device tree for the board that you're using. This is exactly the same thing as for other devices.
One way to to this is to have separate device trees for each variant of the board that you want to support. Another variant may be to have a common device tree and then have some early firmware update the DTB with the correct panel information.
That can be a pain to manage especially if panels are swapped run to run with 2nd sources.
I think it is perfectly fine to have a generic-ish fallback as long as it is just that, a fallback. If the panel has quirks, then you'd better make sure the firmware is stuffing in the right compatibles or that you can update the firmware.
Rob
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
A message that is not in the archive (sent off-list or not yet received): CAL_JsqKt1kOXmRNvkYsQ6AL69+TPZURKpDbKkkEUb2+KZ5hKjQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org
Re: [PATCH RESEND v2 08/12] dt-bindings: add binding for generic eDP panel
Quoted 48 lines · Rob Herring
Quoted 38 lines · Thierry Reding
Quoted 26 lines · Vasily Khoruzhick
Quoted 19 lines · Thierry Reding
Quoted 9 lines · Vasily Khoruzhick
eDP panels usually have EDID EEPROM, so there's no need to define panel width/height or any modes/timings in dts. But this panel still may have regulator and/or backlight.
Signed-off-by Vasily Khoruzhick <[email protected]>--- .../devicetree/bindings/display/panel/panel-edp.txt | 7 +++++++ 1 file changed, 7 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/panel-edp.txtPlease don't try to make panels look more generic than they really are. You're going to have to provide a compatible string for your device that is more specific than "panel-edp". You claim that you don't need any extra information that is panel specific, but you don't know that now. We have in the past thought that we didn't need things like prepare delay, but then we ran into situations where we did need them.
Quoted 5 lines
Just do what everybody else does. Provide a specific compatible string and match on that in the panel-simple driver. Even if you can read all the video timings from an EDID EEPROM, you can still provide a mode in the panel descriptor to serve as a fallback if for example the EEPROM is faulty on some device.
Quoted 4 lines
Pinebook used several 768p panels that have slightly different timings and recent batch uses 1080p panel.
What panel descriptor should I use as fallback?
You don't use panel descriptors as fallback. The simple-panel driver will bind to a panel device and use the corresponding descriptor. If your device tree contains the correct information, the descriptor is correct for the panel you have.
Quoted 8 lines
In other words you need to ensure that you have the correct panel in device tree for the board that you're using. This is exactly the same thing as for other devices.
One way to to this is to have separate device trees for each variant of the board that you want to support. Another variant may be to have a common device tree and then have some early firmware update the DTB with the correct panel information.
Quoted 7 lines
That can be a pain to manage especially if panels are swapped run to run with 2nd sources.
I think it is perfectly fine to have a generic-ish fallback as long as it is just that, a fallback. If the panel has quirks, then you'd better make sure the firmware is stuffing in the right compatibles or that you can update the firmware.
simple-panel would probably work if you stuck in some mostly compatible string and provided a ddc-i2c-bus property in the device tree node. The generic-ish fallback case could be implemented by providing a fallback compatible string (we used to have "simple-panel", which I think would still be adequate for this I suppose) and adding a dummy descriptor in the driver, perhaps one with pre-defined delays that could be adjusted to work for all cases, or they could just be 0. At least that way we'd be explicitly documenting that we support this as a fallback.
I'm not sure how you'd want to enforce that people provide the right compatible strings that way. Currently there's no way to make your panel work without adding a panel driver, so people are forced to write the DT bindings and a driver, or add support to an existing one. If we open this backdoor, I suspect many people will just take the easy route and rely on the fallback. And then what do we do when we get bug reports about panels not working, or requiring some quirks. How do we go and find out what the right compatible strings are for each board, or how to fix things for something we don't have access to.
This all sounds like a Pandora's box to me.
Thierry
Re: [PATCH RESEND v2 08/12] dt-bindings: add binding for generic eDP panel
Quoted 24 lines · Thierry Reding
Quoted 4 lines
I think it is perfectly fine to have a generic-ish fallback as long as it is just that, a fallback. If the panel has quirks, then you'd better make sure the firmware is stuffing in the right compatibles or that you can update the firmware.
simple-panel would probably work if you stuck in some mostly compatible string and provided a ddc-i2c-bus property in the device tree node. The generic-ish fallback case could be implemented by providing a fallback compatible string (we used to have "simple-panel", which I think would still be adequate for this I suppose) and adding a dummy descriptor in the driver, perhaps one with pre-defined delays that could be adjusted to work for all cases, or they could just be 0. At least that way we'd be explicitly documenting that we support this as a fallback.
I'm not sure how you'd want to enforce that people provide the right compatible strings that way. Currently there's no way to make your panel work without adding a panel driver, so people are forced to write the DT bindings and a driver, or add support to an existing one. If we open this backdoor, I suspect many people will just take the easy route and rely on the fallback. And then what do we do when we get bug reports about panels not working, or requiring some quirks. How do we go and find out what the right compatible strings are for each board, or how to fix things for something we don't have access to.
Quoted 1 line
This all sounds like a Pandora's box to me.
OK, just give me an option that will work on this platform with a single software image (keep in mind that u-boot aka "firmware" is part of this image) and that is acceptable for upstream and I'll try to implement it.
Quoted 1 line
Thierry
Re: [PATCH RESEND v2 08/12] dt-bindings: add binding for generic eDP panel
In reply to Thierry RedingQuoted 58 lines · Thierry Reding
Quoted 48 lines · Rob Herring
Quoted 38 lines · Thierry Reding
Quoted 26 lines · Vasily Khoruzhick
Quoted 19 lines · Thierry Reding
Quoted 9 lines · Vasily Khoruzhick
eDP panels usually have EDID EEPROM, so there's no need to define panel width/height or any modes/timings in dts. But this panel still may have regulator and/or backlight.
Signed-off-by Vasily Khoruzhick <[email protected]>--- .../devicetree/bindings/display/panel/panel-edp.txt | 7 +++++++ 1 file changed, 7 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/panel-edp.txtPlease don't try to make panels look more generic than they really are. You're going to have to provide a compatible string for your device that is more specific than "panel-edp". You claim that you don't need any extra information that is panel specific, but you don't know that now. We have in the past thought that we didn't need things like prepare delay, but then we ran into situations where we did need them.
Quoted 5 lines
Just do what everybody else does. Provide a specific compatible string and match on that in the panel-simple driver. Even if you can read all the video timings from an EDID EEPROM, you can still provide a mode in the panel descriptor to serve as a fallback if for example the EEPROM is faulty on some device.
Quoted 4 lines
Pinebook used several 768p panels that have slightly different timings and recent batch uses 1080p panel.
What panel descriptor should I use as fallback?
You don't use panel descriptors as fallback. The simple-panel driver will bind to a panel device and use the corresponding descriptor. If your device tree contains the correct information, the descriptor is correct for the panel you have.
Quoted 8 lines
In other words you need to ensure that you have the correct panel in device tree for the board that you're using. This is exactly the same thing as for other devices.
One way to to this is to have separate device trees for each variant of the board that you want to support. Another variant may be to have a common device tree and then have some early firmware update the DTB with the correct panel information.
Quoted 7 lines
That can be a pain to manage especially if panels are swapped run to run with 2nd sources.
I think it is perfectly fine to have a generic-ish fallback as long as it is just that, a fallback. If the panel has quirks, then you'd better make sure the firmware is stuffing in the right compatibles or that you can update the firmware.
Quoted 8 lines
simple-panel would probably work if you stuck in some mostly compatible string and provided a ddc-i2c-bus property in the device tree node. The generic-ish fallback case could be implemented by providing a fallback compatible string (we used to have "simple-panel", which I think would still be adequate for this I suppose) and adding a dummy descriptor in the driver, perhaps one with pre-defined delays that could be adjusted to work for all cases, or they could just be 0. At least that way we'd be explicitly documenting that we support this as a fallback.
I'd like something more specific than 'simple-panel' that at least implies it has EDID and whatever else we think it should imply.
Looking into this a bit more, why don't we just do a connector here? eDP has a standard connector (with power). It's just like other connectors, but with power and no hotplug. If someone does their own interface, then they should do their own connector or panel binding.
Quoted 9 lines
I'm not sure how you'd want to enforce that people provide the right compatible strings that way. Currently there's no way to make your panel work without adding a panel driver, so people are forced to write the DT bindings and a driver, or add support to an existing one. If we open this backdoor, I suspect many people will just take the easy route and rely on the fallback. And then what do we do when we get bug reports about panels not working, or requiring some quirks. How do we go and find out what the right compatible strings are for each board, or how to fix things for something we don't have access to.
We'll simply reject anything that should be implied by compatible. And now we can enforce with schema that DTs aren't populated with fallbacks alone. Of course, we can't make anyone pass all schema checks before shipping a dtb.
Rob
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
A message that is not in the archive (sent off-list or not yet received): CAL_JsqJx98DfHZSafiXA8QiO=bn1zy8g6keQ15L=cUmbVkTTOA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org
Re: [PATCH RESEND v2 08/12] dt-bindings: add binding for generic eDP panel
Quoted 9 lines · Rob Herring
Quoted 8 lines
simple-panel would probably work if you stuck in some mostly compatible string and provided a ddc-i2c-bus property in the device tree node. The generic-ish fallback case could be implemented by providing a fallback compatible string (we used to have "simple-panel", which I think would still be adequate for this I suppose) and adding a dummy descriptor in the driver, perhaps one with pre-defined delays that could be adjusted to work for all cases, or they could just be 0. At least that way we'd be explicitly documenting that we support this as a fallback.
Quoted 7 lines
I'd like something more specific than 'simple-panel' that at least implies it has EDID and whatever else we think it should imply.
Looking into this a bit more, why don't we just do a connector here? eDP has a standard connector (with power). It's just like other connectors, but with power and no hotplug. If someone does their own interface, then they should do their own connector or panel binding.
Where do we put backlight in this case?
Quoted 16 lines
Quoted 9 lines
I'm not sure how you'd want to enforce that people provide the right compatible strings that way. Currently there's no way to make your panel work without adding a panel driver, so people are forced to write the DT bindings and a driver, or add support to an existing one. If we open this backdoor, I suspect many people will just take the easy route and rely on the fallback. And then what do we do when we get bug reports about panels not working, or requiring some quirks. How do we go and find out what the right compatible strings are for each board, or how to fix things for something we don't have access to.
We'll simply reject anything that should be implied by compatible. And now we can enforce with schema that DTs aren't populated with fallbacks alone. Of course, we can't make anyone pass all schema checks before shipping a dtb.
Rob
Re: [PATCH RESEND v2 08/12] dt-bindings: add binding for generic eDP panel
Quoted 15 lines · Vasily Khoruzhick
Quoted 12 lines · Rob Herring
Quoted 8 lines
simple-panel would probably work if you stuck in some mostly compatible string and provided a ddc-i2c-bus property in the device tree node. The generic-ish fallback case could be implemented by providing a fallback compatible string (we used to have "simple-panel", which I think would still be adequate for this I suppose) and adding a dummy descriptor in the driver, perhaps one with pre-defined delays that could be adjusted to work for all cases, or they could just be 0. At least that way we'd be explicitly documenting that we support this as a fallback.
I'd like something more specific than 'simple-panel' that at least implies it has EDID and whatever else we think it should imply.
Quoted 6 lines
Quoted 4 lines
Looking into this a bit more, why don't we just do a connector here? eDP has a standard connector (with power). It's just like other connectors, but with power and no hotplug. If someone does their own interface, then they should do their own connector or panel binding.
Where do we put backlight in this case?
In the connector node. You'd need a backlight supply, 'backlight-enable-gpios' and backlight phandle to pwm-backlight node.
Rob
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
PATCH RESEND v2 9/12 drm/panel: simple: add generic eDP panel
In reply to a message not in the archiveeDP panels usually have EDID EEPROM, so there's no need to define panel width/height or any modes/timings in dts. But this panel still has regulator and backlight.
Add compatible for generic eDP panel so such kind of panel can be defined in dts.
--- drivers/gpu/drm/panel/panel-simple.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/gpu/drm/panel/panel-simple.c +3 -0
@@ -2759,6 +2759,9 @@ static const struct of_device_id platform_of_match[] = { }, { .compatible = "winstar,wf35ltiacd", .data = &winstar_wf35ltiacd, + }, { + .compatible = "panel-edp", + .data = NULL, }, { /* sentinel */ }
Signature · 1 line
2.20.1
PATCH RESEND v2 10/12 arm64: allwinner: a64: add pinmux for RGB666 LCD
In reply to a message not in the archiveFrom: Icenowy Zheng <[email protected]>
Allwinner A64's TCON0 can output RGB666 LCD signal.
Add its pinmux.
--- arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 9 +++++++++ 1 file changed, 9 insertions(+)
arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi +9 -0
@@ -559,6 +559,15 @@ function = "i2c1"; }; + lcd_rgb666_pins: lcd-rgb666 { + pins = "PD0", "PD1", "PD2", "PD3", "PD4", + "PD5", "PD6", "PD7", "PD8", "PD9", + "PD10", "PD11", "PD12", "PD13", + "PD14", "PD15", "PD16", "PD17", + "PD18", "PD19", "PD20", "PD21"; + function = "lcd0"; + }; + mmc0_pins: mmc0-pins { pins = "PF0", "PF1", "PF2", "PF3", "PF4", "PF5";
Signature · 1 line
2.20.1
PATCH RESEND v2 11/12 arm64: allwinner: a64: enable LCD-related hardware for Pinebook
In reply to a message not in the archiveFrom: Icenowy Zheng <[email protected]>
Pinebook has an ANX6345 bridge connected to the RGB666 LCD output and eDP panel input. The bridge is controlled via I2C that's connected to R_I2C bus.
Enable all this hardware in device tree.
--- .../dts/allwinner/sun50i-a64-pinebook.dts | 74 +++++++++++++++++++ 1 file changed, 74 insertions(+)
arch/arm64/boot/dts/allwinner/sun50i-a64-pinebook.dts +74 -0
@@ -63,6 +63,18 @@ }; }; + edp_panel: edp-panel { + compatible = "panel-edp", "simple-panel"; + backlight = <&backlight>; + power-supply = <®_dc1sw>; + + port { + panel_in_edp: endpoint { + remote-endpoint = <&anx6345_out_panel>; + }; + }; + }; + reg_vcc3v3: vcc3v3 { compatible = "regulator-fixed"; regulator-name = "vcc3v3";
@@ -102,6 +114,10 @@ status = "okay"; }; +&de { + status = "okay"; +}; + &ehci0 { phys = <&usbphy 0>; phy-names = "usb";
@@ -112,6 +128,10 @@ status = "okay"; }; +&mixer0 { + status = "okay"; +}; + &mmc0 { pinctrl-names = "default"; pinctrl-0 = <&mmc0_pins>;
@@ -163,6 +183,46 @@ status = "okay"; }; +&r_i2c { + pinctrl-names = "default"; + pinctrl-0 = <&r_i2c_pins_a>; + status = "okay"; + + anx6345: anx6345@38 { + compatible = "analogix,anx6345"; + reg = <0x38>; + reset-gpios = <&pio 3 24 GPIO_ACTIVE_HIGH>; /* PD24 */ + dvdd25-supply = <®_dldo2>; + dvdd12-supply = <®_fldo1>; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + anx6345_in: port@0 { + #address-cells = <1>; + #size-cells = <0>; + reg = <0>; + anx6345_in_tcon0: endpoint@0 { + reg = <0>; + remote-endpoint = <&tcon0_out_anx6345>; + }; + }; + + anx6345_out: port@1 { + #address-cells = <1>; + #size-cells = <0>; + reg = <1>; + + anx6345_out_panel: endpoint@0 { + reg = <0>; + remote-endpoint = <&panel_in_edp>; + }; + }; + }; + }; +}; + &r_rsb { status = "okay";
@@ -334,6 +394,20 @@ "MIC2", "Internal Microphone Right"; }; +&tcon0 { + pinctrl-names = "default"; + pinctrl-0 = <&lcd_rgb666_pins>; + + status = "okay"; +}; + +&tcon0_out { + tcon0_out_anx6345: endpoint@0 { + reg = <0>; + remote-endpoint = <&anx6345_in_tcon0>; + }; +}; + &uart0 { pinctrl-names = "default"; pinctrl-0 = <&uart0_pb_pins>;
Signature · 1 line
2.20.1
PATCH RESEND v2 12/12 arm64: allwinner: a64: enable LCD-related hardware for TERES-I
In reply to a message not in the archiveFrom: Icenowy Zheng <[email protected]>
TERES-I has an ANX6345 bridge connected to the RGB666 LCD output and eDP panel input. The bridge is controlled via I2C that's connected to I2C0 bus.
Enable all this hardware in device tree.
--- .../boot/dts/allwinner/sun50i-a64-teres-i.dts | 71 +++++++++++++++++-- 1 file changed, 67 insertions(+), 4 deletions(-)
arch/arm64/boot/dts/allwinner/sun50i-a64-teres-i.dts +67 -4
@@ -56,6 +56,17 @@ }; }; + edp_panel: edp-panel { + compatible = "panel-edp", "simple-panel"; + + port { + panel_in_edp: endpoint { + remote-endpoint = <&anx6345_out_panel>; + }; + }; + }; + + reg_usb1_vbus: usb1-vbus { compatible = "regulator-fixed"; regulator-name = "usb1-vbus";
@@ -72,20 +83,58 @@ }; }; +&de { + status = "okay"; +}; + &ehci1 { status = "okay"; }; -/* The ANX6345 eDP-bridge is on i2c0. There is no linux (mainline) - * driver for this chip at the moment, the bootloader initializes it. - * However it can be accessed with the i2c-dev driver from user space. - */ &i2c0 { clock-frequency = <100000>; pinctrl-names = "default"; pinctrl-0 = <&i2c0_pins>; status = "okay"; + + anx6345: anx6345@38 { + compatible = "analogix,anx6345"; + reg = <0x38>; + reset-gpios = <&pio 3 24 GPIO_ACTIVE_HIGH>; /* PD24 */ + dvdd25-supply = <®_dldo2>; + dvdd12-supply = <®_dldo3>; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + anx6345_in: port@0 { + #address-cells = <1>; + #size-cells = <0>; + reg = <0>; + anx6345_in_tcon0: endpoint@0 { + reg = <0>; + remote-endpoint = <&tcon0_out_anx6345>; + }; + }; + + anx6345_out: port@1 { + #address-cells = <1>; + #size-cells = <0>; + reg = <1>; + + anx6345_out_panel: endpoint@0 { + reg = <0>; + remote-endpoint = <&panel_in_edp>; + }; + }; + }; + }; +}; + +&mixer0 { + status = "okay"; }; &mmc0 {
@@ -258,6 +307,20 @@ vcc-hdmi-supply = <®_dldo1>; }; +&tcon0 { + pinctrl-names = "default"; + pinctrl-0 = <&lcd_rgb666_pins>; + + status = "okay"; +}; + +&tcon0_out { + tcon0_out_anx6345: endpoint@0 { + reg = <0>; + remote-endpoint = <&anx6345_in_tcon0>; + }; +}; + &uart0 { pinctrl-names = "default"; pinctrl-0 = <&uart0_pb_pins>;
Signature · 1 line
2.20.1