softirq: modify comments about PF_MEMALLOC in __do_softirq
PATCH 1/1 softirq: modify comments about PF_MEMALLOC in __do_softirq
--- kernel/softirq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/softirq.c +1 -1
@@ -257,7 +257,7 @@ asmlinkage __visible void __softirq_entry __do_softirq(void)int softirq_bit;/* -* Mask out PF_MEMALLOC s current task context is borrowed for the +* Mask out PF_MEMALLOC as current task context is borrowed for the * softirq. A softirq handled such as network RX might set PF_MEMALLOC * again if the socket is related to swap */
Signature · 1 line
2.17.0
I don't know if the trivial tree is dead or not, but this would be a prime candidate.
-- Steve
Quoted 17 lines · On Thu, 18 Oct 2018 10:21:33 -0400 Yangtao Li <[email protected]> wrote:
--- kernel/softirq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)kernel/softirq.c +1
-1@@ -257,7 +257,7 @@ asmlinkage __visible void __softirq_entry __do_softirq(void)int softirq_bit;/* -* Mask out PF_MEMALLOC s current task context is borrowed for the +* Mask out PF_MEMALLOC as current task context is borrowed for the * softirq. A softirq handled such as network RX might set PF_MEMALLOC * again if the socket is related to swap */
This place looks like a small mistake. :-)
-- Yangtao Li
Quoted 30 lines
On Thu, 18 Oct 2018
Steven Rostedt (VMware) <[email protected]> wrote:
I don't know if the trivial tree is dead or not, but this would be a prime candidate.-- Steve
Quoted 17 lines · On Thu, 18 Oct 2018 10:21:33 -0400 Yangtao Li <[email protected]> wrote:
--- kernel/softirq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)kernel/softirq.c +1
-1@@ -257,7 +257,7 @@ asmlinkage __visible void __softirq_entry __do_softirq(void)int softirq_bit;/* -* Mask out PF_MEMALLOC s current task context is borrowed for the +* Mask out PF_MEMALLOC as current task context is borrowed for the * softirq. A softirq handled such as network RX might set PF_MEMALLOC * again if the socket is related to swap */
Quoted 21 lines · Yangtao Li
--- kernel/softirq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)kernel/softirq.c +1
-2@@ -257,7 +257,7 @@ asmlinkage __visible void __softirq_entry __do_softirq(void)int softirq_bit;/* -* Mask out PF_MEMALLOC s current task context is borrowed for the +* Mask out PF_MEMALLOC as current task context is borrowed for the * softirq. A softirq handled such as network RX might set PF_MEMALLOC * again if the socket is related to swap */ --2.17.0
Quoted 9 lines · Yangtao Li
--- kernel/softirq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)kernel/softirq.c +0
-0
kernel/softirq.c asmlinkage __visible void __softirq_entry __do_softirq(void) · line 263
Quoted 8 lines
kernel/softirq.c +1
-1@@ -257,7 +257,7 @@ asmlinkage __visible void __softirq_entry __do_softirq(void)int softirq_bit;/* -* Mask out PF_MEMALLOC s current task context is borrowed for the +* Mask out PF_MEMALLOC as current task context is borrowed for the * softirq. A softirq handled such as network RX might set PF_MEMALLOC * again if the socket is related to swap */
Can I add your Signed-off-by?
Thanks,
Ingo
Quoted 24 lines
On Thu, 18 Oct 2018
Ingo Molnar <[email protected]> wrote:Quoted 9 lines · Yangtao Li
--- kernel/softirq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)kernel/softirq.c +0
-0kernel/softirq.c asmlinkage __visible void __softirq_entry __do_softirq(void) · line 263
Quoted 8 lines
kernel/softirq.c +1
-1@@ -257,7 +257,7 @@ asmlinkage __visible void __softirq_entry __do_softirq(void)int softirq_bit;/* -* Mask out PF_MEMALLOC s current task context is borrowed for the +* Mask out PF_MEMALLOC as current task context is borrowed for the * softirq. A softirq handled such as network RX might set PF_MEMALLOC * again if the socket is related to swap */ Can I add your Signed-off-by?
Quoted 3 lines
Thanks,
Ingo
yeah，Thanks
-- Yangtao Li
Signed-off-by Yangtao Li <[email protected]>
Quoted 27 lines · Ingo Molnar
Quoted 9 lines · Yangtao Li
--- kernel/softirq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)kernel/softirq.c +0
-0kernel/softirq.c asmlinkage __visible void __softirq_entry __do_softirq(void) · line 263
Quoted 8 lines
kernel/softirq.c +1
-1@@ -257,7 +257,7 @@ asmlinkage __visible void __softirq_entry __do_softirq(void)int softirq_bit;/* -* Mask out PF_MEMALLOC s current task context is borrowed for the +* Mask out PF_MEMALLOC as current task context is borrowed for the * softirq. A softirq handled such as network RX might set PF_MEMALLOC * again if the socket is related to swap */ Can I add your Signed-off-by?
Thanks,
Ingo
tip-bot for Yangtao Li
merge bot[tip:irq/core] softirq: Fix typo in __do_softirq() comments
In reply to Yangtao Lisoftirq: Fix typo in __do_softirq() comments
Commit-ID: e45506ac0af9b56b221863e9649fe122d8bb42ff Gitweb: https://git.kernel.org/tip/e45506ac0af9b56b221863e9649fe122d8bb42ff Author: Yangtao Li <[email protected]> AuthorDate: Thu, 18 Oct 2018 10:21:33 -0400 Committer: Ingo Molnar <[email protected]> CommitDate: Thu, 18 Oct 2018 18:10:23 +0200
softirq: Fix typo in __do_softirq() comments
s/s/as
[ mingo: Also add a missing 'the', add proper punctuation and clarify what 'swap' means here. ]
Signed-off-by Yangtao Li <[email protected]>
Cc Linus Torvalds <[email protected]>
Cc Peter Zijlstra <[email protected]>
Cc Thomas Gleixner <[email protected]>
Signed-off-by Ingo Molnar <[email protected]>
--- kernel/softirq.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
kernel/softirq.c +3 -3
@@ -257,9 +257,9 @@ asmlinkage __visible void __softirq_entry __do_softirq(void)int softirq_bit;/* -* Mask out PF_MEMALLOC s current task context is borrowed for the -* softirq. A softirq handled such as network RX might set PF_MEMALLOC -* again if the socket is related to swap +* Mask out PF_MEMALLOC as the current task context is borrowed for the +* softirq. A softirq handled, such as network RX, might set PF_MEMALLOC +* again if the socket is related to swapping. */ current->flags &= ~PF_MEMALLOC ;