nvdimm: Add docs hint for Linux driver name

PATCH Applied Kees Cook 2 participants 2 messages Oct 18, 2018 – Oct 19, 2018

Share & tools

Kees Cook

author

2018-10-18 20:14 UTC #0 lore raw

PATCH 1/1 nvdimm: Add docs hint for Linux driver name

I spent way too much time trying to figure out why the emulated NVDIMM was missing under Linux. In an effort to help others who might be looking for these kinds of things in the future, include a hint.

Signed-off-by Kees Cook <[email protected]>

---
 docs/nvdimm.txt | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

docs/nvdimm.txt +3 -2

index 5f158a61708e..7231c2d78f65 100644
@@ -49,8 +49,9 @@ Multiple vNVDIMM devices can be created if multiple pairs of "-object"
 and "-device" are provided.
 
 For above command line options, if the guest OS has the proper NVDIMM
-driver, it should be able to detect a NVDIMM device which is in the
-persistent memory mode and whose size is $NVDIMM_SIZE.
+driver (e.g. "CONFIG_ACPI_NFIT=y" under Linux), it should be able to
+detect a NVDIMM device which is in the persistent memory mode and whose
+size is $NVDIMM_SIZE.
 
 Note:

Signature · 6 lines

2.17.1


-- 
Kees Cook
Pixel Security

Stefan Hajnoczi

Applied

2018-10-19 11:44 UTC #1 lore raw

Quoted 8 lines · Kees Cook

I spent way too much time trying to figure out why the emulated NVDIMM was missing under Linux. In an effort to help others who might be looking for these kinds of things in the future, include a hint.
Signed-off-by Kees Cook <[email protected]>
---
 docs/nvdimm.txt | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block

Stefan